From 0225edd8c0795b66a5bc54cc5aa038e4972e276b Mon Sep 17 00:00:00 2001 From: Julien Lebosquain Date: Fri, 22 Aug 2025 15:56:42 +0200 Subject: [PATCH] Avoid processing packages in parallel in ValidateApiDiff (#19511) --- nukebuild/ApiDiffHelper.cs | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/nukebuild/ApiDiffHelper.cs b/nukebuild/ApiDiffHelper.cs index 1ef0995eff..06f3e23b7b 100644 --- a/nukebuild/ApiDiffHelper.cs +++ b/nukebuild/ApiDiffHelper.cs @@ -47,20 +47,13 @@ public static class ApiDiffHelper var allErrors = new List(); - Parallel.ForEach( - packageDiff.Frameworks, - framework => - { - var args = $""" -l="{framework.BaselineFolderPath}" -r="{framework.CurrentFolderPath}" {suppressionArgs}"""; - - var localErrors = GetErrors(apiCompatTool(args)); + foreach (var framework in packageDiff.Frameworks) + { + var args = $""" -l="{framework.BaselineFolderPath}" -r="{framework.CurrentFolderPath}" {suppressionArgs}"""; - if (localErrors.Length > 0) - { - lock (allErrors) - allErrors.AddRange(localErrors); - } - }); + var localErrors = GetErrors(apiCompatTool(args)); + allErrors.AddRange(localErrors); + } ThrowOnErrors(allErrors, packageDiff.PackageId, "ValidateApiDiff"); }