From 79e2e5b11adf3ee311e0f3baa912388d41cbbd8c Mon Sep 17 00:00:00 2001 From: Nikita Tsukanov Date: Fri, 14 Apr 2023 20:57:49 +0600 Subject: [PATCH 1/2] DropShadowEffect Direction is in degrees, not radians --- src/Avalonia.Base/Media/Effects/DropShadowEffect.cs | 4 ++-- src/Avalonia.Base/Media/Effects/IDropShadowEffect.cs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Avalonia.Base/Media/Effects/DropShadowEffect.cs b/src/Avalonia.Base/Media/Effects/DropShadowEffect.cs index 67be74fe49..5e4bc0a7ea 100644 --- a/src/Avalonia.Base/Media/Effects/DropShadowEffect.cs +++ b/src/Avalonia.Base/Media/Effects/DropShadowEffect.cs @@ -97,8 +97,8 @@ public class DropShadowDirectionEffect : DropShadowEffectBase, IDirectionDropSha set => SetValue(DirectionProperty, value); } - public double OffsetX => Math.Cos(Direction) * ShadowDepth; - public double OffsetY => Math.Sin(Direction) * ShadowDepth; + public double OffsetX => Math.Cos(Direction * Math.PI / 180) * ShadowDepth; + public double OffsetY => Math.Sin(Direction * Math.PI / 180) * ShadowDepth; public IImmutableEffect ToImmutable() => new ImmutableDropShadowDirectionEffect(OffsetX, OffsetY, BlurRadius, Color, Opacity); } \ No newline at end of file diff --git a/src/Avalonia.Base/Media/Effects/IDropShadowEffect.cs b/src/Avalonia.Base/Media/Effects/IDropShadowEffect.cs index 30d787198c..bb97410d7f 100644 --- a/src/Avalonia.Base/Media/Effects/IDropShadowEffect.cs +++ b/src/Avalonia.Base/Media/Effects/IDropShadowEffect.cs @@ -67,8 +67,8 @@ public class ImmutableDropShadowDirectionEffect : IDirectionDropShadowEffect, II Opacity = opacity; } - public double OffsetX => Math.Cos(Direction) * ShadowDepth; - public double OffsetY => Math.Sin(Direction) * ShadowDepth; + public double OffsetX => Math.Cos(Direction * Math.PI / 180) * ShadowDepth; + public double OffsetY => Math.Sin(Direction * Math.PI / 180) * ShadowDepth; public double Direction { get; } public double ShadowDepth { get; } public double BlurRadius { get; } From e2429184e4eacb70a0b1f5ba44054cfd0c8e6390 Mon Sep 17 00:00:00 2001 From: Nikita Tsukanov Date: Fri, 14 Apr 2023 22:02:31 +0600 Subject: [PATCH 2/2] DropShadow default color = black --- src/Avalonia.Base/Media/Effects/DropShadowEffect.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Avalonia.Base/Media/Effects/DropShadowEffect.cs b/src/Avalonia.Base/Media/Effects/DropShadowEffect.cs index 5e4bc0a7ea..ea931c0a8c 100644 --- a/src/Avalonia.Base/Media/Effects/DropShadowEffect.cs +++ b/src/Avalonia.Base/Media/Effects/DropShadowEffect.cs @@ -18,7 +18,7 @@ public abstract class DropShadowEffectBase : Effect } public static readonly StyledProperty ColorProperty = AvaloniaProperty.Register( - nameof(Color)); + nameof(Color), Colors.Black); public Color Color {