Jeremy Koritzinsky
8 years ago
committed by
GitHub
GitHub
14 changed files with 490 additions and 130 deletions
@ -0,0 +1,85 @@ |
|||
using System; |
|||
using Avalonia.Data.Core; |
|||
using Avalonia.Markup.Parsers; |
|||
using Avalonia.Utilities; |
|||
|
|||
namespace Avalonia.Markup.Xaml.Parsers |
|||
{ |
|||
internal class PropertyParser |
|||
{ |
|||
public (string ns, string owner, string name) Parse(CharacterReader r) |
|||
{ |
|||
if (r.End) |
|||
{ |
|||
throw new ExpressionParseException(0, "Expected property name."); |
|||
} |
|||
|
|||
var openParens = r.TakeIf('('); |
|||
bool closeParens = false; |
|||
string ns = null; |
|||
string owner = null; |
|||
string name = null; |
|||
|
|||
do |
|||
{ |
|||
var token = IdentifierParser.Parse(r); |
|||
|
|||
if (token == null) |
|||
{ |
|||
if (r.End) |
|||
{ |
|||
break; |
|||
} |
|||
else |
|||
{ |
|||
if (openParens && !r.End && (closeParens = r.TakeIf(')'))) |
|||
{ |
|||
break; |
|||
} |
|||
else if (openParens) |
|||
{ |
|||
throw new ExpressionParseException(r.Position, $"Expected ')'."); |
|||
} |
|||
|
|||
throw new ExpressionParseException(r.Position, $"Unexpected '{r.Peek}'."); |
|||
} |
|||
} |
|||
else if (!r.End && r.TakeIf(':')) |
|||
{ |
|||
ns = ns == null ? |
|||
token : |
|||
throw new ExpressionParseException(r.Position, "Unexpected ':'."); |
|||
} |
|||
else if (!r.End && r.TakeIf('.')) |
|||
{ |
|||
owner = owner == null ? |
|||
token : |
|||
throw new ExpressionParseException(r.Position, "Unexpected '.'."); |
|||
} |
|||
else |
|||
{ |
|||
name = token; |
|||
} |
|||
} while (!r.End); |
|||
|
|||
if (name == null) |
|||
{ |
|||
throw new ExpressionParseException(0, "Expected property name."); |
|||
} |
|||
else if (openParens && owner == null) |
|||
{ |
|||
throw new ExpressionParseException(1, "Expected property owner."); |
|||
} |
|||
else if (openParens && !closeParens) |
|||
{ |
|||
throw new ExpressionParseException(r.Position, "Expected ')'."); |
|||
} |
|||
else if (!r.End) |
|||
{ |
|||
throw new ExpressionParseException(r.Position, "Expected end of expression."); |
|||
} |
|||
|
|||
return (ns, owner, name); |
|||
} |
|||
} |
|||
} |
|||
@ -0,0 +1,226 @@ |
|||
using System; |
|||
using Avalonia.Data.Core; |
|||
using Avalonia.Markup.Parsers; |
|||
using Avalonia.Markup.Xaml.Parsers; |
|||
using Avalonia.Utilities; |
|||
using Xunit; |
|||
|
|||
namespace Avalonia.Markup.Xaml.UnitTests.Parsers |
|||
{ |
|||
public class PropertyParserTests |
|||
{ |
|||
[Fact] |
|||
public void Parses_Name() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader("Foo"); |
|||
var (ns, owner, name) = target.Parse(reader); |
|||
|
|||
Assert.Null(ns); |
|||
Assert.Null(owner); |
|||
Assert.Equal("Foo", name); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Parses_Owner_And_Name() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader("Foo.Bar"); |
|||
var (ns, owner, name) = target.Parse(reader); |
|||
|
|||
Assert.Null(ns); |
|||
Assert.Equal("Foo", owner); |
|||
Assert.Equal("Bar", name); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Parses_Namespace_Owner_And_Name() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader("foo:Bar.Baz"); |
|||
var (ns, owner, name) = target.Parse(reader); |
|||
|
|||
Assert.Equal("foo", ns); |
|||
Assert.Equal("Bar", owner); |
|||
Assert.Equal("Baz", name); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Parses_Owner_And_Name_With_Parentheses() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader("(Foo.Bar)"); |
|||
var (ns, owner, name) = target.Parse(reader); |
|||
|
|||
Assert.Null(ns); |
|||
Assert.Equal("Foo", owner); |
|||
Assert.Equal("Bar", name); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Parses_Namespace_Owner_And_Name_With_Parentheses() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader("(foo:Bar.Baz)"); |
|||
var (ns, owner, name) = target.Parse(reader); |
|||
|
|||
Assert.Equal("foo", ns); |
|||
Assert.Equal("Bar", owner); |
|||
Assert.Equal("Baz", name); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Fails_With_Empty_String() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader(""); |
|||
|
|||
var ex = Assert.Throws<ExpressionParseException>(() => target.Parse(reader)); |
|||
Assert.Equal(0, ex.Column); |
|||
Assert.Equal("Expected property name.", ex.Message); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Fails_With_Only_Whitespace() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader(" "); |
|||
|
|||
var ex = Assert.Throws<ExpressionParseException>(() => target.Parse(reader)); |
|||
Assert.Equal(0, ex.Column); |
|||
Assert.Equal("Unexpected ' '.", ex.Message); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Fails_With_Leading_Whitespace() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader(" Foo"); |
|||
|
|||
var ex = Assert.Throws<ExpressionParseException>(() => target.Parse(reader)); |
|||
Assert.Equal(0, ex.Column); |
|||
Assert.Equal("Unexpected ' '.", ex.Message); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Fails_With_Trailing_Whitespace() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader("Foo "); |
|||
|
|||
var ex = Assert.Throws<ExpressionParseException>(() => target.Parse(reader)); |
|||
Assert.Equal(3, ex.Column); |
|||
Assert.Equal("Unexpected ' '.", ex.Message); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Fails_With_Invalid_Property_Name() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader("123"); |
|||
|
|||
var ex = Assert.Throws<ExpressionParseException>(() => target.Parse(reader)); |
|||
Assert.Equal(0, ex.Column); |
|||
Assert.Equal("Unexpected '1'.", ex.Message); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Fails_With_Trailing_Junk() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader("Foo%"); |
|||
|
|||
var ex = Assert.Throws<ExpressionParseException>(() => target.Parse(reader)); |
|||
Assert.Equal(3, ex.Column); |
|||
Assert.Equal("Unexpected '%'.", ex.Message); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Fails_With_Invalid_Property_Name_After_Owner() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader("Foo.123"); |
|||
|
|||
var ex = Assert.Throws<ExpressionParseException>(() => target.Parse(reader)); |
|||
Assert.Equal(4, ex.Column); |
|||
Assert.Equal("Unexpected '1'.", ex.Message); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Fails_With_Whitespace_Between_Owner_And_Name() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader("Foo. Bar"); |
|||
|
|||
var ex = Assert.Throws<ExpressionParseException>(() => target.Parse(reader)); |
|||
Assert.Equal(4, ex.Column); |
|||
Assert.Equal("Unexpected ' '.", ex.Message); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Fails_With_Too_Many_Segments() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader("Foo.Bar.Baz"); |
|||
|
|||
var ex = Assert.Throws<ExpressionParseException>(() => target.Parse(reader)); |
|||
Assert.Equal(8, ex.Column); |
|||
Assert.Equal("Unexpected '.'.", ex.Message); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Fails_With_Too_Many_Namespaces() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader("foo:bar:Baz"); |
|||
|
|||
var ex = Assert.Throws<ExpressionParseException>(() => target.Parse(reader)); |
|||
Assert.Equal(8, ex.Column); |
|||
Assert.Equal("Unexpected ':'.", ex.Message); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Fails_With_Parens_But_No_Owner() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader("(Foo)"); |
|||
|
|||
var ex = Assert.Throws<ExpressionParseException>(() => target.Parse(reader)); |
|||
Assert.Equal(1, ex.Column); |
|||
Assert.Equal("Expected property owner.", ex.Message); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Fails_With_Parens_And_Namespace_But_No_Owner() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader("(foo:Bar)"); |
|||
|
|||
var ex = Assert.Throws<ExpressionParseException>(() => target.Parse(reader)); |
|||
Assert.Equal(1, ex.Column); |
|||
Assert.Equal("Expected property owner.", ex.Message); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Fails_With_Missing_Close_Parens() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader("(Foo.Bar"); |
|||
|
|||
var ex = Assert.Throws<ExpressionParseException>(() => target.Parse(reader)); |
|||
Assert.Equal(8, ex.Column); |
|||
Assert.Equal("Expected ')'.", ex.Message); |
|||
} |
|||
|
|||
[Fact] |
|||
public void Fails_With_Unexpected_Close_Parens() |
|||
{ |
|||
var target = new PropertyParser(); |
|||
var reader = new CharacterReader("Foo.Bar)"); |
|||
|
|||
var ex = Assert.Throws<ExpressionParseException>(() => target.Parse(reader)); |
|||
Assert.Equal(7, ex.Column); |
|||
Assert.Equal("Unexpected ')'.", ex.Message); |
|||
} |
|||
} |
|||
} |
|||
Loading…
Reference in new issue