From 24ebe441f60e89f688573518386127b2196d2ba8 Mon Sep 17 00:00:00 2001
From: Giuseppe Lippolis <workgroupengineering@outlook.com>
Date: Fri, 24 Feb 2023 17:09:58 +0100
Subject: [PATCH] fix: Address Rule AVP1010 AvaloniaProperty owner {type} ,
 which is not the containing type

fixes:

```bash
Warning AVP1010 Type mismatch: AvaloniaProperty owner is Avalonia.Controls.MenuItem, which is not the containing type Avalonia.Controls (net6.0) .\src\Avalonia.Controls\TrayIcon.cs 98 Active
Warning AVP1010 Type mismatch: AvaloniaProperty owner is Avalonia.Controls.MenuItem, which is not the containing type Avalonia.Controls (net6.0) .\src\Avalonia.Controls\NativeMenuItem.cs 140 Active
Warning AVP1010 Type mismatch: AvaloniaProperty owner is Avalonia.Controls.Control, which is not the containing type Avalonia.Controls (net6.0) .\src\Avalonia.Controls\Primitives\AdornerLayer.cs 41 Active
Warning AVP1010 Type mismatch: AvaloniaProperty owner is Avalonia.Application, which is not the containing type Avalonia.Controls (net6.0) .\src\Avalonia.Controls\TopLevel.cs 85 Active
Warning AVP1010 Type mismatch: AvaloniaProperty owner is Avalonia.Application, which is not the containing type Avalonia.Controls (net6.0) .\src\Avalonia.Controls\TopLevel.cs 89 Active
Warning AVP1010 Type mismatch: AvaloniaProperty owner is Avalonia.Controls.StackPanel, which is not the containing type Avalonia.Controls.ItemsRepeater (netstandard2.0) .\src\Avalonia.Controls.ItemsRepeater\Layout\StackLayout.cs 29 Active
```
---
 src/Avalonia.Controls.ItemsRepeater/Layout/StackLayout.cs | 2 +-
 src/Avalonia.Controls/NativeMenuItem.cs                   | 2 +-
 src/Avalonia.Controls/Primitives/AdornerLayer.cs          | 3 +--
 src/Avalonia.Controls/TrayIcon.cs                         | 2 +-
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/Avalonia.Controls.ItemsRepeater/Layout/StackLayout.cs b/src/Avalonia.Controls.ItemsRepeater/Layout/StackLayout.cs
index 5e2b2b8574..5db589fd5b 100644
--- a/src/Avalonia.Controls.ItemsRepeater/Layout/StackLayout.cs
+++ b/src/Avalonia.Controls.ItemsRepeater/Layout/StackLayout.cs
@@ -26,7 +26,7 @@ namespace Avalonia.Layout
         /// Defines the <see cref="Orientation"/> property.
         /// </summary>
         public static readonly StyledProperty<Orientation> OrientationProperty =
-            StackPanel.OrientationProperty.AddOwner<StackPanel>();
+            StackPanel.OrientationProperty.AddOwner<StackLayout>();
 
         /// <summary>
         /// Defines the <see cref="Spacing"/> property.
diff --git a/src/Avalonia.Controls/NativeMenuItem.cs b/src/Avalonia.Controls/NativeMenuItem.cs
index 526eff0f12..32fa574ee6 100644
--- a/src/Avalonia.Controls/NativeMenuItem.cs
+++ b/src/Avalonia.Controls/NativeMenuItem.cs
@@ -137,7 +137,7 @@ namespace Avalonia.Controls
         /// Defines the <see cref="CommandParameter"/> property.
         /// </summary>
         public static readonly StyledProperty<object?> CommandParameterProperty =
-            Button.CommandParameterProperty.AddOwner<MenuItem>();
+            Button.CommandParameterProperty.AddOwner<NativeMenuItem>();
 
         public static readonly DirectProperty<NativeMenuItem, bool> IsEnabledProperty =
            AvaloniaProperty.RegisterDirect<NativeMenuItem, bool>(nameof(IsEnabled), o => o.IsEnabled, (o, v) => o.IsEnabled = v, true);
diff --git a/src/Avalonia.Controls/Primitives/AdornerLayer.cs b/src/Avalonia.Controls/Primitives/AdornerLayer.cs
index 1e07036919..37c46e1e7d 100644
--- a/src/Avalonia.Controls/Primitives/AdornerLayer.cs
+++ b/src/Avalonia.Controls/Primitives/AdornerLayer.cs
@@ -2,7 +2,6 @@ using System;
 using System.Collections.Specialized;
 using Avalonia.Media;
 using Avalonia.Reactive;
-using Avalonia.Rendering;
 using Avalonia.VisualTree;
 
 namespace Avalonia.Controls.Primitives
@@ -38,7 +37,7 @@ namespace Avalonia.Controls.Primitives
         /// Defines the <see cref="DefaultFocusAdorner"/> property.
         /// </summary>
         public static readonly StyledProperty<ITemplate<Control>?> DefaultFocusAdornerProperty =
-            AvaloniaProperty.Register<Control, ITemplate<Control>?>(nameof(DefaultFocusAdorner));
+            AvaloniaProperty.Register<AdornerLayer, ITemplate<Control>?>(nameof(DefaultFocusAdorner));
         
         private static readonly AttachedProperty<AdornedElementInfo?> s_adornedElementInfoProperty =
             AvaloniaProperty.RegisterAttached<AdornerLayer, Visual, AdornedElementInfo?>("AdornedElementInfo");
diff --git a/src/Avalonia.Controls/TrayIcon.cs b/src/Avalonia.Controls/TrayIcon.cs
index 93b177715e..5713846b35 100644
--- a/src/Avalonia.Controls/TrayIcon.cs
+++ b/src/Avalonia.Controls/TrayIcon.cs
@@ -95,7 +95,7 @@ namespace Avalonia.Controls
         /// Defines the <see cref="CommandParameter"/> property.
         /// </summary>
         public static readonly StyledProperty<object?> CommandParameterProperty =
-            Button.CommandParameterProperty.AddOwner<MenuItem>();
+            Button.CommandParameterProperty.AddOwner<TrayIcon>();
 
         /// <summary>
         /// Defines the <see cref="TrayIcons"/> attached property.