From 2a185da6391bd550d9babc8d1e005135e18dd071 Mon Sep 17 00:00:00 2001 From: aljosas Date: Tue, 23 Mar 2021 14:45:42 +0100 Subject: [PATCH] removing Dispatcher.UIThread.RunJobs() from tests --- tests/Avalonia.Controls.UnitTests/CarouselTests.cs | 2 -- tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs | 2 -- tests/Avalonia.Controls.UnitTests/ListBoxTests.cs | 4 +--- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/tests/Avalonia.Controls.UnitTests/CarouselTests.cs b/tests/Avalonia.Controls.UnitTests/CarouselTests.cs index ea39093602..b93e48618d 100644 --- a/tests/Avalonia.Controls.UnitTests/CarouselTests.cs +++ b/tests/Avalonia.Controls.UnitTests/CarouselTests.cs @@ -335,8 +335,6 @@ namespace Avalonia.Controls.UnitTests BindingErrorType.DataValidationError)); target.Bind(ComboBox.SelectedItemProperty, textObservable); - Dispatcher.UIThread.RunJobs(); - Assert.True(DataValidationErrors.GetHasErrors(target)); Assert.True(DataValidationErrors.GetErrors(target).SequenceEqual(new[] { exception })); } diff --git a/tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs b/tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs index 5395dfeadb..8f9c7fdb0b 100644 --- a/tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs +++ b/tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs @@ -195,8 +195,6 @@ namespace Avalonia.Controls.UnitTests var exception = new System.InvalidCastException("failed validation"); var textObservable = new BehaviorSubject(new BindingNotification(exception, BindingErrorType.DataValidationError)); target.Bind(ComboBox.SelectedItemProperty, textObservable); - - Dispatcher.UIThread.RunJobs(); Assert.True(DataValidationErrors.GetHasErrors(target)); Assert.True(DataValidationErrors.GetErrors(target).SequenceEqual(new[] { exception })); diff --git a/tests/Avalonia.Controls.UnitTests/ListBoxTests.cs b/tests/Avalonia.Controls.UnitTests/ListBoxTests.cs index f3d71962b9..963bba7c83 100644 --- a/tests/Avalonia.Controls.UnitTests/ListBoxTests.cs +++ b/tests/Avalonia.Controls.UnitTests/ListBoxTests.cs @@ -573,7 +573,7 @@ namespace Avalonia.Controls.UnitTests Items = new[] { "Foo" }, ItemTemplate = new FuncDataTemplate((_, __) => new Canvas()), SelectionMode = SelectionMode.AlwaysSelected, - VirtualizationMode = ItemVirtualizationMode.None, + VirtualizationMode = ItemVirtualizationMode.None }; Prepare(target); @@ -582,8 +582,6 @@ namespace Avalonia.Controls.UnitTests var textObservable = new BehaviorSubject(new BindingNotification(exception, BindingErrorType.DataValidationError)); target.Bind(ComboBox.SelectedItemProperty, textObservable); - Dispatcher.UIThread.RunJobs(); - Assert.True(DataValidationErrors.GetHasErrors(target)); Assert.True(DataValidationErrors.GetErrors(target).SequenceEqual(new[] { exception })); }