diff --git a/src/Avalonia.Controls.DataGrid/DataGrid.cs b/src/Avalonia.Controls.DataGrid/DataGrid.cs
index 844316741a..3a1e612a05 100644
--- a/src/Avalonia.Controls.DataGrid/DataGrid.cs
+++ b/src/Avalonia.Controls.DataGrid/DataGrid.cs
@@ -2245,7 +2245,7 @@ namespace Avalonia.Controls
/// Builds the visual tree for the column header when a new template is applied.
///
//TODO Validation UI
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
// The template has changed, so we need to refresh the visuals
_measured = false;
diff --git a/src/Avalonia.Controls.DataGrid/DataGridCell.cs b/src/Avalonia.Controls.DataGrid/DataGridCell.cs
index e56c534f50..76b064c328 100644
--- a/src/Avalonia.Controls.DataGrid/DataGridCell.cs
+++ b/src/Avalonia.Controls.DataGrid/DataGridCell.cs
@@ -121,10 +121,8 @@ namespace Avalonia.Controls
///
/// Builds the visual tree for the cell control when a new template is applied.
///
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
- base.OnTemplateApplied(e);
-
UpdatePseudoClasses();
_rightGridLine = e.NameScope.Find(DATAGRIDCELL_elementRightGridLine);
if (_rightGridLine != null && OwningColumn == null)
diff --git a/src/Avalonia.Controls.DataGrid/DataGridRow.cs b/src/Avalonia.Controls.DataGrid/DataGridRow.cs
index c9924660be..0c801a5b11 100644
--- a/src/Avalonia.Controls.DataGrid/DataGridRow.cs
+++ b/src/Avalonia.Controls.DataGrid/DataGridRow.cs
@@ -536,10 +536,8 @@ namespace Avalonia.Controls
///
/// Builds the visual tree for the column header when a new template is applied.
///
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
- base.OnTemplateApplied(e);
-
RootElement = e.NameScope.Find(DATAGRIDROW_elementRoot);
if (RootElement != null)
{
diff --git a/src/Avalonia.Controls.DataGrid/DataGridRowGroupHeader.cs b/src/Avalonia.Controls.DataGrid/DataGridRowGroupHeader.cs
index 69dfed761f..f6628b47d8 100644
--- a/src/Avalonia.Controls.DataGrid/DataGridRowGroupHeader.cs
+++ b/src/Avalonia.Controls.DataGrid/DataGridRowGroupHeader.cs
@@ -168,7 +168,7 @@ namespace Avalonia.Controls
private IDisposable _expanderButtonSubscription;
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
_rootElement = e.NameScope.Find(DataGridRow.DATAGRIDROW_elementRoot);
@@ -199,8 +199,6 @@ namespace Avalonia.Controls
_itemCountElement = e.NameScope.Find(DATAGRIDROWGROUPHEADER_itemCountElement);
_propertyNameElement = e.NameScope.Find(DATAGRIDROWGROUPHEADER_propertyNameElement);
UpdateTitleElements();
-
- base.OnTemplateApplied(e);
}
internal void ApplyHeaderStatus()
diff --git a/src/Avalonia.Controls.DataGrid/DataGridRowHeader.cs b/src/Avalonia.Controls.DataGrid/DataGridRowHeader.cs
index 5bfe449b63..ef88e4a946 100644
--- a/src/Avalonia.Controls.DataGrid/DataGridRowHeader.cs
+++ b/src/Avalonia.Controls.DataGrid/DataGridRowHeader.cs
@@ -94,10 +94,8 @@ namespace Avalonia.Controls.Primitives
///
/// Builds the visual tree for the row header when a new template is applied.
///
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
- base.OnTemplateApplied(e);
-
_rootElement = e.NameScope.Find(DATAGRIDROWHEADER_elementRootName);
if (_rootElement != null)
{
diff --git a/src/Avalonia.Controls/AutoCompleteBox.cs b/src/Avalonia.Controls/AutoCompleteBox.cs
index 9bc7ba9e2f..3e4f47ec8a 100644
--- a/src/Avalonia.Controls/AutoCompleteBox.cs
+++ b/src/Avalonia.Controls/AutoCompleteBox.cs
@@ -1212,7 +1212,7 @@ namespace Avalonia.Controls
/// control
/// when a new template is applied.
///
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
if (DropDownPopup != null)
@@ -1240,7 +1240,7 @@ namespace Avalonia.Controls
OpeningDropDown(false);
}
- base.OnTemplateApplied(e);
+ base.OnApplyTemplate(e);
}
///
diff --git a/src/Avalonia.Controls/ButtonSpinner.cs b/src/Avalonia.Controls/ButtonSpinner.cs
index 2ac9319478..7945d63b06 100644
--- a/src/Avalonia.Controls/ButtonSpinner.cs
+++ b/src/Avalonia.Controls/ButtonSpinner.cs
@@ -121,7 +121,7 @@ namespace Avalonia.Controls
}
///
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
IncreaseButton = e.NameScope.Find
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
- base.OnTemplateApplied(e);
-
Root = e.NameScope.Find(PART_ElementRoot);
SelectedMonth = DisplayDate;
diff --git a/src/Avalonia.Controls/Calendar/CalendarButton.cs b/src/Avalonia.Controls/Calendar/CalendarButton.cs
index a273e68d56..35c082634f 100644
--- a/src/Avalonia.Controls/Calendar/CalendarButton.cs
+++ b/src/Avalonia.Controls/Calendar/CalendarButton.cs
@@ -98,9 +98,8 @@ namespace Avalonia.Controls.Primitives
///
/// when a new template is applied.
///
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
- base.OnTemplateApplied(e);
SetPseudoClasses();
}
diff --git a/src/Avalonia.Controls/Calendar/CalendarDayButton.cs b/src/Avalonia.Controls/Calendar/CalendarDayButton.cs
index e62a1ce1f4..91213acfb3 100644
--- a/src/Avalonia.Controls/Calendar/CalendarDayButton.cs
+++ b/src/Avalonia.Controls/Calendar/CalendarDayButton.cs
@@ -150,11 +150,11 @@ namespace Avalonia.Controls.Primitives
}
}
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
- base.OnTemplateApplied(e);
SetPseudoClasses();
}
+
private void SetPseudoClasses()
{
if (_ignoringMouseOverState)
diff --git a/src/Avalonia.Controls/Calendar/CalendarItem.cs b/src/Avalonia.Controls/Calendar/CalendarItem.cs
index 5a2d1bbfd5..ece0ef97d9 100644
--- a/src/Avalonia.Controls/Calendar/CalendarItem.cs
+++ b/src/Avalonia.Controls/Calendar/CalendarItem.cs
@@ -268,10 +268,8 @@ namespace Avalonia.Controls.Primitives
///
/// when a new template is applied.
///
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
- base.OnTemplateApplied(e);
-
HeaderButton = e.NameScope.Find(PART_ElementHeaderButton);
PreviousButton = e.NameScope.Find(PART_ElementPreviousButton);
NextButton = e.NameScope.Find(PART_ElementNextButton);
diff --git a/src/Avalonia.Controls/Calendar/DatePicker.cs b/src/Avalonia.Controls/Calendar/DatePicker.cs
index b4e4ad1452..de0b09f8e6 100644
--- a/src/Avalonia.Controls/Calendar/DatePicker.cs
+++ b/src/Avalonia.Controls/Calendar/DatePicker.cs
@@ -413,7 +413,7 @@ namespace Avalonia.Controls
DisplayDate = DateTime.Today;
}
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
if (_calendar != null)
{
@@ -508,8 +508,6 @@ namespace Avalonia.Controls
SetSelectedDate();
}
}
-
- base.OnTemplateApplied(e);
}
protected override void OnPropertyChanged(
diff --git a/src/Avalonia.Controls/ComboBox.cs b/src/Avalonia.Controls/ComboBox.cs
index 1daa6a5630..18c4c88aa5 100644
--- a/src/Avalonia.Controls/ComboBox.cs
+++ b/src/Avalonia.Controls/ComboBox.cs
@@ -219,7 +219,7 @@ namespace Avalonia.Controls
}
///
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
if (_popup != null)
{
@@ -230,8 +230,6 @@ namespace Avalonia.Controls
_popup = e.NameScope.Get("PART_Popup");
_popup.Opened += PopupOpened;
_popup.Closed += PopupClosed;
-
- base.OnTemplateApplied(e);
}
internal void ItemFocused(ComboBoxItem dropDownItem)
diff --git a/src/Avalonia.Controls/ListBox.cs b/src/Avalonia.Controls/ListBox.cs
index a9349dadd9..32d237d2b7 100644
--- a/src/Avalonia.Controls/ListBox.cs
+++ b/src/Avalonia.Controls/ListBox.cs
@@ -146,10 +146,9 @@ namespace Avalonia.Controls
}
}
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
Scroll = e.NameScope.Find("PART_ScrollViewer");
- base.OnTemplateApplied(e);
}
}
}
diff --git a/src/Avalonia.Controls/MenuItem.cs b/src/Avalonia.Controls/MenuItem.cs
index 91ee0cf534..b08519963b 100644
--- a/src/Avalonia.Controls/MenuItem.cs
+++ b/src/Avalonia.Controls/MenuItem.cs
@@ -417,10 +417,8 @@ namespace Avalonia.Controls
}
///
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
- base.OnTemplateApplied(e);
-
if (_popup != null)
{
_popup.Opened -= PopupOpened;
diff --git a/src/Avalonia.Controls/Notifications/WindowNotificationManager.cs b/src/Avalonia.Controls/Notifications/WindowNotificationManager.cs
index f1d8fe6763..0cfea2c68b 100644
--- a/src/Avalonia.Controls/Notifications/WindowNotificationManager.cs
+++ b/src/Avalonia.Controls/Notifications/WindowNotificationManager.cs
@@ -77,10 +77,8 @@ namespace Avalonia.Controls.Notifications
}
///
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
- base.OnTemplateApplied(e);
-
var itemsControl = e.NameScope.Find("PART_Items");
_items = itemsControl?.Children;
}
diff --git a/src/Avalonia.Controls/NumericUpDown/NumericUpDown.cs b/src/Avalonia.Controls/NumericUpDown/NumericUpDown.cs
index cbb5b667e7..aae041071d 100644
--- a/src/Avalonia.Controls/NumericUpDown/NumericUpDown.cs
+++ b/src/Avalonia.Controls/NumericUpDown/NumericUpDown.cs
@@ -295,7 +295,7 @@ namespace Avalonia.Controls
}
///
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
if (TextBox != null)
{
diff --git a/src/Avalonia.Controls/Primitives/ScrollBar.cs b/src/Avalonia.Controls/Primitives/ScrollBar.cs
index d48a9316e8..2e6292b4b4 100644
--- a/src/Avalonia.Controls/Primitives/ScrollBar.cs
+++ b/src/Avalonia.Controls/Primitives/ScrollBar.cs
@@ -147,10 +147,8 @@ namespace Avalonia.Controls.Primitives
}
}
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
- base.OnTemplateApplied(e);
-
if (_lineUpButton != null)
{
_lineUpButton.Click -= LineUpClick;
diff --git a/src/Avalonia.Controls/Primitives/TemplatedControl.cs b/src/Avalonia.Controls/Primitives/TemplatedControl.cs
index 3837ef4699..745ee40f48 100644
--- a/src/Avalonia.Controls/Primitives/TemplatedControl.cs
+++ b/src/Avalonia.Controls/Primitives/TemplatedControl.cs
@@ -263,7 +263,9 @@ namespace Avalonia.Controls.Primitives
if (nameScope == null)
nameScope = new NameScope();
- OnTemplateApplied(new TemplateAppliedEventArgs(nameScope));
+ var e = new TemplateAppliedEventArgs(nameScope);
+ OnApplyTemplate(e);
+ RaiseEvent(e);
}
_appliedTemplate = template;
@@ -306,13 +308,17 @@ namespace Avalonia.Controls.Primitives
base.OnDetachedFromLogicalTree(e);
}
+ protected virtual void OnApplyTemplate(TemplateAppliedEventArgs e)
+ {
+ }
+
///
/// Called when the control's template is applied.
///
/// The event args.
+ [Obsolete("Use OnApplyTemplate")]
protected virtual void OnTemplateApplied(TemplateAppliedEventArgs e)
{
- RaiseEvent(e);
}
///
diff --git a/src/Avalonia.Controls/ProgressBar.cs b/src/Avalonia.Controls/ProgressBar.cs
index 361a82e49c..9225625bf5 100644
--- a/src/Avalonia.Controls/ProgressBar.cs
+++ b/src/Avalonia.Controls/ProgressBar.cs
@@ -102,7 +102,7 @@ namespace Avalonia.Controls
}
///
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
_indicator = e.NameScope.Get("PART_Indicator");
diff --git a/src/Avalonia.Controls/Slider.cs b/src/Avalonia.Controls/Slider.cs
index b883a76d1b..f243372926 100644
--- a/src/Avalonia.Controls/Slider.cs
+++ b/src/Avalonia.Controls/Slider.cs
@@ -82,7 +82,7 @@ namespace Avalonia.Controls
}
///
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
if (_decreaseButton != null)
{
diff --git a/src/Avalonia.Controls/TabControl.cs b/src/Avalonia.Controls/TabControl.cs
index f556865fda..d3c65e69de 100644
--- a/src/Avalonia.Controls/TabControl.cs
+++ b/src/Avalonia.Controls/TabControl.cs
@@ -217,10 +217,8 @@ namespace Avalonia.Controls
return new TabItemContainerGenerator(this);
}
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
- base.OnTemplateApplied(e);
-
ItemsPresenterPart = e.NameScope.Get("PART_ItemsPresenter");
}
diff --git a/src/Avalonia.Controls/TextBox.cs b/src/Avalonia.Controls/TextBox.cs
index 06624c555f..42e16e6979 100644
--- a/src/Avalonia.Controls/TextBox.cs
+++ b/src/Avalonia.Controls/TextBox.cs
@@ -341,7 +341,7 @@ namespace Avalonia.Controls
set { SetAndRaise(NewLineProperty, ref _newLine, value); }
}
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
_presenter = e.NameScope.Get("PART_TextPresenter");
diff --git a/src/Avalonia.Controls/TreeViewItem.cs b/src/Avalonia.Controls/TreeViewItem.cs
index d3bd45d13c..cd586f7701 100644
--- a/src/Avalonia.Controls/TreeViewItem.cs
+++ b/src/Avalonia.Controls/TreeViewItem.cs
@@ -162,9 +162,8 @@ namespace Avalonia.Controls
// Don't call base.OnKeyDown - let events bubble up to containing TreeView.
}
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
- base.OnTemplateApplied(e);
_header = e.NameScope.Find("PART_Header");
}
diff --git a/tests/Avalonia.Controls.UnitTests/Primitives/PopupRootTests.cs b/tests/Avalonia.Controls.UnitTests/Primitives/PopupRootTests.cs
index a61d313c8c..ddf109f80e 100644
--- a/tests/Avalonia.Controls.UnitTests/Primitives/PopupRootTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/Primitives/PopupRootTests.cs
@@ -352,7 +352,7 @@ namespace Avalonia.Controls.UnitTests.Primitives
set => SetValue(PopupContentProperty, value);
}
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
Popup = (Popup)this.GetVisualChildren().Single();
}
diff --git a/tests/Avalonia.Controls.UnitTests/TestTemplatedControl.cs b/tests/Avalonia.Controls.UnitTests/TestTemplatedControl.cs
index 5b0520b666..7636ad9db9 100644
--- a/tests/Avalonia.Controls.UnitTests/TestTemplatedControl.cs
+++ b/tests/Avalonia.Controls.UnitTests/TestTemplatedControl.cs
@@ -12,9 +12,8 @@ namespace Avalonia.Controls.UnitTests
VisualChildren.Add(visual);
}
- protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
+ protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
{
- base.OnTemplateApplied(e);
OnTemplateAppliedCalled = true;
}
}