Browse Source

Make some todo-areas of the code more clear

pull/9140/head
robloo 4 years ago
parent
commit
2fdbbacc60
  1. 4
      src/Avalonia.Controls.ColorPicker/ColorSlider/ColorSlider.cs
  2. 2
      src/Avalonia.Controls.ColorPicker/Helpers/ColorPickerHelpers.cs

4
src/Avalonia.Controls.ColorPicker/ColorSlider/ColorSlider.cs

@ -127,14 +127,14 @@ namespace Avalonia.Controls.Primitives
{ {
if (_backgroundBitmap != null) if (_backgroundBitmap != null)
{ {
// CURRENTLY DISABLED DUE TO INTERMITTENT CRASHES IN SKIA/RENDERER // TODO: CURRENTLY DISABLED DUE TO INTERMITTENT CRASHES IN SKIA/RENDERER
// //
// Re-use the existing WriteableBitmap // Re-use the existing WriteableBitmap
// This assumes the height, width and byte counts are the same and must be set to null // This assumes the height, width and byte counts are the same and must be set to null
// elsewhere if that assumption is ever not true. // elsewhere if that assumption is ever not true.
// ColorPickerHelpers.UpdateBitmapFromPixelData(_backgroundBitmap, bgraPixelData); // ColorPickerHelpers.UpdateBitmapFromPixelData(_backgroundBitmap, bgraPixelData);
// ALSO DISABLED DISPOSE DUE TO INTERMITTENT CRASHES // TODO: ALSO DISABLED DISPOSE DUE TO INTERMITTENT CRASHES
//_backgroundBitmap?.Dispose(); //_backgroundBitmap?.Dispose();
_backgroundBitmap = ColorPickerHelpers.CreateBitmapFromPixelData(bgraPixelData, pixelWidth, pixelHeight); _backgroundBitmap = ColorPickerHelpers.CreateBitmapFromPixelData(bgraPixelData, pixelWidth, pixelHeight);
} }

2
src/Avalonia.Controls.ColorPicker/Helpers/ColorPickerHelpers.cs

@ -627,7 +627,7 @@ namespace Avalonia.Controls.Primitives
/// <summary> /// <summary>
/// Updates the given <see cref="WriteableBitmap"/> with new, raw BGRA pre-multiplied alpha pixel data. /// Updates the given <see cref="WriteableBitmap"/> with new, raw BGRA pre-multiplied alpha pixel data.
/// WARNING: THIS METHOD IS CURRENTLY PROVIDED AS REFERENCE BUT CAUSES INTERMITTENT CRASHES IF USED. /// TODO: THIS METHOD IS CURRENTLY PROVIDED AS REFERENCE BUT CAUSES INTERMITTENT CRASHES IF USED.
/// WARNING: The bitmap's width, height and byte count MUST not have changed and MUST be enforced externally. /// WARNING: The bitmap's width, height and byte count MUST not have changed and MUST be enforced externally.
/// </summary> /// </summary>
/// <param name="bitmap">The existing <see cref="WriteableBitmap"/> to update.</param> /// <param name="bitmap">The existing <see cref="WriteableBitmap"/> to update.</param>

Loading…
Cancel
Save