From 31c43d978e3b9cf7aad1a1d1ade8c941b87ee10b Mon Sep 17 00:00:00 2001
From: Melissa <melissa@nimble.tools>
Date: Thu, 25 Sep 2025 20:16:11 +0200
Subject: [PATCH] Added resource for TextControlPlaceholderOpacity (#19705)

* Added resource for TextControlPlaceholderOpacity

This allows overriding of the opacity instead of it being hardcoded to 50%.

* Added `TextControlPlaceholderOpacity` to Simple theme TextBox
---
 src/Avalonia.Themes.Fluent/Accents/FluentControlResources.xaml | 1 +
 src/Avalonia.Themes.Fluent/Controls/TextBox.xaml               | 2 +-
 src/Avalonia.Themes.Simple/Accents/Base.xaml                   | 2 ++
 src/Avalonia.Themes.Simple/Controls/TextBox.xaml               | 2 +-
 4 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/Avalonia.Themes.Fluent/Accents/FluentControlResources.xaml b/src/Avalonia.Themes.Fluent/Accents/FluentControlResources.xaml
index 6d65889cba..10bccf39cf 100644
--- a/src/Avalonia.Themes.Fluent/Accents/FluentControlResources.xaml
+++ b/src/Avalonia.Themes.Fluent/Accents/FluentControlResources.xaml
@@ -240,6 +240,7 @@
       <StaticResource x:Key="TextControlBackgroundDisabled" ResourceKey="SystemControlBackgroundBaseLowBrush" />
       <StaticResource x:Key="TextControlBorderBrushFocused" ResourceKey="SystemControlHighlightAccentBrush" />
       <StaticResource x:Key="TextControlBorderBrushDisabled" ResourceKey="SystemControlDisabledBaseLowBrush" />
+      <x:Double x:Key="TextControlPlaceholderOpacity">0.5</x:Double>
       <StaticResource x:Key="TextControlPlaceholderForeground" ResourceKey="SystemControlPageTextBaseMediumBrush" />
       <StaticResource x:Key="TextControlPlaceholderForegroundPointerOver"
                       ResourceKey="SystemControlPageTextBaseMediumBrush" />
diff --git a/src/Avalonia.Themes.Fluent/Controls/TextBox.xaml b/src/Avalonia.Themes.Fluent/Controls/TextBox.xaml
index b1ef58bcf7..f9608885d4 100644
--- a/src/Avalonia.Themes.Fluent/Controls/TextBox.xaml
+++ b/src/Avalonia.Themes.Fluent/Controls/TextBox.xaml
@@ -145,7 +145,7 @@
                                 BringIntoViewOnFocusChange="{TemplateBinding (ScrollViewer.BringIntoViewOnFocusChange)}">
                     <Panel>
                       <TextBlock Name="PART_Watermark"
-                              Opacity="0.5"
+                              Opacity="{DynamicResource TextControlPlaceholderOpacity}"
                               Text="{TemplateBinding Watermark}"
                               TextAlignment="{TemplateBinding TextAlignment}"
                               TextWrapping="{TemplateBinding TextWrapping}"
diff --git a/src/Avalonia.Themes.Simple/Accents/Base.xaml b/src/Avalonia.Themes.Simple/Accents/Base.xaml
index b22c6ceb69..766e034ee5 100644
--- a/src/Avalonia.Themes.Simple/Accents/Base.xaml
+++ b/src/Avalonia.Themes.Simple/Accents/Base.xaml
@@ -151,4 +151,6 @@
 
   <sys:Double x:Key="IconElementThemeHeight">20</sys:Double>
   <sys:Double x:Key="IconElementThemeWidth">20</sys:Double>
+
+  <sys:Double x:Key="TextControlPlaceholderOpacity">0.5</sys:Double>
 </ResourceDictionary>
diff --git a/src/Avalonia.Themes.Simple/Controls/TextBox.xaml b/src/Avalonia.Themes.Simple/Controls/TextBox.xaml
index 867d5367c3..c3416c0440 100644
--- a/src/Avalonia.Themes.Simple/Controls/TextBox.xaml
+++ b/src/Avalonia.Themes.Simple/Controls/TextBox.xaml
@@ -136,7 +136,7 @@
                     <TextBlock Name="watermark"
                                HorizontalAlignment="{TemplateBinding HorizontalContentAlignment}"
                                VerticalAlignment="{TemplateBinding VerticalContentAlignment}"   
-                               Opacity="0.5"
+                               Opacity="{DynamicResource TextControlPlaceholderOpacity}"
                                Text="{TemplateBinding Watermark}"
                                TextAlignment="{TemplateBinding TextAlignment}"
                                TextWrapping="{TemplateBinding TextWrapping}">