Browse Source

Merge branch 'master' into Add-Ctrl+Insert-and-Shift+Insert

pull/9619/head
zhijun zhou 3 years ago
committed by GitHub
parent
commit
356b97220e
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 13
      .editorconfig
  2. 15
      packages/Avalonia/AvaloniaBuildTasks.targets
  3. 25
      samples/ControlCatalog/Pages/AutoCompleteBoxPage.xaml.cs
  4. 2
      samples/ControlCatalog/Pages/CompositionPage.axaml.cs
  5. 2
      samples/ControlCatalog/Pages/ImagePage.xaml.cs
  6. 2
      samples/ControlCatalog/Pages/OpenGlPage.xaml.cs
  7. 3
      samples/ControlCatalog/Pages/ScreenPage.cs
  8. 2
      samples/ControlCatalog/Pages/TabControlPage.xaml.cs
  9. 2
      src/Android/Avalonia.Android/Platform/Specific/Helpers/AndroidKeyboardEventsHelper.cs
  10. 2
      src/Android/Avalonia.Android/Platform/Storage/AndroidStorageItem.cs
  11. 2
      src/Avalonia.Base/Animation/Animators/GradientBrushAnimator.cs
  12. 2
      src/Avalonia.Base/Animation/KeySpline.cs
  13. 4
      src/Avalonia.Base/Controls/Classes.cs
  14. 2
      src/Avalonia.Base/Data/Core/ExpressionNode.cs
  15. 4
      src/Avalonia.Base/Data/Core/Parsers/ExpressionVisitorNodeBuilder.cs
  16. 2
      src/Avalonia.Base/Data/Core/Plugins/DataAnnotationsValidationPlugin.cs
  17. 2
      src/Avalonia.Base/Data/Core/Plugins/IndeiValidationPlugin.cs
  18. 2
      src/Avalonia.Base/Data/Core/Plugins/TaskStreamPlugin.cs
  19. 18
      src/Avalonia.Base/Input/AccessKeyHandler.cs
  20. 4
      src/Avalonia.Base/Input/DragDropDevice.cs
  21. 5
      src/Avalonia.Base/Input/KeyGesture.cs
  22. 2
      src/Avalonia.Base/Input/KeyboardDevice.cs
  23. 9
      src/Avalonia.Base/Input/MouseDevice.cs
  24. 2
      src/Avalonia.Base/Input/PenDevice.cs
  25. 4
      src/Avalonia.Base/Input/Pointer.cs
  26. 2
      src/Avalonia.Base/Input/TouchDevice.cs
  27. 2
      src/Avalonia.Base/Layout/AttachedLayout.cs
  28. 4
      src/Avalonia.Base/Layout/StackLayout.cs
  29. 2
      src/Avalonia.Base/Layout/UniformGridLayout.cs
  30. 12
      src/Avalonia.Base/Media/PathMarkupParser.cs
  31. 4
      src/Avalonia.Base/Platform/AssetLoader.cs
  32. 12
      src/Avalonia.Base/Rendering/Composition/Animations/KeyFrameAnimationInstance.cs
  33. 2
      src/Avalonia.Base/Rendering/Composition/CompositingRenderer.cs
  34. 4
      src/Avalonia.Base/Rendering/Composition/CompositionTarget.cs
  35. 2
      src/Avalonia.Base/Rendering/Composition/Drawing/CompositionDrawingContext.cs
  36. 2
      src/Avalonia.Base/Rendering/DeferredRenderer.cs
  37. 2
      src/Avalonia.Base/Rendering/SceneGraph/SceneBuilder.cs
  38. 1
      src/Avalonia.Build.Tasks/BuildEngineErrorCode.cs
  39. 119
      src/Avalonia.Build.Tasks/XamlCompilerTaskExecutor.cs
  40. 2
      src/Avalonia.Controls.ColorPicker/ColorSlider/ColorSlider.cs
  41. 2
      src/Avalonia.Controls.ColorPicker/ColorSpectrum/ColorSpectrum.cs
  42. 2
      src/Avalonia.Controls.DataGrid/DataGridTemplateColumn.cs
  43. 2
      src/Avalonia.Controls/Automation/Peers/ComboBoxAutomationPeer.cs
  44. 2
      src/Avalonia.Controls/Calendar/CalendarBlackoutDatesCollection.cs
  45. 3
      src/Avalonia.Controls/Calendar/SelectedDatesCollection.cs
  46. 8
      src/Avalonia.Controls/Grid.cs
  47. 2
      src/Avalonia.Controls/GridSplitter.cs
  48. 11
      src/Avalonia.Controls/MenuItemAccessKeyHandler.cs
  49. 4
      src/Avalonia.Controls/Platform/InProcessDragSource.cs
  50. 6
      src/Avalonia.Controls/Primitives/Popup.cs
  51. 5
      src/Avalonia.Controls/ProgressBar.cs
  52. 2
      src/Avalonia.Controls/Repeater/RecyclingElementFactory.cs
  53. 4
      src/Avalonia.Controls/Selection/SelectionNodeBase.cs
  54. 7
      src/Avalonia.Controls/SplitView.cs
  55. 2
      src/Avalonia.Controls/TextBox.cs
  56. 2
      src/Avalonia.Controls/TopLevel.cs
  57. 1
      src/Avalonia.Controls/UserControl.cs
  58. 2
      src/Avalonia.Diagnostics/Diagnostics/Screenshots/FilePickerHandler.cs
  59. 14
      src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs
  60. 8
      src/Avalonia.Dialogs/ManagedStorageProvider.cs
  61. 8
      src/Avalonia.FreeDesktop/LinuxMountedVolumeInfoListener.cs
  62. 2
      src/Avalonia.Native/AvaloniaNativeMenuExporter.cs
  63. 3
      src/Avalonia.Native/IAvnMenu.cs
  64. 4
      src/Avalonia.OpenGL/Controls/OpenGlControlBase.cs
  65. 2
      src/Avalonia.Remote.Protocol/MetsysBson.cs
  66. 8
      src/Avalonia.Themes.Fluent/FluentTheme.xaml.cs
  67. 8
      src/Avalonia.Themes.Simple/SimpleTheme.xaml.cs
  68. 2
      src/Avalonia.X11/X11IconLoader.cs
  69. 9
      src/Avalonia.X11/X11Platform.cs
  70. 1
      src/Avalonia.X11/X11Window.Ime.cs
  71. 4
      src/Avalonia.X11/X11Window.cs
  72. 20
      src/Markup/Avalonia.Markup.Xaml.Loader/AvaloniaXamlIlRuntimeCompiler.cs
  73. 3
      src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/GroupTransformers/XamlIncludeGroupTransformer.cs
  74. 8
      src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/XamlIlAvaloniaPropertyHelper.cs
  75. 48
      src/Markup/Avalonia.Markup.Xaml/AvaloniaXamlLoader.cs
  76. 8
      src/Markup/Avalonia.Markup.Xaml/Converters/AvaloniaPropertyTypeConverter.cs
  77. 2
      src/Markup/Avalonia.Markup.Xaml/Converters/IconTypeConverter.cs
  78. 2
      src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/DynamicResourceExtension.cs
  79. 21
      src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/StaticResourceExtension.cs
  80. 6
      src/Markup/Avalonia.Markup.Xaml/Parsers/PropertyParser.cs
  81. 7
      src/Markup/Avalonia.Markup.Xaml/RuntimeXamlLoaderDocument.cs
  82. 4
      src/Markup/Avalonia.Markup.Xaml/Styling/ResourceInclude.cs
  83. 4
      src/Markup/Avalonia.Markup.Xaml/Styling/StyleInclude.cs
  84. 28
      src/Markup/Avalonia.Markup.Xaml/XamlIl/Runtime/XamlIlRuntimeHelpers.cs
  85. 6
      src/Markup/Avalonia.Markup/Markup/Parsers/Nodes/StringIndexerNode.cs
  86. 4
      src/Skia/Avalonia.Skia/DrawingContextImpl.cs
  87. 7
      src/Windows/Avalonia.Win32.Interop/Wpf/Direct2DImageSurface.cs
  88. 3
      src/Windows/Avalonia.Win32.Interop/Wpf/WpfTopLevelImpl.cs
  89. 2
      src/Windows/Avalonia.Win32/ClipboardImpl.cs
  90. 2
      src/Windows/Avalonia.Win32/CursorFactory.cs
  91. 8
      src/Windows/Avalonia.Win32/DataObject.cs
  92. 4
      src/Windows/Avalonia.Win32/DirectX/DirectXStructs.cs
  93. 6
      src/Windows/Avalonia.Win32/PopupImpl.cs
  94. 32
      src/Windows/Avalonia.Win32/Win32Platform.cs
  95. 4
      src/Windows/Avalonia.Win32/WindowImpl.AppWndProc.cs
  96. 4
      src/Windows/Avalonia.Win32/WindowImpl.CustomCaptionProc.cs
  97. 7
      src/Windows/Avalonia.Win32/WindowImpl.cs
  98. 2
      src/iOS/Avalonia.iOS/CombinedSpan3.cs
  99. 2
      src/iOS/Avalonia.iOS/TouchHandler.cs
  100. 4
      src/tools/DevGenerators/CompositionGenerator/Generator.ListProxy.cs

13
.editorconfig

@ -137,14 +137,27 @@ space_within_single_line_array_initializer_braces = true
#Net Analyzer
dotnet_analyzer_diagnostic.category-Performance.severity = none #error - Uncomment when all violations are fixed.
# CA1304: Specify CultureInfo
dotnet_diagnostic.CA1304.severity = warning
# CA1802: Use literals where appropriate
dotnet_diagnostic.CA1802.severity = warning
# CA1820: Test for empty strings using string length
dotnet_diagnostic.CA1820.severity = warning
# CA1821: Remove empty finalizers
dotnet_diagnostic.CA1821.severity = warning
# CA1822: Mark members as static
dotnet_diagnostic.CA1822.severity = suggestion
dotnet_code_quality.CA1822.api_surface = private, internal
# CA1825: Avoid zero-length array allocations
dotnet_diagnostic.CA1825.severity = warning
# CA1826: Use property instead of Linq Enumerable method
dotnet_diagnostic.CA1826.severity = suggestion
# CA1827: Do not use Count/LongCount when Any can be used
dotnet_diagnostic.CA1827.severity = warning
# CA1828: Do not use CountAsync/LongCountAsync when AnyAsync can be used
dotnet_diagnostic.CA1828.severity = warning
# CA1829: Use Length/Count property instead of Enumerable.Count method
dotnet_diagnostic.CA1829.severity = warning
#CA1847: Use string.Contains(char) instead of string.Contains(string) with single characters
dotnet_diagnostic.CA1847.severity = warning

15
packages/Avalonia/AvaloniaBuildTasks.targets

@ -30,7 +30,9 @@
/>
<Target Name="AddAvaloniaResources" BeforeTargets="ResolveReferences">
<Target Name="AddAvaloniaResources"
BeforeTargets="ResolveReferences"
Condition="('@(AvaloniaResource->Count())' &gt; 0) or ('@(AvaloniaXaml->Count())' &gt; 0)">
<PropertyGroup>
<AvaloniaResourcesTemporaryFilePath Condition="'$(AvaloniaResourcesTemporaryFilePath)' == ''">$(IntermediateOutputPath)/Avalonia/resources</AvaloniaResourcesTemporaryFilePath>
</PropertyGroup>
@ -62,7 +64,9 @@
BeforeTargets="CoreCompile;CoreResGen"
Inputs="@(AvaloniaResource);@(AvaloniaXaml);@(CustomAdditionalGenerateAvaloniaResourcesInputs);$(MSBuildAllProjects)"
Outputs="$(AvaloniaResourcesTemporaryFilePath)"
DependsOnTargets="$(BuildAvaloniaResourcesDependsOn)">
DependsOnTargets="$(BuildAvaloniaResourcesDependsOn)"
Condition="('@(AvaloniaResource->Count())' &gt; 0) or ('@(AvaloniaXaml->Count())' &gt; 0)"
>
<ItemGroup>
<AvaloniaResource Include="@(AvaloniaXaml)"/>
</ItemGroup>
@ -81,7 +85,12 @@
<Target
Name="CompileAvaloniaXaml"
AfterTargets="AfterCompile"
Condition="Exists('@(IntermediateAssembly)') And $(DesignTimeBuild) != true And $(EnableAvaloniaXamlCompilation) != false"
Condition="
(('@(AvaloniaResource->Count())' &gt; 0)
or ('@(AvaloniaXaml->Count())' &gt; 0))
and Exists('@(IntermediateAssembly)')
And $(DesignTimeBuild) != true
And $(EnableAvaloniaXamlCompilation) != false"
>
<PropertyGroup>
<AvaloniaXamlReferencesTemporaryFilePath Condition="'$(AvaloniaXamlReferencesTemporaryFilePath)' == ''">$(IntermediateOutputPath)/Avalonia/references</AvaloniaXamlReferencesTemporaryFilePath>

25
samples/ControlCatalog/Pages/AutoCompleteBoxPage.xaml.cs

@ -14,7 +14,26 @@ namespace ControlCatalog.Pages
{
public class AutoCompleteBoxPage : UserControl
{
private StateData[] BuildAllStates()
public class StateData
{
public string Name { get; private set; }
public string Abbreviation { get; private set; }
public string Capital { get; private set; }
public StateData(string name, string abbreviatoin, string capital)
{
Name = name;
Abbreviation = abbreviatoin;
Capital = capital;
}
public override string ToString()
{
return Name;
}
}
private static StateData[] BuildAllStates()
{
return new StateData[]
{
@ -72,7 +91,7 @@ namespace ControlCatalog.Pages
}
public StateData[] States { get; private set; }
private LinkedList<string>[] BuildAllSentences()
private static LinkedList<string>[] BuildAllSentences()
{
return new string[]
{
@ -124,7 +143,7 @@ namespace ControlCatalog.Pages
.OfType<AutoCompleteBox>();
}
private bool StringContains(string str, string? query)
private static bool StringContains(string str, string? query)
{
if (query == null) return false;
return str.IndexOf(query, StringComparison.OrdinalIgnoreCase) >= 0;

2
samples/ControlCatalog/Pages/CompositionPage.axaml.cs

@ -25,7 +25,7 @@ public partial class CompositionPage : UserControl
this.Get<ItemsControl>("Items").Items = CreateColorItems();
}
private List<CompositionPageColorItem> CreateColorItems()
private static List<CompositionPageColorItem> CreateColorItems()
{
var list = new List<CompositionPageColorItem>();

2
samples/ControlCatalog/Pages/ImagePage.xaml.cs

@ -58,7 +58,7 @@ namespace ControlCatalog.Pages
}
}
private PixelRect GetCropRect(int index)
private static PixelRect GetCropRect(int index)
{
var bitmapWidth = 640;
var bitmapHeight = 426;

2
samples/ControlCatalog/Pages/OpenGlPage.xaml.cs

@ -247,7 +247,7 @@ namespace ControlCatalog.Pages
}
private void CheckError(GlInterface gl)
private static void CheckError(GlInterface gl)
{
int err;
while ((err = gl.GetError()) != GL_NO_ERROR)

3
samples/ControlCatalog/Pages/ScreenPage.cs

@ -66,6 +66,7 @@ namespace ControlCatalog.Pages
context.DrawText(formattedText, boundsRect.Position.WithY(boundsRect.Size.Height + 40));
formattedText = CreateFormattedText($"IsPrimary: {screen.IsPrimary}");
context.DrawText(formattedText, boundsRect.Position.WithY(boundsRect.Size.Height + 60));
formattedText =
@ -77,7 +78,7 @@ namespace ControlCatalog.Pages
context.DrawRectangle(p, new Rect(w.Position.X / 10f + Math.Abs(_leftMost), w.Position.Y / 10f, w.Bounds.Width / 10, w.Bounds.Height / 10));
}
private FormattedText CreateFormattedText(string textToFormat)
private static FormattedText CreateFormattedText(string textToFormat)
{
return new FormattedText(textToFormat, CultureInfo.CurrentCulture, FlowDirection.LeftToRight,
Typeface.Default, 12, Brushes.Green);

2
samples/ControlCatalog/Pages/TabControlPage.xaml.cs

@ -49,7 +49,7 @@ namespace ControlCatalog.Pages
AvaloniaXamlLoader.Load(this);
}
private IBitmap LoadBitmap(string uri)
private static IBitmap LoadBitmap(string uri)
{
var assets = AvaloniaLocator.Current!.GetService<IAssetLoader>()!;
return new Bitmap(assets.Open(new Uri(uri)));

2
src/Android/Avalonia.Android/Platform/Specific/Helpers/AndroidKeyboardEventsHelper.cs

@ -30,7 +30,7 @@ namespace Avalonia.Android.Platform.Specific.Helpers
return DispatchKeyEventInternal(e, out callBase);
}
string UnicodeTextInput(KeyEvent keyEvent)
static string UnicodeTextInput(KeyEvent keyEvent)
{
return keyEvent.Action == KeyEventActions.Multiple
&& keyEvent.RepeatCount == 0

2
src/Android/Avalonia.Android/Platform/Storage/AndroidStorageItem.cs

@ -178,7 +178,7 @@ internal sealed class AndroidStorageFile : AndroidStorageItem, IStorageBookmarkF
return false;
}
private Stream? GetVirtualFileStream(Context context, AndroidUri uri, bool isOutput)
private static Stream? GetVirtualFileStream(Context context, AndroidUri uri, bool isOutput)
{
var mimeTypes = context.ContentResolver?.GetStreamTypes(uri, FilePickerFileTypes.All.MimeTypes![0]);
if (mimeTypes?.Length >= 1)

2
src/Avalonia.Base/Animation/Animators/GradientBrushAnimator.cs

@ -72,7 +72,7 @@ namespace Avalonia.Animation.Animators
return control.Bind((AvaloniaProperty<IBrush?>)Property, instance, BindingPriority.Animation);
}
private IReadOnlyList<ImmutableGradientStop> InterpolateStops(double progress, IReadOnlyList<IGradientStop> oldValue, IReadOnlyList<IGradientStop> newValue)
private static IReadOnlyList<ImmutableGradientStop> InterpolateStops(double progress, IReadOnlyList<IGradientStop> oldValue, IReadOnlyList<IGradientStop> newValue)
{
var resultCount = Math.Max(oldValue.Count, newValue.Count);
var stops = new ImmutableGradientStop[resultCount];

2
src/Avalonia.Base/Animation/KeySpline.cs

@ -196,7 +196,7 @@ namespace Avalonia.Animation
/// </summary>
/// <param name="value"></param>
/// <returns></returns>
private bool IsValidXValue(double value)
private static bool IsValidXValue(double value)
{
return value >= 0.0 && value <= 1.0;
}

4
src/Avalonia.Base/Controls/Classes.cs

@ -37,7 +37,7 @@ namespace Avalonia.Controls
/// <param name="items">The initial items.</param>
public Classes(params string[] items)
: base(items)
{
{
}
/// <summary>
@ -320,7 +320,7 @@ namespace Avalonia.Controls
listener.Changed();
}
private void ThrowIfPseudoclass(string name, string operation)
private static void ThrowIfPseudoclass(string name, string operation)
{
if (name.StartsWith(":"))
{

2
src/Avalonia.Base/Data/Core/ExpressionNode.cs

@ -159,7 +159,7 @@ namespace Avalonia.Data.Core
_listening = false;
}
private BindingNotification TargetNullNotification()
private static BindingNotification TargetNullNotification()
{
return new BindingNotification(
new MarkupBindingChainException("Null value"),

4
src/Avalonia.Base/Data/Core/Parsers/ExpressionVisitorNodeBuilder.cs

@ -81,7 +81,7 @@ namespace Avalonia.Data.Core.Parsers
return node;
}
private T GetArgumentExpressionValue<T>(Expression expr)
private static T GetArgumentExpressionValue<T>(Expression expr)
{
try
{
@ -193,7 +193,7 @@ namespace Avalonia.Data.Core.Parsers
throw new ExpressionParseException(0, $"Invalid method call in binding expression: '{node.Method.DeclaringType!.AssemblyQualifiedName}.{node.Method.Name}'.");
}
private PropertyInfo? TryGetPropertyFromMethod(MethodInfo method)
private static PropertyInfo? TryGetPropertyFromMethod(MethodInfo method)
{
var type = method.DeclaringType;
return type?.GetRuntimeProperties().FirstOrDefault(prop => prop.GetMethod == method);

2
src/Avalonia.Base/Data/Core/Plugins/DataAnnotationsValidationPlugin.cs

@ -63,7 +63,7 @@ namespace Avalonia.Data.Core.Plugins
}
}
private Exception CreateException(IList<ValidationResult> errors)
private static Exception CreateException(IList<ValidationResult> errors)
{
if (errors.Count == 1)
{

2
src/Avalonia.Base/Data/Core/Plugins/IndeiValidationPlugin.cs

@ -108,7 +108,7 @@ namespace Avalonia.Data.Core.Plugins
return target;
}
private Exception GenerateException(IList<object> errors)
private static Exception GenerateException(IList<object> errors)
{
if (errors.Count == 1)
{

2
src/Avalonia.Base/Data/Core/Plugins/TaskStreamPlugin.cs

@ -59,7 +59,7 @@ namespace Avalonia.Data.Core.Plugins
return Observable.Empty<object?>();
}
private IObservable<object?> HandleCompleted(Task task)
private static IObservable<object?> HandleCompleted(Task task)
{
var resultProperty = task.GetType().GetRuntimeProperty("Result");

18
src/Avalonia.Base/Input/AccessKeyHandler.cs

@ -1,5 +1,6 @@
using System;
using System.Collections.Generic;
using System.Globalization;
using System.Linq;
using Avalonia.Interactivity;
using Avalonia.VisualTree;
@ -23,7 +24,7 @@ namespace Avalonia.Input
/// <summary>
/// The registered access keys.
/// </summary>
private readonly List<Tuple<string, IInputElement>> _registered = new List<Tuple<string, IInputElement>>();
private readonly List<(string AccessKey, IInputElement Element)> _registered = new();
/// <summary>
/// The window to which the handler belongs.
@ -108,12 +109,12 @@ namespace Avalonia.Input
{
var existing = _registered.FirstOrDefault(x => x.Item2 == element);
if (existing != null)
if (existing != default)
{
_registered.Remove(existing);
}
_registered.Add(Tuple.Create(accessKey.ToString().ToUpper(), element));
_registered.Add((accessKey.ToString().ToUpperInvariant(), element));
}
/// <summary>
@ -143,7 +144,7 @@ namespace Avalonia.Input
{
// TODO: Use FocusScopes to store the current element and restore it when context menu is closed.
// Save currently focused input element.
_restoreFocusElement = FocusManager.Instance?.Current;
_restoreFocusElement = FocusManager.Instance?.Current;
// When Alt is pressed without a main menu, or with a closed main menu, show
// access key markers in the window (i.e. "_File").
@ -180,10 +181,11 @@ namespace Avalonia.Input
{
// If any other key is pressed with the Alt key held down, or the main menu is open,
// find all controls who have registered that access key.
var text = e.Key.ToString().ToUpper();
var text = e.Key.ToString();
var matches = _registered
.Where(x => x.Item1 == text && ((Visual)x.Item2).IsEffectivelyVisible)
.Select(x => x.Item2);
.Where(x => string.Equals(x.AccessKey, text, StringComparison.OrdinalIgnoreCase)
&& x.Element.IsEffectivelyVisible)
.Select(x => x.Element);
// If the menu is open, only match controls in the menu's visual tree.
if (menuIsOpen)
@ -194,7 +196,7 @@ namespace Avalonia.Input
var match = matches.FirstOrDefault();
// If there was a match, raise the AccessKeyPressed event on it.
if (match != null)
if (match is not null)
{
match.RaiseEvent(new RoutedEventArgs(AccessKeyPressedEvent));
e.Handled = true;

4
src/Avalonia.Base/Input/DragDropDevice.cs

@ -11,7 +11,7 @@ namespace Avalonia.Input
private Interactive? _lastTarget = null;
private Interactive? GetTarget(IInputRoot root, Point local)
private static Interactive? GetTarget(IInputRoot root, Point local)
{
var hit = root.InputHitTest(local) as Visual;
var target = hit?.GetSelfAndVisualAncestors()?.OfType<Interactive>()?.FirstOrDefault();
@ -20,7 +20,7 @@ namespace Avalonia.Input
return null;
}
private DragDropEffects RaiseDragEvent(Interactive? target, IInputRoot inputRoot, Point point, RoutedEvent<DragEventArgs> routedEvent, DragDropEffects operation, IDataObject data, KeyModifiers modifiers)
private static DragDropEffects RaiseDragEvent(Interactive? target, IInputRoot inputRoot, Point point, RoutedEvent<DragEventArgs> routedEvent, DragDropEffects operation, IDataObject data, KeyModifiers modifiers)
{
if (target == null)
return DragDropEffects.None;

5
src/Avalonia.Base/Input/KeyGesture.cs

@ -1,5 +1,6 @@
using System;
using System.Collections.Generic;
using System.Globalization;
using System.Text;
using Avalonia.Utilities;
@ -143,7 +144,7 @@ namespace Avalonia.Input
// TODO: Move that to external key parser
private static Key ParseKey(string key)
{
if (s_keySynonyms.TryGetValue(key.ToLower(), out Key rv))
if (s_keySynonyms.TryGetValue(key.ToLower(CultureInfo.InvariantCulture), out Key rv))
return rv;
return EnumHelper.Parse<Key>(key, true);
@ -166,7 +167,7 @@ namespace Avalonia.Input
return EnumHelper.Parse<KeyModifiers>(modifier.ToString(), true);
}
private Key ResolveNumPadOperationKey(Key key)
private static Key ResolveNumPadOperationKey(Key key)
{
switch (key)
{

2
src/Avalonia.Base/Input/KeyboardDevice.cs

@ -25,7 +25,7 @@ namespace Avalonia.Input
public IInputElement? FocusedElement => _focusedElement;
private void ClearFocusWithinAncestors(IInputElement? element)
private static void ClearFocusWithinAncestors(IInputElement? element)
{
var el = element;

9
src/Avalonia.Base/Input/MouseDevice.cs

@ -1,12 +1,8 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Reactive.Linq;
using Avalonia.Input.Raw;
using Avalonia.Interactivity;
using Avalonia.Platform;
using Avalonia.Utilities;
using Avalonia.VisualTree;
namespace Avalonia.Input
{
@ -34,7 +30,7 @@ namespace Avalonia.Input
ProcessRawEvent(margs);
}
int ButtonCount(PointerPointProperties props)
static int ButtonCount(PointerPointProperties props)
{
var rv = 0;
if (props.IsLeftButtonPressed)
@ -106,9 +102,10 @@ namespace Avalonia.Input
private void LeaveWindow()
{
}
PointerPointProperties CreateProperties(RawPointerEventArgs args)
static PointerPointProperties CreateProperties(RawPointerEventArgs args)
{
return new PointerPointProperties(args.InputModifiers, args.Type.ToUpdateKind());
}

2
src/Avalonia.Base/Input/PenDevice.cs

@ -99,7 +99,7 @@ namespace Avalonia.Input
return false;
}
private bool PenMove(Pointer pointer, ulong timestamp,
private static bool PenMove(Pointer pointer, ulong timestamp,
IInputRoot root, Point p, PointerPointProperties properties,
KeyModifiers inputModifiers, IInputElement? hitTest,
Lazy<IReadOnlyList<RawPointerPoint>?>? intermediatePoints)

4
src/Avalonia.Base/Input/Pointer.cs

@ -19,7 +19,7 @@ namespace Avalonia.Input
public int Id { get; }
IInputElement? FindCommonParent(IInputElement? control1, IInputElement? control2)
static IInputElement? FindCommonParent(IInputElement? control1, IInputElement? control2)
{
if (control1 is not Visual c1 || control2 is not Visual c2)
return null;
@ -54,7 +54,7 @@ namespace Avalonia.Input
v3.DetachedFromVisualTree += OnCaptureDetached;
}
IInputElement? GetNextCapture(Visual parent)
static IInputElement? GetNextCapture(Visual parent)
{
return parent as IInputElement ?? parent.FindAncestorOfType<IInputElement>();
}

2
src/Avalonia.Base/Input/TouchDevice.cs

@ -21,7 +21,7 @@ namespace Avalonia.Input
private Rect _lastClickRect;
private ulong _lastClickTime;
RawInputModifiers GetModifiers(RawInputModifiers modifiers, bool isLeftButtonDown)
static RawInputModifiers GetModifiers(RawInputModifiers modifiers, bool isLeftButtonDown)
{
var rv = modifiers &= RawInputModifiers.KeyboardMask;
if (isLeftButtonDown)

2
src/Avalonia.Base/Layout/AttachedLayout.cs

@ -184,7 +184,7 @@ namespace Avalonia.Layout
/// </summary>
protected void InvalidateArrange() => ArrangeInvalidated?.Invoke(this, EventArgs.Empty);
private VirtualizingLayoutContext GetVirtualizingLayoutContext(LayoutContext context)
private static VirtualizingLayoutContext GetVirtualizingLayoutContext(LayoutContext context)
{
if (context is VirtualizingLayoutContext virtualizingContext)
{

4
src/Avalonia.Base/Layout/StackLayout.cs

@ -335,7 +335,7 @@ namespace Avalonia.Layout
InvalidateLayout();
}
private double GetAverageElementSize(
private static double GetAverageElementSize(
Size availableSize,
VirtualizingLayoutContext context,
StackLayoutState stackLayoutState)
@ -359,6 +359,6 @@ namespace Avalonia.Layout
private void InvalidateLayout() => InvalidateMeasure();
private FlowLayoutAlgorithm GetFlowAlgorithm(VirtualizingLayoutContext context) => ((StackLayoutState)context.LayoutState!).FlowAlgorithm;
private static FlowLayoutAlgorithm GetFlowAlgorithm(VirtualizingLayoutContext context) => ((StackLayoutState)context.LayoutState!).FlowAlgorithm;
}
}

2
src/Avalonia.Base/Layout/UniformGridLayout.cs

@ -557,6 +557,6 @@ namespace Avalonia.Layout
private void InvalidateLayout() => InvalidateMeasure();
private FlowLayoutAlgorithm GetFlowAlgorithm(VirtualizingLayoutContext context) => ((UniformGridLayoutState)context.LayoutState!).FlowAlgorithm;
private static FlowLayoutAlgorithm GetFlowAlgorithm(VirtualizingLayoutContext context) => ((UniformGridLayoutState)context.LayoutState!).FlowAlgorithm;
}
}

12
src/Avalonia.Base/Media/PathMarkupParser.cs

@ -527,7 +527,7 @@ namespace Avalonia.Media
return span.Slice(i);
}
private bool ReadBool(ref ReadOnlySpan<char> span)
private static bool ReadBool(ref ReadOnlySpan<char> span)
{
span = SkipWhitespace(span);
@ -551,7 +551,7 @@ namespace Avalonia.Media
}
}
private double ReadDouble(ref ReadOnlySpan<char> span)
private static double ReadDouble(ref ReadOnlySpan<char> span)
{
if (!ReadArgument(ref span, out var doubleValue))
{
@ -561,7 +561,7 @@ namespace Avalonia.Media
return double.Parse(doubleValue.ToString(), CultureInfo.InvariantCulture);
}
private Size ReadSize(ref ReadOnlySpan<char> span)
private static Size ReadSize(ref ReadOnlySpan<char> span)
{
var width = ReadDouble(ref span);
span = ReadSeparator(span);
@ -569,7 +569,7 @@ namespace Avalonia.Media
return new Size(width, height);
}
private Point ReadPoint(ref ReadOnlySpan<char> span)
private static Point ReadPoint(ref ReadOnlySpan<char> span)
{
var x = ReadDouble(ref span);
span = ReadSeparator(span);
@ -577,7 +577,7 @@ namespace Avalonia.Media
return new Point(x, y);
}
private Point ReadRelativePoint(ref ReadOnlySpan<char> span, Point origin)
private static Point ReadRelativePoint(ref ReadOnlySpan<char> span, Point origin)
{
var x = ReadDouble(ref span);
span = ReadSeparator(span);
@ -585,7 +585,7 @@ namespace Avalonia.Media
return new Point(origin.X + x, origin.Y + y);
}
private bool ReadCommand(ref ReadOnlySpan<char> span, out Command command, out bool relative)
private static bool ReadCommand(ref ReadOnlySpan<char> span, out Command command, out bool relative)
{
span = SkipWhitespace(span);
if (span.IsEmpty)

4
src/Avalonia.Base/Platform/AssetLoader.cs

@ -187,13 +187,13 @@ namespace Avalonia.Platform
throw new ArgumentException($"Unsupported url type: " + uri.Scheme, nameof(uri));
}
private (IAssemblyDescriptor asm, string path) GetResAsmAndPath(Uri uri)
private static (IAssemblyDescriptor asm, string path) GetResAsmAndPath(Uri uri)
{
var asm = s_assemblyDescriptorResolver.GetAssembly(uri.Authority);
return (asm, uri.GetUnescapeAbsolutePath());
}
private IAssemblyDescriptor? GetAssembly(Uri? uri)
private static IAssemblyDescriptor? GetAssembly(Uri? uri)
{
if (uri != null)
{

12
src/Avalonia.Base/Rendering/Composition/Animations/KeyFrameAnimationInstance.cs

@ -87,7 +87,7 @@ namespace Avalonia.Rendering.Composition.Animations
if (elapsed < _delayTime)
{
if (_delayBehavior == AnimationDelayBehavior.SetInitialValueBeforeDelay)
return ExpressionVariant.Create(GetKeyFrame(ref ctx, _keyFrames[0]));
return ExpressionVariant.Create(KeyFrameAnimationInstance<T>.GetKeyFrame(ref ctx, _keyFrames[0]));
return currentValue;
}
@ -95,7 +95,7 @@ namespace Avalonia.Rendering.Composition.Animations
var iterationNumber = elapsed.Ticks / _duration.Ticks;
if (_iterationBehavior == AnimationIterationBehavior.Count
&& iterationNumber >= _iterationCount)
return ExpressionVariant.Create(GetKeyFrame(ref ctx, _keyFrames[_keyFrames.Length - 1]));
return ExpressionVariant.Create(KeyFrameAnimationInstance<T>.GetKeyFrame(ref ctx, _keyFrames[_keyFrames.Length - 1]));
var evenIterationNumber = iterationNumber % 2 == 0;
@ -124,7 +124,7 @@ namespace Avalonia.Rendering.Composition.Animations
{
// this is the last frame
if (c == _keyFrames.Length - 1)
return ExpressionVariant.Create(GetKeyFrame(ref ctx, kf));
return ExpressionVariant.Create(KeyFrameAnimationInstance<T>.GetKeyFrame(ref ctx, kf));
left = kf;
right = _keyFrames[c + 1];
@ -147,13 +147,13 @@ namespace Avalonia.Rendering.Composition.Animations
return currentValue;
return ExpressionVariant.Create(_interpolator.Interpolate(
GetKeyFrame(ref ctx, left),
GetKeyFrame(ref ctx, right),
KeyFrameAnimationInstance<T>.GetKeyFrame(ref ctx, left),
KeyFrameAnimationInstance<T>.GetKeyFrame(ref ctx, right),
easedKeyProgress
));
}
T GetKeyFrame(ref ExpressionEvaluationContext ctx, ServerKeyFrame<T> f)
static T GetKeyFrame(ref ExpressionEvaluationContext ctx, ServerKeyFrame<T> f)
{
if (f.Expression != null)
return f.Expression.Evaluate(ref ctx).CastOrDefault<T>();

2
src/Avalonia.Base/Rendering/Composition/CompositingRenderer.cs

@ -124,7 +124,7 @@ public class CompositingRenderer : IRendererWithCompositor
QueueUpdate();
}
private void SyncChildren(Visual v)
private static void SyncChildren(Visual v)
{
//TODO: Optimize by moving that logic to Visual itself
if(v.CompositionVisual == null)

4
src/Avalonia.Base/Rendering/Composition/CompositionTarget.cs

@ -62,7 +62,7 @@ namespace Avalonia.Rendering.Composition
return point * m;
}
bool TryGetInvertedTransform(CompositionVisual visual, out Matrix matrix)
static bool TryGetInvertedTransform(CompositionVisual visual, out Matrix matrix)
{
var m = visual.TryGetServerGlobalTransform();
if (m == null)
@ -75,7 +75,7 @@ namespace Avalonia.Rendering.Composition
return m33.TryInvert(out matrix);
}
bool TryTransformTo(CompositionVisual visual, Point globalPoint, out Point v)
static bool TryTransformTo(CompositionVisual visual, Point globalPoint, out Point v)
{
v = default;
if (TryGetInvertedTransform(visual, out var m))

2
src/Avalonia.Base/Rendering/Composition/Drawing/CompositionDrawingContext.cs

@ -368,7 +368,7 @@ internal class CompositionDrawingContext : IDrawingContextImpl, IDrawingContextW
: null;
}
private IDisposable? CreateChildScene(IBrush? brush)
private static IDisposable? CreateChildScene(IBrush? brush)
{
if (brush is VisualBrush visualBrush)
{

2
src/Avalonia.Base/Rendering/DeferredRenderer.cs

@ -272,7 +272,7 @@ namespace Avalonia.Rendering
}
}
Scene? TryGetChildScene(IRef<IDrawOperation>? op) => (op?.Item as BrushDrawOperation)?.Aux as Scene;
static Scene? TryGetChildScene(IRef<IDrawOperation>? op) => (op?.Item as BrushDrawOperation)?.Aux as Scene;
/// <inheritdoc/>
Size IVisualBrushRenderer.GetRenderTargetSize(IVisualBrush brush)

2
src/Avalonia.Base/Rendering/SceneGraph/SceneBuilder.cs

@ -318,7 +318,7 @@ namespace Avalonia.Rendering.SceneGraph
}
}
private void UpdateSize(Scene scene)
private static void UpdateSize(Scene scene)
{
var renderRoot = scene.Root.Visual as IRenderRoot;
var newSize = renderRoot?.ClientSize ?? scene.Root.Visual.Bounds.Size;

1
src/Avalonia.Build.Tasks/BuildEngineErrorCode.cs

@ -7,6 +7,7 @@ namespace Avalonia.Build.Tasks
LegacyResmScheme = 3,
TransformError = 4,
EmitError = 4,
Loader = 5,
Unknown = 9999
}

119
src/Avalonia.Build.Tasks/XamlCompilerTaskExecutor.cs

@ -196,7 +196,8 @@ namespace Avalonia.Build.Tasks
var runtimeHelpers = typeSystem.GetType("Avalonia.Markup.Xaml.XamlIl.Runtime.XamlIlRuntimeHelpers");
var createRootServiceProviderMethod = asm.MainModule.ImportReference(
typeSystem.GetTypeReference(runtimeHelpers).Resolve().Methods
.First(x => x.Name == "CreateRootServiceProviderV2"));
.First(x => x.Name == "CreateRootServiceProviderV3"));
var serviceProviderType = createRootServiceProviderMethod.ReturnType;
var loaderDispatcherDef = new TypeDefinition(CompiledAvaloniaXamlNamespace, "!XamlLoader",
TypeAttributes.Class | TypeAttributes.Public, asm.MainModule.TypeSystem.Object);
@ -212,11 +213,36 @@ namespace Avalonia.Build.Tasks
MethodAttributes.Static | MethodAttributes.Public,
asm.MainModule.TypeSystem.Object)
{
Parameters = {new ParameterDefinition(asm.MainModule.TypeSystem.String)}
Parameters =
{
new ParameterDefinition(serviceProviderType),
new ParameterDefinition(asm.MainModule.TypeSystem.String)
},
};
var loaderDispatcherMethodOld = new MethodDefinition("TryLoad",
MethodAttributes.Static | MethodAttributes.Public,
asm.MainModule.TypeSystem.Object)
{
Parameters =
{
new ParameterDefinition(asm.MainModule.TypeSystem.String)
},
Body =
{
Instructions =
{
Instruction.Create(OpCodes.Ldnull),
Instruction.Create(OpCodes.Ldarg_0),
Instruction.Create(OpCodes.Call, loaderDispatcherMethod),
Instruction.Create(OpCodes.Ret)
}
}
};
loaderDispatcherDef.Methods.Add(loaderDispatcherMethod);
loaderDispatcherDef.Methods.Add(loaderDispatcherMethodOld);
asm.MainModule.Types.Add(loaderDispatcherDef);
var stringEquals = asm.MainModule.ImportReference(asm.MainModule.TypeSystem.String.Resolve().Methods.First(
m =>
m.IsStatic && m.Name == "Equals" && m.Parameters.Count == 3 &&
@ -377,30 +403,42 @@ namespace Avalonia.Build.Tasks
classTypeDefinition.Fields.Add(designLoaderField);
const string TrampolineName = "!XamlIlPopulateTrampoline";
var trampoline = new MethodDefinition(TrampolineName,
MethodAttributes.Static | MethodAttributes.Private, asm.MainModule.TypeSystem.Void);
trampoline.Parameters.Add(new ParameterDefinition(classTypeDefinition));
classTypeDefinition.Methods.Add(trampoline);
var trampolineMethodWithoutSP = new Lazy<MethodDefinition>(() => CreateTrampolineMethod(false));
var trampolineMethodWithSP = new Lazy<MethodDefinition>(() => CreateTrampolineMethod(true));
MethodDefinition CreateTrampolineMethod(bool hasSystemProviderArg)
{
var trampoline = new MethodDefinition(TrampolineName,
MethodAttributes.Static | MethodAttributes.Private, asm.MainModule.TypeSystem.Void);
if (hasSystemProviderArg)
{
trampoline.Parameters.Add(new ParameterDefinition(serviceProviderType));
}
trampoline.Parameters.Add(new ParameterDefinition(classTypeDefinition));
classTypeDefinition.Methods.Add(trampoline);
var regularStart = Instruction.Create(OpCodes.Call, createRootServiceProviderMethod);
var regularStart = Instruction.Create(OpCodes.Nop);
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Ldsfld, designLoaderField));
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Brfalse, regularStart));
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Ldsfld, designLoaderField));
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Ldarg_0));
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Call, designLoaderLoad));
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Ret));
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Ldsfld, designLoaderField));
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Brfalse, regularStart));
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Ldsfld, designLoaderField));
trampoline.Body.Instructions.Add(Instruction.Create(hasSystemProviderArg ? OpCodes.Ldarg_1 : OpCodes.Ldarg_0));
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Call, designLoaderLoad));
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Ret));
trampoline.Body.Instructions.Add(regularStart);
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Ldarg_0));
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Call, compiledPopulateMethod));
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Ret));
CopyDebugDocument(trampoline, compiledPopulateMethod);
trampoline.Body.Instructions.Add(regularStart);
trampoline.Body.Instructions.Add(Instruction.Create(hasSystemProviderArg ? OpCodes.Ldarg_0 : OpCodes.Ldnull));
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Call, createRootServiceProviderMethod));
trampoline.Body.Instructions.Add(Instruction.Create(hasSystemProviderArg ? OpCodes.Ldarg_1 : OpCodes.Ldarg_0));
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Call, compiledPopulateMethod));
trampoline.Body.Instructions.Add(Instruction.Create(OpCodes.Ret));
CopyDebugDocument(trampoline, compiledPopulateMethod);
return trampoline;
}
var foundXamlLoader = false;
// Find AvaloniaXamlLoader.Load(this) and replace it with !XamlIlPopulateTrampoline(this)
foreach (var method in classTypeDefinition.Methods
.Where(m => !m.Attributes.HasFlag(MethodAttributes.Static)))
// Find AvaloniaXamlLoader.Load(this) or AvaloniaXamlLoader.Load(sp, this) and replace it with !XamlIlPopulateTrampoline(this)
foreach (var method in classTypeDefinition.Methods.ToArray())
{
var i = method.Body.Instructions;
for (var c = 1; c < i.Count; c++)
@ -422,7 +460,20 @@ namespace Avalonia.Build.Tasks
{
if (MatchThisCall(i, c - 1))
{
i[c].Operand = trampoline;
i[c].Operand = trampolineMethodWithoutSP.Value;
foundXamlLoader = true;
}
}
if (op != null
&& op.Name == "Load"
&& op.Parameters.Count == 2
&& op.Parameters[0].ParameterType.FullName == "System.IServiceProvider"
&& op.Parameters[1].ParameterType.FullName == "System.Object"
&& op.DeclaringType.FullName == "Avalonia.Markup.Xaml.AvaloniaXamlLoader")
{
if (MatchThisCall(i, c - 1))
{
i[c].Operand = trampolineMethodWithSP.Value;
foundXamlLoader = true;
}
}
@ -439,7 +490,7 @@ namespace Avalonia.Build.Tasks
{
var i = ctors[0].Body.Instructions;
var retIdx = i.IndexOf(i.Last(x => x.OpCode == OpCodes.Ret));
i.Insert(retIdx, Instruction.Create(OpCodes.Call, trampoline));
i.Insert(retIdx, Instruction.Create(OpCodes.Call, trampolineMethodWithoutSP.Value));
i.Insert(retIdx, Instruction.Create(OpCodes.Ldarg_0));
}
else
@ -461,20 +512,33 @@ namespace Avalonia.Build.Tasks
null :
classTypeDefinition.GetConstructors().FirstOrDefault(c =>
c.IsPublic && !c.IsStatic && !c.HasParameters);
var constructorWithSp = compiledBuildMethod != null ?
null :
classTypeDefinition.GetConstructors().FirstOrDefault(c =>
c.IsPublic && !c.IsStatic && c.Parameters.Count == 1 && c.Parameters[0].ParameterType.FullName == serviceProviderType.FullName);
if (compiledBuildMethod != null || parameterlessConstructor != null)
if (compiledBuildMethod != null || parameterlessConstructor != null || constructorWithSp != null)
{
var i = loaderDispatcherMethod.Body.Instructions;
var nop = Instruction.Create(OpCodes.Nop);
i.Add(Instruction.Create(OpCodes.Ldarg_0));
i.Add(Instruction.Create(OpCodes.Ldarg_1));
i.Add(Instruction.Create(OpCodes.Ldstr, res.Uri));
i.Add(Instruction.Create(OpCodes.Ldc_I4, (int)StringComparison.OrdinalIgnoreCase));
i.Add(Instruction.Create(OpCodes.Call, stringEquals));
i.Add(Instruction.Create(OpCodes.Brfalse, nop));
if (parameterlessConstructor != null)
{
i.Add(Instruction.Create(OpCodes.Newobj, parameterlessConstructor));
}
else if (constructorWithSp != null)
{
i.Add(Instruction.Create(OpCodes.Ldarg_0));
i.Add(Instruction.Create(OpCodes.Call, createRootServiceProviderMethod));
i.Add(Instruction.Create(OpCodes.Newobj, constructorWithSp));
}
else
{
i.Add(Instruction.Create(OpCodes.Ldarg_0));
i.Add(Instruction.Create(OpCodes.Call, createRootServiceProviderMethod));
i.Add(Instruction.Create(OpCodes.Call, compiledBuildMethod));
}
@ -482,6 +546,11 @@ namespace Avalonia.Build.Tasks
i.Add(Instruction.Create(OpCodes.Ret));
i.Add(nop);
}
else
{
engine.LogWarning(BuildEngineErrorCode.Loader, "",
$"XAML resource \"{res.Uri}\" won't be reachable via runtime loader, as no public constructor was found");
}
}
}

2
src/Avalonia.Controls.ColorPicker/ColorSlider/ColorSlider.cs

@ -154,7 +154,7 @@ namespace Avalonia.Controls.Primitives
/// </summary>
/// <param name="hsvColor">The <see cref="HsvColor"/> to round component values for.</param>
/// <returns>A new <see cref="HsvColor"/> with rounded component values.</returns>
private HsvColor RoundComponentValues(HsvColor hsvColor)
private static HsvColor RoundComponentValues(HsvColor hsvColor)
{
return new HsvColor(
Math.Round(hsvColor.A, 2, MidpointRounding.AwayFromZero),

2
src/Avalonia.Controls.ColorPicker/ColorSpectrum/ColorSpectrum.cs

@ -1146,7 +1146,7 @@ namespace Avalonia.Controls.Primitives
});
}
private void FillPixelForBox(
private static void FillPixelForBox(
double x,
double y,
Hsv baseHsv,

2
src/Avalonia.Controls.DataGrid/DataGridTemplateColumn.cs

@ -56,7 +56,7 @@ namespace Avalonia.Controls
set => SetAndRaise(CellEditingTemplateProperty, ref _cellEditingCellTemplate, value);
}
private void OnCellTemplateChanged(AvaloniaPropertyChangedEventArgs e)
private static void OnCellTemplateChanged(AvaloniaPropertyChangedEventArgs e)
{
var oldValue = (IDataTemplate)e.OldValue;
var value = (IDataTemplate)e.NewValue;

2
src/Avalonia.Controls/Automation/Peers/ComboBoxAutomationPeer.cs

@ -71,7 +71,7 @@ namespace Avalonia.Automation.Peers
}
}
private ExpandCollapseState ToState(bool value)
private static ExpandCollapseState ToState(bool value)
{
return value ? ExpandCollapseState.Expanded : ExpandCollapseState.Collapsed;
}

2
src/Avalonia.Controls/Calendar/CalendarBlackoutDatesCollection.cs

@ -206,7 +206,7 @@ namespace Avalonia.Controls.Primitives
return true;
}
private void EnsureValidThread()
private static void EnsureValidThread()
{
Dispatcher.UIThread.VerifyAccess();
}

3
src/Avalonia.Controls/Calendar/SelectedDatesCollection.cs

@ -6,7 +6,6 @@
using Avalonia.Threading;
using System;
using System.Collections.ObjectModel;
using System.Threading;
namespace Avalonia.Controls.Primitives
{
@ -353,7 +352,7 @@ namespace Avalonia.Controls.Primitives
return true;
}
private void EnsureValidThread()
private static void EnsureValidThread()
{
Dispatcher.UIThread.VerifyAccess();
}

8
src/Avalonia.Controls/Grid.cs

@ -1165,7 +1165,7 @@ namespace Avalonia.Controls
/// <remarks>
/// For "Auto" definitions MinWidth is used in place of PreferredSize.
/// </remarks>
private double GetMeasureSizeForRange(
private static double GetMeasureSizeForRange(
IReadOnlyList<DefinitionBase> definitions,
int start,
int count)
@ -1192,7 +1192,7 @@ namespace Avalonia.Controls
/// <param name="start">Starting index of the range.</param>
/// <param name="count">Number of definitions included in the range.</param>
/// <returns>Length type for given range.</returns>
private LayoutTimeSizeType GetLengthTypeForRange(
private static LayoutTimeSizeType GetLengthTypeForRange(
IReadOnlyList<DefinitionBase> definitions,
int start,
int count)
@ -1721,7 +1721,7 @@ namespace Avalonia.Controls
/// </summary>
/// <param name="definitions">Array of definitions to use for calculations.</param>
/// <returns>Desired size.</returns>
private double CalculateDesiredSize(
private static double CalculateDesiredSize(
IReadOnlyList<DefinitionBase> definitions)
{
double desiredSize = 0;
@ -2281,7 +2281,7 @@ namespace Avalonia.Controls
/// <param name="start">Start of the range.</param>
/// <param name="count">Number of items in the range.</param>
/// <returns>Final size.</returns>
private double GetFinalSizeForRange(
private static double GetFinalSizeForRange(
IReadOnlyList<DefinitionBase> definitions,
int start,
int count)

2
src/Avalonia.Controls/GridSplitter.cs

@ -516,7 +516,7 @@ namespace Avalonia.Controls
/// <summary>
/// Retrieves the ActualWidth or ActualHeight of the definition depending on its type Column or Row.
/// </summary>
private double GetActualLength(DefinitionBase definition)
private static double GetActualLength(DefinitionBase definition)
{
var column = definition as ColumnDefinition;

11
src/Avalonia.Controls/MenuItemAccessKeyHandler.cs

@ -14,7 +14,7 @@ namespace Avalonia.Controls
/// <summary>
/// The registered access keys.
/// </summary>
private readonly List<Tuple<string, IInputElement>> _registered = new List<Tuple<string, IInputElement>>();
private readonly List<(string AccessKey, IInputElement Element)> _registered = new();
/// <summary>
/// The window to which the handler belongs.
@ -59,12 +59,12 @@ namespace Avalonia.Controls
{
var existing = _registered.FirstOrDefault(x => x.Item2 == element);
if (existing != null)
if (existing != default)
{
_registered.Remove(existing);
}
_registered.Add(Tuple.Create(accessKey.ToString().ToUpper(), element));
_registered.Add((accessKey.ToString().ToUpperInvariant(), element));
}
/// <summary>
@ -88,9 +88,10 @@ namespace Avalonia.Controls
{
if (!string.IsNullOrWhiteSpace(e.Text))
{
var text = e.Text.ToUpper();
var text = e.Text;
var focus = _registered
.FirstOrDefault(x => x.Item1 == text && x.Item2.IsEffectivelyVisible)?.Item2;
.FirstOrDefault(x => string.Equals(x.AccessKey, text, StringComparison.OrdinalIgnoreCase)
&& x.Element.IsEffectivelyVisible).Element;
focus?.RaiseEvent(new RoutedEventArgs(AccessKeyHandler.AccessKeyPressedEvent));

4
src/Avalonia.Controls/Platform/InProcessDragSource.cs

@ -69,7 +69,7 @@ namespace Avalonia.Platform
return effect;
}
private DragDropEffects GetPreferredEffect(DragDropEffects effect, RawInputModifiers modifiers)
private static DragDropEffects GetPreferredEffect(DragDropEffects effect, RawInputModifiers modifiers)
{
if (effect == DragDropEffects.Copy || effect == DragDropEffects.Move || effect == DragDropEffects.Link || effect == DragDropEffects.None)
return effect; // No need to check for the modifiers.
@ -80,7 +80,7 @@ namespace Avalonia.Platform
return DragDropEffects.Move;
}
private StandardCursorType GetCursorForDropEffect(DragDropEffects effects)
private static StandardCursorType GetCursorForDropEffect(DragDropEffects effects)
{
if (effects.HasAllFlags(DragDropEffects.Copy))
return StandardCursorType.DragCopy;

6
src/Avalonia.Controls/Primitives/Popup.cs

@ -1,6 +1,5 @@
using System;
using System.ComponentModel;
using System.Linq;
using System.Reactive.Disposables;
using Avalonia.Automation.Peers;
using Avalonia.Controls.Mixins;
@ -15,7 +14,6 @@ using Avalonia.Metadata;
using Avalonia.Platform;
using Avalonia.VisualTree;
using Avalonia.Media;
using Avalonia.Utilities;
namespace Avalonia.Controls.Primitives
{
@ -639,7 +637,7 @@ namespace Avalonia.Controls.Primitives
return Disposable.Create((unsubscribe, target, handler), state => state.unsubscribe(state.target, state.handler));
}
private void WindowManagerAddShadowHintChanged(IPopupHost host, bool hint)
private static void WindowManagerAddShadowHintChanged(IPopupHost host, bool hint)
{
if(host is PopupRoot pr && pr.PlatformImpl is not null)
{
@ -769,7 +767,7 @@ namespace Avalonia.Controls.Primitives
}
}
private void PassThroughEvent(PointerPressedEventArgs e)
private static void PassThroughEvent(PointerPressedEventArgs e)
{
if (e.Source is LightDismissOverlayLayer layer &&
layer.GetVisualRoot() is InputElement root)

5
src/Avalonia.Controls/ProgressBar.cs

@ -270,15 +270,16 @@ namespace Avalonia.Controls
double percent = Maximum == Minimum ? 1.0 : (Value - Minimum) / (Maximum - Minimum);
// When the Orientation changed, the indicator's Width or Height should set to double.NaN.
// Indicator size calculation should consider the ProgressBar's Padding property setting
if (Orientation == Orientation.Horizontal)
{
_indicator.Width = barSize.Width * percent;
_indicator.Width = (barSize.Width - _indicator.Margin.Left - _indicator.Margin.Right) * percent;
_indicator.Height = double.NaN;
}
else
{
_indicator.Width = double.NaN;
_indicator.Height = barSize.Height * percent;
_indicator.Height = (barSize.Height - _indicator.Margin.Top - _indicator.Margin.Bottom) * percent;
}

2
src/Avalonia.Controls/Repeater/RecyclingElementFactory.cs

@ -87,7 +87,7 @@ namespace Avalonia.Controls
protected virtual string OnSelectTemplateKeyCore(object? dataContext, Control? owner)
{
if (SelectTemplateKey is object)
if (SelectTemplateKey is not null)
{
_args ??= new SelectTemplateEventArgs();
_args.TemplateKey = null;

4
src/Avalonia.Controls/Selection/SelectionNodeBase.cs

@ -290,12 +290,12 @@ namespace Avalonia.Controls.Selection
// so bail.
//
// See unit test Handles_Selection_Made_In_CollectionChanged for more details.
if (ItemsView is object &&
if (ItemsView is not null &&
RangesEnabled &&
Ranges.Count > 0 &&
e.Action == NotifyCollectionChangedAction.Add)
{
var lastIndex = Ranges.Last().End;
var lastIndex = Ranges[Ranges.Count - 1].End;
if (e.NewStartingIndex <= lastIndex)
{

7
src/Avalonia.Controls/SplitView.cs

@ -1,14 +1,11 @@
using Avalonia.Controls.Metadata;
using Avalonia.Controls.Primitives;
using Avalonia.Input;
using Avalonia.Input.Raw;
using Avalonia.Interactivity;
using Avalonia.Media;
using Avalonia.Metadata;
using Avalonia.Platform;
using Avalonia.VisualTree;
using System;
using System.Reactive.Disposables;
using Avalonia.Controls.Presenters;
using Avalonia.Controls.Templates;
using Avalonia.LogicalTree;
@ -431,7 +428,7 @@ namespace Avalonia.Controls
}
}
private string GetPseudoClass(SplitViewDisplayMode mode)
private static string GetPseudoClass(SplitViewDisplayMode mode)
{
return mode switch
{
@ -443,7 +440,7 @@ namespace Avalonia.Controls
};
}
private string GetPseudoClass(SplitViewPanePlacement placement)
private static string GetPseudoClass(SplitViewPanePlacement placement)
{
return placement switch
{

2
src/Avalonia.Controls/TextBox.cs

@ -1588,7 +1588,7 @@ namespace Avalonia.Controls
private int CoerceCaretIndex(int value) => CoerceCaretIndex(value, Text);
private int CoerceCaretIndex(int value, string? text)
private static int CoerceCaretIndex(int value, string? text)
{
if (text == null)
{

2
src/Avalonia.Controls/TopLevel.cs

@ -427,7 +427,7 @@ namespace Avalonia.Controls
LayoutHelper.InvalidateSelfAndChildrenMeasure(this);
}
private bool TransparencyLevelsMatch (WindowTransparencyLevel requested, WindowTransparencyLevel received)
private static bool TransparencyLevelsMatch (WindowTransparencyLevel requested, WindowTransparencyLevel received)
{
if(requested == received)
{

1
src/Avalonia.Controls/UserControl.cs

@ -1,4 +1,3 @@
using System;
using Avalonia.Styling;
namespace Avalonia.Controls

2
src/Avalonia.Diagnostics/Diagnostics/Screenshots/FilePickerHandler.cs

@ -47,7 +47,7 @@ namespace Avalonia.Diagnostics.Screenshots
/// </summary>
public string Title { get; } = "Save Screenshot to ...";
Window GetWindow(Control control)
static Window GetWindow(Control control)
{
var window = control.VisualRoot as Window;
var app = Application.Current;

14
src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs

@ -82,7 +82,7 @@ namespace Avalonia.Diagnostics.ViewModels
{
var setterValue = regularSetter.Value;
var resourceInfo = GetResourceInfo(setterValue);
var resourceInfo = GetResourceInfo(setterValue);
SetterViewModel setterVm;
@ -121,7 +121,7 @@ namespace Avalonia.Diagnostics.ViewModels
public bool CanNavigateToParentProperty => _selectedEntitiesStack.Count >= 1;
private (object resourceKey, bool isDynamic)? GetResourceInfo(object? value)
private static (object resourceKey, bool isDynamic)? GetResourceInfo(object? value)
{
if (value is StaticResourceExtension staticResource)
{
@ -136,7 +136,7 @@ namespace Avalonia.Diagnostics.ViewModels
return null;
}
private bool IsBinding(object? value)
private static bool IsBinding(object? value)
{
switch (value)
{
@ -253,7 +253,7 @@ namespace Avalonia.Diagnostics.ViewModels
}
}
private IEnumerable<PropertyViewModel> GetAvaloniaProperties(object o)
private static IEnumerable<PropertyViewModel> GetAvaloniaProperties(object o)
{
if (o is AvaloniaObject ao)
{
@ -267,7 +267,7 @@ namespace Avalonia.Diagnostics.ViewModels
}
}
private IEnumerable<PropertyViewModel> GetClrProperties(object o, bool showImplementedInterfaces)
private static IEnumerable<PropertyViewModel> GetClrProperties(object o, bool showImplementedInterfaces)
{
foreach (var p in GetClrProperties(o, o.GetType()))
{
@ -286,7 +286,7 @@ namespace Avalonia.Diagnostics.ViewModels
}
}
private IEnumerable<PropertyViewModel> GetClrProperties(object o, Type t)
private static IEnumerable<PropertyViewModel> GetClrProperties(object o, Type t)
{
return t.GetProperties()
.Where(x => x.GetIndexParameters().Length == 0)
@ -411,7 +411,7 @@ namespace Avalonia.Diagnostics.ViewModels
}
}
private int GroupIndex(string? group)
private static int GroupIndex(string? group)
{
switch (group)
{

8
src/Avalonia.Dialogs/ManagedStorageProvider.cs

@ -29,7 +29,7 @@ public class ManagedStorageProvider<T> : BclStorageProvider where T : Window, ne
public override async Task<IReadOnlyList<IStorageFile>> OpenFilePickerAsync(FilePickerOpenOptions options)
{
var model = new ManagedFileChooserViewModel(options, _managedOptions);
var results = await Show(model, _parent);
var results = await ManagedStorageProvider<T>.Show(model, _parent);
return results.Select(f => new BclStorageFile(new FileInfo(f))).ToArray();
}
@ -37,7 +37,7 @@ public class ManagedStorageProvider<T> : BclStorageProvider where T : Window, ne
public override async Task<IStorageFile?> SaveFilePickerAsync(FilePickerSaveOptions options)
{
var model = new ManagedFileChooserViewModel(options, _managedOptions);
var results = await Show(model, _parent);
var results = await ManagedStorageProvider<T>.Show(model, _parent);
return results.FirstOrDefault() is { } result
? new BclStorageFile(new FileInfo(result))
@ -47,12 +47,12 @@ public class ManagedStorageProvider<T> : BclStorageProvider where T : Window, ne
public override async Task<IReadOnlyList<IStorageFolder>> OpenFolderPickerAsync(FolderPickerOpenOptions options)
{
var model = new ManagedFileChooserViewModel(options, _managedOptions);
var results = await Show(model, _parent);
var results = await ManagedStorageProvider<T>.Show(model, _parent);
return results.Select(f => new BclStorageFolder(new DirectoryInfo(f))).ToArray();
}
private async Task<string[]> Show(ManagedFileChooserViewModel model, Window parent)
private static async Task<string[]> Show(ManagedFileChooserViewModel model, Window parent)
{
var dialog = new T
{

8
src/Avalonia.FreeDesktop/LinuxMountedVolumeInfoListener.cs

@ -34,14 +34,14 @@ namespace Avalonia.FreeDesktop
Poll(0);
}
private string GetSymlinkTarget(string x) => Path.GetFullPath(Path.Combine(DevByLabelDir, NativeMethods.ReadLink(x)));
private static string GetSymlinkTarget(string x) => Path.GetFullPath(Path.Combine(DevByLabelDir, NativeMethods.ReadLink(x)));
private string UnescapeString(string input, string regexText, int escapeBase) =>
private static string UnescapeString(string input, string regexText, int escapeBase) =>
new Regex(regexText).Replace(input, m => Convert.ToChar(Convert.ToByte(m.Groups[1].Value, escapeBase)).ToString());
private string UnescapePathFromProcMounts(string input) => UnescapeString(input, @"\\(\d{3})", 8);
private static string UnescapePathFromProcMounts(string input) => UnescapeString(input, @"\\(\d{3})", 8);
private string UnescapeDeviceLabel(string input) => UnescapeString(input, @"\\x([0-9a-f]{2})", 16);
private static string UnescapeDeviceLabel(string input) => UnescapeString(input, @"\\x([0-9a-f]{2})", 16);
private void Poll(long _)
{

2
src/Avalonia.Native/AvaloniaNativeMenuExporter.cs

@ -65,7 +65,7 @@ namespace Avalonia.Native
}
}
private NativeMenu CreateDefaultAppMenu()
private static NativeMenu CreateDefaultAppMenu()
{
var result = new NativeMenu();

3
src/Avalonia.Native/IAvnMenu.cs

@ -3,7 +3,6 @@ using System.Collections.Generic;
using System.Collections.Specialized;
using System.Reactive.Disposables;
using Avalonia.Controls;
using Avalonia.Platform.Interop;
namespace Avalonia.Native.Interop
{
@ -112,7 +111,7 @@ namespace Avalonia.Native.Interop.Impl
return result;
}
private __MicroComIAvnMenuItemProxy CreateNew(IAvaloniaNativeFactory factory, NativeMenuItemBase item)
private static __MicroComIAvnMenuItemProxy CreateNew(IAvaloniaNativeFactory factory, NativeMenuItemBase item)
{
var nativeItem = (__MicroComIAvnMenuItemProxy)(item is NativeMenuItemSeparator ?
factory.CreateMenuItemSeparator() :

4
src/Avalonia.OpenGL/Controls/OpenGlControlBase.cs

@ -38,7 +38,7 @@ namespace Avalonia.OpenGL.Controls
base.Render(context);
}
private void CheckError(GlInterface gl)
private static void CheckError(GlInterface gl)
{
int err;
while ((err = gl.GetError()) != GL_NO_ERROR)
@ -197,7 +197,7 @@ namespace Avalonia.OpenGL.Controls
}
}
private bool CheckFramebufferStatus(GlInterface gl)
private static bool CheckFramebufferStatus(GlInterface gl)
{
var status = gl.CheckFramebufferStatus(GL_FRAMEBUFFER);
if (status != GL_FRAMEBUFFER_COMPLETE)

2
src/Avalonia.Remote.Protocol/MetsysBson.cs

@ -562,7 +562,7 @@ namespace Metsys.Bson
{
if (_string == null && Value != null)
{
_string = BitConverter.ToString(Value).Replace("-", string.Empty).ToLower();
_string = BitConverter.ToString(Value).Replace("-", string.Empty).ToLowerInvariant();
}
return _string;

8
src/Avalonia.Themes.Fluent/FluentTheme.xaml.cs

@ -1,4 +1,5 @@
using System.Collections.Generic;
using System;
using System.Collections.Generic;
using Avalonia.Controls;
using Avalonia.Markup.Xaml;
using Avalonia.Styling;
@ -31,9 +32,10 @@ namespace Avalonia.Themes.Fluent
/// <summary>
/// Initializes a new instance of the <see cref="FluentTheme"/> class.
/// </summary>
public FluentTheme()
/// <param name="sp">The parent's service provider.</param>
public FluentTheme(IServiceProvider? sp = null)
{
AvaloniaXamlLoader.Load(this);
AvaloniaXamlLoader.Load(sp, this);
_baseDark = (IResourceDictionary)GetAndRemove("BaseDark");
_fluentDark = (IResourceDictionary)GetAndRemove("FluentDark");

8
src/Avalonia.Themes.Simple/SimpleTheme.xaml.cs

@ -1,4 +1,5 @@
using System.Collections.Generic;
using System;
using System.Collections.Generic;
using Avalonia.Controls;
using Avalonia.Markup.Xaml;
using Avalonia.Styling;
@ -16,9 +17,10 @@ namespace Avalonia.Themes.Simple
/// <summary>
/// Initializes a new instance of the <see cref="SimpleTheme"/> class.
/// </summary>
public SimpleTheme()
/// <param name="sp">The parent's service provider.</param>
public SimpleTheme(IServiceProvider? sp = null)
{
AvaloniaXamlLoader.Load(this);
AvaloniaXamlLoader.Load(sp, this);
_simpleDark = (IResourceDictionary)GetAndRemove("BaseDark");
_simpleLight = (IResourceDictionary)GetAndRemove("BaseLight");

2
src/Avalonia.X11/X11IconLoader.cs

@ -9,7 +9,7 @@ namespace Avalonia.X11
{
class X11IconLoader : IPlatformIconLoader
{
IWindowIconImpl LoadIcon(Bitmap bitmap)
static IWindowIconImpl LoadIcon(Bitmap bitmap)
{
var rv = new X11IconData(bitmap);
bitmap.Dispose();

9
src/Avalonia.X11/X11Platform.cs

@ -5,7 +5,6 @@ using System.Reflection;
using System.Runtime.InteropServices;
using Avalonia.Controls;
using Avalonia.Controls.Platform;
using Avalonia.Dialogs;
using Avalonia.FreeDesktop;
using Avalonia.FreeDesktop.DBusIme;
using Avalonia.Input;
@ -85,7 +84,7 @@ namespace Avalonia.X11
.Bind<IMountedVolumeInfoProvider>().ToConstant(new LinuxMountedVolumeInfoProvider())
.Bind<IPlatformLifetimeEventsImpl>().ToConstant(new X11PlatformLifetimeEvents(this));
X11Screens = Avalonia.X11.X11Screens.Init(this);
X11Screens = X11.X11Screens.Init(this);
Screens = new X11Screens(X11Screens);
if (Info.XInputVersion != null)
{
@ -143,7 +142,7 @@ namespace Avalonia.X11
throw new NotSupportedException();
}
bool EnableIme(X11PlatformOptions options)
static bool EnableIme(X11PlatformOptions options)
{
// Disable if explicitly asked by user
var avaloniaImModule = Environment.GetEnvironmentVariable("AVALONIA_IM_MODULE");
@ -164,8 +163,8 @@ namespace Avalonia.X11
return isCjkLocale;
}
bool ShouldUseXim()
static bool ShouldUseXim()
{
// Check if we are forbidden from using IME
if (Environment.GetEnvironmentVariable("AVALONIA_IM_MODULE") == "none"

1
src/Avalonia.X11/X11Window.Ime.cs

@ -2,7 +2,6 @@ using System;
using System.Collections.Generic;
using System.Runtime.InteropServices;
using System.Text;
using System.Threading.Tasks;
using Avalonia.FreeDesktop;
using Avalonia.Input;
using Avalonia.Input.Raw;

4
src/Avalonia.X11/X11Window.cs

@ -1,9 +1,7 @@
using System;
using System.Collections.Generic;
using System.ComponentModel.DataAnnotations;
using System.Diagnostics;
using System.Linq;
using System.Reactive.Disposables;
using System.Text;
using System.Threading.Tasks;
using System.Threading;
@ -683,7 +681,7 @@ namespace Avalonia.X11
}
RawInputModifiers TranslateModifiers(XModifierMask state)
static RawInputModifiers TranslateModifiers(XModifierMask state)
{
var rv = default(RawInputModifiers);
if (state.HasAllFlags(XModifierMask.Button1Mask))

20
src/Markup/Avalonia.Markup.Xaml.Loader/AvaloniaXamlIlRuntimeCompiler.cs

@ -209,7 +209,7 @@ namespace Avalonia.Markup.Xaml.XamlIl
};
var parsedDocuments = new List<XamlDocumentResource>();
var rootInstances = new List<object>();
var originalDocuments = new List<RuntimeXamlLoaderDocument>();
foreach (var document in documents)
{
@ -235,7 +235,7 @@ namespace Avalonia.Markup.Xaml.XamlIl
builder,
compiler.DefinePopulateMethod(builder, parsed, AvaloniaXamlIlCompiler.PopulateName, true),
compiler.DefineBuildMethod(builder, parsed, AvaloniaXamlIlCompiler.BuildName, true)));
rootInstances.Add(document.RootInstance);
originalDocuments.Add(document);
}
compiler.TransformGroup(parsedDocuments);
@ -251,7 +251,9 @@ namespace Avalonia.Markup.Xaml.XamlIl
indexerClosureType.CreateTypeInfo();
trampolineBuilder.CreateTypeInfo();
return createdTypes.Zip(rootInstances, (l, r) => (l, r)).Select(t => LoadOrPopulate(t.Item1, t.Item2)).ToArray();
return createdTypes.Zip(originalDocuments, (l, r) => (l, r))
.Select(t => LoadOrPopulate(t.Item1, t.Item2.RootInstance, t.Item2.ServiceProvider))
.ToArray();
}
static object LoadSreCore(RuntimeXamlLoaderDocument document, RuntimeXamlLoaderConfiguration configuration)
@ -260,7 +262,7 @@ namespace Avalonia.Markup.Xaml.XamlIl
}
#endif
static object LoadOrPopulate(Type created, object rootInstance)
static object LoadOrPopulate(Type created, object rootInstance, IServiceProvider parentServiceProvider)
{
var isp = Expression.Parameter(typeof(IServiceProvider));
@ -271,6 +273,8 @@ namespace Avalonia.Markup.Xaml.XamlIl
var populateCb = Expression.Lambda<Action<IServiceProvider, object>>(
Expression.Call(populate, isp, Expression.Convert(epar, populate.GetParameters()[1].ParameterType)),
isp, epar).Compile();
var serviceProvider = XamlIlRuntimeHelpers.CreateRootServiceProviderV3(parentServiceProvider);
if (rootInstance == null)
{
@ -282,7 +286,7 @@ namespace Avalonia.Markup.Xaml.XamlIl
{
overrideField.SetValue(null,
new Action<object>(
target => { populateCb(XamlIlRuntimeHelpers.CreateRootServiceProviderV2(), target); }));
target => { populateCb(serviceProvider, target); }));
try
{
return Activator.CreateInstance(targetType);
@ -296,11 +300,11 @@ namespace Avalonia.Markup.Xaml.XamlIl
var createCb = Expression.Lambda<Func<IServiceProvider, object>>(
Expression.Convert(Expression.Call(
created.GetMethod(AvaloniaXamlIlCompiler.BuildName), isp), typeof(object)), isp).Compile();
return createCb(XamlIlRuntimeHelpers.CreateRootServiceProviderV2());
return createCb(serviceProvider);
}
else
{
populateCb(XamlIlRuntimeHelpers.CreateRootServiceProviderV2(), rootInstance);
populateCb(serviceProvider, rootInstance);
return rootInstance;
}
}
@ -411,7 +415,7 @@ namespace Avalonia.Markup.Xaml.XamlIl
var loaded = Assembly.LoadFile(asmPath)
.GetTypes().First(x => x.Name == safeUri);
_cecilGeneratedCache[safeUri] = loaded;
return LoadOrPopulate(loaded, rootInstance);
return LoadOrPopulate(loaded, rootInstance, null);
}
#endif
}

3
src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/GroupTransformers/XamlIncludeGroupTransformer.cs

@ -163,8 +163,9 @@ internal class AvaloniaXamlIncludeTransformer : IXamlAstGroupTransformer
public bool NeedsParentStack => true;
public XamlILNodeEmitResult Emit(XamlEmitContext<IXamlILEmitter, XamlILNodeEmitResult> context, IXamlILEmitter codeGen)
{
codeGen.Ldloc(context.ContextLocal);
var method = context.GetAvaloniaTypes().RuntimeHelpers
.FindMethod(m => m.Name == "CreateRootServiceProviderV2");
.FindMethod(m => m.Name == "CreateRootServiceProviderV3");
codeGen.EmitCall(method);
return XamlILNodeEmitResult.Type(0, Type.GetClrType());

8
src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/XamlIlAvaloniaPropertyHelper.cs

@ -1,11 +1,9 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Xml;
using Avalonia.Markup.Xaml.Parsers;
using Avalonia.Markup.Xaml.XamlIl.CompilerExtensions.Transformers;
using Avalonia.Utilities;
using XamlX;
using XamlX.Ast;
using XamlX.Transform;
using XamlX.Transform.Transformers;
@ -67,10 +65,8 @@ namespace Avalonia.Markup.Xaml.XamlIl.CompilerExtensions
string propertyName, IXamlAstTypeReference selectorTypeReference, IXamlLineInfo lineInfo)
{
XamlAstNamePropertyReference forgedReference;
var parser = new PropertyParser();
var parsedPropertyName = parser.Parse(new CharacterReader(propertyName.AsSpan()));
var parsedPropertyName = PropertyParser.Parse(new CharacterReader(propertyName.AsSpan()));
if(parsedPropertyName.owner == null)
forgedReference = new XamlAstNamePropertyReference(lineInfo, selectorTypeReference,
propertyName, selectorTypeReference);

48
src/Markup/Avalonia.Markup.Xaml/AvaloniaXamlLoader.cs

@ -23,6 +23,17 @@ namespace Avalonia.Markup.Xaml
throw new XamlLoadException(
$"No precompiled XAML found for {obj.GetType()}, make sure to specify x:Class and include your XAML file as AvaloniaResource");
}
/// <summary>
/// Loads the XAML into a Avalonia component.
/// </summary>
/// <param name="sp">The parent's service provider.</param>
/// <param name="obj">The object to load the XAML into.</param>
public static void Load(IServiceProvider? sp, object obj)
{
throw new XamlLoadException(
$"No precompiled XAML found for {obj.GetType()}, make sure to specify x:Class and include your XAML file as AvaloniaResource");
}
/// <summary>
/// Loads XAML from a URI.
@ -33,6 +44,20 @@ namespace Avalonia.Markup.Xaml
/// </param>
/// <returns>The loaded object.</returns>
public static object Load(Uri uri, Uri? baseUri = null)
{
return Load(null, uri, baseUri);
}
/// <summary>
/// Loads XAML from a URI.
/// </summary>
/// <param name="sp">The parent's service provider.</param>
/// <param name="uri">The URI of the XAML file.</param>
/// <param name="baseUri">
/// A base URI to use if <paramref name="uri"/> is relative.
/// </param>
/// <returns>The loaded object.</returns>
public static object Load(IServiceProvider? sp, Uri uri, Uri? baseUri = null)
{
if (uri is null)
throw new ArgumentNullException(nameof(uri));
@ -51,13 +76,25 @@ namespace Avalonia.Markup.Xaml
var compiledLoader = assetLocator.GetAssembly(uri, baseUri)
?.GetType("CompiledAvaloniaXaml.!XamlLoader")
?.GetMethod("TryLoad", new[] {typeof(string)});
?.GetMethod("TryLoad", new[] { typeof(System.IServiceProvider), typeof(string) });
if (compiledLoader != null)
{
var compiledResult = compiledLoader.Invoke(null, new object[] {absoluteUri.ToString()});
var compiledResult = compiledLoader.Invoke(null, new object?[] { sp, absoluteUri.ToString()});
if (compiledResult != null)
return compiledResult;
}
else
{
compiledLoader = assetLocator.GetAssembly(uri, baseUri)
?.GetType("CompiledAvaloniaXaml.!XamlLoader")
?.GetMethod("TryLoad", new[] {typeof(string)});
if (compiledLoader != null)
{
var compiledResult = compiledLoader.Invoke(null, new object?[] {absoluteUri.ToString()});
if (compiledResult != null)
return compiledResult;
}
}
// This is intended for unit-tests only
var runtimeLoader = AvaloniaLocator.Current.GetService<IRuntimeXamlLoader>();
@ -66,10 +103,9 @@ namespace Avalonia.Markup.Xaml
var asset = assetLocator.OpenAndGetAssembly(uri, baseUri);
using (var stream = asset.stream)
{
return runtimeLoader.Load(new RuntimeXamlLoaderDocument(absoluteUri, stream), new RuntimeXamlLoaderConfiguration
{
LocalAssembly = asset.assembly
});
var document = new RuntimeXamlLoaderDocument(absoluteUri, stream) { ServiceProvider = sp };
var configuration = new RuntimeXamlLoaderConfiguration { LocalAssembly = asset.assembly };
return runtimeLoader.Load(document, configuration);
}
}

8
src/Markup/Avalonia.Markup.Xaml/Converters/AvaloniaPropertyTypeConverter.cs

@ -3,7 +3,6 @@ using System.ComponentModel;
using System.Globalization;
using Avalonia.Controls;
using Avalonia.Logging;
using Avalonia.Markup.Parsers;
using Avalonia.Markup.Xaml.Parsers;
using Avalonia.Markup.Xaml.Templates;
using Avalonia.Styling;
@ -21,8 +20,7 @@ namespace Avalonia.Markup.Xaml.Converters
public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)
{
var registry = AvaloniaPropertyRegistry.Instance;
var parser = new PropertyParser();
var (ns, owner, propertyName) = parser.Parse(new CharacterReader(((string)value).AsSpan()));
var (ns, owner, propertyName) = PropertyParser.Parse(new CharacterReader(((string)value).AsSpan()));
var ownerType = TryResolveOwnerByName(context, ns, owner);
var targetType = context.GetFirstParent<ControlTemplate>()?.TargetType ??
context.GetFirstParent<Style>()?.Selector?.TargetType ??
@ -37,7 +35,7 @@ namespace Avalonia.Markup.Xaml.Converters
if (effectiveOwner != targetType &&
!property.IsAttached &&
!registry.IsRegistered(targetType, property))
!AvaloniaPropertyRegistry.Instance.IsRegistered(targetType, property))
{
Logger.TryGet(LogEventLevel.Warning, LogArea.Property)?.Log(
this,
@ -50,7 +48,7 @@ namespace Avalonia.Markup.Xaml.Converters
return property;
}
private Type TryResolveOwnerByName(ITypeDescriptorContext context, string ns, string owner)
private static Type TryResolveOwnerByName(ITypeDescriptorContext context, string ns, string owner)
{
if (owner != null)
{

2
src/Markup/Avalonia.Markup.Xaml/Converters/IconTypeConverter.cs

@ -32,7 +32,7 @@ namespace Avalonia.Markup.Xaml.Converters
throw new NotSupportedException();
}
private WindowIcon CreateIconFromPath(ITypeDescriptorContext context, string s)
private static WindowIcon CreateIconFromPath(ITypeDescriptorContext context, string s)
{
var uri = s.StartsWith("/")
? new Uri(s, UriKind.Relative)

2
src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/DynamicResourceExtension.cs

@ -68,7 +68,7 @@ namespace Avalonia.Markup.Xaml.MarkupExtensions
return null;
}
private Func<object?, object?>? GetConverter(AvaloniaProperty? targetProperty)
private static Func<object?, object?>? GetConverter(AvaloniaProperty? targetProperty)
{
if (targetProperty?.PropertyType == typeof(IBrush))
{

21
src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/StaticResourceExtension.cs

@ -34,13 +34,11 @@ namespace Avalonia.Markup.Xaml.MarkupExtensions
_ => null,
};
if (provideTarget.TargetObject is Setter setter)
if (provideTarget.TargetObject is Setter { Property: not null } setter)
{
targetType = setter.Property.PropertyType;
}
var previousWasControlTheme = false;
// Look upwards though the ambient context for IResourceNodes
// which might be able to give us the resource.
foreach (var parent in stack.Parents)
@ -49,21 +47,6 @@ namespace Avalonia.Markup.Xaml.MarkupExtensions
{
return ColorToBrushConverter.Convert(value, targetType);
}
// HACK: Temporary fix for #8678. Hard-coded to only work for the DevTools main
// window as we don't want 3rd parties to start relying on this hack.
//
// We need to implement compile-time merging of resource dictionaries and this
// hack can be removed.
if (previousWasControlTheme &&
parent is IResourceProvider hack &&
hack.Owner?.GetType().FullName == "Avalonia.Diagnostics.Views.MainWindow" &&
hack.Owner.TryGetResource(ResourceKey, out value))
{
return ColorToBrushConverter.Convert(value, targetType);
}
previousWasControlTheme = parent is ControlTheme;
}
if (provideTarget.TargetObject is Control target &&

6
src/Markup/Avalonia.Markup.Xaml/Parsers/PropertyParser.cs

@ -1,13 +1,11 @@
using System;
using Avalonia.Data.Core;
using Avalonia.Markup.Parsers;
using Avalonia.Data.Core;
using Avalonia.Utilities;
namespace Avalonia.Markup.Xaml.Parsers
{
internal class PropertyParser
{
public (string ns, string owner, string name) Parse(CharacterReader r)
public static (string ns, string owner, string name) Parse(CharacterReader r)
{
if (r.End)
{

7
src/Markup/Avalonia.Markup.Xaml/RuntimeXamlLoaderDocument.cs

@ -66,5 +66,10 @@ public class RuntimeXamlLoaderDocument
/// <summary>
/// The stream containing the XAML.
/// </summary>
public Stream XamlStream { get; set; }
public Stream XamlStream { get; }
/// <summary>
/// Parent's service provider to pass to the Build method or type ctor, if available.
/// </summary>
public IServiceProvider? ServiceProvider { get; set; }
}

4
src/Markup/Avalonia.Markup.Xaml/Styling/ResourceInclude.cs

@ -10,6 +10,7 @@ namespace Avalonia.Markup.Xaml.Styling
/// </summary>
public class ResourceInclude : IResourceProvider
{
private readonly IServiceProvider _serviceProvider;
private readonly Uri? _baseUri;
private IResourceDictionary? _loaded;
private bool _isLoading;
@ -29,6 +30,7 @@ namespace Avalonia.Markup.Xaml.Styling
/// <param name="serviceProvider">The XAML service provider.</param>
public ResourceInclude(IServiceProvider serviceProvider)
{
_serviceProvider = serviceProvider;
_baseUri = serviceProvider.GetContextBaseUri();
}
@ -43,7 +45,7 @@ namespace Avalonia.Markup.Xaml.Styling
{
_isLoading = true;
var source = Source ?? throw new InvalidOperationException("ResourceInclude.Source must be set.");
_loaded = (IResourceDictionary)AvaloniaXamlLoader.Load(source, _baseUri);
_loaded = (IResourceDictionary)AvaloniaXamlLoader.Load(_serviceProvider, source, _baseUri);
_isLoading = false;
}

4
src/Markup/Avalonia.Markup.Xaml/Styling/StyleInclude.cs

@ -12,6 +12,7 @@ namespace Avalonia.Markup.Xaml.Styling
/// </summary>
public class StyleInclude : IStyle, IResourceProvider
{
private readonly IServiceProvider _serviceProvider;
private readonly Uri? _baseUri;
private IStyle[]? _loaded;
private bool _isLoading;
@ -31,6 +32,7 @@ namespace Avalonia.Markup.Xaml.Styling
/// <param name="serviceProvider">The XAML service provider.</param>
public StyleInclude(IServiceProvider serviceProvider)
{
_serviceProvider = serviceProvider;
_baseUri = serviceProvider.GetContextBaseUri();
}
@ -52,7 +54,7 @@ namespace Avalonia.Markup.Xaml.Styling
{
_isLoading = true;
var source = Source ?? throw new InvalidOperationException("StyleInclude.Source must be set.");
var loaded = (IStyle)AvaloniaXamlLoader.Load(source, _baseUri);
var loaded = (IStyle)AvaloniaXamlLoader.Load(_serviceProvider, source, _baseUri);
_loaded = new[] { loaded };
_isLoading = false;
}

28
src/Markup/Avalonia.Markup.Xaml/XamlIl/Runtime/XamlIlRuntimeHelpers.cs

@ -167,18 +167,24 @@ namespace Avalonia.Markup.Xaml.XamlIl.Runtime
#line hidden
public static IServiceProvider CreateRootServiceProviderV2()
{
return new RootServiceProvider(new NameScope());
return new RootServiceProvider(new NameScope(), null);
}
public static IServiceProvider CreateRootServiceProviderV3(IServiceProvider parentServiceProvider)
{
return new RootServiceProvider(new NameScope(), parentServiceProvider);
}
#line default
class RootServiceProvider : IServiceProvider, IAvaloniaXamlIlParentStackProvider
class RootServiceProvider : IServiceProvider
{
private readonly INameScope _nameScope;
private readonly IServiceProvider _parentServiceProvider;
private readonly IRuntimePlatform _runtimePlatform;
public RootServiceProvider(INameScope nameScope)
public RootServiceProvider(INameScope nameScope, IServiceProvider parentServiceProvider)
{
_nameScope = nameScope;
_parentServiceProvider = parentServiceProvider;
_runtimePlatform = AvaloniaLocator.Current.GetService<IRuntimePlatform>();
}
@ -187,19 +193,25 @@ namespace Avalonia.Markup.Xaml.XamlIl.Runtime
if (serviceType == typeof(INameScope))
return _nameScope;
if (serviceType == typeof(IAvaloniaXamlIlParentStackProvider))
return this;
return _parentServiceProvider?.GetService<IAvaloniaXamlIlParentStackProvider>()
?? DefaultAvaloniaXamlIlParentStackProvider.Instance;
if (serviceType == typeof(IRuntimePlatform))
return _runtimePlatform ?? throw new KeyNotFoundException($"{nameof(IRuntimePlatform)} was not registered");
return null;
}
public IEnumerable<object> Parents
private class DefaultAvaloniaXamlIlParentStackProvider : IAvaloniaXamlIlParentStackProvider
{
get
public static DefaultAvaloniaXamlIlParentStackProvider Instance { get; } = new();
public IEnumerable<object> Parents
{
if (Application.Current != null)
yield return Application.Current;
get
{
if (Application.Current != null)
yield return Application.Current;
}
}
}
}

6
src/Markup/Avalonia.Markup/Markup/Parsers/Nodes/StringIndexerNode.cs

@ -113,7 +113,7 @@ namespace Avalonia.Markup.Parsers.Nodes
}
private bool SetValueInArray(Array array, int[] indices, object? value)
private static bool SetValueInArray(Array array, int[] indices, object? value)
{
if (ValidBounds(indices, array))
{
@ -223,7 +223,7 @@ namespace Avalonia.Markup.Parsers.Nodes
return GetValueFromArray(array, intArgs);
}
private object? GetValueFromArray(Array array, int[] indices)
private static object? GetValueFromArray(Array array, int[] indices)
{
if (ValidBounds(indices, array))
{
@ -275,7 +275,7 @@ namespace Avalonia.Markup.Parsers.Nodes
return null;
}
private bool ValidBounds(int[] indices, Array array)
private static bool ValidBounds(int[] indices, Array array)
{
if (indices.Length == array.Rank)
{

4
src/Skia/Avalonia.Skia/DrawingContextImpl.cs

@ -280,7 +280,7 @@ namespace Avalonia.Skia
}
}
SKRect AreaCastingShadowInHole(
static SKRect AreaCastingShadowInHole(
SKRect hole_rect,
float shadow_blur,
float shadow_spread,
@ -689,7 +689,7 @@ namespace Avalonia.Skia
/// <param name="paintWrapper">Paint wrapper.</param>
/// <param name="targetSize">Target size.</param>
/// <param name="gradientBrush">Gradient brush.</param>
private void ConfigureGradientBrush(ref PaintWrapper paintWrapper, Size targetSize, IGradientBrush gradientBrush)
private static void ConfigureGradientBrush(ref PaintWrapper paintWrapper, Size targetSize, IGradientBrush gradientBrush)
{
var tileMode = gradientBrush.SpreadMethod.ToSKShaderTileMode();
var stopColors = gradientBrush.GradientStops.Select(s => s.Color.ToSKColor()).ToArray();

7
src/Windows/Avalonia.Win32.Interop/Wpf/Direct2DImageSurface.cs

@ -113,7 +113,8 @@ namespace Avalonia.Win32.Interop.Wpf
[DllImport("user32.dll", SetLastError = false)]
private static extern IntPtr GetDesktopWindow();
void EnsureDirectX()
static void EnsureDirectX()
{
if(s_d3DDevice != null)
return;
@ -153,7 +154,7 @@ namespace Avalonia.Win32.Interop.Wpf
_oldDpi = dpi;
}
_impl.ImageSource = _image;
RemoveAndDispose(ref _backBuffer);
if (size == default(IntSize))
{
@ -167,7 +168,7 @@ namespace Avalonia.Win32.Interop.Wpf
return _backBuffer.Target;
}
void RemoveAndDispose<T>(ref T d) where T : IDisposable
static void RemoveAndDispose<T>(ref T d) where T : IDisposable
{
d?.Dispose();
d = default(T);

3
src/Windows/Avalonia.Win32.Interop/Wpf/WpfTopLevelImpl.cs

@ -142,8 +142,7 @@ namespace Avalonia.Win32.Interop.Wpf
protected override void OnLostFocus(RoutedEventArgs e) => LostFocus?.Invoke();
RawInputModifiers GetModifiers(MouseEventArgs e)
static RawInputModifiers GetModifiers(MouseEventArgs e)
{
var state = Keyboard.Modifiers;
var rv = default(RawInputModifiers);

2
src/Windows/Avalonia.Win32/ClipboardImpl.cs

@ -16,7 +16,7 @@ namespace Avalonia.Win32
private const int OleRetryCount = 10;
private const int OleRetryDelay = 100;
private async Task<IDisposable> OpenClipboard()
private static async Task<IDisposable> OpenClipboard()
{
var i = OleRetryCount;

2
src/Windows/Avalonia.Win32/CursorFactory.cs

@ -107,7 +107,7 @@ namespace Avalonia.Win32
return new CursorImpl(UnmanagedMethods.CreateIconIndirect(ref info), true);
}
private SdBitmap LoadSystemDrawingBitmap(IBitmapImpl bitmap)
private static SdBitmap LoadSystemDrawingBitmap(IBitmapImpl bitmap)
{
using var memoryStream = new MemoryStream();
bitmap.Save(memoryStream);

8
src/Windows/Avalonia.Win32/DataObject.cs

@ -291,7 +291,7 @@ namespace Avalonia.Win32
return WriteBytesToHGlobal(ref hGlobal, SerializeObject(data));
}
private byte[] SerializeObject(object data)
private static byte[] SerializeObject(object data)
{
using (var ms = new MemoryStream())
{
@ -302,7 +302,7 @@ namespace Avalonia.Win32
}
}
private unsafe uint WriteBytesToHGlobal(ref IntPtr hGlobal, ReadOnlySpan<byte> data)
private static unsafe uint WriteBytesToHGlobal(ref IntPtr hGlobal, ReadOnlySpan<byte> data)
{
int required = data.Length;
if (hGlobal == IntPtr.Zero)
@ -326,7 +326,7 @@ namespace Avalonia.Win32
}
}
private uint WriteFileListToHGlobal(ref IntPtr hGlobal, IEnumerable<string> files)
private static uint WriteFileListToHGlobal(ref IntPtr hGlobal, IEnumerable<string> files)
{
if (!files?.Any() ?? false)
return unchecked((int)UnmanagedMethods.HRESULT.S_OK);
@ -358,7 +358,7 @@ namespace Avalonia.Win32
}
}
private uint WriteStringToHGlobal(ref IntPtr hGlobal, string data)
private static uint WriteStringToHGlobal(ref IntPtr hGlobal, string data)
{
int required = (data.Length + 1) * sizeof(char);
if (hGlobal == IntPtr.Zero)

4
src/Windows/Avalonia.Win32/DirectX/DirectXStructs.cs

@ -1245,7 +1245,7 @@ namespace Avalonia.Win32.DxgiSwapchain
internal RECT DesktopCoordinates;
internal bool AttachedToDesktop;
internal int AttachedToDesktop; // BOOL maps to int. If we use the CLR 'bool' type here, the struct becomes non-blittable. See #9599
internal DXGI_MODE_ROTATION Rotation;
@ -1323,7 +1323,7 @@ namespace Avalonia.Win32.DxgiSwapchain
public uint Width;
public uint Height;
public DXGI_FORMAT Format;
public bool Stereo;
public int Stereo; // BOOL maps to int. If we use the CLR 'bool' type here, the struct becomes non-blittable. See #9599
public DXGI_SAMPLE_DESC SampleDesc;
public uint BufferUsage;
public uint BufferCount;

6
src/Windows/Avalonia.Win32/PopupImpl.cs

@ -92,7 +92,7 @@ namespace Avalonia.Win32
IntPtr.Zero);
s_parentHandle = IntPtr.Zero;
EnableBoxShadow(result, _dropShadowHint);
PopupImpl.EnableBoxShadow(result, _dropShadowHint);
return result;
}
@ -139,7 +139,7 @@ namespace Avalonia.Win32
//TODO: We ignore the scaling override for now
}
private void EnableBoxShadow (IntPtr hwnd, bool enabled)
private static void EnableBoxShadow (IntPtr hwnd, bool enabled)
{
var classes = (int)UnmanagedMethods.GetClassLongPtr(hwnd, (int)UnmanagedMethods.ClassLongIndex.GCL_STYLE);
@ -161,7 +161,7 @@ namespace Avalonia.Win32
if (Handle != null)
{
EnableBoxShadow(Handle.Handle, enabled);
PopupImpl.EnableBoxShadow(Handle.Handle, enabled);
}
}

32
src/Windows/Avalonia.Win32/Win32Platform.cs

@ -184,16 +184,16 @@ namespace Avalonia.Win32
public bool HasMessages()
{
UnmanagedMethods.MSG msg;
return UnmanagedMethods.PeekMessage(out msg, IntPtr.Zero, 0, 0, 0);
return PeekMessage(out msg, IntPtr.Zero, 0, 0, 0);
}
public void ProcessMessage()
{
if (UnmanagedMethods.GetMessage(out var msg, IntPtr.Zero, 0, 0) > -1)
if (GetMessage(out var msg, IntPtr.Zero, 0, 0) > -1)
{
UnmanagedMethods.TranslateMessage(ref msg);
UnmanagedMethods.DispatchMessage(ref msg);
TranslateMessage(ref msg);
DispatchMessage(ref msg);
}
else
{
@ -207,10 +207,10 @@ namespace Avalonia.Win32
{
var result = 0;
while (!cancellationToken.IsCancellationRequested
&& (result = UnmanagedMethods.GetMessage(out var msg, IntPtr.Zero, 0, 0)) > 0)
&& (result = GetMessage(out var msg, IntPtr.Zero, 0, 0)) > 0)
{
UnmanagedMethods.TranslateMessage(ref msg);
UnmanagedMethods.DispatchMessage(ref msg);
TranslateMessage(ref msg);
DispatchMessage(ref msg);
}
if (result < 0)
{
@ -224,7 +224,7 @@ namespace Avalonia.Win32
UnmanagedMethods.TimerProc timerDelegate =
(hWnd, uMsg, nIDEvent, dwTime) => callback();
IntPtr handle = UnmanagedMethods.SetTimer(
IntPtr handle = SetTimer(
IntPtr.Zero,
IntPtr.Zero,
(uint)interval.TotalMilliseconds,
@ -236,7 +236,7 @@ namespace Avalonia.Win32
return Disposable.Create(() =>
{
_delegates.Remove(timerDelegate);
UnmanagedMethods.KillTimer(IntPtr.Zero, handle);
KillTimer(IntPtr.Zero, handle);
});
}
@ -245,9 +245,9 @@ namespace Avalonia.Win32
public void Signal(DispatcherPriority prio)
{
UnmanagedMethods.PostMessage(
PostMessage(
_hwnd,
(int) UnmanagedMethods.WindowsMessage.WM_DISPATCH_WORK_ITEM,
(int)WindowsMessage.WM_DISPATCH_WORK_ITEM,
new IntPtr(SignalW),
new IntPtr(SignalL));
}
@ -261,7 +261,7 @@ namespace Avalonia.Win32
[SuppressMessage("Microsoft.StyleCop.CSharp.NamingRules", "SA1305:FieldNamesMustNotUseHungarianNotation", Justification = "Using Win32 naming for consistency.")]
private IntPtr WndProc(IntPtr hWnd, uint msg, IntPtr wParam, IntPtr lParam)
{
if (msg == (int) UnmanagedMethods.WindowsMessage.WM_DISPATCH_WORK_ITEM && wParam.ToInt64() == SignalW && lParam.ToInt64() == SignalL)
if (msg == (int)WindowsMessage.WM_DISPATCH_WORK_ITEM && wParam.ToInt64() == SignalW && lParam.ToInt64() == SignalL)
{
Signaled?.Invoke(null);
}
@ -283,7 +283,7 @@ namespace Avalonia.Win32
TrayIconImpl.ProcWnd(hWnd, msg, wParam, lParam);
return UnmanagedMethods.DefWindowProc(hWnd, msg, wParam, lParam);
return DefWindowProc(hWnd, msg, wParam, lParam);
}
private void CreateMessageWindow()
@ -295,18 +295,18 @@ namespace Avalonia.Win32
{
cbSize = Marshal.SizeOf<UnmanagedMethods.WNDCLASSEX>(),
lpfnWndProc = _wndProcDelegate,
hInstance = UnmanagedMethods.GetModuleHandle(null),
hInstance = GetModuleHandle(null),
lpszClassName = "AvaloniaMessageWindow " + Guid.NewGuid(),
};
ushort atom = UnmanagedMethods.RegisterClassEx(ref wndClassEx);
ushort atom = RegisterClassEx(ref wndClassEx);
if (atom == 0)
{
throw new Win32Exception();
}
_hwnd = UnmanagedMethods.CreateWindowEx(0, atom, null, 0, 0, 0, 0, 0, IntPtr.Zero, IntPtr.Zero, IntPtr.Zero, IntPtr.Zero);
_hwnd = CreateWindowEx(0, atom, null, 0, 0, 0, 0, 0, IntPtr.Zero, IntPtr.Zero, IntPtr.Zero, IntPtr.Zero);
if (_hwnd == IntPtr.Zero)
{

4
src/Windows/Avalonia.Win32/WindowImpl.AppWndProc.cs

@ -377,7 +377,7 @@ namespace Avalonia.Win32
RawPointerEventType.XButton1Down :
RawPointerEventType.XButton2Down,
},
PointToClient(PointFromLParam(lParam)), GetMouseModifiers(wParam));
PointToClient(WindowImpl.PointFromLParam(lParam)), GetMouseModifiers(wParam));
break;
}
case WindowsMessage.WM_TOUCH:
@ -1035,7 +1035,7 @@ namespace Avalonia.Win32
return new Point((short)(ToInt32(lParam) & 0xffff), (short)(ToInt32(lParam) >> 16)) / RenderScaling;
}
private PixelPoint PointFromLParam(IntPtr lParam)
private static PixelPoint PointFromLParam(IntPtr lParam)
{
return new PixelPoint((short)(ToInt32(lParam) & 0xffff), (short)(ToInt32(lParam) >> 16));
}

4
src/Windows/Avalonia.Win32/WindowImpl.CustomCaptionProc.cs

@ -13,7 +13,7 @@ namespace Avalonia.Win32
private HitTestValues HitTestNCA(IntPtr hWnd, IntPtr wParam, IntPtr lParam)
{
// Get the point coordinates for the hit test (screen space).
var ptMouse = PointFromLParam(lParam);
var ptMouse = WindowImpl.PointFromLParam(lParam);
// Get the window rectangle.
GetWindowRect(hWnd, out var rcWindow);
@ -105,7 +105,7 @@ namespace Avalonia.Win32
if (hittestResult == HitTestValues.HTCAPTION)
{
var position = PointToClient(PointFromLParam(lParam));
var position = PointToClient(WindowImpl.PointFromLParam(lParam));
if (_owner is Window window)
{

7
src/Windows/Avalonia.Win32/WindowImpl.cs

@ -666,7 +666,7 @@ namespace Avalonia.Win32
public Point PointToClient(PixelPoint point)
{
var p = new POINT { X = point.X, Y = point.Y };
UnmanagedMethods.ScreenToClient(_hwnd, ref p);
ScreenToClient(_hwnd, ref p);
return new Point(p.X, p.Y) / RenderScaling;
}
@ -1347,12 +1347,13 @@ namespace Avalonia.Win32
private const int MF_DISABLED = 0x2;
private const int SC_CLOSE = 0xF060;
void DisableCloseButton(IntPtr hwnd)
static void DisableCloseButton(IntPtr hwnd)
{
EnableMenuItem(GetSystemMenu(hwnd, false), SC_CLOSE,
MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
}
void EnableCloseButton(IntPtr hwnd)
static void EnableCloseButton(IntPtr hwnd)
{
EnableMenuItem(GetSystemMenu(hwnd, false), SC_CLOSE,
MF_BYCOMMAND | MF_ENABLED);

2
src/iOS/Avalonia.iOS/CombinedSpan3.cs

@ -16,7 +16,7 @@ internal ref struct CombinedSpan3<T>
public int Length => Span1.Length + Span2.Length + Span3.Length;
void CopyFromSpan(ReadOnlySpan<T> from, int offset, ref Span<T> to)
static void CopyFromSpan(ReadOnlySpan<T> from, int offset, ref Span<T> to)
{
if(to.Length == 0)
return;

2
src/iOS/Avalonia.iOS/TouchHandler.cs

@ -19,7 +19,7 @@ namespace Avalonia.iOS
_tl = tl;
}
ulong Ts(UIEvent evt) => (ulong) (evt.Timestamp * 1000);
static ulong Ts(UIEvent evt) => (ulong) (evt.Timestamp * 1000);
private IInputRoot Root => _view.InputRoot;
private static long _nextTouchPointId = 1;
private Dictionary<UITouch, long> _knownTouches = new Dictionary<UITouch, long>();

4
src/tools/DevGenerators/CompositionGenerator/Generator.ListProxy.cs

@ -92,7 +92,7 @@ class Template
}}
";
private ClassDeclarationSyntax AppendListProxy(GList list, ClassDeclarationSyntax cl)
private static ClassDeclarationSyntax AppendListProxy(GList list, ClassDeclarationSyntax cl)
{
var itemType = list.ItemType;
@ -120,4 +120,4 @@ class Template
}
}
}
}

Some files were not shown because too many files changed in this diff

Loading…
Cancel
Save