From 38e839997d2c204548e6fad396c178780a010cb1 Mon Sep 17 00:00:00 2001 From: Max Katz Date: Thu, 4 Jan 2024 09:16:39 -0800 Subject: [PATCH] Avoid hardcoded font properties (#14088) * Avoid hardcoded FontSize and other Font properties that can be inherited * Avoid TemplateBinding, when Font property can be inherited * Improve Calendar font customization a little * Opps --- .../Accents/FluentControlResources.xaml | 6 ++++++ .../Controls/AutoCompleteBox.xaml | 4 ---- .../Controls/ButtonSpinner.xaml | 3 --- .../Controls/Calendar.xaml | 1 + .../Controls/CalendarButton.xaml | 4 +--- .../Controls/CalendarDayButton.xaml | 2 -- .../Controls/CalendarItem.xaml | 3 +-- .../Controls/CheckBox.xaml | 1 - .../Controls/ComboBox.xaml | 1 - .../Controls/ContextMenu.xaml | 2 -- .../Controls/DatePicker.xaml | 18 +++--------------- .../Controls/HeaderedContentControl.xaml | 8 -------- .../Controls/ListBox.xaml | 1 - .../Controls/ListBoxItem.xaml | 5 ----- src/Avalonia.Themes.Fluent/Controls/Menu.xaml | 1 - .../Controls/MenuItem.xaml | 1 - .../Controls/NotificationCard.xaml | 1 - .../Controls/NumericUpDown.xaml | 2 -- .../Controls/OverlayPopupHost.xaml | 2 +- .../Controls/PopupRoot.xaml | 2 +- .../Controls/RadioButton.xaml | 1 - .../Controls/RepeatButton.xaml | 2 -- .../Controls/Slider.xaml | 1 - .../Controls/SplitButton.xaml | 3 --- .../Controls/TabItem.xaml | 5 +---- .../Controls/TabStripItem.xaml | 5 +---- .../Controls/TextBox.xaml | 2 -- .../Controls/ThemeVariantScope.xaml | 2 -- .../Controls/TimePicker.xaml | 17 +++-------------- .../Controls/ToggleButton.xaml | 2 -- .../Controls/ToggleSwitch.xaml | 1 - .../DensityStyles/Compact.xaml | 1 - .../Controls/NotificationCard.xaml | 2 +- .../Controls/ThemeVariantScope.xaml | 1 - 34 files changed, 20 insertions(+), 93 deletions(-) diff --git a/src/Avalonia.Themes.Fluent/Accents/FluentControlResources.xaml b/src/Avalonia.Themes.Fluent/Accents/FluentControlResources.xaml index c906827e50..c38599f171 100644 --- a/src/Avalonia.Themes.Fluent/Accents/FluentControlResources.xaml +++ b/src/Avalonia.Themes.Fluent/Accents/FluentControlResources.xaml @@ -385,6 +385,9 @@ + 20 + 12 + SemiBold @@ -1180,6 +1183,9 @@ + 20 + 12 + SemiBold diff --git a/src/Avalonia.Themes.Fluent/Controls/AutoCompleteBox.xaml b/src/Avalonia.Themes.Fluent/Controls/AutoCompleteBox.xaml index 083d90b010..5ade49fab0 100644 --- a/src/Avalonia.Themes.Fluent/Controls/AutoCompleteBox.xaml +++ b/src/Avalonia.Themes.Fluent/Controls/AutoCompleteBox.xaml @@ -28,7 +28,6 @@ - @@ -43,9 +42,6 @@ BorderThickness="{TemplateBinding BorderThickness}" CornerRadius="{TemplateBinding CornerRadius}" CaretIndex="{TemplateBinding CaretIndex, Mode=TwoWay}" - FontSize="{TemplateBinding FontSize}" - FontFamily="{TemplateBinding FontFamily}" - FontWeight="{TemplateBinding FontWeight}" Padding="{TemplateBinding Padding}" Margin="0" DataValidationErrors.Errors="{TemplateBinding (DataValidationErrors.Errors)}" /> diff --git a/src/Avalonia.Themes.Fluent/Controls/ButtonSpinner.xaml b/src/Avalonia.Themes.Fluent/Controls/ButtonSpinner.xaml index 095e801d0c..a03366ab0a 100644 --- a/src/Avalonia.Themes.Fluent/Controls/ButtonSpinner.xaml +++ b/src/Avalonia.Themes.Fluent/Controls/ButtonSpinner.xaml @@ -79,7 +79,6 @@ - @@ -104,7 +103,6 @@ VerticalAlignment="Stretch" VerticalContentAlignment="Center" Foreground="{TemplateBinding Foreground}" - FontSize="{TemplateBinding FontSize}" MinWidth="34"> + - @@ -41,7 +40,6 @@ Content="{TemplateBinding Content}" HorizontalAlignment="{TemplateBinding HorizontalContentAlignment}" VerticalAlignment="{TemplateBinding VerticalContentAlignment}" - FontSize="{TemplateBinding FontSize}" Margin="{TemplateBinding Padding}" /> @@ -73,7 +71,7 @@