diff --git a/src/Avalonia.Base/Platform/IAssetLoader.cs b/src/Avalonia.Base/Platform/IAssetLoader.cs
index ba30af60bf..3b459818dd 100644
--- a/src/Avalonia.Base/Platform/IAssetLoader.cs
+++ b/src/Avalonia.Base/Platform/IAssetLoader.cs
@@ -2,6 +2,7 @@
// Licensed under the MIT license. See licence.md file in the project root for full license information.
using System;
+using System.Collections.Generic;
using System.IO;
using System.Reflection;
@@ -18,8 +19,8 @@ namespace Avalonia.Platform
/// AssetLoader needs a refactor cause right now it lives in 3+ platforms which
/// can all be loaded on Windows.
///
- ///
- void SetDefaultAssembly(Assembly asm);
+ ///
+ void SetDefaultAssembly(Assembly assembly);
///
/// Checks if an asset with the specified URI exists.
@@ -32,32 +33,39 @@ namespace Avalonia.Platform
bool Exists(Uri uri, Uri baseUri = null);
///
- /// Opens the resource with the requested URI.
+ /// Opens the asset with the requested URI.
///
/// The URI.
///
/// A base URI to use if is relative.
///
- /// A stream containing the resource contents.
+ /// A stream containing the asset contents.
///
/// The resource was not found.
///
Stream Open(Uri uri, Uri baseUri = null);
///
- /// Opens the resource with the requested URI and returns the resource string and the
- /// assembly containing the resource.
+ /// Opens the asset with the requested URI and returns the asset stream and the
+ /// assembly containing the asset.
///
/// The URI.
///
/// A base URI to use if is relative.
///
///
- /// The stream containing the resource contents together with the assembly.
+ /// The stream containing the asset contents together with the assembly.
///
///
/// The resource was not found.
///
- Tuple OpenAndGetAssembly(Uri uri, Uri baseUri = null);
+ (Stream stream, Assembly assembly) OpenAndGetAssembly(Uri uri, Uri baseUri = null);
+
+ ///
+ /// Gets all assets at a specific location.
+ ///
+ /// The location of assets.
+ /// A tuple containing the absolute path to the resource and the owner assembly
+ IEnumerable<(string absolutePath, Assembly assembly)> GetAssets(Uri location);
}
}
diff --git a/src/Shared/PlatformSupport/AssetLoader.cs b/src/Shared/PlatformSupport/AssetLoader.cs
index fa11edb57b..b835170036 100644
--- a/src/Shared/PlatformSupport/AssetLoader.cs
+++ b/src/Shared/PlatformSupport/AssetLoader.cs
@@ -10,6 +10,7 @@ using Avalonia.Platform;
namespace Avalonia.Shared.PlatformSupport
{
+ ///
///
/// Loads assets compiled into the application binary.
///
@@ -34,21 +35,26 @@ namespace Avalonia.Shared.PlatformSupport
_defaultAssembly = new AssemblyDescriptor(assembly);
}
+ ///
///
- /// Sets the default assembly from which to load assets for which no assembly is specified.
+ /// We need a way to override the default assembly selected by the host platform
+ /// because right now it is selecting the wrong one for PCL based Apps. The
+ /// AssetLoader needs a refactor cause right now it lives in 3+ platforms which
+ /// can all be loaded on Windows.
///
- /// The default assembly.
+ ///
public void SetDefaultAssembly(Assembly assembly)
{
_defaultAssembly = new AssemblyDescriptor(assembly);
}
+ ///
///
/// Checks if an asset with the specified URI exists.
///
/// The URI.
///
- /// A base URI to use if is relative.
+ /// A base URI to use if is relative.
///
/// True if the asset could be found; otherwise false.
public bool Exists(Uri uri, Uri baseUri = null)
@@ -56,34 +62,37 @@ namespace Avalonia.Shared.PlatformSupport
return GetAsset(uri, baseUri) != null;
}
+ ///
///
- /// Opens the resource with the requested URI.
+ /// Opens the asset with the requested URI.
///
/// The URI.
///
- /// A base URI to use if is relative.
+ /// A base URI to use if is relative.
///
- /// A stream containing the resource contents.
- ///
+ /// A stream containing the asset contents.
+ ///
/// The resource was not found.
///
- public Stream Open(Uri uri, Uri baseUri = null) => OpenAndGetAssembly(uri, baseUri).Item1;
-
+ public Stream Open(Uri uri, Uri baseUri = null) => OpenAndGetAssembly(uri, baseUri).stream;
+
+
+ ///
///
- /// Opens the resource with the requested URI and returns the resource string and the
- /// assembly containing the resource.
+ /// Opens the asset with the requested URI and returns the asset stream and the
+ /// assembly containing the asset.
///
/// The URI.
///
- /// A base URI to use if is relative.
+ /// A base URI to use if is relative.
///
///
- /// The stream containing the resource contents together with the assembly.
+ /// The stream containing the asset contents together with the assembly.
///
- ///
+ ///
/// The resource was not found.
///
- public Tuple OpenAndGetAssembly(Uri uri, Uri baseUri = null)
+ public (Stream stream, Assembly assembly) OpenAndGetAssembly(Uri uri, Uri baseUri = null)
{
var asset = GetAsset(uri, baseUri);
@@ -92,7 +101,22 @@ namespace Avalonia.Shared.PlatformSupport
throw new FileNotFoundException($"The resource {uri} could not be found.");
}
- return Tuple.Create(asset.GetStream(), asset.Assembly);
+ return (asset.GetStream(), asset.Assembly);
+ }
+
+ ///
+ ///
+ /// Gets all assets at a specific location.
+ ///
+ /// The location of assets.
+ /// A tuple containing the absolute path to the resource and the owner assembly
+ public IEnumerable<(string absolutePath, Assembly assembly)> GetAssets(Uri location)
+ {
+ var assembly = GetAssembly(location);
+
+ return assembly?.Assets.Where(x => x.Key.Contains(location.AbsolutePath))
+ .Select(x => (x.Key, x.Value.Assembly)) ??
+ Enumerable.Empty<(string AbsolutePath, Assembly Assembly)>();
}
private IAssetDescriptor GetAsset(Uri uri, Uri baseUri)
@@ -110,8 +134,8 @@ namespace Avalonia.Shared.PlatformSupport
IAssetDescriptor rv;
- var resourceKey = uri.AbsolutePath;
- asm.Resources.TryGetValue(resourceKey, out rv);
+ var assetKey = uri.AbsolutePath;
+ asm.Assets.TryGetValue(assetKey, out rv);
return rv;
}
throw new ArgumentException($"Invalid uri, see https://github.com/AvaloniaUI/Avalonia/issues/282#issuecomment-166982104", nameof(uri));
@@ -122,9 +146,8 @@ namespace Avalonia.Shared.PlatformSupport
if (uri != null)
{
var qs = ParseQueryString(uri);
- string assemblyName;
- if (qs.TryGetValue("assembly", out assemblyName))
+ if (qs.TryGetValue("assembly", out var assemblyName))
{
return GetAssembly(assemblyName);
}
@@ -140,8 +163,7 @@ namespace Avalonia.Shared.PlatformSupport
return _defaultAssembly;
}
- AssemblyDescriptor rv;
- if (!AssemblyNameCache.TryGetValue(name, out rv))
+ if (!AssemblyNameCache.TryGetValue(name, out var rv))
{
var loadedAssemblies = AvaloniaLocator.Current.GetService().GetLoadedAssemblies();
var match = loadedAssemblies.FirstOrDefault(a => a.GetName().Name == name);
@@ -208,14 +230,14 @@ namespace Avalonia.Shared.PlatformSupport
if (assembly != null)
{
- Resources = assembly.GetManifestResourceNames()
+ Assets = assembly.GetManifestResourceNames()
.ToDictionary(n => n, n => (IAssetDescriptor)new AssemblyResourceDescriptor(assembly, n));
Name = assembly.GetName().Name;
}
}
public Assembly Assembly { get; }
- public Dictionary Resources { get; }
+ public Dictionary Assets { get; }
public string Name { get; }
}
}
diff --git a/tests/Avalonia.UnitTests/MockAssetLoader.cs b/tests/Avalonia.UnitTests/MockAssetLoader.cs
index d6b70aee16..abfac77a5e 100644
--- a/tests/Avalonia.UnitTests/MockAssetLoader.cs
+++ b/tests/Avalonia.UnitTests/MockAssetLoader.cs
@@ -4,7 +4,6 @@ using System.IO;
using System.Linq;
using System.Reflection;
using System.Text;
-using System.Threading.Tasks;
using Avalonia.Platform;
namespace Avalonia.UnitTests
@@ -27,10 +26,16 @@ namespace Avalonia.UnitTests
{
return new MemoryStream(Encoding.UTF8.GetBytes(_assets[uri]));
}
-
- public Tuple OpenAndGetAssembly(Uri uri, Uri baseUri = null)
+
+ public (Stream stream, Assembly assembly) OpenAndGetAssembly(Uri uri, Uri baseUri = null)
+ {
+ return (Open(uri, baseUri), (Assembly)null);
+ }
+
+ public IEnumerable<(string absolutePath, Assembly assembly)> GetAssets(Uri location)
{
- return Tuple.Create(Open(uri, baseUri), (Assembly)null);
+ return _assets.Keys.Where(x => x.AbsolutePath.Contains(location.AbsolutePath))
+ .Select(x => (x.AbsolutePath, Assembly.GetEntryAssembly()));
}
public void SetDefaultAssembly(Assembly asm)