Browse Source

fix: address review

pull/9628/head
Giuseppe Lippolis 4 years ago
parent
commit
51c2fa0858
  1. 14
      src/Avalonia.Base/Animation/Cue.cs
  2. 6
      src/Avalonia.Base/Media/BoxShadow.cs
  3. 4
      src/Avalonia.Base/Media/BoxShadows.cs

14
src/Avalonia.Base/Animation/Cue.cs

@ -49,15 +49,6 @@ namespace Avalonia.Animation
}
}
/// <summary>
/// Checks for equality between two <see cref="Cue"/>s.
/// </summary>
/// <param name="other">The second cue.</param>
public bool Equals(Cue other)
{
return CueValue == other.CueValue;
}
/// <summary>
/// Checks for equality between a <see cref="Cue"/>
/// and a <see cref="double"/> value.
@ -68,11 +59,6 @@ namespace Avalonia.Animation
{
return CueValue == other;
}
public override int GetHashCode()
{
return CueValue.GetHashCode();
}
}
public class CueTypeConverter : TypeConverter

6
src/Avalonia.Base/Media/BoxShadow.cs

@ -171,5 +171,11 @@ namespace Avalonia.Media
public Rect TransformBounds(in Rect rect)
=> IsInset ? rect : rect.Translate(new Vector(OffsetX, OffsetY)).Inflate(Spread + Blur);
public static bool operator ==(BoxShadow left, BoxShadow right) =>
left.Equals(right);
public static bool operator !=(BoxShadow left, BoxShadow right) =>
!(left == right);
}
}

4
src/Avalonia.Base/Media/BoxShadows.cs

@ -62,7 +62,9 @@ namespace Avalonia.Media
}
[EditorBrowsable(EditorBrowsableState.Never)]
public record struct BoxShadowsEnumerator
#pragma warning disable CA1815 // Override equals and operator equals on value types
public struct BoxShadowsEnumerator
#pragma warning restore CA1815 // Override equals and operator equals on value types
{
private int _index;
private BoxShadows _shadows;

Loading…
Cancel
Save