tsai
/
Avalonia
mirror of https://github.com/AvaloniaUI/Avalonia.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Expose ContentPresenter from ItemsControl.LogicalChildren. 

Exposing the `ContentPresenter.Child` in `ItemsControl.LogicalChildren` was causing problems when detaching and reattaching an `ItemsControl` to the logical tree. Instead, expose the `ContentPresenter` itself in effect meaning that `ItemsControl` has a "container" type just like the controls derived from it.

Fixes #3487
pull/3546/head
Steven Kirk 7 years ago
parent
632c40340a
commit
56825d252e
3 changed files with 29 additions and 64 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 39
      src/Avalonia.Controls/ItemsControl.cs
  2. 46
      tests/Avalonia.Controls.UnitTests/CarouselTests.cs
  3. 8
      tests/Avalonia.Controls.UnitTests/ItemsControlTests.cs

39
src/Avalonia.Controls/ItemsControl.cs
View File

@ -236,25 +236,7 @@ namespace Avalonia.Controls
// it was added to the Items collection.
if (container.ContainerControl != null && container.ContainerControl != container.Item)
{
if (ItemContainerGenerator.ContainerType == null)
{
var containerControl = container.ContainerControl as ContentPresenter;
if (containerControl != null)
{
((ISetLogicalParent)containerControl).SetParent(this);
containerControl.UpdateChild();
if (containerControl.Child != null)
{
LogicalChildren.Add(containerControl.Child);
}
}
}
else
{
LogicalChildren.Add(container.ContainerControl);
}
LogicalChildren.Add(container.ContainerControl);
}
}
}
@ -272,24 +254,7 @@ namespace Avalonia.Controls
// when it is removed from the Items collection.
if (container?.ContainerControl != container?.Item)
{
if (ItemContainerGenerator.ContainerType == null)
{
var containerControl = container.ContainerControl as ContentPresenter;
if (containerControl != null)
{
((ISetLogicalParent)containerControl).SetParent(null);
if (containerControl.Child != null)
{
LogicalChildren.Remove(containerControl.Child);
}
}
}
else
{
LogicalChildren.Remove(container.ContainerControl);
}
LogicalChildren.Remove(container.ContainerControl);
}
}
}

46
tests/Avalonia.Controls.UnitTests/CarouselTests.cs
View File

@ -51,10 +51,9 @@ namespace Avalonia.Controls.UnitTests
Assert.Single(target.GetLogicalChildren());
var child = target.GetLogicalChildren().Single();
var child = GetContainerTextBlock(target.GetLogicalChildren().Single());
Assert.IsType<TextBlock>(child);
Assert.Equal("Foo", ((TextBlock)child).Text);
Assert.Equal("Foo", child.Text);
}
[Fact]
@ -98,20 +97,18 @@ namespace Avalonia.Controls.UnitTests
Assert.Equal(3, target.GetLogicalChildren().Count());
var child = target.GetLogicalChildren().First();
var child = GetContainerTextBlock(target.GetLogicalChildren().First());
Assert.IsType<TextBlock>(child);
Assert.Equal("Foo", ((TextBlock)child).Text);
Assert.Equal("Foo", child.Text);
var newItems = items.ToList();
newItems.RemoveAt(0);
target.Items = newItems;
child = target.GetLogicalChildren().First();
child = GetContainerTextBlock(target.GetLogicalChildren().First());
Assert.IsType<TextBlock>(child);
Assert.Equal("Bar", ((TextBlock)child).Text);
Assert.Equal("Bar", child.Text);
}
[Fact]
@ -136,20 +133,18 @@ namespace Avalonia.Controls.UnitTests
Assert.Single(target.GetLogicalChildren());
var child = target.GetLogicalChildren().Single();
var child = GetContainerTextBlock(target.GetLogicalChildren().Single());
Assert.IsType<TextBlock>(child);
Assert.Equal("Foo", ((TextBlock)child).Text);
Assert.Equal("Foo", child.Text);
var newItems = items.ToList();
newItems.RemoveAt(0);
target.Items = newItems;
child = target.GetLogicalChildren().Single();
child = GetContainerTextBlock(target.GetLogicalChildren().Single());
Assert.IsType<TextBlock>(child);
Assert.Equal("Bar", ((TextBlock)child).Text);
Assert.Equal("Bar", child.Text);
}
[Fact]
@ -197,10 +192,9 @@ namespace Avalonia.Controls.UnitTests
Assert.Equal(3, target.GetLogicalChildren().Count());
var child = target.GetLogicalChildren().First();
var child = GetContainerTextBlock(target.GetLogicalChildren().First());
Assert.IsType<TextBlock>(child);
Assert.Equal("Foo", ((TextBlock)child).Text);
Assert.Equal("Foo", child.Text);
target.Items = null;
@ -233,7 +227,7 @@ namespace Avalonia.Controls.UnitTests
Assert.Equal("FooBar", target.SelectedItem);
var child = target.GetVisualDescendants().LastOrDefault();
var child = GetContainerTextBlock(target.GetVisualDescendants().LastOrDefault());
Assert.IsType<TextBlock>(child);
Assert.Equal("FooBar", ((TextBlock)child).Text);
@ -261,14 +255,13 @@ namespace Avalonia.Controls.UnitTests
Assert.Equal(3, target.GetLogicalChildren().Count());
var child = target.GetLogicalChildren().First();
var child = GetContainerTextBlock(target.GetLogicalChildren().First());
Assert.IsType<TextBlock>(child);
Assert.Equal("Foo", ((TextBlock)child).Text);
Assert.Equal("Foo", child.Text);
items.RemoveAt(0);
child = target.GetLogicalChildren().First();
child = GetContainerTextBlock(target.GetLogicalChildren().First());
Assert.IsType<TextBlock>(child);
Assert.Equal("Bar", ((TextBlock)child).Text);
@ -314,5 +307,12 @@ namespace Avalonia.Controls.UnitTests
[~CarouselPresenter.PageTransitionProperty] = control[~Carousel.PageTransitionProperty],
}.RegisterInNameScope(scope);
}
private static TextBlock GetContainerTextBlock(object control)
{
var contentPresenter = Assert.IsType<ContentPresenter>(control);
contentPresenter.UpdateChild();
return Assert.IsType<TextBlock>(contentPresenter.Child);
}
}
}

8
tests/Avalonia.Controls.UnitTests/ItemsControlTests.cs
View File

@ -66,7 +66,7 @@ namespace Avalonia.Controls.UnitTests
}
[Fact]
public void Container_Child_Should_Have_LogicalParent_Set_To_Container()
public void Container_Should_Have_LogicalParent_Set_To_ItemsControl()
{
using (UnitTestApplication.Start(TestServices.StyledWindow))
{
@ -87,7 +87,7 @@ namespace Avalonia.Controls.UnitTests
var container = (ContentPresenter)target.Presenter.Panel.Children[0];
Assert.Equal(container, container.Child.Parent);
Assert.Equal(target, container.Parent);
}
}
@ -190,7 +190,7 @@ namespace Avalonia.Controls.UnitTests
}
[Fact]
public void Adding_String_Item_Should_Make_TextBlock_Appear_In_LogicalChildren()
public void Adding_String_Item_Should_Make_ContentPresenter_Appear_In_LogicalChildren()
{
var target = new ItemsControl();
var child = new Control();
@ -202,7 +202,7 @@ namespace Avalonia.Controls.UnitTests
var logical = (ILogical)target;
Assert.Equal(1, logical.LogicalChildren.Count);
Assert.IsType<TextBlock>(logical.LogicalChildren[0]);
Assert.IsType<ContentPresenter>(logical.LogicalChildren[0]);
}
[Fact]

Write Preview
Loading…
Cancel
Save