From 667b02d2c0d6e713980f0ad05c843d96e0c5a6f4 Mon Sep 17 00:00:00 2001
From: robloo <robloo@users.noreply.github.com>
Date: Sun, 2 Oct 2022 14:33:24 -0400
Subject: [PATCH] Disable WriteableBitmap re-use in ColorSlider due to crashes

---
 .../ColorSlider/ColorSlider.cs                            | 8 +++++++-
 .../Helpers/ColorPickerHelpers.cs                         | 1 +
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/Avalonia.Controls.ColorPicker/ColorSlider/ColorSlider.cs b/src/Avalonia.Controls.ColorPicker/ColorSlider/ColorSlider.cs
index 6f20238b70..8b624958dd 100644
--- a/src/Avalonia.Controls.ColorPicker/ColorSlider/ColorSlider.cs
+++ b/src/Avalonia.Controls.ColorPicker/ColorSlider/ColorSlider.cs
@@ -135,10 +135,16 @@ namespace Avalonia.Controls.Primitives
                 {
                     if (_backgroundBitmap != null)
                     {
+                        // CURRENTLY DISABLED DUE TO INTERMITTENT CRASHES IN SKIA/RENDERER
+                        //
                         // Re-use the existing WriteableBitmap
                         // This assumes the height, width and byte counts are the same and must be set to null
                         // elsewhere if that assumption is ever not true.
-                        ColorPickerHelpers.UpdateBitmapFromPixelData(_backgroundBitmap, bgraPixelData);
+                        // ColorPickerHelpers.UpdateBitmapFromPixelData(_backgroundBitmap, bgraPixelData);
+
+                        // ALSO DISABLED DISPOSE DUE TO INTERMITTENT CRASHES
+                        //_backgroundBitmap?.Dispose();
+                        _backgroundBitmap = ColorPickerHelpers.CreateBitmapFromPixelData(bgraPixelData, pixelWidth, pixelHeight);
                     }
                     else
                     {
diff --git a/src/Avalonia.Controls.ColorPicker/Helpers/ColorPickerHelpers.cs b/src/Avalonia.Controls.ColorPicker/Helpers/ColorPickerHelpers.cs
index 2378813f52..01e5a0868f 100644
--- a/src/Avalonia.Controls.ColorPicker/Helpers/ColorPickerHelpers.cs
+++ b/src/Avalonia.Controls.ColorPicker/Helpers/ColorPickerHelpers.cs
@@ -627,6 +627,7 @@ namespace Avalonia.Controls.Primitives
 
         /// <summary>
         /// Updates the given <see cref="WriteableBitmap"/> with new, raw BGRA pre-multiplied alpha pixel data.
+        /// WARNING: THIS METHOD IS CURRENTLY PROVIDED AS REFERENCE BUT CAUSES INTERMITTENT CRASHES IF USED.
         /// WARNING: The bitmap's width, height and byte count MUST not have changed and MUST be enforced externally.
         /// </summary>
         /// <param name="bitmap">The existing <see cref="WriteableBitmap"/> to update.</param>