Merge branch 'master' into fixes/avalonialist-copyto

src/Avalonia.Controls/Primitives/SelectingItemsControl.cs

@@ -491,8 +491,7 @@ namespace Avalonia.Controls.Primitives
 
                 if (ItemCount > 0 &&
                     Match(keymap.SelectAll) &&
-                    (((SelectionMode & SelectionMode.Multiple) != 0) ||
+                    SelectionMode.HasFlag(SelectionMode.Multiple))
-                      (SelectionMode & SelectionMode.Toggle) != 0))
                 {
                     Selection.SelectAll();
                     e.Handled = true;

src/Avalonia.Controls/Selection/InternalSelectionModel.cs

@@ -63,6 +63,11 @@ namespace Avalonia.Controls.Selection
 
         private protected override void SetSource(IEnumerable? value)
         {
+            if (Source == value)
+            {
+                return;
+            }
+
             object?[]? oldSelection = null;
 
             if (Source is object && value is object)

src/Avalonia.Input/KeyboardNavigation.cs

@@ -25,12 +25,11 @@ namespace Avalonia.Input
         /// attached property set to <see cref="KeyboardNavigationMode.Once"/>, this property
         /// defines to which child the focus should move.
         /// </remarks>
-        public static readonly AttachedProperty<IInputElement> TabOnceActiveElementProperty =
+        public static readonly AttachedProperty<IInputElement?> TabOnceActiveElementProperty =
-            AvaloniaProperty.RegisterAttached<InputElement, IInputElement>(
+            AvaloniaProperty.RegisterAttached<InputElement, IInputElement?>(
                 "TabOnceActiveElement",
                 typeof(KeyboardNavigation));
 
-
         /// <summary>
         /// Defines the IsTabStop attached property.
         /// </summary>
@@ -68,7 +67,7 @@ namespace Avalonia.Input
         /// </summary>
         /// <param name="element">The container.</param>
         /// <returns>The active element for the container.</returns>
-        public static IInputElement GetTabOnceActiveElement(InputElement element)
+        public static IInputElement? GetTabOnceActiveElement(InputElement element)
         {
             return element.GetValue(TabOnceActiveElementProperty);
         }
@@ -78,7 +77,7 @@ namespace Avalonia.Input
         /// </summary>
         /// <param name="element">The container.</param>
         /// <param name="value">The active element for the container.</param>
-        public static void SetTabOnceActiveElement(InputElement element, IInputElement value)
+        public static void SetTabOnceActiveElement(InputElement element, IInputElement? value)
         {
             element.SetValue(TabOnceActiveElementProperty, value);
         }

src/Avalonia.Layout/FlowLayoutAlgorithm.cs

@@ -211,7 +211,7 @@ namespace Avalonia.Layout
                             anchorPosition = new Point(anchorBounds.X, anchorBounds.Y);
                         }
                     }
-                    else
+                    else if (anchorIndex >= 0)
                     {
                         // It is possible to end up in a situation during a collection change where GetAnchorForTargetElement returns an index
                         // which is not in the realized range. Eg. insert one item at index 0 for a grid layout.