From 772937ad1543e339b55eb10cadaec0fc9ea1fa6e Mon Sep 17 00:00:00 2001
From: Steven Kirk <grokys@gmail.com>
Date: Wed, 30 Sep 2015 20:29:35 +0200
Subject: [PATCH] Change ExpressionValue to struct.

And add some docs.
---
 .../Perspex.Markup/Binding/ExpressionNode.cs  |  5 ----
 .../Binding/ExpressionObserver.cs             | 23 ++++++++++++++++++
 .../Perspex.Markup/Binding/ExpressionValue.cs | 24 ++++++++++++++-----
 3 files changed, 41 insertions(+), 11 deletions(-)

diff --git a/src/Markup/Perspex.Markup/Binding/ExpressionNode.cs b/src/Markup/Perspex.Markup/Binding/ExpressionNode.cs
index 64fbe20873..aec90ee070 100644
--- a/src/Markup/Perspex.Markup/Binding/ExpressionNode.cs
+++ b/src/Markup/Perspex.Markup/Binding/ExpressionNode.cs
@@ -58,11 +58,6 @@ namespace Perspex.Markup.Binding
 
             set
             {
-                if (value == null)
-                {
-                    throw new ArgumentNullException("value");
-                }
-
                 _value = value;
 
                 if (Next != null)
diff --git a/src/Markup/Perspex.Markup/Binding/ExpressionObserver.cs b/src/Markup/Perspex.Markup/Binding/ExpressionObserver.cs
index 4bc0192c9f..cdbeddda0c 100644
--- a/src/Markup/Perspex.Markup/Binding/ExpressionObserver.cs
+++ b/src/Markup/Perspex.Markup/Binding/ExpressionObserver.cs
@@ -9,16 +9,32 @@ using System.Reactive.Disposables;
 
 namespace Perspex.Markup.Binding
 {
+    /// <summary>
+    /// Observes the value of an expression on a root object.
+    /// </summary>
     public class ExpressionObserver : ObservableBase<ExpressionValue>
     {
         private int _count;
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="ExpressionObserver"/> class.
+        /// </summary>
+        /// <param name="root">The root object.</param>
+        /// <param name="expression">The expression.</param>
         public ExpressionObserver(object root, string expression)
         {
             Root = root;
             Nodes = ExpressionNodeBuilder.Build(expression);
         }
 
+        /// <summary>
+        /// Attempts to set the value of a property expression.
+        /// </summary>
+        /// <param name="value">The value to set.</param>
+        /// <returns>
+        /// True if the value could be set; false if the expression does not evaluate to a 
+        /// property.
+        /// </returns>
         public bool SetValue(object value)
         {
             var last = Nodes.Last() as PropertyAccessorNode;
@@ -39,10 +55,17 @@ namespace Perspex.Markup.Binding
             return false;
         }
 
+        /// <summary>
+        /// Gets the root object that the expression is being observed on.
+        /// </summary>
         public object Root { get; }
 
+        /// <summary>
+        /// Gets a list of nodes representing the parts of the expression.
+        /// </summary>
         public IList<ExpressionNode> Nodes { get; }
 
+        /// <inheritdoc/>
         protected override IDisposable SubscribeCore(IObserver<ExpressionValue> observer)
         {
             IncrementCount();
diff --git a/src/Markup/Perspex.Markup/Binding/ExpressionValue.cs b/src/Markup/Perspex.Markup/Binding/ExpressionValue.cs
index 7579f98db4..2441acda73 100644
--- a/src/Markup/Perspex.Markup/Binding/ExpressionValue.cs
+++ b/src/Markup/Perspex.Markup/Binding/ExpressionValue.cs
@@ -5,22 +5,34 @@ using System;
 
 namespace Perspex.Markup.Binding
 {
-    public class ExpressionValue
+    /// <summary>
+    /// Holds the value for an <see cref="ExpressionObserver"/>.
+    /// </summary>
+    public struct ExpressionValue
     {
+        /// <summary>
+        /// An <see cref="ExpressionValue"/> that has no value.
+        /// </summary>
         public static readonly ExpressionValue None = new ExpressionValue();
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="ExpressionValue"/> struct.
+        /// </summary>
+        /// <param name="value"></param>
         public ExpressionValue(object value)
         {
             HasValue = true;
             Value = value;
         }
 
-        private ExpressionValue()
-        {
-            HasValue = false;
-        }
-
+        /// <summary>
+        /// Gets a value indicating whether the evaluated expression resulted in a value.
+        /// </summary>
         public bool HasValue { get; }
+
+        /// <summary>
+        /// Gets a the result of the expression.
+        /// </summary>
         public object Value { get; }
     }
 }