From 68134c925fb3ff9acf78725b0cdc4a3cb77554e8 Mon Sep 17 00:00:00 2001
From: robloo <robloo@users.noreply.github.com>
Date: Sat, 27 May 2023 19:48:07 -0400
Subject: [PATCH 1/4] Switch RangeBase.ValueChanged from generic
 RoutedPropertyChangedEventArgs<double> to RangeBaseValueChangedEventArgs

This follows the WinUI pattern and makes a bit more sense. It is also similar to what is done with TextBox events as well.
---
 src/Avalonia.Controls/Primitives/RangeBase.cs |  8 ++--
 .../RangeBaseValueChangedEventArgs.cs         | 47 +++++++++++++++++++
 2 files changed, 51 insertions(+), 4 deletions(-)
 create mode 100644 src/Avalonia.Controls/Primitives/RangeBaseValueChangedEventArgs.cs

diff --git a/src/Avalonia.Controls/Primitives/RangeBase.cs b/src/Avalonia.Controls/Primitives/RangeBase.cs
index ebf7879412..33ab78b66f 100644
--- a/src/Avalonia.Controls/Primitives/RangeBase.cs
+++ b/src/Avalonia.Controls/Primitives/RangeBase.cs
@@ -45,14 +45,14 @@ namespace Avalonia.Controls.Primitives
         /// <summary>
         /// Defines the <see cref="ValueChanged"/> event.
         /// </summary>
-        public static readonly RoutedEvent<RoutedPropertyChangedEventArgs<double>> ValueChangedEvent =
-            RoutedEvent.Register<RangeBase, RoutedPropertyChangedEventArgs<double>>(
+        public static readonly RoutedEvent<RangeBaseValueChangedEventArgs> ValueChangedEvent =
+            RoutedEvent.Register<RangeBase, RangeBaseValueChangedEventArgs>(
                 nameof(ValueChanged), RoutingStrategies.Bubble);
 
         /// <summary>
         /// Occurs when the <see cref="Value"/> property changes.
         /// </summary>
-        public event EventHandler<RoutedPropertyChangedEventArgs<double>>? ValueChanged
+        public event EventHandler<RangeBaseValueChangedEventArgs>? ValueChanged
         {
             add => AddHandler(ValueChangedEvent, value);
             remove => RemoveHandler(ValueChangedEvent, value);
@@ -163,7 +163,7 @@ namespace Avalonia.Controls.Primitives
             }
             else if (change.Property == ValueProperty)
             {
-                var valueChangedEventArgs = new RoutedPropertyChangedEventArgs<double>(
+                var valueChangedEventArgs = new RangeBaseValueChangedEventArgs(
                     change.GetOldValue<double>(),
                     change.GetNewValue<double>(),
                     ValueChangedEvent);
diff --git a/src/Avalonia.Controls/Primitives/RangeBaseValueChangedEventArgs.cs b/src/Avalonia.Controls/Primitives/RangeBaseValueChangedEventArgs.cs
new file mode 100644
index 0000000000..ce1ac90bc6
--- /dev/null
+++ b/src/Avalonia.Controls/Primitives/RangeBaseValueChangedEventArgs.cs
@@ -0,0 +1,47 @@
+using Avalonia.Interactivity;
+
+namespace Avalonia.Controls.Primitives
+{
+    /// <summary>
+    /// Provides data specific to a <see cref="RangeBase.ValueChanged"/> event.
+    /// </summary>
+    public class RangeBaseValueChangedEventArgs : RoutedEventArgs
+    {
+        /// <summary>
+        /// Initializes a new instance of the <see cref="RangeBaseValueChangedEventArgs"/> class.
+        /// </summary>
+        /// <param name="oldValue">The old property value.</param>
+        /// <param name="newValue">The new property value.</param>
+        /// <param name="routedEvent">The routed event associated with these event args.</param>
+        public RangeBaseValueChangedEventArgs(double oldValue, double newValue, RoutedEvent? routedEvent)
+            : base(routedEvent)
+        {
+            OldValue = oldValue;
+            NewValue = newValue;
+        }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="RangeBaseValueChangedEventArgs"/> class.
+        /// </summary>
+        /// <param name="oldValue">The old property value.</param>
+        /// <param name="newValue">The new property value.</param>
+        /// <param name="routedEvent">The routed event associated with these event args.</param>
+        /// <param name="source">The source object that raised the routed event.</param>
+        public RangeBaseValueChangedEventArgs(double oldValue, double newValue, RoutedEvent? routedEvent, object? source)
+            : base(routedEvent, source)
+        {
+            OldValue = oldValue;
+            NewValue = newValue;
+        }
+
+        /// <summary>
+        /// Gets the old value of the property.
+        /// </summary>
+        public double OldValue { get; init; }
+
+        /// <summary>
+        /// Gets the new value of the property.
+        /// </summary>
+        public double NewValue { get; init; }
+    }
+}

From 545e9051bd89083f9d272703a5df475fbad89920 Mon Sep 17 00:00:00 2001
From: robloo <robloo@users.noreply.github.com>
Date: Sat, 27 May 2023 19:48:55 -0400
Subject: [PATCH 2/4] Remove generic RoutedPropertyChangedEventArgs

---
 .../RoutedPropertyChangedEventArgs.cs         | 46 -------------------
 1 file changed, 46 deletions(-)
 delete mode 100644 src/Avalonia.Base/Interactivity/RoutedPropertyChangedEventArgs.cs

diff --git a/src/Avalonia.Base/Interactivity/RoutedPropertyChangedEventArgs.cs b/src/Avalonia.Base/Interactivity/RoutedPropertyChangedEventArgs.cs
deleted file mode 100644
index 22134b518d..0000000000
--- a/src/Avalonia.Base/Interactivity/RoutedPropertyChangedEventArgs.cs
+++ /dev/null
@@ -1,46 +0,0 @@
-namespace Avalonia.Interactivity
-{
-    /// <summary>
-    /// Provides both old and new property values with a routed event.
-    /// </summary>
-    /// <typeparam name="T">The type of values.</typeparam>
-    public class RoutedPropertyChangedEventArgs<T> : RoutedEventArgs
-    {
-        /// <summary>
-        /// Initializes a new instance of the <see cref="RoutedPropertyChangedEventArgs{T}"/> class.
-        /// </summary>
-        /// <param name="oldValue">The old property value.</param>
-        /// <param name="newValue">The new property value.</param>
-        /// <param name="routedEvent">The routed event associated with these event args.</param>
-        public RoutedPropertyChangedEventArgs(T oldValue, T newValue, RoutedEvent? routedEvent)
-            : base(routedEvent)
-        {
-            OldValue = oldValue;
-            NewValue = newValue;
-        }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="RoutedPropertyChangedEventArgs{T}"/> class.
-        /// </summary>
-        /// <param name="oldValue">The old property value.</param>
-        /// <param name="newValue">The new property value.</param>
-        /// <param name="routedEvent">The routed event associated with these event args.</param>
-        /// <param name="source">The source object that raised the routed event.</param>
-        public RoutedPropertyChangedEventArgs(T oldValue, T newValue, RoutedEvent? routedEvent, object? source)
-            : base(routedEvent, source)
-        {
-            OldValue = oldValue;
-            NewValue = newValue;
-        }
-
-        /// <summary>
-        /// Gets the old value of the property.
-        /// </summary>
-        public T OldValue { get; init; }
-
-        /// <summary>
-        /// Gets the new value of the property.
-        /// </summary>
-        public T NewValue { get; init; }
-    }
-}

From 0d1ef8f7b62c037dafd53d9afdcec6a7d5c9f869 Mon Sep 17 00:00:00 2001
From: robloo <robloo@users.noreply.github.com>
Date: Sat, 27 May 2023 19:49:19 -0400
Subject: [PATCH 3/4] Add comments to TextChangedEventArgs and
 TextChangingEventArgs

---
 src/Avalonia.Controls/TextChangedEventArgs.cs  | 11 ++++++++++-
 src/Avalonia.Controls/TextChangingEventArgs.cs | 11 ++++++++++-
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/src/Avalonia.Controls/TextChangedEventArgs.cs b/src/Avalonia.Controls/TextChangedEventArgs.cs
index 1418154256..f614d2d760 100644
--- a/src/Avalonia.Controls/TextChangedEventArgs.cs
+++ b/src/Avalonia.Controls/TextChangedEventArgs.cs
@@ -3,15 +3,24 @@
 namespace Avalonia.Controls
 {
     /// <summary>
-    /// Provides data specific to a TextChanged event.
+    /// Provides data specific to a <see cref="TextBox.TextChanged"/> event.
     /// </summary>
     public class TextChangedEventArgs : RoutedEventArgs
     {
+        /// <summary>
+        /// Initializes a new instance of the <see cref="TextChangedEventArgs"/> class.
+        /// </summary>
+        /// <param name="routedEvent">The routed event associated with these event args.</param>
         public TextChangedEventArgs(RoutedEvent? routedEvent)
             : base (routedEvent)
         {
         }
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="TextChangedEventArgs"/> class.
+        /// </summary>
+        /// <param name="routedEvent">The routed event associated with these event args.</param>
+        /// <param name="source">The source object that raised the routed event.</param>
         public TextChangedEventArgs(RoutedEvent? routedEvent, Interactive? source)
             : base(routedEvent, source)
         {
diff --git a/src/Avalonia.Controls/TextChangingEventArgs.cs b/src/Avalonia.Controls/TextChangingEventArgs.cs
index 09e7d5b258..6ec5afd030 100644
--- a/src/Avalonia.Controls/TextChangingEventArgs.cs
+++ b/src/Avalonia.Controls/TextChangingEventArgs.cs
@@ -3,15 +3,24 @@
 namespace Avalonia.Controls
 {
     /// <summary>
-    /// Provides data specific to a TextChanging event.
+    /// Provides data specific to a <see cref="TextBox.TextChanging"/> event.
     /// </summary>
     public class TextChangingEventArgs : RoutedEventArgs
     {
+        /// <summary>
+        /// Initializes a new instance of the <see cref="TextChangingEventArgs"/> class.
+        /// </summary>
+        /// <param name="routedEvent">The routed event associated with these event args.</param>
         public TextChangingEventArgs(RoutedEvent? routedEvent)
             : base (routedEvent)
         {
         }
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="TextChangingEventArgs"/> class.
+        /// </summary>
+        /// <param name="routedEvent">The routed event associated with these event args.</param>
+        /// <param name="source">The source object that raised the routed event.</param>
         public TextChangingEventArgs(RoutedEvent? routedEvent, Interactive? source)
             : base(routedEvent, source)
         {

From 4bcf08a9dc70efe18cc48fd6ca01679195bec683 Mon Sep 17 00:00:00 2001
From: robloo <robloo@users.noreply.github.com>
Date: Sat, 27 May 2023 20:00:37 -0400
Subject: [PATCH 4/4] Update RangeBaseValueChangedEventArgs comments

---
 .../Primitives/RangeBaseValueChangedEventArgs.cs     | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/Avalonia.Controls/Primitives/RangeBaseValueChangedEventArgs.cs b/src/Avalonia.Controls/Primitives/RangeBaseValueChangedEventArgs.cs
index ce1ac90bc6..480e82e4fc 100644
--- a/src/Avalonia.Controls/Primitives/RangeBaseValueChangedEventArgs.cs
+++ b/src/Avalonia.Controls/Primitives/RangeBaseValueChangedEventArgs.cs
@@ -10,8 +10,8 @@ namespace Avalonia.Controls.Primitives
         /// <summary>
         /// Initializes a new instance of the <see cref="RangeBaseValueChangedEventArgs"/> class.
         /// </summary>
-        /// <param name="oldValue">The old property value.</param>
-        /// <param name="newValue">The new property value.</param>
+        /// <param name="oldValue">The old value of the range value property.</param>
+        /// <param name="newValue">The new value of the range value property.</param>
         /// <param name="routedEvent">The routed event associated with these event args.</param>
         public RangeBaseValueChangedEventArgs(double oldValue, double newValue, RoutedEvent? routedEvent)
             : base(routedEvent)
@@ -23,8 +23,8 @@ namespace Avalonia.Controls.Primitives
         /// <summary>
         /// Initializes a new instance of the <see cref="RangeBaseValueChangedEventArgs"/> class.
         /// </summary>
-        /// <param name="oldValue">The old property value.</param>
-        /// <param name="newValue">The new property value.</param>
+        /// <param name="oldValue">The old value of the range value property.</param>
+        /// <param name="newValue">The new value of the range value property.</param>
         /// <param name="routedEvent">The routed event associated with these event args.</param>
         /// <param name="source">The source object that raised the routed event.</param>
         public RangeBaseValueChangedEventArgs(double oldValue, double newValue, RoutedEvent? routedEvent, object? source)
@@ -35,12 +35,12 @@ namespace Avalonia.Controls.Primitives
         }
 
         /// <summary>
-        /// Gets the old value of the property.
+        /// Gets the old value of the range value property.
         /// </summary>
         public double OldValue { get; init; }
 
         /// <summary>
-        /// Gets the new value of the property.
+        /// Gets the new value of the range value property.
         /// </summary>
         public double NewValue { get; init; }
     }