From 87cc247100a1e47348adccd0e6200620803b0ecc Mon Sep 17 00:00:00 2001 From: Benedikt Schroeder Date: Mon, 16 Apr 2018 18:45:42 +0200 Subject: [PATCH] fix tests --- .../ContentPresenterTests_Layout.cs | 2 +- .../Data/BindingExpressionTests.cs | 20 +++++++++---------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/Avalonia.Controls.UnitTests/Presenters/ContentPresenterTests_Layout.cs b/tests/Avalonia.Controls.UnitTests/Presenters/ContentPresenterTests_Layout.cs index 2c1074aa9a..98e57601a4 100644 --- a/tests/Avalonia.Controls.UnitTests/Presenters/ContentPresenterTests_Layout.cs +++ b/tests/Avalonia.Controls.UnitTests/Presenters/ContentPresenterTests_Layout.cs @@ -233,7 +233,7 @@ namespace Avalonia.Controls.UnitTests.Presenters target.Arrange(new Rect(0, 0, 100, 100)); - Assert.Equal(new Rect(48, 48, 0, 0), content.Bounds); + Assert.Equal(new Rect(32, 32, 0, 0), content.Bounds); } } } \ No newline at end of file diff --git a/tests/Avalonia.Markup.UnitTests/Data/BindingExpressionTests.cs b/tests/Avalonia.Markup.UnitTests/Data/BindingExpressionTests.cs index f5c0c6ec15..a6fb2fa722 100644 --- a/tests/Avalonia.Markup.UnitTests/Data/BindingExpressionTests.cs +++ b/tests/Avalonia.Markup.UnitTests/Data/BindingExpressionTests.cs @@ -58,7 +58,7 @@ namespace Avalonia.Markup.UnitTests.Data [Fact] public async Task Should_Convert_Get_String_To_Double() { - var data = new Class1 { StringValue = "5.6" }; + var data = new Class1 { StringValue = 5.6.ToString(CultureInfo.CurrentCulture) }; var target = new BindingExpression(new ExpressionObserver(data, "StringValue"), typeof(double)); var result = await target.Take(1); @@ -94,12 +94,12 @@ namespace Avalonia.Markup.UnitTests.Data [Fact] public void Should_Convert_Set_String_To_Double() { - var data = new Class1 { StringValue = (5.6).ToString() }; + var data = new Class1 { StringValue = 5.6.ToString(CultureInfo.CurrentCulture) }; var target = new BindingExpression(new ExpressionObserver(data, "StringValue"), typeof(double)); target.OnNext(6.7); - Assert.Equal((6.7).ToString(), data.StringValue); + Assert.Equal(6.7.ToString(CultureInfo.CurrentCulture), data.StringValue); GC.KeepAlive(data); } @@ -111,7 +111,7 @@ namespace Avalonia.Markup.UnitTests.Data var target = new BindingExpression(new ExpressionObserver(data, "DoubleValue"), typeof(string)); var result = await target.Take(1); - Assert.Equal((5.6).ToString(), result); + Assert.Equal((5.6).ToString(CultureInfo.CurrentCulture), result); GC.KeepAlive(data); } @@ -122,7 +122,7 @@ namespace Avalonia.Markup.UnitTests.Data var data = new Class1 { DoubleValue = 5.6 }; var target = new BindingExpression(new ExpressionObserver(data, "DoubleValue"), typeof(string)); - target.OnNext("6.7"); + target.OnNext(6.7.ToString(CultureInfo.CurrentCulture)); Assert.Equal(6.7, data.DoubleValue); @@ -296,7 +296,7 @@ namespace Avalonia.Markup.UnitTests.Data var data = new Class1 { DoubleValue = 5.6 }; var converter = new Mock(); var target = new BindingExpression( - new ExpressionObserver(data, "DoubleValue"), + new ExpressionObserver(data, "DoubleValue"), typeof(string), converter.Object, converterParameter: "foo"); @@ -318,15 +318,15 @@ namespace Avalonia.Markup.UnitTests.Data target.Subscribe(x => result.Add(x)); target.OnNext(1.2); - target.OnNext("3.4"); + target.OnNext(3.4.ToString(CultureInfo.CurrentCulture)); target.OnNext("bar"); Assert.Equal( new[] { - new BindingNotification("5.6"), - new BindingNotification("1.2"), - new BindingNotification("3.4"), + new BindingNotification(5.6.ToString(CultureInfo.CurrentCulture)), + new BindingNotification(1.2.ToString(CultureInfo.CurrentCulture)), + new BindingNotification(3.4.ToString(CultureInfo.CurrentCulture)), new BindingNotification( new InvalidCastException("'bar' is not a valid number."), BindingErrorType.Error)