Browse Source

Cleanup Skia internal APIs

pull/10336/head
Max Katz 3 years ago
parent
commit
8a322d616f
  1. 5
      src/Skia/Avalonia.Skia/GlyphRunImpl.cs
  2. 4
      src/Skia/Avalonia.Skia/GlyphTypefaceImpl.cs
  3. 2
      src/Skia/Avalonia.Skia/SKTypefaceCollection.cs
  4. 2
      src/Skia/Avalonia.Skia/SKTypefaceCollectionCache.cs
  5. 22
      src/Skia/Avalonia.Skia/readme.md

5
src/Skia/Avalonia.Skia/GlyphRunImpl.cs

@ -1,15 +1,12 @@
using System;
using System.Collections.Generic;
using Avalonia.Metadata;
using Avalonia.Platform;
using SkiaSharp;
#nullable enable
namespace Avalonia.Skia
{
/// <inheritdoc />
[Unstable]
public class GlyphRunImpl : IGlyphRunImpl
internal class GlyphRunImpl : IGlyphRunImpl
{
public GlyphRunImpl(SKTextBlob textBlob, Size size, Point baselineOrigin)
{

4
src/Skia/Avalonia.Skia/GlyphTypefaceImpl.cs

@ -1,14 +1,12 @@
using System;
using System.Runtime.InteropServices;
using Avalonia.Media;
using Avalonia.Metadata;
using HarfBuzzSharp;
using SkiaSharp;
namespace Avalonia.Skia
{
[Unstable]
public class GlyphTypefaceImpl : IGlyphTypeface
internal class GlyphTypefaceImpl : IGlyphTypeface
{
private bool _isDisposed;

2
src/Skia/Avalonia.Skia/SKTypefaceCollection.cs

@ -4,7 +4,7 @@ using SkiaSharp;
namespace Avalonia.Skia
{
public class SKTypefaceCollection
internal class SKTypefaceCollection
{
private readonly ConcurrentDictionary<Typeface, SKTypeface> _typefaces =
new ConcurrentDictionary<Typeface, SKTypeface>();

2
src/Skia/Avalonia.Skia/SKTypefaceCollectionCache.cs

@ -7,7 +7,7 @@ using SkiaSharp;
namespace Avalonia.Skia
{
public static class SKTypefaceCollectionCache
internal static class SKTypefaceCollectionCache
{
private static readonly ConcurrentDictionary<FontFamily, SKTypefaceCollection> s_cachedCollections;

22
src/Skia/Avalonia.Skia/readme.md

@ -1,22 +0,0 @@
DrawingContextImpl
- Alpha support missing as SkiaSharp does not expose this
- Gradient Shader caching?
- Pen Dash styles
Formatted Text Rendering
- Minor polish
Linux
- Need gpu platform implementation
macOS
- Need gpu platform implementation
Android
- Not tested at all yet
iOS
- Not tested at all yet
General
- Get Skia Unit Tests passing (most of the issues are related to antialiasing)
Loading…
Cancel
Save