Provide parent type metadata scope for Animatable.Transitions

src/Markup/Avalonia.Markup.Xaml/Avalonia.Markup.Xaml.csproj

@@ -61,6 +61,7 @@
         <Compile Include="XamlIl\CompilerExtensions\Transformers\AvaloniaXamlIlDesignPropertiesTransformer.cs" />
         <Compile Include="XamlIl\CompilerExtensions\Transformers\AvaloniaXamlIlMetadataRemover.cs" />
         <Compile Include="XamlIl\CompilerExtensions\Transformers\AvaloniaXamlIlTransformInstanceAttachedProperties.cs" />
+        <Compile Include="XamlIl\CompilerExtensions\Transformers\AvaloniaXamlIlTransitionsTypeMetadataTransformer.cs" />
         <Compile Include="XamlIl\CompilerExtensions\Transformers\AvaloniaXamlIlWellKnownTypes.cs" />
         <Compile Include="XamlIl\CompilerExtensions\Transformers\AvaloniaXamlIlBindingPropertyAssignmentsTransformer.cs" />
         <Compile Include="XamlIl\CompilerExtensions\XamlIlAvaloniaPropertyHelper.cs" />

src/Markup/Avalonia.Markup.Xaml/XamlIl/CompilerExtensions/AvaloniaXamlIlCompiler.cs

@@ -42,7 +42,8 @@ namespace Avalonia.Markup.Xaml.XamlIl.CompilerExtensions
                 new AvaloniaXamlIlSelectorTransformer(),
                 new AvaloniaXamlIlSetterTransformer(),
                 new AvaloniaXamlIlControlTemplateTargetTypeMetadataTransformer(),
-                new AvaloniaXamlIlConstructorServiceProviderTransformer()
+                new AvaloniaXamlIlConstructorServiceProviderTransformer(),
+                new AvaloniaXamlIlTransitionsTypeMetadataTransformer()
             );
             
             // After everything else

src/Markup/Avalonia.Markup.Xaml/XamlIl/CompilerExtensions/Transformers/AvaloniaXamlIlControlTemplateTargetTypeMetadataTransformer.cs

@@ -56,7 +56,8 @@ namespace Avalonia.Markup.Xaml.XamlIl.CompilerExtensions.Transformers
         public enum ScopeType
         {
             Style,
-            ControlTemplate
+            ControlTemplate,
+            Transitions
         }
         
         public AvaloniaXamlIlTargetTypeMetadataNode(IXamlIlAstValueNode value, IXamlIlAstTypeReference targetType,

src/Markup/Avalonia.Markup.Xaml/XamlIl/CompilerExtensions/Transformers/AvaloniaXamlIlTransitionsTypeMetadataTransformer.cs

@@ -0,0 +1,28 @@
+using XamlIl.Ast;
+using XamlIl.Transform;
+
+namespace Avalonia.Markup.Xaml.XamlIl.CompilerExtensions.Transformers
+{
+    public class AvaloniaXamlIlTransitionsTypeMetadataTransformer : IXamlIlAstTransformer
+    {
+        public IXamlIlAstNode Transform(XamlIlAstTransformationContext context, IXamlIlAstNode node)
+        {
+            if (node is XamlIlAstObjectNode on)
+            {
+                foreach (var ch in on.Children)
+                {
+                    if (ch is XamlIlAstXamlPropertyValueNode pn
+                        && pn.Property.GetClrProperty().PropertyType.Equals(context.GetAvaloniaTypes().Transitions))
+                    {
+                        for (var c = 0; c < pn.Values.Count; c++)
+                        {
+                            pn.Values[c] = new AvaloniaXamlIlTargetTypeMetadataNode(pn.Values[c], on.Type,
+                                AvaloniaXamlIlTargetTypeMetadataNode.ScopeType.Transitions);
+                        }
+                    }
+                }
+            }
+            return node;
+        }
+    }
+}

src/Markup/Avalonia.Markup.Xaml/XamlIl/CompilerExtensions/Transformers/AvaloniaXamlIlWellKnownTypes.cs

@@ -13,6 +13,7 @@ namespace Avalonia.Markup.Xaml.XamlIl.CompilerExtensions.Transformers
         public IXamlIlMethod AvaloniaObjectBindMethod { get; }
         public IXamlIlType IDisposable { get; }
         public XamlIlTypeWellKnownTypes XamlIlTypes { get; }
+        public IXamlIlType Transitions { get; }
         
         public AvaloniaXamlIlWellKnownTypes(XamlIlAstTransformationContext ctx)
         {
@@ -23,6 +24,7 @@ namespace Avalonia.Markup.Xaml.XamlIl.CompilerExtensions.Transformers
             AvaloniaProperty = ctx.Configuration.TypeSystem.GetType("Avalonia.AvaloniaProperty");
             IBinding = ctx.Configuration.TypeSystem.GetType("Avalonia.Data.IBinding");
             IDisposable = ctx.Configuration.TypeSystem.GetType("System.IDisposable");
+            Transitions = ctx.Configuration.TypeSystem.GetType("Avalonia.Animation.Transitions");
             AvaloniaObjectBindMethod = AvaloniaObjectExtensions.FindMethod("Bind", IDisposable, false, IAvaloniaObject,
                 AvaloniaProperty,
                 IBinding, ctx.Configuration.WellKnownTypes.Object);

tests/Avalonia.Markup.Xaml.UnitTests/XamlIlBugTests.cs

@@ -18,7 +18,21 @@ namespace Avalonia.Markup.Xaml.UnitTests
             parsed.DataContext = ctx;
             parsed.SetValue(Button.IsPressedProperty, true);
             Assert.True(ctx.IsPressed);
-            
+        }
+
+        [Fact]
+        public void Transitions_Should_Be_Properly_Parsed()
+        {
+            var parsed = (Grid)AvaloniaXamlLoader.Parse(@"
+<Grid xmlns='https://github.com/avaloniaui' >
+  <Grid.Transitions>
+    <DoubleTransition Property='Opacity'
+       Easing='CircularEaseIn'
+       Duration='0:0:0.5' />
+  </Grid.Transitions>
+</Grid>");
+            Assert.Equal(1, parsed.Transitions.Count);
+            Assert.Equal(Visual.OpacityProperty, parsed.Transitions[0].Property);
         }