From 90dc7ea95238ab696316b89fd00066d13f4a0541 Mon Sep 17 00:00:00 2001
From: Steven Kirk <grokys@gmail.com>
Date: Fri, 11 Sep 2020 17:33:15 +0200
Subject: [PATCH] Fix failing test but actual issue not fixed.

Fixed the failing test for #4654 but actual issue still remains. Needs more test.
---
 src/Avalonia.Controls/TabControl.cs | 55 ++++++-----------------------
 1 file changed, 11 insertions(+), 44 deletions(-)

diff --git a/src/Avalonia.Controls/TabControl.cs b/src/Avalonia.Controls/TabControl.cs
index f81e355a7d..f7e7126324 100644
--- a/src/Avalonia.Controls/TabControl.cs
+++ b/src/Avalonia.Controls/TabControl.cs
@@ -1,3 +1,4 @@
+using System.ComponentModel;
 using System.Linq;
 using Avalonia.Collections;
 using Avalonia.Controls.Generators;
@@ -66,7 +67,7 @@ namespace Avalonia.Controls
             SelectionModeProperty.OverrideDefaultValue<TabControl>(SelectionMode.AlwaysSelected);
             ItemsPanelProperty.OverrideDefaultValue<TabControl>(DefaultPanel);
             AffectsMeasure<TabControl>(TabStripPlacementProperty);
-            SelectedIndexProperty.Changed.AddClassHandler<TabControl>((x, e) => x.UpdateSelectedContent(e));
+            SelectedItemProperty.Changed.AddClassHandler<TabControl>((x, e) => x.UpdateSelectedContent());
         }
 
         /// <summary>
@@ -145,55 +146,21 @@ namespace Avalonia.Controls
         protected override void OnContainersMaterialized(ItemContainerEventArgs e)
         {
             base.OnContainersMaterialized(e);
-
-            if (SelectedContent != null || SelectedIndex == -1)
-            {
-                return;
-            }
-
-            var container = (TabItem)ItemContainerGenerator.ContainerFromIndex(SelectedIndex);
-
-            if (container == null)
-            {
-                return;
-            }
-
-            UpdateSelectedContent(container);
-        }
-
-        private void UpdateSelectedContent(AvaloniaPropertyChangedEventArgs e)
-        {
-            var index = (int)e.NewValue;
-
-            if (index == -1)
-            {
-                SelectedContentTemplate = null;
-
-                SelectedContent = null;
-
-                return;
-            }
-
-            var container = (TabItem)ItemContainerGenerator.ContainerFromIndex(index);
-
-            if (container == null)
-            {
-                return;
-            }
-
-            UpdateSelectedContent(container);
+            UpdateSelectedContent();
         }
 
-        private void UpdateSelectedContent(IContentControl item)
+        private void UpdateSelectedContent()
         {
-            if (SelectedContentTemplate != item.ContentTemplate)
+            if (SelectedIndex == -1)
             {
-                SelectedContentTemplate = item.ContentTemplate;
+                SelectedContent = SelectedContentTemplate = null;
             }
-
-            if (SelectedContent != item.Content)
+            else
             {
-                SelectedContent = item.Content;
+                var container = SelectedItem as IContentControl ??
+                    ItemContainerGenerator.ContainerFromIndex(SelectedIndex) as IContentControl;
+                SelectedContentTemplate = container?.ContentTemplate;
+                SelectedContent = container?.Content;
             }
         }