Browse Source

Fixed or suppressed various analyzer warnings

Updated desktop solution filter
pull/11366/head
Tom Edwards 3 years ago
parent
commit
91ff652c12
  1. 11
      Avalonia.Desktop.slnf
  2. 2
      src/Avalonia.Controls/Calendar/CalendarButton.cs
  3. 2
      src/Avalonia.Controls/Calendar/CalendarDayButton.cs
  4. 3
      src/Avalonia.Controls/GridSplitter.cs
  5. 2
      src/Avalonia.Controls/NativeMenuItemSeparator.cs
  6. 1
      src/Avalonia.Controls/Primitives/OverlayPopupHost.cs
  7. 2
      src/Avalonia.Controls/PullToRefresh/RefreshVisualizer.cs

11
Avalonia.Desktop.slnf

@ -39,14 +39,13 @@
"src\\Markup\\Avalonia.Markup.Xaml\\Avalonia.Markup.Xaml.csproj", "src\\Markup\\Avalonia.Markup.Xaml\\Avalonia.Markup.Xaml.csproj",
"src\\Markup\\Avalonia.Markup\\Avalonia.Markup.csproj", "src\\Markup\\Avalonia.Markup\\Avalonia.Markup.csproj",
"src\\Skia\\Avalonia.Skia\\Avalonia.Skia.csproj", "src\\Skia\\Avalonia.Skia\\Avalonia.Skia.csproj",
"src\\tools\\Avalonia.Generators\\Avalonia.Generators.csproj",
"src\\tools\\Avalonia.Generators\\Avalonia.Generators.csproj",
"src\\tools\\DevAnalyzers\\DevAnalyzers.csproj",
"src\\tools\\DevGenerators\\DevGenerators.csproj",
"src\\tools\\PublicAnalyzers\\Avalonia.Analyzers.csproj",
"src\\Windows\\Avalonia.Direct2D1\\Avalonia.Direct2D1.csproj", "src\\Windows\\Avalonia.Direct2D1\\Avalonia.Direct2D1.csproj",
"src\\Windows\\Avalonia.Win32.Interop\\Avalonia.Win32.Interop.csproj", "src\\Windows\\Avalonia.Win32.Interop\\Avalonia.Win32.Interop.csproj",
"src\\Windows\\Avalonia.Win32\\Avalonia.Win32.csproj", "src\\Windows\\Avalonia.Win32\\Avalonia.Win32.csproj",
"src\\tools\\Avalonia.Analyzers\\Avalonia.Analyzers.csproj",
"src\\tools\\Avalonia.Generators\\Avalonia.Generators.csproj",
"src\\tools\\DevAnalyzers\\DevAnalyzers.csproj",
"src\\tools\\DevGenerators\\DevGenerators.csproj",
"tests\\Avalonia.Base.UnitTests\\Avalonia.Base.UnitTests.csproj", "tests\\Avalonia.Base.UnitTests\\Avalonia.Base.UnitTests.csproj",
"tests\\Avalonia.Benchmarks\\Avalonia.Benchmarks.csproj", "tests\\Avalonia.Benchmarks\\Avalonia.Benchmarks.csproj",
"tests\\Avalonia.Controls.DataGrid.UnitTests\\Avalonia.Controls.DataGrid.UnitTests.csproj", "tests\\Avalonia.Controls.DataGrid.UnitTests\\Avalonia.Controls.DataGrid.UnitTests.csproj",
@ -66,4 +65,4 @@
"tests\\Avalonia.UnitTests\\Avalonia.UnitTests.csproj" "tests\\Avalonia.UnitTests\\Avalonia.UnitTests.csproj"
] ]
} }
} }

2
src/Avalonia.Controls/Calendar/CalendarButton.cs

@ -39,7 +39,7 @@ namespace Avalonia.Controls.Primitives
public CalendarButton() public CalendarButton()
: base() : base()
{ {
Content = DateTimeHelper.GetCurrentDateFormat().AbbreviatedMonthNames[0]; SetCurrentValue(ContentProperty, DateTimeHelper.GetCurrentDateFormat().AbbreviatedMonthNames[0]);
} }
/// <summary> /// <summary>

2
src/Avalonia.Controls/Calendar/CalendarDayButton.cs

@ -34,7 +34,7 @@ namespace Avalonia.Controls.Primitives
: base() : base()
{ {
//Focusable = false; //Focusable = false;
Content = DefaultContent.ToString(CultureInfo.CurrentCulture); SetCurrentValue(ContentProperty, DefaultContent.ToString(CultureInfo.CurrentCulture));
} }
/// <summary> /// <summary>

3
src/Avalonia.Controls/GridSplitter.cs

@ -695,7 +695,8 @@ namespace Avalonia.Controls
{ {
private readonly TranslateTransform _translation; private readonly TranslateTransform _translation;
private readonly Decorator _decorator; private readonly Decorator _decorator;
[System.Diagnostics.CodeAnalysis.SuppressMessage("AvaloniaProperty", "AVP1012", Justification = "Private object")]
public PreviewAdorner(Control? previewControl) public PreviewAdorner(Control? previewControl)
{ {
// Add a decorator to perform translations. // Add a decorator to perform translations.

2
src/Avalonia.Controls/NativeMenuItemSeparator.cs

@ -4,7 +4,7 @@
{ {
public NativeMenuItemSeparator() public NativeMenuItemSeparator()
{ {
Header = "-"; SetCurrentValue(HeaderProperty, "-");
} }
} }
} }

1
src/Avalonia.Controls/Primitives/OverlayPopupHost.cs

@ -29,6 +29,7 @@ namespace Avalonia.Controls.Primitives
} }
/// <inheritdoc /> /// <inheritdoc />
[System.Diagnostics.CodeAnalysis.SuppressMessage("AvaloniaProperty", "AVP1012", Justification = "Explicit set")]
public void SetChild(Control? control) public void SetChild(Control? control)
{ {
Content = control; Content = control;

2
src/Avalonia.Controls/PullToRefresh/RefreshVisualizer.cs

@ -193,7 +193,7 @@ namespace Avalonia.Controls
UpdateContent(); UpdateContent();
}; };
Content = _content; SetCurrentValue(ContentProperty, _content);
} }
else else
{ {

Loading…
Cancel
Save