Merge branch 'master' into avalonia-list-improvements

src/Avalonia.Dialogs/Avalonia.Dialogs.csproj

@@ -1,7 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
-    <IsPackable>false</IsPackable>
   </PropertyGroup>
 
   <ItemGroup>

src/Markup/Avalonia.Markup.Xaml/XamlIl/CompilerExtensions/Transformers/AvaloniaXamlIlTransformInstanceAttachedProperties.cs

@@ -164,6 +164,8 @@ namespace Avalonia.Markup.Xaml.XamlIl.CompilerExtensions.Transformers
                 public bool IsStatic => true;
                 public string Name { get; protected set; }
                 public IXamlIlType DeclaringType { get; }
+                public IXamlIlMethod MakeGenericMethod(IReadOnlyList<IXamlIlType> typeArguments) 
+                    => throw new System.NotSupportedException();
 
 
                 public bool Equals(IXamlIlMethod other) =>

src/Markup/Avalonia.Markup.Xaml/XamlIl/xamlil.github

@@ -1 +1 @@
-Subproject commit c2ec091f79fb4e1eea629bc823c9c24da7050022
+Subproject commit c7155c5f6c1a5153ee2d8cd78e5d1524dd6744cf

tests/Avalonia.Markup.Xaml.UnitTests/Xaml/BindingTests.cs

@@ -309,8 +309,12 @@ namespace Avalonia.Markup.Xaml.UnitTests.Xaml
             }
         }
 
-        [Fact]
-        public void Binding_To_TextBlock_Text_With_StringConverter_Works()
+        [Theory,
+            InlineData(@"Hello \{0\}"),
+            InlineData(@"'Hello {0}'"),
+            InlineData(@"Hello {0}")]
+        
+        public void Binding_To_TextBlock_Text_With_StringConverter_Works(string fmt)
         {
             using (UnitTestApplication.Start(TestServices.StyledWindow))
             {
@@ -318,8 +322,8 @@ namespace Avalonia.Markup.Xaml.UnitTests.Xaml
 <Window xmlns='https://github.com/avaloniaui'
         xmlns:x='http://schemas.microsoft.com/winfx/2006/xaml'
         xmlns:local='clr-namespace:Avalonia.Markup.Xaml.UnitTests.Xaml;assembly=Avalonia.Markup.Xaml.UnitTests'>
-    <TextBlock Name='textBlock' Text='{Binding Foo, StringFormat=Hello \{0\}}'/> 
-</Window>"; 
+    <TextBlock Name='textBlock' Text=""{Binding Foo, StringFormat=" + fmt + @"}""/> 
+</Window>";
                 var loader = new AvaloniaXamlLoader();
                 var window = (Window)loader.Load(xaml); 
                 var textBlock = window.FindControl<TextBlock>("textBlock"); 
@@ -331,8 +335,10 @@ namespace Avalonia.Markup.Xaml.UnitTests.Xaml
             }
         }
 
-        [Fact(Skip="Issue #2592")]
-        public void MultiBinding_To_TextBlock_Text_With_StringConverter_Works()
+        [Theory,
+            InlineData("{}{0} {1}!"),
+            InlineData(@"\{0\} \{1\}!")]
+        public void MultiBinding_To_TextBlock_Text_With_StringConverter_Works(string fmt)
         {
             using (UnitTestApplication.Start(TestServices.StyledWindow))
             {
@@ -342,7 +348,7 @@ namespace Avalonia.Markup.Xaml.UnitTests.Xaml
         xmlns:local='clr-namespace:Avalonia.Markup.Xaml.UnitTests.Xaml;assembly=Avalonia.Markup.Xaml.UnitTests'>
     <TextBlock Name='textBlock'>
         <TextBlock.Text>
-            <MultiBinding StringFormat='\{0\} \{1\}!'>
+            <MultiBinding StringFormat='" + fmt + @"'>
                 <Binding Path='Greeting1'/>
                 <Binding Path='Greeting2'/>
             </MultiBinding>