From ac9a8d74b87b451529c18a4f9832b97efcee018a Mon Sep 17 00:00:00 2001 From: brandonhood Date: Sat, 14 Oct 2017 18:23:36 -0400 Subject: [PATCH 01/12] Update Control.cs Updated the setter for Name to use IsNullOrWhiteSpace to both protect against null and do the emptiness check --- src/Avalonia.Controls/Control.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Avalonia.Controls/Control.cs b/src/Avalonia.Controls/Control.cs index 14beb2eab7..89c4f9279a 100644 --- a/src/Avalonia.Controls/Control.cs +++ b/src/Avalonia.Controls/Control.cs @@ -175,9 +175,9 @@ namespace Avalonia.Controls set { - if (value.Trim() == string.Empty) + if (String.IsNullOrWhiteSpace(value)) { - throw new InvalidOperationException("Cannot set Name to empty string."); + throw new InvalidOperationException("Cannot set Name to null or empty string."); } if (_styled) From 4ecbea9d5e12324663799fa9eb3bbd60a54cbcd6 Mon Sep 17 00:00:00 2001 From: Jeremy Koritzinsky Date: Sun, 15 Oct 2017 14:54:23 -0500 Subject: [PATCH 02/12] Remove unneeded markup extensions. --- Avalonia.sln | 3 ++- .../Avalonia.Markup.Xaml.csproj | 2 -- .../MarkupExtensions/StaticExtension.cs | 25 ------------------- .../MarkupExtensions/TypeExtension.cs | 23 ----------------- 4 files changed, 2 insertions(+), 51 deletions(-) delete mode 100644 src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/StaticExtension.cs delete mode 100644 src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/TypeExtension.cs diff --git a/Avalonia.sln b/Avalonia.sln index 7f516667ee..c6509817ce 100644 --- a/Avalonia.sln +++ b/Avalonia.sln @@ -1,7 +1,7 @@  Microsoft Visual Studio Solution File, Format Version 12.00 # Visual Studio 15 -VisualStudioVersion = 15.0.26730.3 +VisualStudioVersion = 15.0.26730.10 MinimumVisualStudioVersion = 10.0.40219.1 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Avalonia.Base", "src\Avalonia.Base\Avalonia.Base.csproj", "{B09B78D8-9B26-48B0-9149-D64A2F120F3F}" EndProject @@ -204,6 +204,7 @@ Global tests\Avalonia.RenderTests\Avalonia.RenderTests.projitems*{48840edd-24bf-495d-911e-2eb12ae75d3b}*SharedItemsImports = 13 src\Shared\PlatformSupport\PlatformSupport.projitems*{4a1abb09-9047-4bd5-a4ad-a055e52c5ee0}*SharedItemsImports = 4 src\Shared\PlatformSupport\PlatformSupport.projitems*{7863ea94-f0fb-4386-bf8c-e5bfa761560a}*SharedItemsImports = 4 + src\Shared\PlatformSupport\PlatformSupport.projitems*{7b92af71-6287-4693-9dcb-bd5b6e927e23}*SharedItemsImports = 4 src\Shared\RenderHelpers\RenderHelpers.projitems*{7d2d3083-71dd-4cc9-8907-39a0d86fb322}*SharedItemsImports = 4 src\Windows\Avalonia.Win32\Avalonia.Win32.Shared.projitems*{811a76cf-1cf6-440f-963b-bbe31bd72a82}*SharedItemsImports = 4 src\Windows\Avalonia.Win32\Avalonia.Win32.Shared.projitems*{9defc6b7-845b-4d8f-afc0-d32bf0032b8c}*SharedItemsImports = 13 diff --git a/src/Markup/Avalonia.Markup.Xaml/Avalonia.Markup.Xaml.csproj b/src/Markup/Avalonia.Markup.Xaml/Avalonia.Markup.Xaml.csproj index de015fc947..e07c22d750 100644 --- a/src/Markup/Avalonia.Markup.Xaml/Avalonia.Markup.Xaml.csproj +++ b/src/Markup/Avalonia.Markup.Xaml/Avalonia.Markup.Xaml.csproj @@ -77,9 +77,7 @@ - - diff --git a/src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/StaticExtension.cs b/src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/StaticExtension.cs deleted file mode 100644 index c084e362c2..0000000000 --- a/src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/StaticExtension.cs +++ /dev/null @@ -1,25 +0,0 @@ -// Copyright (c) The Avalonia Project. All rights reserved. -// Licensed under the MIT license. See licence.md file in the project root for full license information. - -using System; - -namespace Avalonia.Markup.Xaml.MarkupExtensions -{ - public class StaticExtension : Portable.Xaml.Markup.StaticExtension - { - public StaticExtension() - { - } - - public StaticExtension(string member) - : base(member) - { - } - - public override object ProvideValue(IServiceProvider serviceProvider) - { - return base.ProvideValue(serviceProvider); - } - } - -} \ No newline at end of file diff --git a/src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/TypeExtension.cs b/src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/TypeExtension.cs deleted file mode 100644 index 062096e746..0000000000 --- a/src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/TypeExtension.cs +++ /dev/null @@ -1,23 +0,0 @@ -// Copyright (c) The Avalonia Project. All rights reserved. -// Licensed under the MIT license. See licence.md file in the project root for full license information. - -using System; - -namespace Avalonia.Markup.Xaml.MarkupExtensions -{ - public class TypeExtension : Portable.Xaml.Markup.TypeExtension - { - public TypeExtension() - { - } - - public TypeExtension(string typeName) : base(typeName) - { - } - - public override object ProvideValue(IServiceProvider serviceProvider) - { - return base.ProvideValue(serviceProvider); - } - } -} \ No newline at end of file From b0a1f3f3dff53d82efa4c3b763a69fed7aa04989 Mon Sep 17 00:00:00 2001 From: Jeremy Koritzinsky Date: Sun, 15 Oct 2017 15:42:19 -0500 Subject: [PATCH 03/12] Update tests to use `x:Static`. --- tests/Avalonia.Markup.Xaml.UnitTests/Xaml/BasicTests.cs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/BasicTests.cs b/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/BasicTests.cs index ce370790c3..8c7dad1bce 100644 --- a/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/BasicTests.cs +++ b/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/BasicTests.cs @@ -609,8 +609,8 @@ namespace Avalonia.Markup.Xaml.UnitTests.Xaml public void Multi_Xaml_Binding_Is_Parsed() { var xaml = -@" +@" "; @@ -818,10 +818,11 @@ do we need it?")] { var xaml = @" - + "; From 745517f68e601c2941b88fe10a249c9cbd5dd1e9 Mon Sep 17 00:00:00 2001 From: Jeremy Koritzinsky Date: Sun, 15 Oct 2017 15:47:48 -0500 Subject: [PATCH 04/12] Updated usage of Static and Type to be x:Static and x:Type. --- samples/ControlCatalog/SideBar.xaml | 6 +++--- samples/RenderTest/SideBar.xaml | 6 +++--- src/Avalonia.Themes.Default/TabControl.xaml | 6 +++--- src/Avalonia.Themes.Default/TextBox.xaml | 8 ++++---- .../Xaml/DataTemplateTests.cs | 9 +++++---- 5 files changed, 18 insertions(+), 17 deletions(-) diff --git a/samples/ControlCatalog/SideBar.xaml b/samples/ControlCatalog/SideBar.xaml index c03bc432d4..7fcd828ba3 100644 --- a/samples/ControlCatalog/SideBar.xaml +++ b/samples/ControlCatalog/SideBar.xaml @@ -1,11 +1,11 @@ - +