Browse Source

Rename MenuBase Opened/Closed events removing type prefix

pull/11549/head
robloo 3 years ago
parent
commit
9eeebbc99d
  1. 4
      src/Avalonia.Base/Input/AccessKeyHandler.cs
  2. 2
      src/Avalonia.Base/Input/IMainMenu.cs
  3. 4
      src/Avalonia.Controls/ContextMenu.cs
  4. 4
      src/Avalonia.Controls/Menu.cs
  5. 28
      src/Avalonia.Controls/MenuBase.cs
  6. 4
      src/Avalonia.Controls/Platform/DefaultMenuInteractionHandler.cs
  7. 8
      tests/Avalonia.Controls.UnitTests/ContextMenuTests.cs

4
src/Avalonia.Base/Input/AccessKeyHandler.cs

@ -65,14 +65,14 @@ namespace Avalonia.Input
{
if (_mainMenu != null)
{
_mainMenu.MenuClosed -= MainMenuClosed;
_mainMenu.Closed -= MainMenuClosed;
}
_mainMenu = value;
if (_mainMenu != null)
{
_mainMenu.MenuClosed += MainMenuClosed;
_mainMenu.Closed += MainMenuClosed;
}
}
}

2
src/Avalonia.Base/Input/IMainMenu.cs

@ -26,6 +26,6 @@ namespace Avalonia.Input
/// <summary>
/// Occurs when the main menu closes.
/// </summary>
event EventHandler<RoutedEventArgs>? MenuClosed;
event EventHandler<RoutedEventArgs>? Closed;
}
}

4
src/Avalonia.Controls/ContextMenu.cs

@ -353,7 +353,7 @@ namespace Avalonia.Controls
RaiseEvent(new RoutedEventArgs
{
RoutedEvent = MenuOpenedEvent,
RoutedEvent = OpenedEvent,
Source = this,
});
}
@ -394,7 +394,7 @@ namespace Avalonia.Controls
RaiseEvent(new RoutedEventArgs
{
RoutedEvent = MenuClosedEvent,
RoutedEvent = ClosedEvent,
Source = this,
});

4
src/Avalonia.Controls/Menu.cs

@ -60,7 +60,7 @@ namespace Avalonia.Controls
RaiseEvent(new RoutedEventArgs
{
RoutedEvent = MenuClosedEvent,
RoutedEvent = ClosedEvent,
Source = this,
});
}
@ -77,7 +77,7 @@ namespace Avalonia.Controls
RaiseEvent(new RoutedEventArgs
{
RoutedEvent = MenuOpenedEvent,
RoutedEvent = OpenedEvent,
Source = this,
});
}

28
src/Avalonia.Controls/MenuBase.cs

@ -25,16 +25,16 @@ namespace Avalonia.Controls
o => o.IsOpen);
/// <summary>
/// Defines the <see cref="MenuOpened"/> event.
/// Defines the <see cref="Opened"/> event.
/// </summary>
public static readonly RoutedEvent<RoutedEventArgs> MenuOpenedEvent =
RoutedEvent.Register<MenuBase, RoutedEventArgs>(nameof(MenuOpened), RoutingStrategies.Bubble);
public static readonly RoutedEvent<RoutedEventArgs> OpenedEvent =
RoutedEvent.Register<MenuBase, RoutedEventArgs>(nameof(Opened), RoutingStrategies.Bubble);
/// <summary>
/// Defines the <see cref="MenuClosed"/> event.
/// Defines the <see cref="Closed"/> event.
/// </summary>
public static readonly RoutedEvent<RoutedEventArgs> MenuClosedEvent =
RoutedEvent.Register<MenuBase, RoutedEventArgs>(nameof(MenuClosed), RoutingStrategies.Bubble);
public static readonly RoutedEvent<RoutedEventArgs> ClosedEvent =
RoutedEvent.Register<MenuBase, RoutedEventArgs>(nameof(Closed), RoutingStrategies.Bubble);
private bool _isOpen;
@ -68,8 +68,8 @@ namespace Avalonia.Controls
/// </summary>
public bool IsOpen
{
get { return _isOpen; }
protected set { SetAndRaise(IsOpenProperty, ref _isOpen, value); }
get => _isOpen;
protected set => SetAndRaise(IsOpenProperty, ref _isOpen, value);
}
/// <inheritdoc/>
@ -105,19 +105,19 @@ namespace Avalonia.Controls
/// <summary>
/// Occurs when a <see cref="Menu"/> is opened.
/// </summary>
public event EventHandler<RoutedEventArgs>? MenuOpened
public event EventHandler<RoutedEventArgs>? Opened
{
add { AddHandler(MenuOpenedEvent, value); }
remove { RemoveHandler(MenuOpenedEvent, value); }
add => AddHandler(OpenedEvent, value);
remove => RemoveHandler(OpenedEvent, value);
}
/// <summary>
/// Occurs when a <see cref="Menu"/> is closed.
/// </summary>
public event EventHandler<RoutedEventArgs>? MenuClosed
public event EventHandler<RoutedEventArgs>? Closed
{
add { AddHandler(MenuClosedEvent, value); }
remove { RemoveHandler(MenuClosedEvent, value); }
add => AddHandler(ClosedEvent, value);
remove => RemoveHandler(ClosedEvent, value);
}
/// <summary>

4
src/Avalonia.Controls/Platform/DefaultMenuInteractionHandler.cs

@ -290,7 +290,7 @@ namespace Avalonia.Controls.Platform
Menu.PointerPressed += PointerPressed;
Menu.PointerReleased += PointerReleased;
Menu.AddHandler(AccessKeyHandler.AccessKeyPressedEvent, AccessKeyPressed);
Menu.AddHandler(MenuBase.MenuOpenedEvent, MenuOpened);
Menu.AddHandler(MenuBase.OpenedEvent, MenuOpened);
Menu.AddHandler(MenuItem.PointerEnteredItemEvent, PointerEntered);
Menu.AddHandler(MenuItem.PointerExitedItemEvent, PointerExited);
Menu.AddHandler(InputElement.PointerMovedEvent, PointerMoved);
@ -326,7 +326,7 @@ namespace Avalonia.Controls.Platform
Menu.PointerPressed -= PointerPressed;
Menu.PointerReleased -= PointerReleased;
Menu.RemoveHandler(AccessKeyHandler.AccessKeyPressedEvent, AccessKeyPressed);
Menu.RemoveHandler(MenuBase.MenuOpenedEvent, MenuOpened);
Menu.RemoveHandler(MenuBase.OpenedEvent, MenuOpened);
Menu.RemoveHandler(MenuItem.PointerEnteredItemEvent, PointerEntered);
Menu.RemoveHandler(MenuItem.PointerExitedItemEvent, PointerExited);
Menu.RemoveHandler(InputElement.PointerMovedEvent, PointerMoved);

8
tests/Avalonia.Controls.UnitTests/ContextMenuTests.cs

@ -35,7 +35,7 @@ namespace Avalonia.Controls.UnitTests
int openedCount = 0;
sut.MenuOpened += (sender, args) =>
sut.Opened += (sender, args) =>
{
openedCount++;
};
@ -138,7 +138,7 @@ namespace Avalonia.Controls.UnitTests
int openedCount = 0;
sut.MenuOpened += (sender, args) =>
sut.Opened += (sender, args) =>
{
openedCount++;
};
@ -167,7 +167,7 @@ namespace Avalonia.Controls.UnitTests
bool opened = false;
sut.MenuOpened += (sender, args) =>
sut.Opened += (sender, args) =>
{
opened = true;
};
@ -220,7 +220,7 @@ namespace Avalonia.Controls.UnitTests
int closedCount = 0;
sut.MenuClosed += (sender, args) =>
sut.Closed += (sender, args) =>
{
closedCount++;
};

Loading…
Cancel
Save