Browse Source

Merge pull request #5830 from Gillibald/fixes/TextBoxWrapWithoutAcceptsReturn

Fixes TextBox text wrap without accepts return
release/0.10.3
Benedikt Stebner 5 years ago
committed by Dan Walmsley
parent
commit
a37ccee9e0
  1. 12
      src/Avalonia.Controls/TextBox.cs
  2. 2
      tests/Avalonia.Controls.UnitTests/TextBoxTests.cs

12
src/Avalonia.Controls/TextBox.cs

@ -175,16 +175,12 @@ namespace Avalonia.Controls
this.GetObservable(TextWrappingProperty),
(acceptsReturn, wrapping) =>
{
if (acceptsReturn)
if (wrapping != TextWrapping.NoWrap)
{
return wrapping != TextWrapping.Wrap ?
ScrollBarVisibility.Auto :
ScrollBarVisibility.Disabled;
}
else
{
return ScrollBarVisibility.Hidden;
return ScrollBarVisibility.Disabled;
}
return acceptsReturn ? ScrollBarVisibility.Auto : ScrollBarVisibility.Hidden;
});
this.Bind(
ScrollViewer.HorizontalScrollBarVisibilityProperty,

2
tests/Avalonia.Controls.UnitTests/TextBoxTests.cs

@ -378,7 +378,7 @@ namespace Avalonia.Controls.UnitTests
[Theory]
[InlineData(new object[] { false, TextWrapping.NoWrap, ScrollBarVisibility.Hidden })]
[InlineData(new object[] { false, TextWrapping.Wrap, ScrollBarVisibility.Hidden })]
[InlineData(new object[] { false, TextWrapping.Wrap, ScrollBarVisibility.Disabled })]
[InlineData(new object[] { true, TextWrapping.NoWrap, ScrollBarVisibility.Auto })]
[InlineData(new object[] { true, TextWrapping.Wrap, ScrollBarVisibility.Disabled })]
public void Has_Correct_Horizontal_ScrollBar_Visibility(

Loading…
Cancel
Save