Browse Source

Revert "Updated ReactiveUI to version 10.1.1"

pull/3044/head
danwalmsley 6 years ago
committed by GitHub
parent
commit
a487b38c33
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      build/ReactiveUI.props
  2. 2
      build/Rx.props
  3. 2
      build/System.Memory.props
  4. 7
      samples/BindingDemo/ViewModels/MainWindowViewModel.cs
  5. 5
      samples/RenderDemo/ViewModels/MainWindowViewModel.cs
  6. 27
      samples/VirtualizationDemo/ViewModels/MainWindowViewModel.cs
  7. 2
      src/Avalonia.ReactiveUI/AvaloniaActivationForViewFetcher.cs
  8. 4
      src/Avalonia.ReactiveUI/RoutedViewHost.cs
  9. 8
      tests/Avalonia.ReactiveUI.UnitTests/AvaloniaActivationForViewFetcherTest.cs

2
build/ReactiveUI.props

@ -1,5 +1,5 @@
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> <Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<ItemGroup> <ItemGroup>
<PackageReference Include="ReactiveUI" Version="10.1.1" /> <PackageReference Include="reactiveui" Version="9.0.1" />
</ItemGroup> </ItemGroup>
</Project> </Project>

2
build/Rx.props

@ -1,5 +1,5 @@
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> <Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<ItemGroup> <ItemGroup>
<PackageReference Include="System.Reactive" Version="4.1.6" /> <PackageReference Include="System.Reactive" Version="4.0.0" />
</ItemGroup> </ItemGroup>
</Project> </Project>

2
build/System.Memory.props

@ -1,5 +1,5 @@
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> <Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<ItemGroup> <ItemGroup>
<PackageReference Include="System.Memory" Version="4.5.3" /> <PackageReference Include="System.Memory" Version="4.5.1" />
</ItemGroup> </ItemGroup>
</Project> </Project>

7
samples/BindingDemo/ViewModels/MainWindowViewModel.cs

@ -1,11 +1,10 @@
using System; using System;
using System.Collections.ObjectModel; using System.Collections.ObjectModel;
using System.Linq; using System.Linq;
using System.Reactive; using ReactiveUI;
using System.Reactive.Linq; using System.Reactive.Linq;
using System.Threading.Tasks; using System.Threading.Tasks;
using System.Threading; using System.Threading;
using ReactiveUI;
namespace BindingDemo.ViewModels namespace BindingDemo.ViewModels
{ {
@ -57,7 +56,7 @@ namespace BindingDemo.ViewModels
public ObservableCollection<TestItem> Items { get; } public ObservableCollection<TestItem> Items { get; }
public ObservableCollection<TestItem> SelectedItems { get; } public ObservableCollection<TestItem> SelectedItems { get; }
public ReactiveCommand<Unit, Unit> ShuffleItems { get; } public ReactiveCommand ShuffleItems { get; }
public string BooleanString public string BooleanString
{ {
@ -90,7 +89,7 @@ namespace BindingDemo.ViewModels
} }
public IObservable<string> CurrentTimeObservable { get; } public IObservable<string> CurrentTimeObservable { get; }
public ReactiveCommand<object, Unit> StringValueCommand { get; } public ReactiveCommand StringValueCommand { get; }
public DataAnnotationsErrorViewModel DataAnnotationsValidation { get; } = new DataAnnotationsErrorViewModel(); public DataAnnotationsErrorViewModel DataAnnotationsValidation { get; } = new DataAnnotationsErrorViewModel();
public ExceptionErrorViewModel ExceptionDataValidation { get; } = new ExceptionErrorViewModel(); public ExceptionErrorViewModel ExceptionDataValidation { get; } = new ExceptionErrorViewModel();

5
samples/RenderDemo/ViewModels/MainWindowViewModel.cs

@ -1,5 +1,4 @@
using System; using System;
using System.Reactive;
using ReactiveUI; using ReactiveUI;
namespace RenderDemo.ViewModels namespace RenderDemo.ViewModels
@ -27,7 +26,7 @@ namespace RenderDemo.ViewModels
set { this.RaiseAndSetIfChanged(ref drawFps, value); } set { this.RaiseAndSetIfChanged(ref drawFps, value); }
} }
public ReactiveCommand<Unit, bool> ToggleDrawDirtyRects { get; } public ReactiveCommand ToggleDrawDirtyRects { get; }
public ReactiveCommand<Unit, bool> ToggleDrawFps { get; } public ReactiveCommand ToggleDrawFps { get; }
} }
} }

27
samples/VirtualizationDemo/ViewModels/MainWindowViewModel.cs

@ -4,10 +4,10 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq; using System.Linq;
using System.Reactive;
using Avalonia.Collections; using Avalonia.Collections;
using Avalonia.Controls; using Avalonia.Controls;
using Avalonia.Controls.Primitives; using Avalonia.Controls.Primitives;
using ReactiveUI.Legacy;
using ReactiveUI; using ReactiveUI;
using Avalonia.Layout; using Avalonia.Layout;
@ -18,7 +18,7 @@ namespace VirtualizationDemo.ViewModels
private int _itemCount = 200; private int _itemCount = 200;
private string _newItemString = "New Item"; private string _newItemString = "New Item";
private int _newItemIndex; private int _newItemIndex;
private AvaloniaList<ItemViewModel> _items; private IReactiveList<ItemViewModel> _items;
private string _prefix = "Item"; private string _prefix = "Item";
private ScrollBarVisibility _horizontalScrollBarVisibility = ScrollBarVisibility.Auto; private ScrollBarVisibility _horizontalScrollBarVisibility = ScrollBarVisibility.Auto;
private ScrollBarVisibility _verticalScrollBarVisibility = ScrollBarVisibility.Auto; private ScrollBarVisibility _verticalScrollBarVisibility = ScrollBarVisibility.Auto;
@ -28,12 +28,11 @@ namespace VirtualizationDemo.ViewModels
public MainWindowViewModel() public MainWindowViewModel()
{ {
this.WhenAnyValue(x => x.ItemCount).Subscribe(ResizeItems); this.WhenAnyValue(x => x.ItemCount).Subscribe(ResizeItems);
RecreateCommand = ReactiveCommand.Create(() => Recreate());
RecreateCommand = ReactiveCommand.Create(Recreate); AddItemCommand = ReactiveCommand.Create(() => AddItem());
AddItemCommand = ReactiveCommand.Create(AddItem); RemoveItemCommand = ReactiveCommand.Create(() => Remove());
RemoveItemCommand = ReactiveCommand.Create(Remove);
SelectFirstCommand = ReactiveCommand.Create(() => SelectItem(0)); SelectFirstCommand = ReactiveCommand.Create(() => SelectItem(0));
@ -55,7 +54,7 @@ namespace VirtualizationDemo.ViewModels
public AvaloniaList<ItemViewModel> SelectedItems { get; } public AvaloniaList<ItemViewModel> SelectedItems { get; }
= new AvaloniaList<ItemViewModel>(); = new AvaloniaList<ItemViewModel>();
public AvaloniaList<ItemViewModel> Items public IReactiveList<ItemViewModel> Items
{ {
get { return _items; } get { return _items; }
private set { this.RaiseAndSetIfChanged(ref _items, value); } private set { this.RaiseAndSetIfChanged(ref _items, value); }
@ -94,11 +93,11 @@ namespace VirtualizationDemo.ViewModels
public IEnumerable<ItemVirtualizationMode> VirtualizationModes => public IEnumerable<ItemVirtualizationMode> VirtualizationModes =>
Enum.GetValues(typeof(ItemVirtualizationMode)).Cast<ItemVirtualizationMode>(); Enum.GetValues(typeof(ItemVirtualizationMode)).Cast<ItemVirtualizationMode>();
public ReactiveCommand<Unit, Unit> AddItemCommand { get; private set; } public ReactiveCommand AddItemCommand { get; private set; }
public ReactiveCommand<Unit, Unit> RecreateCommand { get; private set; } public ReactiveCommand RecreateCommand { get; private set; }
public ReactiveCommand<Unit, Unit> RemoveItemCommand { get; private set; } public ReactiveCommand RemoveItemCommand { get; private set; }
public ReactiveCommand<Unit, Unit> SelectFirstCommand { get; private set; } public ReactiveCommand SelectFirstCommand { get; private set; }
public ReactiveCommand<Unit, Unit> SelectLastCommand { get; private set; } public ReactiveCommand SelectLastCommand { get; private set; }
public void RandomizeSize() public void RandomizeSize()
{ {
@ -124,7 +123,7 @@ namespace VirtualizationDemo.ViewModels
{ {
var items = Enumerable.Range(0, count) var items = Enumerable.Range(0, count)
.Select(x => new ItemViewModel(x)); .Select(x => new ItemViewModel(x));
Items = new AvaloniaList<ItemViewModel>(items); Items = new ReactiveList<ItemViewModel>(items);
} }
else if (count > Items.Count) else if (count > Items.Count)
{ {
@ -163,7 +162,7 @@ namespace VirtualizationDemo.ViewModels
_prefix = _prefix == "Item" ? "Recreated" : "Item"; _prefix = _prefix == "Item" ? "Recreated" : "Item";
var items = Enumerable.Range(0, _itemCount) var items = Enumerable.Range(0, _itemCount)
.Select(x => new ItemViewModel(x, _prefix)); .Select(x => new ItemViewModel(x, _prefix));
Items = new AvaloniaList<ItemViewModel>(items); Items = new ReactiveList<ItemViewModel>(items);
} }
private void SelectItem(int index) private void SelectItem(int index)

2
src/Avalonia.ReactiveUI/AvaloniaActivationForViewFetcher.cs

@ -27,7 +27,7 @@ namespace Avalonia.ReactiveUI
/// <summary> /// <summary>
/// Returns activation observable for activatable Avalonia view. /// Returns activation observable for activatable Avalonia view.
/// </summary> /// </summary>
public IObservable<bool> GetActivationForView(IActivatableView view) public IObservable<bool> GetActivationForView(IActivatable view)
{ {
if (!(view is IVisual visual)) return Observable.Return(false); if (!(view is IVisual visual)) return Observable.Return(false);
if (view is WindowBase window) return GetActivationForWindowBase(window); if (view is WindowBase window) return GetActivationForWindowBase(window);

4
src/Avalonia.ReactiveUI/RoutedViewHost.cs

@ -53,7 +53,7 @@ namespace Avalonia.ReactiveUI
/// ReactiveUI routing documentation website</see> for more info. /// ReactiveUI routing documentation website</see> for more info.
/// </para> /// </para>
/// </remarks> /// </remarks>
public class RoutedViewHost : TransitioningContentControl, IActivatableView, IEnableLogger public class RoutedViewHost : TransitioningContentControl, IActivatable, IEnableLogger
{ {
/// <summary> /// <summary>
/// <see cref="AvaloniaProperty"/> for the <see cref="Router"/> property. /// <see cref="AvaloniaProperty"/> for the <see cref="Router"/> property.
@ -118,4 +118,4 @@ namespace Avalonia.ReactiveUI
Content = viewInstance; Content = viewInstance;
} }
} }
} }

8
tests/Avalonia.ReactiveUI.UnitTests/AvaloniaActivationForViewFetcherTest.cs

@ -20,9 +20,9 @@ namespace Avalonia.ReactiveUI.UnitTests
{ {
public class AvaloniaActivationForViewFetcherTest public class AvaloniaActivationForViewFetcherTest
{ {
public class TestUserControl : UserControl, IActivatableView { } public class TestUserControl : UserControl, IActivatable { }
public class TestUserControlWithWhenActivated : UserControl, IActivatableView public class TestUserControlWithWhenActivated : UserControl, IActivatable
{ {
public bool Active { get; private set; } public bool Active { get; private set; }
@ -38,7 +38,7 @@ namespace Avalonia.ReactiveUI.UnitTests
} }
} }
public class TestWindowWithWhenActivated : Window, IActivatableView public class TestWindowWithWhenActivated : Window, IActivatable
{ {
public bool Active { get; private set; } public bool Active { get; private set; }
@ -54,7 +54,7 @@ namespace Avalonia.ReactiveUI.UnitTests
} }
} }
public class ActivatableViewModel : IActivatableViewModel public class ActivatableViewModel : ISupportsActivation
{ {
public ViewModelActivator Activator { get; } public ViewModelActivator Activator { get; }

Loading…
Cancel
Save