From e4cf7a6bf75c087769e738bb14047072a2c28a53 Mon Sep 17 00:00:00 2001 From: luthfiampas Date: Thu, 4 Feb 2021 01:52:45 +0700 Subject: [PATCH 01/19] add auto-select functionality to ComboBox control --- src/Avalonia.Controls/ComboBox.cs | 72 +++++++++++++++++++ .../ComboBoxTests.cs | 37 ++++++++++ 2 files changed, 109 insertions(+) diff --git a/src/Avalonia.Controls/ComboBox.cs b/src/Avalonia.Controls/ComboBox.cs index 7f2acb58fe..95baf8146d 100644 --- a/src/Avalonia.Controls/ComboBox.cs +++ b/src/Avalonia.Controls/ComboBox.cs @@ -10,6 +10,7 @@ using Avalonia.Interactivity; using Avalonia.Layout; using Avalonia.LogicalTree; using Avalonia.Media; +using Avalonia.Threading; using Avalonia.VisualTree; namespace Avalonia.Controls @@ -76,6 +77,14 @@ namespace Avalonia.Controls public static readonly StyledProperty VerticalContentAlignmentProperty = ContentControl.VerticalContentAlignmentProperty.AddOwner(); + /// + /// Defines the property. + /// + public static readonly StyledProperty IsAutoSelectEnabledProperty = + AvaloniaProperty.Register(nameof(IsAutoSelectEnabled)); + + private string _autoSelectTerm = string.Empty; + private DispatcherTimer _autoSelectTimer; private bool _isDropDownOpen; private Popup _popup; private object _selectionBoxItem; @@ -164,6 +173,17 @@ namespace Avalonia.Controls set { SetValue(VerticalContentAlignmentProperty, value); } } + /// + /// Gets or sets value indicating whether auto-select is currently enabled. + /// If true, the control will try to find then select matched + /// based on current keyboard inputs. + /// + public bool IsAutoSelectEnabled + { + get { return GetValue(IsAutoSelectEnabledProperty); } + set { SetValue(IsAutoSelectEnabledProperty, value); } + } + /// protected override IItemContainerGenerator CreateItemContainerGenerator() { @@ -229,6 +249,32 @@ namespace Avalonia.Controls } } + /// + protected override void OnTextInput(TextInputEventArgs e) + { + if (!IsAutoSelectEnabled || e.Handled) + return; + + StopAutoSelectTimer(); + + _autoSelectTerm += e.Text; + + bool match(ItemContainerInfo info) => + info.ContainerControl is IContentControl control && + control.Content?.ToString()?.StartsWith(_autoSelectTerm, StringComparison.OrdinalIgnoreCase) == true; + + var info = ItemContainerGenerator.Containers.FirstOrDefault(match); + + if (info != null) + { + SelectedIndex = info.Index; + } + + StartAutoSelectTimer(); + + e.Handled = true; + } + /// protected override void OnPointerWheelChanged(PointerWheelEventArgs e) { @@ -426,5 +472,31 @@ namespace Avalonia.Controls SelectedIndex = prev; } + + private void StartAutoSelectTimer() + { + _autoSelectTimer = new DispatcherTimer { Interval = TimeSpan.FromSeconds(1) }; + _autoSelectTimer.Tick += AutoSelectTimer_Tick; + _autoSelectTimer.Start(); + } + + private void StopAutoSelectTimer() + { + if (_autoSelectTimer == null) + { + return; + } + + _autoSelectTimer.Stop(); + _autoSelectTimer.Tick -= AutoSelectTimer_Tick; + + _autoSelectTimer = null; + } + + private void AutoSelectTimer_Tick(object sender, EventArgs e) + { + _autoSelectTerm = string.Empty; + StopAutoSelectTimer(); + } } } diff --git a/tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs b/tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs index c8a30a42e9..218832d988 100644 --- a/tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs +++ b/tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs @@ -1,7 +1,9 @@ +using System.Linq; using Avalonia.Controls.Presenters; using Avalonia.Controls.Primitives; using Avalonia.Controls.Shapes; using Avalonia.Controls.Templates; +using Avalonia.Input; using Avalonia.LogicalTree; using Avalonia.Media; using Avalonia.UnitTests; @@ -137,5 +139,40 @@ namespace Avalonia.Controls.UnitTests Assert.True(other.IsFocused); } } + + [Theory] + [InlineData(-1, 2, "c", "A item", "B item", "C item")] + [InlineData(0, 1, "b", "A item", "B item", "C item")] + [InlineData(2, 2, "x", "A item", "B item", "C item")] + public void AutoSelect_Should_Have_Expected_SelectedIndex( + int initialSelectedIndex, + int expectedSelectedIndex, + string searchTerm, + params string[] items) + { + using (UnitTestApplication.Start(TestServices.MockThreadingInterface)) + { + var target = new ComboBox + { + IsAutoSelectEnabled = true, + Template = GetTemplate(), + Items = items.Select(x => new ComboBoxItem { Content = x }) + }; + + target.ApplyTemplate(); + target.Presenter.ApplyTemplate(); + target.SelectedIndex = initialSelectedIndex; + + var args = new TextInputEventArgs + { + Text = searchTerm, + RoutedEvent = InputElement.TextInputEvent + }; + + target.RaiseEvent(args); + + Assert.Equal(expectedSelectedIndex, target.SelectedIndex); + } + } } } From 079d1d64360a2b0689628ce9cc0967f1a6c93008 Mon Sep 17 00:00:00 2001 From: Steven Kirk Date: Tue, 16 Feb 2021 16:47:05 +0100 Subject: [PATCH 02/19] Turn off light dismiss for non-toplevel menus. #5295 enabled the light dismiss overlay for popups, which in turn broke submenu interactions (#5475). The fix seems to be simple: turn off light dismiss for non-toplevel menus. These menus will be in popups so this means their behavior will be reverted to that of before #5295. Fixes #5475 --- src/Avalonia.Themes.Fluent/Controls/MenuItem.xaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Avalonia.Themes.Fluent/Controls/MenuItem.xaml b/src/Avalonia.Themes.Fluent/Controls/MenuItem.xaml index 4950043a99..4c098afe16 100644 --- a/src/Avalonia.Themes.Fluent/Controls/MenuItem.xaml +++ b/src/Avalonia.Themes.Fluent/Controls/MenuItem.xaml @@ -112,9 +112,8 @@ Date: Tue, 23 Feb 2021 16:34:34 +0100 Subject: [PATCH 03/19] Turn off light dismiss for non-toplevel menus. For default theme. --- src/Avalonia.Themes.Default/MenuItem.xaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Avalonia.Themes.Default/MenuItem.xaml b/src/Avalonia.Themes.Default/MenuItem.xaml index 9ce19cff6e..b58d2ff808 100644 --- a/src/Avalonia.Themes.Default/MenuItem.xaml +++ b/src/Avalonia.Themes.Default/MenuItem.xaml @@ -59,7 +59,7 @@ Grid.Column="4"/> Date: Tue, 23 Feb 2021 21:21:44 +0100 Subject: [PATCH 04/19] Removed unneeded binding. Co-authored-by: Max Katz --- src/Avalonia.Themes.Default/MenuItem.xaml | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Avalonia.Themes.Default/MenuItem.xaml b/src/Avalonia.Themes.Default/MenuItem.xaml index b58d2ff808..4bfae4c223 100644 --- a/src/Avalonia.Themes.Default/MenuItem.xaml +++ b/src/Avalonia.Themes.Default/MenuItem.xaml @@ -60,7 +60,6 @@ Date: Wed, 24 Feb 2021 14:46:40 +0700 Subject: [PATCH 05/19] rename AutoSelect to TextSearch --- src/Avalonia.Controls/ComboBox.cs | 54 +++++++++---------- .../ComboBoxTests.cs | 4 +- 2 files changed, 28 insertions(+), 30 deletions(-) diff --git a/src/Avalonia.Controls/ComboBox.cs b/src/Avalonia.Controls/ComboBox.cs index 95baf8146d..fa467a83ac 100644 --- a/src/Avalonia.Controls/ComboBox.cs +++ b/src/Avalonia.Controls/ComboBox.cs @@ -78,13 +78,13 @@ namespace Avalonia.Controls ContentControl.VerticalContentAlignmentProperty.AddOwner(); /// - /// Defines the property. + /// Defines the property. /// - public static readonly StyledProperty IsAutoSelectEnabledProperty = - AvaloniaProperty.Register(nameof(IsAutoSelectEnabled)); + public static readonly StyledProperty IsTextSearchEnabledProperty = + AvaloniaProperty.Register(nameof(IsTextSearchEnabled)); - private string _autoSelectTerm = string.Empty; - private DispatcherTimer _autoSelectTimer; + private string _textSearchTerm = string.Empty; + private DispatcherTimer _textSearchTimer; private bool _isDropDownOpen; private Popup _popup; private object _selectionBoxItem; @@ -174,14 +174,12 @@ namespace Avalonia.Controls } /// - /// Gets or sets value indicating whether auto-select is currently enabled. - /// If true, the control will try to find then select matched - /// based on current keyboard inputs. + /// Gets or sets a value that specifies whether a user can jump to a value by typing. /// - public bool IsAutoSelectEnabled + public bool IsTextSearchEnabled { - get { return GetValue(IsAutoSelectEnabledProperty); } - set { SetValue(IsAutoSelectEnabledProperty, value); } + get { return GetValue(IsTextSearchEnabledProperty); } + set { SetValue(IsTextSearchEnabledProperty, value); } } /// @@ -252,16 +250,16 @@ namespace Avalonia.Controls /// protected override void OnTextInput(TextInputEventArgs e) { - if (!IsAutoSelectEnabled || e.Handled) + if (!IsTextSearchEnabled || e.Handled) return; - StopAutoSelectTimer(); + StopTextSearchTimer(); - _autoSelectTerm += e.Text; + _textSearchTerm += e.Text; bool match(ItemContainerInfo info) => info.ContainerControl is IContentControl control && - control.Content?.ToString()?.StartsWith(_autoSelectTerm, StringComparison.OrdinalIgnoreCase) == true; + control.Content?.ToString()?.StartsWith(_textSearchTerm, StringComparison.OrdinalIgnoreCase) == true; var info = ItemContainerGenerator.Containers.FirstOrDefault(match); @@ -270,7 +268,7 @@ namespace Avalonia.Controls SelectedIndex = info.Index; } - StartAutoSelectTimer(); + StartTextSearchTimer(); e.Handled = true; } @@ -473,30 +471,30 @@ namespace Avalonia.Controls SelectedIndex = prev; } - private void StartAutoSelectTimer() + private void StartTextSearchTimer() { - _autoSelectTimer = new DispatcherTimer { Interval = TimeSpan.FromSeconds(1) }; - _autoSelectTimer.Tick += AutoSelectTimer_Tick; - _autoSelectTimer.Start(); + _textSearchTimer = new DispatcherTimer { Interval = TimeSpan.FromSeconds(1) }; + _textSearchTimer.Tick += TextSearchTimer_Tick; + _textSearchTimer.Start(); } - private void StopAutoSelectTimer() + private void StopTextSearchTimer() { - if (_autoSelectTimer == null) + if (_textSearchTimer == null) { return; } - _autoSelectTimer.Stop(); - _autoSelectTimer.Tick -= AutoSelectTimer_Tick; + _textSearchTimer.Stop(); + _textSearchTimer.Tick -= TextSearchTimer_Tick; - _autoSelectTimer = null; + _textSearchTimer = null; } - private void AutoSelectTimer_Tick(object sender, EventArgs e) + private void TextSearchTimer_Tick(object sender, EventArgs e) { - _autoSelectTerm = string.Empty; - StopAutoSelectTimer(); + _textSearchTerm = string.Empty; + StopTextSearchTimer(); } } } diff --git a/tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs b/tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs index 218832d988..7cd7e74976 100644 --- a/tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs +++ b/tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs @@ -144,7 +144,7 @@ namespace Avalonia.Controls.UnitTests [InlineData(-1, 2, "c", "A item", "B item", "C item")] [InlineData(0, 1, "b", "A item", "B item", "C item")] [InlineData(2, 2, "x", "A item", "B item", "C item")] - public void AutoSelect_Should_Have_Expected_SelectedIndex( + public void TextSearch_Should_Have_Expected_SelectedIndex( int initialSelectedIndex, int expectedSelectedIndex, string searchTerm, @@ -154,7 +154,7 @@ namespace Avalonia.Controls.UnitTests { var target = new ComboBox { - IsAutoSelectEnabled = true, + IsTextSearchEnabled = true, Template = GetTemplate(), Items = items.Select(x => new ComboBoxItem { Content = x }) }; From a4477e7de62870fe6082c4e306cd1d953c36b4e5 Mon Sep 17 00:00:00 2001 From: luthfiampas Date: Wed, 24 Feb 2021 15:08:30 +0700 Subject: [PATCH 06/19] set default value of IsTextSearchEnabled to true --- src/Avalonia.Controls/ComboBox.cs | 2 +- tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Avalonia.Controls/ComboBox.cs b/src/Avalonia.Controls/ComboBox.cs index fa467a83ac..8e7f01cad9 100644 --- a/src/Avalonia.Controls/ComboBox.cs +++ b/src/Avalonia.Controls/ComboBox.cs @@ -81,7 +81,7 @@ namespace Avalonia.Controls /// Defines the property. /// public static readonly StyledProperty IsTextSearchEnabledProperty = - AvaloniaProperty.Register(nameof(IsTextSearchEnabled)); + AvaloniaProperty.Register(nameof(IsTextSearchEnabled), true); private string _textSearchTerm = string.Empty; private DispatcherTimer _textSearchTimer; diff --git a/tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs b/tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs index 7cd7e74976..4ea838358c 100644 --- a/tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs +++ b/tests/Avalonia.Controls.UnitTests/ComboBoxTests.cs @@ -154,7 +154,6 @@ namespace Avalonia.Controls.UnitTests { var target = new ComboBox { - IsTextSearchEnabled = true, Template = GetTemplate(), Items = items.Select(x => new ComboBoxItem { Content = x }) }; From 188faa07c5333b14e9c734b1c8a3cefa47da94b6 Mon Sep 17 00:00:00 2001 From: Dariusz Komosinski Date: Mon, 22 Feb 2021 09:47:12 +0100 Subject: [PATCH 07/19] WIP setup for inspecting styles. --- .../ViewModels/ControlDetailsViewModel.cs | 208 ++++++++++++++++++ .../Diagnostics/Views/ControlDetailsView.xaml | 49 ++++- src/Avalonia.Styling/StyledElement.cs | 30 +++ .../Styling/IStyleInstance.cs | 2 + src/Avalonia.Styling/Styling/StyleInstance.cs | 9 +- 5 files changed, 292 insertions(+), 6 deletions(-) diff --git a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs index fa41eacbeb..6c622ad6c3 100644 --- a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs +++ b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs @@ -1,12 +1,131 @@ using System; using System.Collections.Generic; +using System.Collections.ObjectModel; +using System.Collections.Specialized; using System.ComponentModel; using System.Linq; +using System.Reflection; using Avalonia.Collections; +using Avalonia.Controls; +using Avalonia.Controls.Metadata; +using Avalonia.Markup.Xaml.MarkupExtensions; +using Avalonia.Media; +using Avalonia.Styling; using Avalonia.VisualTree; namespace Avalonia.Diagnostics.ViewModels { + internal class StyleViewModel : ViewModelBase + { + private readonly IStyleInstance _styleInstance; + private bool _isActive; + + public StyleViewModel(IStyleInstance styleInstance, string name, List setters) + { + _styleInstance = styleInstance; + IsActive = styleInstance.IsActive; + Name = name; + Setters = setters; + } + + public bool IsActive + { + get => _isActive; + set => RaiseAndSetIfChanged(ref _isActive, value); + } + + public string Name { get; } + + public List Setters { get; } + + public void Update() + { + IsActive = _styleInstance.IsActive; + } + } + + internal enum ValueKind + { + Regular, + Resource + } + + internal class SetterViewModel : ViewModelBase + { + public string Name { get; } + + public object Value { get; } + + public ValueKind Kind { get; } + + public bool IsSpecialKind => Kind != ValueKind.Regular; + + public IBrush KindColor { get; } + + public SetterViewModel(string name, object value, ValueKind kind) + { + Name = name; + Value = value; + Kind = kind; + + if (Kind == ValueKind.Resource) + { + KindColor = Brushes.Brown; + } + else + { + KindColor = Brushes.Transparent; + } + } + } + + internal class PseudoClassesViewModel : ViewModelBase + { + private readonly StyledElement _source; + private readonly IPseudoClasses _pseudoClasses; + private bool _isActive; + private bool _isUpdating; + + public PseudoClassesViewModel(string name, StyledElement source) + { + Name = name; + _source = source; + _pseudoClasses = _source.Classes; + + Update(); + } + + public string Name { get; } + + public bool IsActive + { + get => _isActive; + set + { + RaiseAndSetIfChanged(ref _isActive, value); + + if (!_isUpdating) + { + _pseudoClasses.Set(Name, value); + } + } + } + + public void Update() + { + try + { + _isUpdating = true; + + IsActive = _source.Classes.Contains(Name); + } + finally + { + _isUpdating = false; + } + } + } + internal class ControlDetailsViewModel : ViewModelBase, IDisposable { private readonly IVisual _control; @@ -43,12 +162,76 @@ namespace Avalonia.Diagnostics.ViewModels { ao.PropertyChanged += ControlPropertyChanged; } + + AppliedStyles = new ObservableCollection(); + PseudoClasses = new ObservableCollection(); + + if (control is StyledElement styledElement) + { + styledElement.Classes.CollectionChanged += OnClassesChanged; + + var pseudoClassAttributes = styledElement.GetType().GetCustomAttributes(true); + + foreach (var classAttribute in pseudoClassAttributes) + { + foreach (var className in classAttribute.PseudoClasses) + { + PseudoClasses.Add(new PseudoClassesViewModel(className, styledElement)); + } + } + + var styleDiagnostics = styledElement.GetStyleDiagnostics(); + + foreach (var appliedStyle in styleDiagnostics.AppliedStyles) + { + var styleSource = appliedStyle.Source; + + var setters = new List(); + + if (styleSource is Style style) + { + foreach (var setter in style.Setters) + { + if (setter is Setter regularSetter) + { + var setterValue = regularSetter.Value; + + ValueKind kind = ValueKind.Regular; + + if (setterValue is DynamicResourceExtension dynResource) + { + var resolved = styledElement.FindResource(dynResource.ResourceKey); + + if (resolved != null) + { + setterValue = $"{resolved} ({dynResource.ResourceKey})"; + } + else + { + setterValue = dynResource.ResourceKey; + } + + kind = ValueKind.Resource; + } + + setters.Add(new SetterViewModel(regularSetter.Property?.Name ?? "?", setterValue, kind)); + } + } + + AppliedStyles.Add(new StyleViewModel(appliedStyle, style.Selector?.ToString() ?? "No selector", setters)); + } + } + } } public TreePageViewModel TreePage { get; } public DataGridCollectionView PropertiesView { get; } + public ObservableCollection AppliedStyles { get; } + + public ObservableCollection PseudoClasses { get; } + public AvaloniaPropertyViewModel SelectedProperty { get => _selectedProperty; @@ -68,6 +251,11 @@ namespace Avalonia.Diagnostics.ViewModels { ao.PropertyChanged -= ControlPropertyChanged; } + + if (_control is StyledElement se) + { + se.Classes.CollectionChanged -= OnClassesChanged; + } } private IEnumerable GetAvaloniaProperties(object o) @@ -129,6 +317,26 @@ namespace Avalonia.Diagnostics.ViewModels property.Update(); } } + + UpdateStyles(); + } + + private void OnClassesChanged(object sender, NotifyCollectionChangedEventArgs e) + { + UpdateStyles(); + } + + private void UpdateStyles() + { + foreach (var style in AppliedStyles) + { + style.Update(); + } + + foreach (var pseudoClass in PseudoClasses) + { + pseudoClass.Update(); + } } private bool FilterProperty(object arg) diff --git a/src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml b/src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml index 2e0b6813ba..9b341c1388 100644 --- a/src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml +++ b/src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml @@ -105,7 +105,7 @@ - + @@ -148,7 +148,52 @@ - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/src/Avalonia.Styling/StyledElement.cs b/src/Avalonia.Styling/StyledElement.cs index cc8d91462d..2f7ec13775 100644 --- a/src/Avalonia.Styling/StyledElement.cs +++ b/src/Avalonia.Styling/StyledElement.cs @@ -16,6 +16,24 @@ using Avalonia.Styling; namespace Avalonia { + public class StyleDiagnostics + { + public IReadOnlyList AppliedStyles { get; } + + public StyleDiagnostics(IReadOnlyList appliedStyles) + { + AppliedStyles = appliedStyles; + } + } + + public static class StyledElementExtensions + { + public static StyleDiagnostics GetStyleDiagnostics(this StyledElement styledElement) + { + return styledElement.GetStyleDiagnosticsInternal(); + } + } + /// /// Extends an with the following features: /// @@ -356,6 +374,18 @@ namespace Avalonia } } + internal StyleDiagnostics GetStyleDiagnosticsInternal() + { + IReadOnlyList? appliedStyles = _appliedStyles; + + if (appliedStyles is null) + { + appliedStyles = Array.Empty(); + } + + return new StyleDiagnostics(appliedStyles); + } + /// void ILogical.NotifyAttachedToLogicalTree(LogicalTreeAttachmentEventArgs e) { diff --git a/src/Avalonia.Styling/Styling/IStyleInstance.cs b/src/Avalonia.Styling/Styling/IStyleInstance.cs index cb094badd2..cdccc552a3 100644 --- a/src/Avalonia.Styling/Styling/IStyleInstance.cs +++ b/src/Avalonia.Styling/Styling/IStyleInstance.cs @@ -14,6 +14,8 @@ namespace Avalonia.Styling /// IStyle Source { get; } + bool IsActive { get; } + /// /// Instructs the style to start acting upon the control. /// diff --git a/src/Avalonia.Styling/Styling/StyleInstance.cs b/src/Avalonia.Styling/Styling/StyleInstance.cs index 8ca31d654f..830cf49a0d 100644 --- a/src/Avalonia.Styling/Styling/StyleInstance.cs +++ b/src/Avalonia.Styling/Styling/StyleInstance.cs @@ -17,7 +17,6 @@ namespace Avalonia.Styling private readonly List? _animations; private readonly IStyleActivator? _activator; private readonly Subject? _animationTrigger; - private bool _active; public StyleInstance( IStyle source, @@ -29,6 +28,7 @@ namespace Avalonia.Styling Source = source ?? throw new ArgumentNullException(nameof(source)); Target = target ?? throw new ArgumentNullException(nameof(target)); _activator = activator; + IsActive = _activator is null; if (setters is object) { @@ -56,6 +56,7 @@ namespace Avalonia.Styling } } + public bool IsActive { get; private set; } public IStyle Source { get; } public IStyleable Target { get; } @@ -104,15 +105,15 @@ namespace Avalonia.Styling private void ActivatorChanged(bool value) { - if (_active != value) + if (IsActive != value) { - _active = value; + IsActive = value; _animationTrigger?.OnNext(value); if (_setters is object) { - if (_active) + if (IsActive) { foreach (var setter in _setters) { From e428d5601aec3ff77ac7049be59729f214e1c8b1 Mon Sep 17 00:00:00 2001 From: Dariusz Komosinski Date: Mon, 22 Feb 2021 19:14:36 +0100 Subject: [PATCH 08/19] General UX improvements. --- .../Converters/BoolToOpacityConverter.cs | 21 ++ .../ViewModels/ControlDetailsViewModel.cs | 227 ++++++++---------- .../ViewModels/PseudoClassesViewModel.cs | 51 ++++ .../ViewModels/ResourceSetterViewModel.cs | 17 ++ .../Diagnostics/ViewModels/SetterViewModel.cs | 35 +++ .../Diagnostics/ViewModels/StyleViewModel.cs | 43 ++++ .../ViewModels/TreePageViewModel.cs | 7 + .../Diagnostics/Views/ControlDetailsView.xaml | 70 +++++- 8 files changed, 334 insertions(+), 137 deletions(-) create mode 100644 src/Avalonia.Diagnostics/Diagnostics/Converters/BoolToOpacityConverter.cs create mode 100644 src/Avalonia.Diagnostics/Diagnostics/ViewModels/PseudoClassesViewModel.cs create mode 100644 src/Avalonia.Diagnostics/Diagnostics/ViewModels/ResourceSetterViewModel.cs create mode 100644 src/Avalonia.Diagnostics/Diagnostics/ViewModels/SetterViewModel.cs create mode 100644 src/Avalonia.Diagnostics/Diagnostics/ViewModels/StyleViewModel.cs diff --git a/src/Avalonia.Diagnostics/Diagnostics/Converters/BoolToOpacityConverter.cs b/src/Avalonia.Diagnostics/Diagnostics/Converters/BoolToOpacityConverter.cs new file mode 100644 index 0000000000..63ac3ab62f --- /dev/null +++ b/src/Avalonia.Diagnostics/Diagnostics/Converters/BoolToOpacityConverter.cs @@ -0,0 +1,21 @@ +using System; +using System.Globalization; +using Avalonia.Data.Converters; + +namespace Avalonia.Diagnostics.Converters +{ + internal class BoolToOpacityConverter : IValueConverter + { + public double Opacity { get; set; } + + public object Convert(object value, Type targetType, object parameter, CultureInfo culture) + { + return (bool)value ? 1d : Opacity; + } + + public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture) + { + throw new NotImplementedException(); + } + } +} diff --git a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs index 6c622ad6c3..e6758d680c 100644 --- a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs +++ b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs @@ -9,128 +9,17 @@ using Avalonia.Collections; using Avalonia.Controls; using Avalonia.Controls.Metadata; using Avalonia.Markup.Xaml.MarkupExtensions; -using Avalonia.Media; using Avalonia.Styling; using Avalonia.VisualTree; namespace Avalonia.Diagnostics.ViewModels { - internal class StyleViewModel : ViewModelBase - { - private readonly IStyleInstance _styleInstance; - private bool _isActive; - - public StyleViewModel(IStyleInstance styleInstance, string name, List setters) - { - _styleInstance = styleInstance; - IsActive = styleInstance.IsActive; - Name = name; - Setters = setters; - } - - public bool IsActive - { - get => _isActive; - set => RaiseAndSetIfChanged(ref _isActive, value); - } - - public string Name { get; } - - public List Setters { get; } - - public void Update() - { - IsActive = _styleInstance.IsActive; - } - } - - internal enum ValueKind - { - Regular, - Resource - } - - internal class SetterViewModel : ViewModelBase - { - public string Name { get; } - - public object Value { get; } - - public ValueKind Kind { get; } - - public bool IsSpecialKind => Kind != ValueKind.Regular; - - public IBrush KindColor { get; } - - public SetterViewModel(string name, object value, ValueKind kind) - { - Name = name; - Value = value; - Kind = kind; - - if (Kind == ValueKind.Resource) - { - KindColor = Brushes.Brown; - } - else - { - KindColor = Brushes.Transparent; - } - } - } - - internal class PseudoClassesViewModel : ViewModelBase - { - private readonly StyledElement _source; - private readonly IPseudoClasses _pseudoClasses; - private bool _isActive; - private bool _isUpdating; - - public PseudoClassesViewModel(string name, StyledElement source) - { - Name = name; - _source = source; - _pseudoClasses = _source.Classes; - - Update(); - } - - public string Name { get; } - - public bool IsActive - { - get => _isActive; - set - { - RaiseAndSetIfChanged(ref _isActive, value); - - if (!_isUpdating) - { - _pseudoClasses.Set(Name, value); - } - } - } - - public void Update() - { - try - { - _isUpdating = true; - - IsActive = _source.Classes.Contains(Name); - } - finally - { - _isUpdating = false; - } - } - } - internal class ControlDetailsViewModel : ViewModelBase, IDisposable { private readonly IVisual _control; private readonly IDictionary> _propertyIndex; private AvaloniaPropertyViewModel _selectedProperty; + private string _styleFilter; public ControlDetailsViewModel(TreePageViewModel treePage, IVisual control) { @@ -196,32 +85,46 @@ namespace Avalonia.Diagnostics.ViewModels { var setterValue = regularSetter.Value; - ValueKind kind = ValueKind.Regular; + var resourceInfo = GetResourceInfo(setterValue); + + SetterViewModel setterVm; - if (setterValue is DynamicResourceExtension dynResource) + if (resourceInfo.HasValue) { - var resolved = styledElement.FindResource(dynResource.ResourceKey); - - if (resolved != null) - { - setterValue = $"{resolved} ({dynResource.ResourceKey})"; - } - else - { - setterValue = dynResource.ResourceKey; - } - - kind = ValueKind.Resource; + var resourceKey = resourceInfo.Value.resourceKey; + var resourceValue = styledElement.FindResource(resourceKey); + + setterVm = new ResourceSetterViewModel(regularSetter.Property, resourceKey, resourceValue, resourceInfo.Value.isDynamic); + } + else + { + setterVm = new SetterViewModel(regularSetter.Property, setterValue); } - setters.Add(new SetterViewModel(regularSetter.Property?.Name ?? "?", setterValue, kind)); + setters.Add(setterVm); } } AppliedStyles.Add(new StyleViewModel(appliedStyle, style.Selector?.ToString() ?? "No selector", setters)); } } + + UpdateStyles(); + } + } + + private (object resourceKey, bool isDynamic)? GetResourceInfo(object value) + { + if (value is StaticResourceExtension staticResource) + { + return (staticResource.ResourceKey, false); } + else if (value is DynamicResourceExtension dynamicResource) + { + return (dynamicResource.ResourceKey, true); + } + + return null; } public TreePageViewModel TreePage { get; } @@ -237,9 +140,46 @@ namespace Avalonia.Diagnostics.ViewModels get => _selectedProperty; set => RaiseAndSetIfChanged(ref _selectedProperty, value); } + + public string StyleFilter + { + get => _styleFilter; + set => RaiseAndSetIfChanged(ref _styleFilter, value); + } public ControlLayoutViewModel Layout { get; } + protected override void OnPropertyChanged(PropertyChangedEventArgs e) + { + base.OnPropertyChanged(e); + + if (e.PropertyName == nameof(StyleFilter)) + { + UpdateStyleFilters(); + } + } + + private void UpdateStyleFilters() + { + var filter = StyleFilter; + bool hasFilter = !string.IsNullOrEmpty(filter); + + foreach (var style in AppliedStyles) + { + var hasVisibleSetter = false; + + foreach (var setter in style.Setters) + { + setter.IsVisible = + !hasFilter || setter.Name.IndexOf(filter, StringComparison.OrdinalIgnoreCase) >= 0; + + hasVisibleSetter |= setter.IsVisible; + } + + style.IsVisible = hasVisibleSetter; + } + } + public void Dispose() { if (_control is INotifyPropertyChanged inpc) @@ -333,6 +273,39 @@ namespace Avalonia.Diagnostics.ViewModels style.Update(); } + var propertyBuckets = new Dictionary>(); + + foreach (var style in AppliedStyles) + { + if (!style.IsActive) + { + continue; + } + + foreach (var setter in style.Setters) + { + if (propertyBuckets.TryGetValue(setter.Property, out var setters)) + { + foreach (var otherSetter in setters) + { + otherSetter.IsActive = false; + } + + setter.IsActive = true; + + setters.Add(setter); + } + else + { + setter.IsActive = true; + + setters = new List { setter }; + + propertyBuckets.Add(setter.Property, setters); + } + } + } + foreach (var pseudoClass in PseudoClasses) { pseudoClass.Update(); diff --git a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/PseudoClassesViewModel.cs b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/PseudoClassesViewModel.cs new file mode 100644 index 0000000000..dd2452333e --- /dev/null +++ b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/PseudoClassesViewModel.cs @@ -0,0 +1,51 @@ +using Avalonia.Controls; + +namespace Avalonia.Diagnostics.ViewModels +{ + internal class PseudoClassesViewModel : ViewModelBase + { + private readonly IPseudoClasses _pseudoClasses; + private readonly StyledElement _source; + private bool _isActive; + private bool _isUpdating; + + public PseudoClassesViewModel(string name, StyledElement source) + { + Name = name; + _source = source; + _pseudoClasses = _source.Classes; + + Update(); + } + + public string Name { get; } + + public bool IsActive + { + get => _isActive; + set + { + RaiseAndSetIfChanged(ref _isActive, value); + + if (!_isUpdating) + { + _pseudoClasses.Set(Name, value); + } + } + } + + public void Update() + { + try + { + _isUpdating = true; + + IsActive = _source.Classes.Contains(Name); + } + finally + { + _isUpdating = false; + } + } + } +} diff --git a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ResourceSetterViewModel.cs b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ResourceSetterViewModel.cs new file mode 100644 index 0000000000..fedfa1c0b4 --- /dev/null +++ b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ResourceSetterViewModel.cs @@ -0,0 +1,17 @@ +using Avalonia.Media; + +namespace Avalonia.Diagnostics.ViewModels +{ + internal class ResourceSetterViewModel : SetterViewModel + { + public object Key { get; } + + public IBrush Tint { get; } + + public ResourceSetterViewModel(AvaloniaProperty property, object resourceKey, object resourceValue, bool isDynamic) : base(property, resourceValue) + { + Key = resourceKey; + Tint = isDynamic ? Brushes.Orange : Brushes.Brown; + } + } +} diff --git a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/SetterViewModel.cs b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/SetterViewModel.cs new file mode 100644 index 0000000000..691817ccd1 --- /dev/null +++ b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/SetterViewModel.cs @@ -0,0 +1,35 @@ +namespace Avalonia.Diagnostics.ViewModels +{ + internal class SetterViewModel : ViewModelBase + { + private bool _isActive; + private bool _isVisible; + + public AvaloniaProperty Property { get; } + + public string Name { get; } + + public object Value { get; } + + public bool IsActive + { + get => _isActive; + set => RaiseAndSetIfChanged(ref _isActive, value); + } + + public bool IsVisible + { + get => _isVisible; + set => RaiseAndSetIfChanged(ref _isVisible, value); + } + + public SetterViewModel(AvaloniaProperty property, object value) + { + Property = property; + Name = property.Name; + Value = value; + IsActive = true; + IsVisible = true; + } + } +} diff --git a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/StyleViewModel.cs b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/StyleViewModel.cs new file mode 100644 index 0000000000..06e2409800 --- /dev/null +++ b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/StyleViewModel.cs @@ -0,0 +1,43 @@ +using System.Collections.Generic; +using Avalonia.Styling; + +namespace Avalonia.Diagnostics.ViewModels +{ + internal class StyleViewModel : ViewModelBase + { + private readonly IStyleInstance _styleInstance; + private bool _isActive; + private bool _isVisible; + + public StyleViewModel(IStyleInstance styleInstance, string name, List setters) + { + _styleInstance = styleInstance; + IsVisible = true; + Name = name; + Setters = setters; + + Update(); + } + + public bool IsActive + { + get => _isActive; + set => RaiseAndSetIfChanged(ref _isActive, value); + } + + public bool IsVisible + { + get => _isVisible; + set => RaiseAndSetIfChanged(ref _isVisible, value); + } + + public string Name { get; } + + public List Setters { get; } + + public void Update() + { + IsActive = _styleInstance.IsActive; + } + } +} diff --git a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/TreePageViewModel.cs b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/TreePageViewModel.cs index bd65a3b06b..6b779cd6ac 100644 --- a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/TreePageViewModel.cs +++ b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/TreePageViewModel.cs @@ -31,11 +31,18 @@ namespace Avalonia.Diagnostics.ViewModels get => _selectedNode; private set { + var oldDetails = Details; + if (RaiseAndSetIfChanged(ref _selectedNode, value)) { Details = value != null ? new ControlDetailsViewModel(this, value.Visual) : null; + + if (Details != null && oldDetails != null) + { + Details.StyleFilter = oldDetails.StyleFilter; + } } } } diff --git a/src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml b/src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml index 9b341c1388..7b5fbbfb22 100644 --- a/src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml +++ b/src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml @@ -2,6 +2,7 @@ xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:conv="clr-namespace:Avalonia.Diagnostics.Converters" xmlns:local="clr-namespace:Avalonia.Diagnostics.Views" + xmlns:vm="clr-namespace:Avalonia.Diagnostics.ViewModels" x:Class="Avalonia.Diagnostics.Views.ControlDetailsView"> @@ -11,6 +12,7 @@ + @@ -149,29 +151,77 @@ - + + + + - + - + + + + + + + + - - + + + + + + + + + + - - - - + + + + + + - + + + + + + + + ( + + + ) + + + + + + + + + + + + + + + + + + From 02fa3502e0438b8f04194a9fc51bfbdcdb1c2056 Mon Sep 17 00:00:00 2001 From: Dariusz Komosinski Date: Thu, 25 Feb 2021 23:20:07 +0100 Subject: [PATCH 09/19] Cleanup styling code. --- .../Diagnostics/StyleDiagnostics.cs | 21 +++++++++++++++++++ .../Diagnostics/StyledElementExtensions.cs | 17 +++++++++++++++ src/Avalonia.Styling/StyledElement.cs | 18 ---------------- .../Styling/IStyleInstance.cs | 3 +++ 4 files changed, 41 insertions(+), 18 deletions(-) create mode 100644 src/Avalonia.Styling/Diagnostics/StyleDiagnostics.cs create mode 100644 src/Avalonia.Styling/Diagnostics/StyledElementExtensions.cs diff --git a/src/Avalonia.Styling/Diagnostics/StyleDiagnostics.cs b/src/Avalonia.Styling/Diagnostics/StyleDiagnostics.cs new file mode 100644 index 0000000000..984b145e68 --- /dev/null +++ b/src/Avalonia.Styling/Diagnostics/StyleDiagnostics.cs @@ -0,0 +1,21 @@ +using System.Collections.Generic; +using Avalonia.Styling; + +namespace Avalonia.Diagnostics +{ + /// + /// Contains information about style related diagnostics of a control. + /// + public class StyleDiagnostics + { + /// + /// Currently applied styles. + /// + public IReadOnlyList AppliedStyles { get; } + + public StyleDiagnostics(IReadOnlyList appliedStyles) + { + AppliedStyles = appliedStyles; + } + } +} diff --git a/src/Avalonia.Styling/Diagnostics/StyledElementExtensions.cs b/src/Avalonia.Styling/Diagnostics/StyledElementExtensions.cs new file mode 100644 index 0000000000..d7bcc1aa47 --- /dev/null +++ b/src/Avalonia.Styling/Diagnostics/StyledElementExtensions.cs @@ -0,0 +1,17 @@ +namespace Avalonia.Diagnostics +{ + /// + /// Defines diagnostic extensions on s. + /// + public static class StyledElementExtensions + { + /// + /// Gets a style diagnostics for a . + /// + /// The element. + public static StyleDiagnostics GetStyleDiagnostics(this StyledElement styledElement) + { + return styledElement.GetStyleDiagnosticsInternal(); + } + } +} diff --git a/src/Avalonia.Styling/StyledElement.cs b/src/Avalonia.Styling/StyledElement.cs index 2f7ec13775..fad281244f 100644 --- a/src/Avalonia.Styling/StyledElement.cs +++ b/src/Avalonia.Styling/StyledElement.cs @@ -16,24 +16,6 @@ using Avalonia.Styling; namespace Avalonia { - public class StyleDiagnostics - { - public IReadOnlyList AppliedStyles { get; } - - public StyleDiagnostics(IReadOnlyList appliedStyles) - { - AppliedStyles = appliedStyles; - } - } - - public static class StyledElementExtensions - { - public static StyleDiagnostics GetStyleDiagnostics(this StyledElement styledElement) - { - return styledElement.GetStyleDiagnosticsInternal(); - } - } - /// /// Extends an with the following features: /// diff --git a/src/Avalonia.Styling/Styling/IStyleInstance.cs b/src/Avalonia.Styling/Styling/IStyleInstance.cs index cdccc552a3..8ddb989bc0 100644 --- a/src/Avalonia.Styling/Styling/IStyleInstance.cs +++ b/src/Avalonia.Styling/Styling/IStyleInstance.cs @@ -14,6 +14,9 @@ namespace Avalonia.Styling /// IStyle Source { get; } + /// + /// Gets a value indicating whether this style is active. + /// bool IsActive { get; } /// From bf40bae0ed0634a69db3ace9795a7e40e1fe2671 Mon Sep 17 00:00:00 2001 From: Dariusz Komosinski Date: Thu, 25 Feb 2021 23:23:14 +0100 Subject: [PATCH 10/19] API diff update. --- src/Avalonia.Styling/ApiCompatBaseline.txt | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 src/Avalonia.Styling/ApiCompatBaseline.txt diff --git a/src/Avalonia.Styling/ApiCompatBaseline.txt b/src/Avalonia.Styling/ApiCompatBaseline.txt new file mode 100644 index 0000000000..0eedc3e360 --- /dev/null +++ b/src/Avalonia.Styling/ApiCompatBaseline.txt @@ -0,0 +1,4 @@ +Compat issues with assembly Avalonia.Styling: +InterfacesShouldHaveSameMembers : Interface member 'public System.Boolean Avalonia.Styling.IStyleInstance.IsActive' is present in the implementation but not in the contract. +InterfacesShouldHaveSameMembers : Interface member 'public System.Boolean Avalonia.Styling.IStyleInstance.IsActive.get()' is present in the implementation but not in the contract. +Total Issues: 2 From 161b9374a59a9631f2b2bfa976a0bf4eba21e457 Mon Sep 17 00:00:00 2001 From: Dariusz Komosinski Date: Fri, 26 Feb 2021 00:27:30 +0100 Subject: [PATCH 11/19] Add style snapshotting and context menus to copy property values. --- .../ViewModels/ControlDetailsViewModel.cs | 32 +++++++++++++++---- .../Diagnostics/ViewModels/MainViewModel.cs | 8 +++++ ...esViewModel.cs => PseudoClassViewModel.cs} | 4 +-- .../ViewModels/ResourceSetterViewModel.cs | 10 ++++++ .../Diagnostics/ViewModels/SetterViewModel.cs | 26 ++++++++++++++- .../Diagnostics/Views/ControlDetailsView.xaml | 22 +++++++++++-- .../Diagnostics/Views/MainWindow.xaml.cs | 10 ++++++ 7 files changed, 101 insertions(+), 11 deletions(-) rename src/Avalonia.Diagnostics/Diagnostics/ViewModels/{PseudoClassesViewModel.cs => PseudoClassViewModel.cs} (88%) diff --git a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs index e6758d680c..19eb14ba06 100644 --- a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs +++ b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs @@ -20,6 +20,7 @@ namespace Avalonia.Diagnostics.ViewModels private readonly IDictionary> _propertyIndex; private AvaloniaPropertyViewModel _selectedProperty; private string _styleFilter; + private bool _snapshotStyles; public ControlDetailsViewModel(TreePageViewModel treePage, IVisual control) { @@ -53,7 +54,7 @@ namespace Avalonia.Diagnostics.ViewModels } AppliedStyles = new ObservableCollection(); - PseudoClasses = new ObservableCollection(); + PseudoClasses = new ObservableCollection(); if (control is StyledElement styledElement) { @@ -65,7 +66,7 @@ namespace Avalonia.Diagnostics.ViewModels { foreach (var className in classAttribute.PseudoClasses) { - PseudoClasses.Add(new PseudoClassesViewModel(className, styledElement)); + PseudoClasses.Add(new PseudoClassViewModel(className, styledElement)); } } @@ -133,7 +134,7 @@ namespace Avalonia.Diagnostics.ViewModels public ObservableCollection AppliedStyles { get; } - public ObservableCollection PseudoClasses { get; } + public ObservableCollection PseudoClasses { get; } public AvaloniaPropertyViewModel SelectedProperty { @@ -146,7 +147,13 @@ namespace Avalonia.Diagnostics.ViewModels get => _styleFilter; set => RaiseAndSetIfChanged(ref _styleFilter, value); } - + + public bool SnapshotStyles + { + get => _snapshotStyles; + set => RaiseAndSetIfChanged(ref _snapshotStyles, value); + } + public ControlLayoutViewModel Layout { get; } protected override void OnPropertyChanged(PropertyChangedEventArgs e) @@ -157,6 +164,13 @@ namespace Avalonia.Diagnostics.ViewModels { UpdateStyleFilters(); } + else if (e.PropertyName == nameof(SnapshotStyles)) + { + if (!SnapshotStyles) + { + UpdateStyles(); + } + } } private void UpdateStyleFilters() @@ -258,12 +272,18 @@ namespace Avalonia.Diagnostics.ViewModels } } - UpdateStyles(); + if (!SnapshotStyles) + { + UpdateStyles(); + } } private void OnClassesChanged(object sender, NotifyCollectionChangedEventArgs e) { - UpdateStyles(); + if (!SnapshotStyles) + { + UpdateStyles(); + } } private void UpdateStyles() diff --git a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/MainViewModel.cs b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/MainViewModel.cs index bf7d0e232a..3049431361 100644 --- a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/MainViewModel.cs +++ b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/MainViewModel.cs @@ -163,6 +163,14 @@ namespace Avalonia.Diagnostics.ViewModels tree?.SelectControl(control); } + public void EnableSnapshotStyles(bool enable) + { + if (Content is TreePageViewModel treeVm && treeVm.Details != null) + { + treeVm.Details.SnapshotStyles = enable; + } + } + public void Dispose() { KeyboardDevice.Instance.PropertyChanged -= KeyboardPropertyChanged; diff --git a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/PseudoClassesViewModel.cs b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/PseudoClassViewModel.cs similarity index 88% rename from src/Avalonia.Diagnostics/Diagnostics/ViewModels/PseudoClassesViewModel.cs rename to src/Avalonia.Diagnostics/Diagnostics/ViewModels/PseudoClassViewModel.cs index dd2452333e..69126c2e2f 100644 --- a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/PseudoClassesViewModel.cs +++ b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/PseudoClassViewModel.cs @@ -2,14 +2,14 @@ namespace Avalonia.Diagnostics.ViewModels { - internal class PseudoClassesViewModel : ViewModelBase + internal class PseudoClassViewModel : ViewModelBase { private readonly IPseudoClasses _pseudoClasses; private readonly StyledElement _source; private bool _isActive; private bool _isUpdating; - public PseudoClassesViewModel(string name, StyledElement source) + public PseudoClassViewModel(string name, StyledElement source) { Name = name; _source = source; diff --git a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ResourceSetterViewModel.cs b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ResourceSetterViewModel.cs index fedfa1c0b4..a82e13fcfa 100644 --- a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ResourceSetterViewModel.cs +++ b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ResourceSetterViewModel.cs @@ -13,5 +13,15 @@ namespace Avalonia.Diagnostics.ViewModels Key = resourceKey; Tint = isDynamic ? Brushes.Orange : Brushes.Brown; } + + public void CopyResourceKey() + { + if (Key is null) + { + return; + } + + CopyToClipboard(Key.ToString()); + } } } diff --git a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/SetterViewModel.cs b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/SetterViewModel.cs index 691817ccd1..e835f5a878 100644 --- a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/SetterViewModel.cs +++ b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/SetterViewModel.cs @@ -1,4 +1,6 @@ -namespace Avalonia.Diagnostics.ViewModels +using Avalonia.Input.Platform; + +namespace Avalonia.Diagnostics.ViewModels { internal class SetterViewModel : ViewModelBase { @@ -31,5 +33,27 @@ IsActive = true; IsVisible = true; } + + public void CopyValue() + { + if (Value is null) + { + return; + } + + CopyToClipboard(Value.ToString()); + } + + public void CopyPropertyName() + { + CopyToClipboard(Property.Name); + } + + protected static void CopyToClipboard(string value) + { + var clipboard = AvaloniaLocator.Current.GetService(); + + clipboard?.SetTextAsync(value); + } } } diff --git a/src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml b/src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml index 7b5fbbfb22..c7a52a5a5f 100644 --- a/src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml +++ b/src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml @@ -152,8 +152,13 @@ - - + + + + + + + @@ -195,6 +200,13 @@ + + + + + + + @@ -210,6 +222,12 @@ + + + + + + diff --git a/src/Avalonia.Diagnostics/Diagnostics/Views/MainWindow.xaml.cs b/src/Avalonia.Diagnostics/Diagnostics/Views/MainWindow.xaml.cs index c4f9185728..330121321a 100644 --- a/src/Avalonia.Diagnostics/Diagnostics/Views/MainWindow.xaml.cs +++ b/src/Avalonia.Diagnostics/Diagnostics/Views/MainWindow.xaml.cs @@ -90,6 +90,16 @@ namespace Avalonia.Diagnostics.Views var vm = (MainViewModel)DataContext; vm.SelectControl((IControl)control); } + } + else if (e.Modifiers == RawInputModifiers.Alt) + { + if (e.Key == Key.S || e.Key == Key.D) + { + var enable = e.Key == Key.S; + + var vm = (MainViewModel)DataContext; + vm.EnableSnapshotStyles(enable); + } } } From 38ebab0916c933cb35938cade546ecf90366c2eb Mon Sep 17 00:00:00 2001 From: Dariusz Komosinski Date: Fri, 26 Feb 2021 18:15:59 +0100 Subject: [PATCH 12/19] Add info about how many styles are active and allow for showing inactive styles. --- .../Data/Converters/BoolConverters.cs | 6 +++++ .../ViewModels/ControlDetailsViewModel.cs | 23 +++++++++++++++++++ .../Diagnostics/Views/ControlDetailsView.xaml | 17 +++++++++----- 3 files changed, 40 insertions(+), 6 deletions(-) diff --git a/src/Avalonia.Base/Data/Converters/BoolConverters.cs b/src/Avalonia.Base/Data/Converters/BoolConverters.cs index 6740c2168f..9329cdd6af 100644 --- a/src/Avalonia.Base/Data/Converters/BoolConverters.cs +++ b/src/Avalonia.Base/Data/Converters/BoolConverters.cs @@ -12,5 +12,11 @@ namespace Avalonia.Data.Converters /// public static readonly IMultiValueConverter And = new FuncMultiValueConverter(x => x.All(y => y)); + + /// + /// A multi-value converter that returns true if any of the inputs is true. + /// + public static readonly IMultiValueConverter Or = + new FuncMultiValueConverter(x => x.Any(y => y)); } } diff --git a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs index 19eb14ba06..32592559e5 100644 --- a/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs +++ b/src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs @@ -21,6 +21,8 @@ namespace Avalonia.Diagnostics.ViewModels private AvaloniaPropertyViewModel _selectedProperty; private string _styleFilter; private bool _snapshotStyles; + private bool _showInactiveStyles; + private string _styleStatus; public ControlDetailsViewModel(TreePageViewModel treePage, IVisual control) { @@ -154,6 +156,18 @@ namespace Avalonia.Diagnostics.ViewModels set => RaiseAndSetIfChanged(ref _snapshotStyles, value); } + public bool ShowInactiveStyles + { + get => _showInactiveStyles; + set => RaiseAndSetIfChanged(ref _showInactiveStyles, value); + } + + public string StyleStatus + { + get => _styleStatus; + set => RaiseAndSetIfChanged(ref _styleStatus, value); + } + public ControlLayoutViewModel Layout { get; } protected override void OnPropertyChanged(PropertyChangedEventArgs e) @@ -288,9 +302,16 @@ namespace Avalonia.Diagnostics.ViewModels private void UpdateStyles() { + int activeCount = 0; + foreach (var style in AppliedStyles) { style.Update(); + + if (style.IsActive) + { + activeCount++; + } } var propertyBuckets = new Dictionary>(); @@ -330,6 +351,8 @@ namespace Avalonia.Diagnostics.ViewModels { pseudoClass.Update(); } + + StyleStatus = $"Styles ({activeCount}/{AppliedStyles.Count} active)"; } private bool FilterProperty(object arg) diff --git a/src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml b/src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml index c7a52a5a5f..9ba576c826 100644 --- a/src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml +++ b/src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml @@ -3,7 +3,8 @@ xmlns:conv="clr-namespace:Avalonia.Diagnostics.Converters" xmlns:local="clr-namespace:Avalonia.Diagnostics.Views" xmlns:vm="clr-namespace:Avalonia.Diagnostics.ViewModels" - x:Class="Avalonia.Diagnostics.Views.ControlDetailsView"> + x:Class="Avalonia.Diagnostics.Views.ControlDetailsView" + x:Name="Main"> @@ -153,9 +154,10 @@ - - - + + + + @@ -165,10 +167,13 @@ - + - + + + + From 0a54da63ecf2b53d8bb7a8c9c1e401f47859ac1c Mon Sep 17 00:00:00 2001 From: Giuseppe Lippolis Date: Mon, 1 Mar 2021 16:31:33 +0100 Subject: [PATCH 13/19] fixes invalid name of DirectProperty in Avalonia.Animation.Animation --- src/Avalonia.Animation/Animation.cs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/Avalonia.Animation/Animation.cs b/src/Avalonia.Animation/Animation.cs index ca1d97290e..05142532e9 100644 --- a/src/Avalonia.Animation/Animation.cs +++ b/src/Avalonia.Animation/Animation.cs @@ -22,7 +22,7 @@ namespace Avalonia.Animation /// public static readonly DirectProperty DurationProperty = AvaloniaProperty.RegisterDirect( - nameof(_duration), + nameof(Duration), o => o._duration, (o, v) => o._duration = v); @@ -31,7 +31,7 @@ namespace Avalonia.Animation /// public static readonly DirectProperty IterationCountProperty = AvaloniaProperty.RegisterDirect( - nameof(_iterationCount), + nameof(IterationCount), o => o._iterationCount, (o, v) => o._iterationCount = v); @@ -40,7 +40,7 @@ namespace Avalonia.Animation /// public static readonly DirectProperty PlaybackDirectionProperty = AvaloniaProperty.RegisterDirect( - nameof(_playbackDirection), + nameof(PlaybackDirection), o => o._playbackDirection, (o, v) => o._playbackDirection = v); @@ -49,7 +49,7 @@ namespace Avalonia.Animation /// public static readonly DirectProperty FillModeProperty = AvaloniaProperty.RegisterDirect( - nameof(_fillMode), + nameof(FillMode), o => o._fillMode, (o, v) => o._fillMode = v); @@ -58,7 +58,7 @@ namespace Avalonia.Animation /// public static readonly DirectProperty EasingProperty = AvaloniaProperty.RegisterDirect( - nameof(_easing), + nameof(Easing), o => o._easing, (o, v) => o._easing = v); @@ -67,7 +67,7 @@ namespace Avalonia.Animation /// public static readonly DirectProperty DelayProperty = AvaloniaProperty.RegisterDirect( - nameof(_delay), + nameof(Delay), o => o._delay, (o, v) => o._delay = v); @@ -76,7 +76,7 @@ namespace Avalonia.Animation /// public static readonly DirectProperty DelayBetweenIterationsProperty = AvaloniaProperty.RegisterDirect( - nameof(_delayBetweenIterations), + nameof(DelayBetweenIterations), o => o._delayBetweenIterations, (o, v) => o._delayBetweenIterations = v); @@ -85,7 +85,7 @@ namespace Avalonia.Animation /// public static readonly DirectProperty SpeedRatioProperty = AvaloniaProperty.RegisterDirect( - nameof(_speedRatio), + nameof(SpeedRatio), o => o._speedRatio, (o, v) => o._speedRatio = v, defaultBindingMode: BindingMode.TwoWay); From d8d6a47809c0b492c1ebcf66e545db85969153ea Mon Sep 17 00:00:00 2001 From: Dan Walmsley Date: Mon, 1 Mar 2021 15:43:39 +0000 Subject: [PATCH 14/19] make cell template the content of DataGridTemplateColumn saves a lot of bloat when decalring TemplatedColumns. --- src/Avalonia.Controls.DataGrid/DataGridTemplateColumn.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Avalonia.Controls.DataGrid/DataGridTemplateColumn.cs b/src/Avalonia.Controls.DataGrid/DataGridTemplateColumn.cs index e513a7b678..a93f5314c6 100644 --- a/src/Avalonia.Controls.DataGrid/DataGridTemplateColumn.cs +++ b/src/Avalonia.Controls.DataGrid/DataGridTemplateColumn.cs @@ -22,6 +22,7 @@ namespace Avalonia.Controls o => o.CellTemplate, (o, v) => o.CellTemplate = v); + [Content] public IDataTemplate CellTemplate { get { return _cellTemplate; } From 30a0be6ef51c24294bbd911b22a2df6e4879ee57 Mon Sep 17 00:00:00 2001 From: Dan Walmsley Date: Mon, 1 Mar 2021 18:26:29 +0000 Subject: [PATCH 15/19] missing using. --- src/Avalonia.Controls.DataGrid/DataGridTemplateColumn.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Avalonia.Controls.DataGrid/DataGridTemplateColumn.cs b/src/Avalonia.Controls.DataGrid/DataGridTemplateColumn.cs index a93f5314c6..7e95dd100c 100644 --- a/src/Avalonia.Controls.DataGrid/DataGridTemplateColumn.cs +++ b/src/Avalonia.Controls.DataGrid/DataGridTemplateColumn.cs @@ -8,6 +8,7 @@ using Avalonia.Controls.Utils; using Avalonia.Input; using Avalonia.Interactivity; using Avalonia.Media; +using Avalonia.Metadata; using Avalonia.Utilities; namespace Avalonia.Controls From 8f330b0b82334276f10ab97e935b280fb0329913 Mon Sep 17 00:00:00 2001 From: Yoh Deadfall Date: Tue, 2 Mar 2021 15:22:38 +0100 Subject: [PATCH 16/19] Return desired size as is without recreating it --- src/Avalonia.Layout/UniformGridLayout.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Avalonia.Layout/UniformGridLayout.cs b/src/Avalonia.Layout/UniformGridLayout.cs index 68f08d7cbb..6b147590ab 100644 --- a/src/Avalonia.Layout/UniformGridLayout.cs +++ b/src/Avalonia.Layout/UniformGridLayout.cs @@ -447,7 +447,7 @@ namespace Avalonia.Layout // and only use the layout when to clear it when it's done. gridState.EnsureFirstElementOwnership(context); - return new Size(desiredSize.Width, desiredSize.Height); + return desiredSize; } protected internal override Size ArrangeOverride(VirtualizingLayoutContext context, Size finalSize) From 111a9c80abc9f83bd267a1ef425394abf2eb605b Mon Sep 17 00:00:00 2001 From: Dan Walmsley Date: Tue, 2 Mar 2021 22:00:27 +0000 Subject: [PATCH 17/19] allow user to disable generation of default appmenu items on osx. --- native/Avalonia.Native/src/OSX/common.h | 2 + native/Avalonia.Native/src/OSX/main.mm | 17 ++++ native/Avalonia.Native/src/OSX/menu.mm | 85 ++++++++++--------- src/Avalonia.Native/AvaloniaNativePlatform.cs | 2 + .../AvaloniaNativePlatformExtensions.cs | 2 + src/Avalonia.Native/avn.idl | 1 + 6 files changed, 68 insertions(+), 41 deletions(-) diff --git a/native/Avalonia.Native/src/OSX/common.h b/native/Avalonia.Native/src/OSX/common.h index ea48a19874..05b2d762ae 100644 --- a/native/Avalonia.Native/src/OSX/common.h +++ b/native/Avalonia.Native/src/OSX/common.h @@ -28,6 +28,8 @@ extern IAvnNativeControlHost* CreateNativeControlHost(NSView* parent); extern void SetAppMenu (NSString* appName, IAvnMenu* appMenu); extern IAvnMenu* GetAppMenu (); extern NSMenuItem* GetAppMenuItem (); +extern void SetAutoGenerateDefaultAppMenuItems (bool enabled); +extern bool GetAutoGenerateDefaultAppMenuItems (); extern void InitializeAvnApp(); extern NSApplicationActivationPolicy AvnDesiredActivationPolicy; diff --git a/native/Avalonia.Native/src/OSX/main.mm b/native/Avalonia.Native/src/OSX/main.mm index 72f5aa0a7d..17746e1d1d 100644 --- a/native/Avalonia.Native/src/OSX/main.mm +++ b/native/Avalonia.Native/src/OSX/main.mm @@ -2,6 +2,7 @@ #define COM_GUIDS_MATERIALIZE #include "common.h" +static bool s_generateDefaultAppMenuItems = true; static NSString* s_appTitle = @"Avalonia"; // Copyright (c) 2011 The Chromium Authors. All rights reserved. @@ -122,6 +123,12 @@ public: ? NSApplicationActivationPolicyRegular : NSApplicationActivationPolicyAccessory; return S_OK; } + + virtual HRESULT SetDisableDefaultApplicationMenuItems (bool enabled) override + { + SetAutoGenerateDefaultAppMenuItems(!enabled); + return S_OK; + } }; /// See "Using POSIX Threads in a Cocoa Application" section here: @@ -310,3 +317,13 @@ CGFloat PrimaryDisplayHeight() { return NSMaxY([[[NSScreen screens] firstObject] frame]); } + +void SetAutoGenerateDefaultAppMenuItems (bool enabled) +{ + s_generateDefaultAppMenuItems = enabled; +} + +bool GetAutoGenerateDefaultAppMenuItems () +{ + return s_generateDefaultAppMenuItems; +} diff --git a/native/Avalonia.Native/src/OSX/menu.mm b/native/Avalonia.Native/src/OSX/menu.mm index 198b01714f..ea5cca9ce8 100644 --- a/native/Avalonia.Native/src/OSX/menu.mm +++ b/native/Avalonia.Native/src/OSX/menu.mm @@ -445,47 +445,50 @@ extern void SetAppMenu (NSString* appName, IAvnMenu* menu) auto appMenu = [s_appMenuItem submenu]; - [appMenu addItem:[NSMenuItem separatorItem]]; - - // Services item and menu - auto servicesItem = [[NSMenuItem alloc] init]; - servicesItem.title = @"Services"; - NSMenu *servicesMenu = [[NSMenu alloc] initWithTitle:@"Services"]; - servicesItem.submenu = servicesMenu; - [NSApplication sharedApplication].servicesMenu = servicesMenu; - [appMenu addItem:servicesItem]; - - [appMenu addItem:[NSMenuItem separatorItem]]; - - // Hide Application - auto hideItem = [[NSMenuItem alloc] initWithTitle:[@"Hide " stringByAppendingString:appName] action:@selector(hide:) keyEquivalent:@"h"]; - - [appMenu addItem:hideItem]; - - // Hide Others - auto hideAllOthersItem = [[NSMenuItem alloc] initWithTitle:@"Hide Others" - action:@selector(hideOtherApplications:) - keyEquivalent:@"h"]; - - hideAllOthersItem.keyEquivalentModifierMask = NSEventModifierFlagCommand | NSEventModifierFlagOption; - [appMenu addItem:hideAllOthersItem]; - - // Show All - auto showAllItem = [[NSMenuItem alloc] initWithTitle:@"Show All" - action:@selector(unhideAllApplications:) - keyEquivalent:@""]; - - [appMenu addItem:showAllItem]; - - [appMenu addItem:[NSMenuItem separatorItem]]; - - // Quit Application - auto quitItem = [[NSMenuItem alloc] init]; - quitItem.title = [@"Quit " stringByAppendingString:appName]; - quitItem.keyEquivalent = @"q"; - quitItem.target = [AvnWindow class]; - quitItem.action = @selector(closeAll); - [appMenu addItem:quitItem]; + if(GetAutoGenerateDefaultAppMenuItems()) + { + [appMenu addItem:[NSMenuItem separatorItem]]; + + // Services item and menu + auto servicesItem = [[NSMenuItem alloc] init]; + servicesItem.title = @"Services"; + NSMenu *servicesMenu = [[NSMenu alloc] initWithTitle:@"Services"]; + servicesItem.submenu = servicesMenu; + [NSApplication sharedApplication].servicesMenu = servicesMenu; + [appMenu addItem:servicesItem]; + + [appMenu addItem:[NSMenuItem separatorItem]]; + + // Hide Application + auto hideItem = [[NSMenuItem alloc] initWithTitle:[@"Hide " stringByAppendingString:appName] action:@selector(hide:) keyEquivalent:@"h"]; + + [appMenu addItem:hideItem]; + + // Hide Others + auto hideAllOthersItem = [[NSMenuItem alloc] initWithTitle:@"Hide Others" + action:@selector(hideOtherApplications:) + keyEquivalent:@"h"]; + + hideAllOthersItem.keyEquivalentModifierMask = NSEventModifierFlagCommand | NSEventModifierFlagOption; + [appMenu addItem:hideAllOthersItem]; + + // Show All + auto showAllItem = [[NSMenuItem alloc] initWithTitle:@"Show All" + action:@selector(unhideAllApplications:) + keyEquivalent:@""]; + + [appMenu addItem:showAllItem]; + + [appMenu addItem:[NSMenuItem separatorItem]]; + + // Quit Application + auto quitItem = [[NSMenuItem alloc] init]; + quitItem.title = [@"Quit " stringByAppendingString:appName]; + quitItem.keyEquivalent = @"q"; + quitItem.target = [AvnWindow class]; + quitItem.action = @selector(closeAll); + [appMenu addItem:quitItem]; + } } else { diff --git a/src/Avalonia.Native/AvaloniaNativePlatform.cs b/src/Avalonia.Native/AvaloniaNativePlatform.cs index edcbf90ebc..35d21a75d3 100644 --- a/src/Avalonia.Native/AvaloniaNativePlatform.cs +++ b/src/Avalonia.Native/AvaloniaNativePlatform.cs @@ -92,6 +92,8 @@ namespace Avalonia.Native var macOpts = AvaloniaLocator.Current.GetService(); _factory.MacOptions.SetShowInDock(macOpts?.ShowInDock != false ? 1 : 0); + _factory.MacOptions.SetDisableDefaultApplicationMenuItems( + macOpts?.DisableDefaultApplicationMenuItems == true ? 1 : 0); } AvaloniaLocator.CurrentMutable diff --git a/src/Avalonia.Native/AvaloniaNativePlatformExtensions.cs b/src/Avalonia.Native/AvaloniaNativePlatformExtensions.cs index 545659f813..76cb7a8057 100644 --- a/src/Avalonia.Native/AvaloniaNativePlatformExtensions.cs +++ b/src/Avalonia.Native/AvaloniaNativePlatformExtensions.cs @@ -38,5 +38,7 @@ namespace Avalonia public class MacOSPlatformOptions { public bool ShowInDock { get; set; } = true; + + public bool DisableDefaultApplicationMenuItems { get; set; } } } diff --git a/src/Avalonia.Native/avn.idl b/src/Avalonia.Native/avn.idl index 3627ff6894..57a0c32067 100644 --- a/src/Avalonia.Native/avn.idl +++ b/src/Avalonia.Native/avn.idl @@ -528,6 +528,7 @@ interface IAvnMacOptions : IUnknown { HRESULT SetShowInDock(int show); HRESULT SetApplicationTitle(char* utf8string); + HRESULT SetDisableDefaultApplicationMenuItems(bool enabled); } [uuid(04c1b049-1f43-418a-9159-cae627ec1367)] From f831b5d346897500ba1d03bb3a46249416ff7d0c Mon Sep 17 00:00:00 2001 From: Yoh Deadfall Date: Wed, 3 Mar 2021 18:19:20 +0100 Subject: [PATCH 18/19] Fixed parameter name in uniform grid state --- src/Avalonia.Layout/UniformGridLayoutState.cs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Avalonia.Layout/UniformGridLayoutState.cs b/src/Avalonia.Layout/UniformGridLayoutState.cs index 62c5174775..282bbab1a8 100644 --- a/src/Avalonia.Layout/UniformGridLayoutState.cs +++ b/src/Avalonia.Layout/UniformGridLayoutState.cs @@ -44,7 +44,7 @@ namespace Avalonia.Layout Size availableSize, VirtualizingLayoutContext context, double layoutItemWidth, - double LayoutItemHeight, + double layoutItemHeight, UniformGridLayoutItemsStretch stretch, Orientation orientation, double minRowSpacing, @@ -63,7 +63,7 @@ namespace Avalonia.Layout if (realizedElement != null) { realizedElement.Measure(availableSize); - SetSize(realizedElement, layoutItemWidth, LayoutItemHeight, availableSize, stretch, orientation, minRowSpacing, minColumnSpacing, maxItemsPerLine); + SetSize(realizedElement, layoutItemWidth, layoutItemHeight, availableSize, stretch, orientation, minRowSpacing, minColumnSpacing, maxItemsPerLine); _cachedFirstElement = null; } else @@ -78,7 +78,7 @@ namespace Avalonia.Layout _cachedFirstElement.Measure(availableSize); - SetSize(_cachedFirstElement, layoutItemWidth, LayoutItemHeight, availableSize, stretch, orientation, minRowSpacing, minColumnSpacing, maxItemsPerLine); + SetSize(_cachedFirstElement, layoutItemWidth, layoutItemHeight, availableSize, stretch, orientation, minRowSpacing, minColumnSpacing, maxItemsPerLine); // See if we can move ownership to the flow algorithm. If we can, we do not need a local cache. bool added = FlowAlgorithm.TryAddElement0(_cachedFirstElement); @@ -93,7 +93,7 @@ namespace Avalonia.Layout private void SetSize( ILayoutable element, double layoutItemWidth, - double LayoutItemHeight, + double layoutItemHeight, Size availableSize, UniformGridLayoutItemsStretch stretch, Orientation orientation, @@ -107,7 +107,7 @@ namespace Avalonia.Layout } EffectiveItemWidth = (double.IsNaN(layoutItemWidth) ? element.DesiredSize.Width : layoutItemWidth); - EffectiveItemHeight = (double.IsNaN(LayoutItemHeight) ? element.DesiredSize.Height : LayoutItemHeight); + EffectiveItemHeight = (double.IsNaN(layoutItemHeight) ? element.DesiredSize.Height : layoutItemHeight); var availableSizeMinor = orientation == Orientation.Horizontal ? availableSize.Width : availableSize.Height; var minorItemSpacing = orientation == Orientation.Vertical ? minRowSpacing : minColumnSpacing; From 7475354709e597bf21ea0cd6c0145016eefe45ac Mon Sep 17 00:00:00 2001 From: Dariusz Komosinski Date: Thu, 4 Mar 2021 10:37:41 +0100 Subject: [PATCH 19/19] Add more mono trickery --- .../ExpressionObserverBuilderTests_AttachedProperty.cs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/Avalonia.Markup.UnitTests/Parsers/ExpressionObserverBuilderTests_AttachedProperty.cs b/tests/Avalonia.Markup.UnitTests/Parsers/ExpressionObserverBuilderTests_AttachedProperty.cs index 7c48a975ef..e5e63b24d0 100644 --- a/tests/Avalonia.Markup.UnitTests/Parsers/ExpressionObserverBuilderTests_AttachedProperty.cs +++ b/tests/Avalonia.Markup.UnitTests/Parsers/ExpressionObserverBuilderTests_AttachedProperty.cs @@ -117,9 +117,11 @@ namespace Avalonia.Markup.UnitTests.Parsers var result = run(); result.Item1.Subscribe(x => { }); - GC.Collect(); + // Mono trickery + GC.Collect(2); GC.WaitForPendingFinalizers(); - GC.Collect(); + GC.WaitForPendingFinalizers(); + GC.Collect(2); Assert.Null(result.Item2.Target); }