Browse Source

Fix nullable errors after merge.

And remove now-unneeded `#nullable enable` statements.
pull/5177/head
Steven Kirk 4 years ago
parent
commit
b9f9d4d4b9
  1. 2
      src/Avalonia.Controls/Automation/AutomationPropertyChangedEventArgs.cs
  2. 2
      src/Avalonia.Controls/Automation/Peers/AutomationPeer.cs
  3. 2
      src/Avalonia.Controls/Automation/Peers/ButtonAutomationPeer.cs
  4. 4
      src/Avalonia.Controls/Automation/Peers/ComboBoxAutomationPeer.cs
  5. 2
      src/Avalonia.Controls/Automation/Peers/ContentControlAutomationPeer.cs
  6. 6
      src/Avalonia.Controls/Automation/Peers/ControlAutomationPeer.cs
  7. 2
      src/Avalonia.Controls/Automation/Peers/ItemsControlAutomationPeer.cs
  8. 2
      src/Avalonia.Controls/Automation/Peers/ListItemAutomationPeer.cs
  9. 2
      src/Avalonia.Controls/Automation/Peers/MenuItemAutomationPeer.cs
  10. 2
      src/Avalonia.Controls/Automation/Peers/NoneAutomationPeer.cs
  11. 4
      src/Avalonia.Controls/Automation/Peers/PopupAutomationPeer.cs
  12. 6
      src/Avalonia.Controls/Automation/Peers/PopupRootAutomationPeer.cs
  13. 4
      src/Avalonia.Controls/Automation/Peers/RangeBaseAutomationPeer.cs
  14. 2
      src/Avalonia.Controls/Automation/Peers/ScrollViewerAutomationPeer.cs
  15. 6
      src/Avalonia.Controls/Automation/Peers/SelectingItemsControlAutomationPeer.cs
  16. 2
      src/Avalonia.Controls/Automation/Peers/TextBlockAutomationPeer.cs
  17. 2
      src/Avalonia.Controls/Automation/Peers/TextBoxAutomationPeer.cs
  18. 2
      src/Avalonia.Controls/Automation/Peers/ToggleButtonAutomationPeer.cs
  19. 2
      src/Avalonia.Controls/Automation/Peers/UnrealizedElementAutomationPeer.cs
  20. 8
      src/Avalonia.Controls/Automation/Peers/WindowAutomationPeer.cs
  21. 18
      src/Avalonia.Controls/Automation/Peers/WindowBaseAutomationPeer.cs
  22. 4
      src/Avalonia.Controls/Automation/Provider/IRangeValueProvider.cs
  23. 2
      src/Avalonia.Controls/Automation/Provider/IRootProvider.cs
  24. 4
      src/Avalonia.Controls/Automation/Provider/ISelectionItemProvider .cs
  25. 4
      src/Avalonia.Controls/Automation/Provider/IValueProvider.cs

2
src/Avalonia.Controls/Automation/AutomationPropertyChangedEventArgs.cs

@ -1,7 +1,5 @@
using System;
#nullable enable
namespace Avalonia.Automation
{
public class AutomationPropertyChangedEventArgs : EventArgs

2
src/Avalonia.Controls/Automation/Peers/AutomationPeer.cs

@ -1,8 +1,6 @@
using System;
using System.Collections.Generic;
#nullable enable
namespace Avalonia.Automation.Peers
{
public enum AutomationControlType

2
src/Avalonia.Controls/Automation/Peers/ButtonAutomationPeer.cs

@ -1,8 +1,6 @@
using Avalonia.Automation.Provider;
using Avalonia.Controls;
#nullable enable
namespace Avalonia.Automation.Peers
{
public class ButtonAutomationPeer : ContentControlAutomationPeer,

4
src/Avalonia.Controls/Automation/Peers/ComboBoxAutomationPeer.cs

@ -3,8 +3,6 @@ using System.Collections.Generic;
using Avalonia.Automation.Provider;
using Avalonia.Controls;
#nullable enable
namespace Avalonia.Automation.Peers
{
public class ComboBoxAutomationPeer : SelectingItemsControlAutomationPeer,
@ -60,7 +58,7 @@ namespace Avalonia.Automation.Peers
return null;
}
protected override void OwnerPropertyChanged(object sender, AvaloniaPropertyChangedEventArgs e)
protected override void OwnerPropertyChanged(object? sender, AvaloniaPropertyChangedEventArgs e)
{
base.OwnerPropertyChanged(sender, e);

2
src/Avalonia.Controls/Automation/Peers/ContentControlAutomationPeer.cs

@ -1,7 +1,5 @@
using Avalonia.Controls;
#nullable enable
namespace Avalonia.Automation.Peers
{
public class ContentControlAutomationPeer : ControlAutomationPeer

6
src/Avalonia.Controls/Automation/Peers/ControlAutomationPeer.cs

@ -4,8 +4,6 @@ using System.Linq;
using Avalonia.Controls;
using Avalonia.VisualTree;
#nullable enable
namespace Avalonia.Automation.Peers
{
/// <summary>
@ -174,9 +172,9 @@ namespace Avalonia.Automation.Peers
visualChildren.CollectionChanged += VisualChildrenChanged;
}
private void VisualChildrenChanged(object sender, EventArgs e) => InvalidateChildren();
private void VisualChildrenChanged(object? sender, EventArgs e) => InvalidateChildren();
private void OwnerPropertyChanged(object sender, AvaloniaPropertyChangedEventArgs e)
private void OwnerPropertyChanged(object? sender, AvaloniaPropertyChangedEventArgs e)
{
if (e.Property == Visual.IsVisibleProperty)
{

2
src/Avalonia.Controls/Automation/Peers/ItemsControlAutomationPeer.cs

@ -1,8 +1,6 @@
using Avalonia.Automation.Provider;
using Avalonia.Controls;
#nullable enable
namespace Avalonia.Automation.Peers
{
public class ItemsControlAutomationPeer : ControlAutomationPeer, IScrollProvider

2
src/Avalonia.Controls/Automation/Peers/ListItemAutomationPeer.cs

@ -4,8 +4,6 @@ using Avalonia.Controls;
using Avalonia.Controls.Primitives;
using Avalonia.Controls.Selection;
#nullable enable
namespace Avalonia.Automation.Peers
{
public class ListItemAutomationPeer : ContentControlAutomationPeer,

2
src/Avalonia.Controls/Automation/Peers/MenuItemAutomationPeer.cs

@ -1,8 +1,6 @@
using Avalonia.Controls;
using Avalonia.Controls.Primitives;
#nullable enable
namespace Avalonia.Automation.Peers
{
public class MenuItemAutomationPeer : ControlAutomationPeer

2
src/Avalonia.Controls/Automation/Peers/NoneAutomationPeer.cs

@ -1,7 +1,5 @@
using Avalonia.Controls;
#nullable enable
namespace Avalonia.Automation.Peers
{
/// <summary>

4
src/Avalonia.Controls/Automation/Peers/PopupAutomationPeer.cs

@ -4,8 +4,6 @@ using Avalonia.Controls;
using Avalonia.Controls.Diagnostics;
using Avalonia.Controls.Primitives;
#nullable enable
namespace Avalonia.Automation.Peers
{
public class PopupAutomationPeer : ControlAutomationPeer
@ -26,7 +24,7 @@ namespace Avalonia.Automation.Peers
protected override bool IsContentElementCore() => false;
protected override bool IsControlElementCore() => false;
private void PopupOpenedClosed(object sender, EventArgs e)
private void PopupOpenedClosed(object? sender, EventArgs e)
{
// This is golden. We're following WPF's automation peer API here where the
// parent of a peer is set when another peer returns it as a child. We want to

6
src/Avalonia.Controls/Automation/Peers/PopupRootAutomationPeer.cs

@ -1,8 +1,6 @@
using System;
using Avalonia.Controls.Primitives;
#nullable enable
namespace Avalonia.Automation.Peers
{
public class PopupRootAutomationPeer : WindowBaseAutomationPeer
@ -27,13 +25,13 @@ namespace Avalonia.Automation.Peers
return parent;
}
private void OnOpened(object sender, EventArgs e)
private void OnOpened(object? sender, EventArgs e)
{
((PopupRoot)Owner).Opened -= OnOpened;
StartTrackingFocus();
}
private void OnClosed(object sender, EventArgs e)
private void OnClosed(object? sender, EventArgs e)
{
((PopupRoot)Owner).Closed -= OnClosed;
StopTrackingFocus();

4
src/Avalonia.Controls/Automation/Peers/RangeBaseAutomationPeer.cs

@ -1,8 +1,6 @@
using Avalonia.Automation.Provider;
using Avalonia.Controls.Primitives;
#nullable enable
namespace Avalonia.Automation.Peers
{
public abstract class RangeBaseAutomationPeer : ControlAutomationPeer, IRangeValueProvider
@ -23,7 +21,7 @@ namespace Avalonia.Automation.Peers
public void SetValue(double value) => Owner.Value = value;
protected virtual void OwnerPropertyChanged(object sender, AvaloniaPropertyChangedEventArgs e)
protected virtual void OwnerPropertyChanged(object? sender, AvaloniaPropertyChangedEventArgs e)
{
if (e.Property == RangeBase.MinimumProperty)
RaisePropertyChangedEvent(RangeValuePatternIdentifiers.MinimumProperty, e.OldValue, e.NewValue);

2
src/Avalonia.Controls/Automation/Peers/ScrollViewerAutomationPeer.cs

@ -3,8 +3,6 @@ using Avalonia.Automation.Provider;
using Avalonia.Controls;
using Avalonia.Utilities;
#nullable enable
namespace Avalonia.Automation.Peers
{
public class ScrollViewerAutomationPeer : ControlAutomationPeer, IScrollProvider

6
src/Avalonia.Controls/Automation/Peers/SelectingItemsControlAutomationPeer.cs

@ -6,8 +6,6 @@ using Avalonia.Controls.Primitives;
using Avalonia.Controls.Selection;
using Avalonia.VisualTree;
#nullable enable
namespace Avalonia.Automation.Peers
{
public abstract class SelectingItemsControlAutomationPeer : ItemsControlAutomationPeer,
@ -62,7 +60,7 @@ namespace Avalonia.Automation.Peers
return (Owner as SelectingItemsControl)?.GetValue(ListBox.SelectionModeProperty) ?? SelectionMode.Single;
}
protected virtual void OwnerPropertyChanged(object sender, AvaloniaPropertyChangedEventArgs e)
protected virtual void OwnerPropertyChanged(object? sender, AvaloniaPropertyChangedEventArgs e)
{
if (e.Property == ListBox.SelectionProperty)
{
@ -73,7 +71,7 @@ namespace Avalonia.Automation.Peers
}
}
protected virtual void OwnerSelectionChanged(object sender, SelectionModelSelectionChangedEventArgs e)
protected virtual void OwnerSelectionChanged(object? sender, SelectionModelSelectionChangedEventArgs e)
{
RaiseSelectionChanged();
}

2
src/Avalonia.Controls/Automation/Peers/TextBlockAutomationPeer.cs

@ -1,7 +1,5 @@
using Avalonia.Controls;
#nullable enable
namespace Avalonia.Automation.Peers
{
public class TextBlockAutomationPeer : ControlAutomationPeer

2
src/Avalonia.Controls/Automation/Peers/TextBoxAutomationPeer.cs

@ -1,8 +1,6 @@
using Avalonia.Automation.Provider;
using Avalonia.Controls;
#nullable enable
namespace Avalonia.Automation.Peers
{
public class TextBoxAutomationPeer : ControlAutomationPeer, IValueProvider

2
src/Avalonia.Controls/Automation/Peers/ToggleButtonAutomationPeer.cs

@ -1,8 +1,6 @@
using Avalonia.Automation.Provider;
using Avalonia.Controls.Primitives;
#nullable enable
namespace Avalonia.Automation.Peers
{
public class ToggleButtonAutomationPeer : ContentControlAutomationPeer, IToggleProvider

2
src/Avalonia.Controls/Automation/Peers/UnrealizedElementAutomationPeer.cs

@ -1,8 +1,6 @@
using System;
using System.Collections.Generic;
#nullable enable
namespace Avalonia.Automation.Peers
{
/// <summary>

8
src/Avalonia.Controls/Automation/Peers/WindowAutomationPeer.cs

@ -1,8 +1,6 @@
using System;
using Avalonia.Controls;
#nullable enable
namespace Avalonia.Automation.Peers
{
public class WindowAutomationPeer : WindowBaseAutomationPeer
@ -19,15 +17,15 @@ namespace Avalonia.Automation.Peers
public new Window Owner => (Window)base.Owner;
protected override string GetNameCore() => Owner.Title;
protected override string? GetNameCore() => Owner.Title;
private void OnOpened(object sender, EventArgs e)
private void OnOpened(object? sender, EventArgs e)
{
Owner.Opened -= OnOpened;
StartTrackingFocus();
}
private void OnClosed(object sender, EventArgs e)
private void OnClosed(object? sender, EventArgs e)
{
Owner.Closed -= OnClosed;
StopTrackingFocus();

18
src/Avalonia.Controls/Automation/Peers/WindowBaseAutomationPeer.cs

@ -6,8 +6,6 @@ using Avalonia.Input;
using Avalonia.Platform;
using Avalonia.VisualTree;
#nullable enable
namespace Avalonia.Automation.Peers
{
public class WindowBaseAutomationPeer : ControlAutomationPeer, IRootProvider
@ -20,7 +18,7 @@ namespace Avalonia.Automation.Peers
}
public new WindowBase Owner => (WindowBase)base.Owner;
public ITopLevelImpl PlatformImpl => Owner.PlatformImpl;
public ITopLevelImpl? PlatformImpl => Owner.PlatformImpl;
public event EventHandler? FocusChanged;
@ -39,13 +37,17 @@ namespace Avalonia.Automation.Peers
protected void StartTrackingFocus()
{
KeyboardDevice.Instance.PropertyChanged += KeyboardDevicePropertyChanged;
OnFocusChanged(KeyboardDevice.Instance.FocusedElement);
if (KeyboardDevice.Instance is not null)
{
KeyboardDevice.Instance.PropertyChanged += KeyboardDevicePropertyChanged;
OnFocusChanged(KeyboardDevice.Instance.FocusedElement);
}
}
protected void StopTrackingFocus()
{
KeyboardDevice.Instance.PropertyChanged -= KeyboardDevicePropertyChanged;
if (KeyboardDevice.Instance is not null)
KeyboardDevice.Instance.PropertyChanged -= KeyboardDevicePropertyChanged;
}
private void OnFocusChanged(IInputElement? focus)
@ -63,11 +65,11 @@ namespace Avalonia.Automation.Peers
}
}
private void KeyboardDevicePropertyChanged(object sender, PropertyChangedEventArgs e)
private void KeyboardDevicePropertyChanged(object? sender, PropertyChangedEventArgs e)
{
if (e.PropertyName == nameof(KeyboardDevice.FocusedElement))
{
OnFocusChanged(KeyboardDevice.Instance.FocusedElement);
OnFocusChanged(KeyboardDevice.Instance!.FocusedElement);
}
}
}

4
src/Avalonia.Controls/Automation/Provider/IRangeValueProvider.cs

@ -1,6 +1,4 @@
#nullable enable
namespace Avalonia.Automation.Provider
namespace Avalonia.Automation.Provider
{
/// <summary>
/// Exposes methods and properties to support access by a UI Automation client to controls

2
src/Avalonia.Controls/Automation/Provider/IRootProvider.cs

@ -2,8 +2,6 @@
using Avalonia.Automation.Peers;
using Avalonia.Platform;
#nullable enable
namespace Avalonia.Automation.Provider
{
public interface IRootProvider

4
src/Avalonia.Controls/Automation/Provider/ISelectionItemProvider .cs

@ -1,6 +1,4 @@
#nullable enable
namespace Avalonia.Automation.Provider
namespace Avalonia.Automation.Provider
{
/// <summary>
/// Exposes methods and properties to support access by a UI Automation client to individual,

4
src/Avalonia.Controls/Automation/Provider/IValueProvider.cs

@ -1,6 +1,4 @@
#nullable enable
namespace Avalonia.Automation.Provider
namespace Avalonia.Automation.Provider
{
/// <summary>
/// Exposes methods and properties to support access by a UI Automation client to controls

Loading…
Cancel
Save