Browse Source

Remove ColorSlider background disposal on attach/detach from visual tree

pull/9140/head
robloo 4 years ago
parent
commit
bc927d0312
  1. 8
      src/Avalonia.Controls.ColorPicker/ColorSlider/ColorSlider.cs

8
src/Avalonia.Controls.ColorPicker/ColorSlider/ColorSlider.cs

@ -45,20 +45,12 @@ namespace Avalonia.Controls.Primitives
protected override void OnAttachedToVisualTree(VisualTreeAttachmentEventArgs e) protected override void OnAttachedToVisualTree(VisualTreeAttachmentEventArgs e)
{ {
base.OnAttachedToVisualTree(e); base.OnAttachedToVisualTree(e);
// Bitmaps were released when detached from the visual tree so they must be re-built
UpdateBackground();
} }
/// <inheritdoc/> /// <inheritdoc/>
protected override void OnDetachedFromVisualTree(VisualTreeAttachmentEventArgs e) protected override void OnDetachedFromVisualTree(VisualTreeAttachmentEventArgs e)
{ {
base.OnDetachedFromVisualTree(e); base.OnDetachedFromVisualTree(e);
// Clean-up all bitmaps
// https://github.com/AvaloniaUI/Avalonia/issues/9051
_backgroundBitmap?.Dispose();
_backgroundBitmap = null;
} }
/// <summary> /// <summary>

Loading…
Cancel
Save