From bcc6cc196ca1b0d862ff70365406974acbcdd740 Mon Sep 17 00:00:00 2001 From: Dan Walmsley Date: Sat, 12 Nov 2016 22:17:00 +0000 Subject: [PATCH] Set TemplatedParentProperty null before calling update child so it doesnt end up seting the ItemsControls parent as the container.childs parent. Preventing it being removed from logical tree. --- src/Avalonia.Controls/ItemsControl.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Avalonia.Controls/ItemsControl.cs b/src/Avalonia.Controls/ItemsControl.cs index b8621fc30b..bf357edfd8 100644 --- a/src/Avalonia.Controls/ItemsControl.cs +++ b/src/Avalonia.Controls/ItemsControl.cs @@ -242,14 +242,14 @@ namespace Avalonia.Controls if (containerControl != null) { ((ISetLogicalParent)containerControl).SetParent(this); + containerControl.SetValue(TemplatedParentProperty, null); + containerControl.UpdateChild(); if (containerControl.Child is ILogical) { LogicalChildren.Add(containerControl.Child as ILogical); } - - containerControl.SetValue(TemplatedParentProperty, null); } else { @@ -286,6 +286,7 @@ namespace Avalonia.Controls if (containerControl != null && containerControl.Child is ILogical) { toRemove.Add(containerControl.Child as ILogical); + ((ISetLogicalParent)containerControl).SetParent(null); } else {