Browse Source

Merge branch 'master' into feature-devtool-search-regex

pull/4529/head
danwalmsley 6 years ago
committed by GitHub
parent
commit
c23f6aa9cd
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 1
      src/Avalonia.Controls.DataGrid/Themes/Default.xaml
  2. 2
      src/Avalonia.Controls/ToolTip.cs
  3. 7
      src/Avalonia.Controls/ToolTipService.cs
  4. 2
      src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs
  5. 29
      tests/Avalonia.Controls.UnitTests/ToolTipTests.cs

1
src/Avalonia.Controls.DataGrid/Themes/Default.xaml

@ -201,7 +201,6 @@
<Setter Property="HorizontalScrollBarVisibility" Value="Auto" />
<Setter Property="VerticalScrollBarVisibility" Value="Auto" />
<Setter Property="SelectionMode" Value="Extended" />
<Setter Property="GridLinesVisibility" Value="Vertical" />
<Setter Property="HorizontalGridLinesBrush" Value="{DynamicResource ThemeBorderHighColor}" />
<Setter Property="VerticalGridLinesBrush" Value="{DynamicResource ThemeBorderHighColor}" />
<Setter Property="BorderBrush" Value="{DynamicResource ThemeBorderLowColor}"/>

2
src/Avalonia.Controls/ToolTip.cs

@ -55,7 +55,7 @@ namespace Avalonia.Controls
/// <summary>
/// Stores the current <see cref="ToolTip"/> instance in the control.
/// </summary>
private static readonly AttachedProperty<ToolTip> ToolTipProperty =
internal static readonly AttachedProperty<ToolTip> ToolTipProperty =
AvaloniaProperty.RegisterAttached<ToolTip, Control, ToolTip>("ToolTip");
private IPopupHost _popup;

7
src/Avalonia.Controls/ToolTipService.cs

@ -35,6 +35,13 @@ namespace Avalonia.Controls
control.PointerEnter += ControlPointerEnter;
control.PointerLeave += ControlPointerLeave;
}
if (ToolTip.GetIsOpen(control) && e.NewValue != e.OldValue && !(e.NewValue is ToolTip))
{
var tip = control.GetValue(ToolTip.ToolTipProperty);
tip.Content = e.NewValue;
}
}
internal void TipOpenChanged(AvaloniaPropertyChangedEventArgs e)

2
src/Avalonia.Diagnostics/Diagnostics/ViewModels/ControlDetailsViewModel.cs

@ -71,7 +71,7 @@ namespace Avalonia.Diagnostics.ViewModels
if (o is AvaloniaObject ao)
{
return AvaloniaPropertyRegistry.Instance.GetRegistered(ao)
.Concat(AvaloniaPropertyRegistry.Instance.GetRegisteredAttached(ao.GetType()))
.Union(AvaloniaPropertyRegistry.Instance.GetRegisteredAttached(ao.GetType()))
.Select(x => new AvaloniaPropertyViewModel(ao, x));
}
else

29
tests/Avalonia.Controls.UnitTests/ToolTipTests.cs

@ -124,6 +124,35 @@ namespace Avalonia.Controls.UnitTests
Assert.True(ToolTip.GetIsOpen(target));
}
}
[Fact]
public void Content_Should_Update_When_Tip_Property_Changes_And_Already_Open()
{
using (UnitTestApplication.Start(TestServices.StyledWindow))
{
var window = new Window();
var target = new Decorator()
{
[ToolTip.TipProperty] = "Tip",
[ToolTip.ShowDelayProperty] = 0
};
window.Content = target;
window.ApplyTemplate();
window.Presenter.ApplyTemplate();
_mouseHelper.Enter(target);
Assert.True(ToolTip.GetIsOpen(target));
Assert.Equal("Tip", target.GetValue(ToolTip.ToolTipProperty).Content);
ToolTip.SetTip(target, "Tip1");
Assert.Equal("Tip1", target.GetValue(ToolTip.ToolTipProperty).Content);
}
}
[Fact]
public void Should_Open_On_Pointer_Enter_With_Delay()

Loading…
Cancel
Save