Browse Source

Merge pull request #2347 from MarchingCube/feature/tree-view-selection

Tree view multiple selection support
pull/2366/head
Steven Kirk 8 years ago
committed by GitHub
parent
commit
c5e4089f79
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 3
      .editorconfig
  2. 2
      samples/ControlCatalog/Pages/TreeViewPage.xaml
  3. 42
      src/Avalonia.Controls/Primitives/SelectingItemsControl.cs
  4. 530
      src/Avalonia.Controls/TreeView.cs
  5. 258
      tests/Avalonia.Controls.UnitTests/TreeViewTests.cs

3
.editorconfig

@ -132,6 +132,9 @@ csharp_space_between_method_declaration_parameter_list_parentheses = false
csharp_space_between_parentheses = false csharp_space_between_parentheses = false
csharp_space_between_square_brackets = false csharp_space_between_square_brackets = false
# Wrapping preferences
csharp_wrap_before_ternary_opsigns = false
# Xaml files # Xaml files
[*.xaml] [*.xaml]
indent_size = 4 indent_size = 4

2
samples/ControlCatalog/Pages/TreeViewPage.xaml

@ -9,7 +9,7 @@
Margin="0,16,0,0" Margin="0,16,0,0"
HorizontalAlignment="Center" HorizontalAlignment="Center"
Spacing="16"> Spacing="16">
<TreeView Items="{Binding}" Width="250" Height="350"> <TreeView SelectionMode="Multiple" Items="{Binding}" Width="250" Height="350">
<TreeView.ItemTemplate> <TreeView.ItemTemplate>
<TreeDataTemplate ItemsSource="{Binding Children}"> <TreeDataTemplate ItemsSource="{Binding Children}">
<TextBlock Text="{Binding Header}"/> <TextBlock Text="{Binding Header}"/>

42
src/Avalonia.Controls/Primitives/SelectingItemsControl.cs

@ -614,32 +614,12 @@ namespace Avalonia.Controls.Primitives
return false; return false;
} }
/// <summary>
/// Gets a range of items from an IEnumerable.
/// </summary>
/// <param name="items">The items.</param>
/// <param name="first">The index of the first item.</param>
/// <param name="last">The index of the last item.</param>
/// <returns>The items.</returns>
private static IEnumerable<object> GetRange(IEnumerable items, int first, int last)
{
var list = (items as IList) ?? items.Cast<object>().ToList();
int step = first > last ? -1 : 1;
for (int i = first; i != last; i += step)
{
yield return list[i];
}
yield return list[last];
}
/// <summary> /// <summary>
/// Makes a list of objects equal another. /// Makes a list of objects equal another.
/// </summary> /// </summary>
/// <param name="items">The items collection.</param> /// <param name="items">The items collection.</param>
/// <param name="desired">The desired items.</param> /// <param name="desired">The desired items.</param>
private static void SynchronizeItems(IList items, IEnumerable<object> desired) internal static void SynchronizeItems(IList items, IEnumerable<object> desired)
{ {
int index = 0; int index = 0;
@ -666,6 +646,26 @@ namespace Avalonia.Controls.Primitives
} }
} }
/// <summary>
/// Gets a range of items from an IEnumerable.
/// </summary>
/// <param name="items">The items.</param>
/// <param name="first">The index of the first item.</param>
/// <param name="last">The index of the last item.</param>
/// <returns>The items.</returns>
private static IEnumerable<object> GetRange(IEnumerable items, int first, int last)
{
var list = (items as IList) ?? items.Cast<object>().ToList();
int step = first > last ? -1 : 1;
for (int i = first; i != last; i += step)
{
yield return list[i];
}
yield return list[last];
}
/// <summary> /// <summary>
/// Called when a container raises the <see cref="IsSelectedChangedEvent"/>. /// Called when a container raises the <see cref="IsSelectedChangedEvent"/>.
/// </summary> /// </summary>

530
src/Avalonia.Controls/TreeView.cs

@ -2,13 +2,15 @@
// Licensed under the MIT license. See licence.md file in the project root for full license information. // Licensed under the MIT license. See licence.md file in the project root for full license information.
using System; using System;
using System.Collections;
using System.Collections.Generic; using System.Collections.Generic;
using System.Collections.Specialized;
using System.Linq; using System.Linq;
using Avalonia.Collections;
using Avalonia.Controls.Generators; using Avalonia.Controls.Generators;
using Avalonia.Controls.Primitives; using Avalonia.Controls.Primitives;
using Avalonia.Input; using Avalonia.Input;
using Avalonia.Interactivity; using Avalonia.Interactivity;
using Avalonia.Styling;
using Avalonia.Threading; using Avalonia.Threading;
using Avalonia.VisualTree; using Avalonia.VisualTree;
@ -34,14 +36,24 @@ namespace Avalonia.Controls
(o, v) => o.SelectedItem = v); (o, v) => o.SelectedItem = v);
/// <summary> /// <summary>
/// Defines the <see cref="SelectedItemChanged"/> event. /// Defines the <see cref="SelectedItems"/> property.
/// </summary> /// </summary>
public static readonly RoutedEvent<SelectionChangedEventArgs> SelectedItemChangedEvent = public static readonly DirectProperty<TreeView, IList> SelectedItemsProperty =
RoutedEvent.Register<TreeView, SelectionChangedEventArgs>( AvaloniaProperty.RegisterDirect<TreeView, IList>(
"SelectedItemChanged", nameof(SelectedItems),
RoutingStrategies.Bubble); o => o.SelectedItems,
(o, v) => o.SelectedItems = v);
/// <summary>
/// Defines the <see cref="SelectionMode"/> property.
/// </summary>
protected static readonly StyledProperty<SelectionMode> SelectionModeProperty =
AvaloniaProperty.Register<SelectingItemsControl, SelectionMode>(
nameof(SelectionMode));
private static readonly IList Empty = new object[0];
private object _selectedItem; private object _selectedItem;
private IList _selectedItems;
/// <summary> /// <summary>
/// Initializes static members of the <see cref="TreeView"/> class. /// Initializes static members of the <see cref="TreeView"/> class.
@ -54,16 +66,16 @@ namespace Avalonia.Controls
/// <summary> /// <summary>
/// Occurs when the control's selection changes. /// Occurs when the control's selection changes.
/// </summary> /// </summary>
public event EventHandler<SelectionChangedEventArgs> SelectedItemChanged public event EventHandler<SelectionChangedEventArgs> SelectionChanged
{ {
add { AddHandler(SelectedItemChangedEvent, value); } add => AddHandler(SelectingItemsControl.SelectionChangedEvent, value);
remove { RemoveHandler(SelectedItemChangedEvent, value); } remove => RemoveHandler(SelectingItemsControl.SelectionChangedEvent, value);
} }
/// <summary> /// <summary>
/// Gets the <see cref="ITreeItemContainerGenerator"/> for the tree view. /// Gets the <see cref="ITreeItemContainerGenerator"/> for the tree view.
/// </summary> /// </summary>
public new ITreeItemContainerGenerator ItemContainerGenerator => public new ITreeItemContainerGenerator ItemContainerGenerator =>
(ITreeItemContainerGenerator)base.ItemContainerGenerator; (ITreeItemContainerGenerator)base.ItemContainerGenerator;
/// <summary> /// <summary>
@ -71,67 +83,258 @@ namespace Avalonia.Controls
/// </summary> /// </summary>
public bool AutoScrollToSelectedItem public bool AutoScrollToSelectedItem
{ {
get { return GetValue(AutoScrollToSelectedItemProperty); } get => GetValue(AutoScrollToSelectedItemProperty);
set { SetValue(AutoScrollToSelectedItemProperty, value); } set => SetValue(AutoScrollToSelectedItemProperty, value);
}
private bool _syncingSelectedItems;
/// <summary>
/// Gets or sets the selection mode.
/// </summary>
public SelectionMode SelectionMode
{
get => GetValue(SelectionModeProperty);
set => SetValue(SelectionModeProperty, value);
} }
/// <summary> /// <summary>
/// Gets or sets the selected item. /// Gets or sets the selected item.
/// </summary> /// </summary>
public object SelectedItem public object SelectedItem
{
get => _selectedItem;
set
{
SetAndRaise(SelectedItemProperty, ref _selectedItem,
(object val, ref object backing, Action<Action> notifyWrapper) =>
{
var old = backing;
backing = val;
notifyWrapper(() =>
RaisePropertyChanged(
SelectedItemProperty,
old,
val));
if (val != null)
{
if (SelectedItems.Count != 1 || SelectedItems[0] != val)
{
_syncingSelectedItems = true;
SelectSingleItem(val);
_syncingSelectedItems = false;
}
}
else if (SelectedItems.Count > 0)
{
SelectedItems.Clear();
}
}, value);
}
}
/// <summary>
/// Gets the selected items.
/// </summary>
public IList SelectedItems
{ {
get get
{ {
return _selectedItem; if (_selectedItems == null)
{
_selectedItems = new AvaloniaList<object>();
SubscribeToSelectedItems();
}
return _selectedItems;
} }
set set
{ {
if (_selectedItem != null) if (value?.IsFixedSize == true || value?.IsReadOnly == true)
{ {
var container = ItemContainerGenerator.Index.ContainerFromItem(_selectedItem); throw new NotSupportedException(
MarkContainerSelected(container, false); "Cannot use a fixed size or read-only collection as SelectedItems.");
} }
var oldItem = _selectedItem; UnsubscribeFromSelectedItems();
SetAndRaise(SelectedItemProperty, ref _selectedItem, value); _selectedItems = value ?? new AvaloniaList<object>();
SubscribeToSelectedItems();
}
}
if (_selectedItem != null) /// <summary>
{ /// Subscribes to the <see cref="SelectedItems"/> CollectionChanged event, if any.
var container = ItemContainerGenerator.Index.ContainerFromItem(_selectedItem); /// </summary>
MarkContainerSelected(container, true); private void SubscribeToSelectedItems()
{
if (_selectedItems is INotifyCollectionChanged incc)
{
incc.CollectionChanged += SelectedItemsCollectionChanged;
}
SelectedItemsCollectionChanged(
_selectedItems,
new NotifyCollectionChangedEventArgs(NotifyCollectionChangedAction.Reset));
}
if (AutoScrollToSelectedItem && container != null) private void SelectSingleItem(object item)
{
SelectedItems.Clear();
SelectedItems.Add(item);
}
/// <summary>
/// Called when the <see cref="SelectedItems"/> CollectionChanged event is raised.
/// </summary>
/// <param name="sender">The event sender.</param>
/// <param name="e">The event args.</param>
private void SelectedItemsCollectionChanged(object sender, NotifyCollectionChangedEventArgs e)
{
IList added = null;
IList removed = null;
switch (e.Action)
{
case NotifyCollectionChangedAction.Add:
SelectedItemsAdded(e.NewItems.Cast<object>().ToArray());
if (AutoScrollToSelectedItem)
{ {
container.BringIntoView(); var container = (TreeViewItem)ItemContainerGenerator.Index.ContainerFromItem(e.NewItems[0]);
container?.BringIntoView();
} }
}
if (oldItem != _selectedItem) added = e.NewItems;
{
// Fire the SelectionChanged event break;
List<object> removed = new List<object>(); case NotifyCollectionChangedAction.Remove:
if (oldItem != null)
if (!_syncingSelectedItems)
{
if (SelectedItems.Count == 0)
{
SelectedItem = null;
}
else
{
var selectedIndex = SelectedItems.IndexOf(_selectedItem);
if (selectedIndex == -1)
{
var old = _selectedItem;
_selectedItem = SelectedItems[0];
RaisePropertyChanged(SelectedItemProperty, old, _selectedItem);
}
}
}
foreach (var item in e.OldItems)
{ {
removed.Add(oldItem); MarkItemSelected(item, false);
} }
List<object> added = new List<object>(); removed = e.OldItems;
if (_selectedItem != null)
break;
case NotifyCollectionChangedAction.Reset:
foreach (IControl container in ItemContainerGenerator.Index.Items)
{ {
added.Add(_selectedItem); MarkContainerSelected(container, false);
} }
var changed = new SelectionChangedEventArgs( if (SelectedItems.Count > 0)
SelectedItemChangedEvent, {
added, SelectedItemsAdded(SelectedItems);
removed);
RaiseEvent(changed); added = SelectedItems;
} }
else if (!_syncingSelectedItems)
{
SelectedItem = null;
}
break;
case NotifyCollectionChangedAction.Replace:
foreach (var item in e.OldItems)
{
MarkItemSelected(item, false);
}
foreach (var item in e.NewItems)
{
MarkItemSelected(item, true);
}
if (SelectedItem != SelectedItems[0] && !_syncingSelectedItems)
{
var oldItem = SelectedItem;
var item = SelectedItems[0];
_selectedItem = item;
RaisePropertyChanged(SelectedItemProperty, oldItem, item);
}
added = e.NewItems;
removed = e.OldItems;
break;
} }
if (added?.Count > 0 || removed?.Count > 0)
{
var changed = new SelectionChangedEventArgs(
SelectingItemsControl.SelectionChangedEvent,
added ?? Empty,
removed ?? Empty);
RaiseEvent(changed);
}
}
private void MarkItemSelected(object item, bool selected)
{
var container = ItemContainerGenerator.Index.ContainerFromItem(item);
MarkContainerSelected(container, selected);
} }
(bool handled, IInputElement next) ICustomKeyboardNavigation.GetNext(IInputElement element, NavigationDirection direction) private void SelectedItemsAdded(IList items)
{
if (items.Count == 0)
{
return;
}
foreach (object item in items)
{
MarkItemSelected(item, true);
}
if (SelectedItem == null && !_syncingSelectedItems)
{
SetAndRaise(SelectedItemProperty, ref _selectedItem, items[0]);
}
}
/// <summary>
/// Unsubscribes from the <see cref="SelectedItems"/> CollectionChanged event, if any.
/// </summary>
private void UnsubscribeFromSelectedItems()
{
if (_selectedItems is INotifyCollectionChanged incc)
{
incc.CollectionChanged -= SelectedItemsCollectionChanged;
}
}
(bool handled, IInputElement next) ICustomKeyboardNavigation.GetNext(IInputElement element,
NavigationDirection direction)
{ {
if (direction == NavigationDirection.Next || direction == NavigationDirection.Previous) if (direction == NavigationDirection.Next || direction == NavigationDirection.Previous)
{ {
@ -142,10 +345,8 @@ namespace Avalonia.Controls
ItemContainerGenerator.ContainerFromIndex(0); ItemContainerGenerator.ContainerFromIndex(0);
return (true, result); return (true, result);
} }
else
{ return (true, null);
return (true, null);
}
} }
return (false, null); return (false, null);
@ -186,7 +387,7 @@ namespace Avalonia.Controls
if (SelectedItem != null) if (SelectedItem != null)
{ {
var next = GetContainerInDirection( var next = GetContainerInDirection(
GetContainerFromEventSource(e.Source) as TreeViewItem, GetContainerFromEventSource(e.Source),
direction.Value, direction.Value,
true); true);
@ -208,17 +409,9 @@ namespace Avalonia.Controls
NavigationDirection direction, NavigationDirection direction,
bool intoChildren) bool intoChildren)
{ {
IItemContainerGenerator parentGenerator; IItemContainerGenerator parentGenerator = GetParentContainerGenerator(from);
if (from?.Parent is TreeView treeView) if (parentGenerator == null)
{
parentGenerator = treeView.ItemContainerGenerator;
}
else if (from?.Parent is TreeViewItem item)
{
parentGenerator = item.ItemContainerGenerator;
}
else
{ {
return null; return null;
} }
@ -257,6 +450,7 @@ namespace Avalonia.Controls
{ {
return GetContainerInDirection(parentItem, direction, false); return GetContainerInDirection(parentItem, direction, false);
} }
break; break;
} }
@ -293,20 +487,184 @@ namespace Avalonia.Controls
{ {
var item = ItemContainerGenerator.Index.ItemFromContainer(container); var item = ItemContainerGenerator.Index.ItemFromContainer(container);
if (item != null) if (item == null)
{ {
if (SelectedItem != null) return;
}
IControl selectedContainer = null;
if (SelectedItem != null)
{
selectedContainer = ItemContainerGenerator.Index.ContainerFromItem(SelectedItem);
}
var mode = SelectionMode;
var toggle = toggleModifier || (mode & SelectionMode.Toggle) != 0;
var multi = (mode & SelectionMode.Multiple) != 0;
var range = multi && selectedContainer != null && rangeModifier;
if (!toggle && !range)
{
SelectSingleItem(item);
}
else if (multi && range)
{
SelectingItemsControl.SynchronizeItems(
SelectedItems,
GetItemsInRange(selectedContainer as TreeViewItem, container as TreeViewItem));
}
else
{
var i = SelectedItems.IndexOf(item);
if (i != -1)
{ {
var old = ItemContainerGenerator.Index.ContainerFromItem(SelectedItem); SelectedItems.Remove(item);
MarkContainerSelected(old, false);
} }
else
{
if (multi)
{
SelectedItems.Add(item);
}
else
{
SelectedItem = item;
}
}
}
}
SelectedItem = item; private static IItemContainerGenerator GetParentContainerGenerator(TreeViewItem item)
{
if (item == null)
{
return null;
}
MarkContainerSelected(container, true); switch (item.Parent)
{
case TreeView treeView:
return treeView.ItemContainerGenerator;
case TreeViewItem treeViewItem:
return treeViewItem.ItemContainerGenerator;
default:
return null;
} }
} }
/// <summary>
/// Find which node is first in hierarchy.
/// </summary>
/// <param name="treeView">Search root.</param>
/// <param name="nodeA">Nodes to find.</param>
/// <param name="nodeB">Node to find.</param>
/// <returns>Found first node.</returns>
private static TreeViewItem FindFirstNode(TreeView treeView, TreeViewItem nodeA, TreeViewItem nodeB)
{
return FindInContainers(treeView.ItemContainerGenerator, nodeA, nodeB);
}
private static TreeViewItem FindInContainers(ITreeItemContainerGenerator containerGenerator,
TreeViewItem nodeA,
TreeViewItem nodeB)
{
IEnumerable<ItemContainerInfo> containers = containerGenerator.Containers;
foreach (ItemContainerInfo container in containers)
{
TreeViewItem node = FindFirstNode(container.ContainerControl as TreeViewItem, nodeA, nodeB);
if (node != null)
{
return node;
}
}
return null;
}
private static TreeViewItem FindFirstNode(TreeViewItem node, TreeViewItem nodeA, TreeViewItem nodeB)
{
if (node == null)
{
return null;
}
TreeViewItem match = node == nodeA ? nodeA : node == nodeB ? nodeB : null;
if (match != null)
{
return match;
}
return FindInContainers(node.ItemContainerGenerator, nodeA, nodeB);
}
/// <summary>
/// Returns all items that belong to containers between <paramref name="from"/> and <paramref name="to"/>.
/// The range is inclusive.
/// </summary>
/// <param name="from">From container.</param>
/// <param name="to">To container.</param>
private List<object> GetItemsInRange(TreeViewItem from, TreeViewItem to)
{
var items = new List<object>();
if (from == null || to == null)
{
return items;
}
TreeViewItem firstItem = FindFirstNode(this, from, to);
if (firstItem == null)
{
return items;
}
bool wasReversed = false;
if (firstItem == to)
{
var temp = from;
from = to;
to = temp;
wasReversed = true;
}
TreeViewItem node = from;
while (node != to)
{
var item = ItemContainerGenerator.Index.ItemFromContainer(node);
if (item != null)
{
items.Add(item);
}
node = GetContainerInDirection(node, NavigationDirection.Down, true);
}
var toItem = ItemContainerGenerator.Index.ItemFromContainer(to);
if (toItem != null)
{
items.Add(toItem);
}
if (wasReversed)
{
items.Reverse();
}
return items;
}
/// <summary> /// <summary>
/// Updates the selection based on an event that may have originated in a container that /// Updates the selection based on an event that may have originated in a container that
/// belongs to the control. /// belongs to the control.
@ -341,7 +699,7 @@ namespace Avalonia.Controls
/// </summary> /// </summary>
/// <param name="eventSource">The control that raised the event.</param> /// <param name="eventSource">The control that raised the event.</param>
/// <returns>The container or null if the event did not originate in a container.</returns> /// <returns>The container or null if the event did not originate in a container.</returns>
protected IControl GetContainerFromEventSource(IInteractive eventSource) protected TreeViewItem GetContainerFromEventSource(IInteractive eventSource)
{ {
var item = ((IVisual)eventSource).GetSelfAndVisualAncestors() var item = ((IVisual)eventSource).GetSelfAndVisualAncestors()
.OfType<TreeViewItem>() .OfType<TreeViewItem>()
@ -349,7 +707,7 @@ namespace Avalonia.Controls
if (item != null) if (item != null)
{ {
if (item.ItemContainerGenerator.Index == this.ItemContainerGenerator.Index) if (item.ItemContainerGenerator.Index == ItemContainerGenerator.Index)
{ {
return item; return item;
} }
@ -367,21 +725,23 @@ namespace Avalonia.Controls
{ {
var selectedItem = SelectedItem; var selectedItem = SelectedItem;
if (selectedItem != null) if (selectedItem == null)
{ {
foreach (var container in e.Containers) return;
{ }
if (container.Item == selectedItem)
{
((TreeViewItem)container.ContainerControl).IsSelected = true;
if (AutoScrollToSelectedItem) foreach (var container in e.Containers)
{ {
Dispatcher.UIThread.Post(container.ContainerControl.BringIntoView); if (container.Item == selectedItem)
} {
((TreeViewItem)container.ContainerControl).IsSelected = true;
break; if (AutoScrollToSelectedItem)
{
Dispatcher.UIThread.Post(container.ContainerControl.BringIntoView);
} }
break;
} }
} }
} }
@ -393,18 +753,18 @@ namespace Avalonia.Controls
/// <param name="selected">Whether the control is selected</param> /// <param name="selected">Whether the control is selected</param>
private void MarkContainerSelected(IControl container, bool selected) private void MarkContainerSelected(IControl container, bool selected)
{ {
if (container != null) if (container == null)
{ {
var selectable = container as ISelectable; return;
}
if (selectable != null) if (container is ISelectable selectable)
{ {
selectable.IsSelected = selected; selectable.IsSelected = selected;
} }
else else
{ {
((IPseudoClasses)container.Classes).Set(":selected", selected); container.Classes.Set(":selected", selected);
}
} }
} }
} }

258
tests/Avalonia.Controls.UnitTests/TreeViewTests.cs

@ -11,7 +11,6 @@ using Avalonia.Data;
using Avalonia.Data.Core; using Avalonia.Data.Core;
using Avalonia.Input; using Avalonia.Input;
using Avalonia.LogicalTree; using Avalonia.LogicalTree;
using Avalonia.Markup.Data;
using Avalonia.UnitTests; using Avalonia.UnitTests;
using Xunit; using Xunit;
@ -140,6 +139,235 @@ namespace Avalonia.Controls.UnitTests
Assert.True(container.IsSelected); Assert.True(container.IsSelected);
} }
[Fact]
public void Clicking_WithControlModifier_Selected_Item_Should_Deselect_It()
{
var tree = CreateTestTreeData();
var target = new TreeView
{
Template = CreateTreeViewTemplate(),
Items = tree
};
var visualRoot = new TestRoot();
visualRoot.Child = target;
CreateNodeDataTemplate(target);
ApplyTemplates(target);
var item = tree[0].Children[1].Children[0];
var container = (TreeViewItem)target.ItemContainerGenerator.Index.ContainerFromItem(item);
Assert.NotNull(container);
target.SelectedItem = item;
Assert.True(container.IsSelected);
container.RaiseEvent(new PointerPressedEventArgs
{
RoutedEvent = InputElement.PointerPressedEvent,
MouseButton = MouseButton.Left,
InputModifiers = InputModifiers.Control
});
Assert.Null(target.SelectedItem);
Assert.False(container.IsSelected);
}
[Fact]
public void Clicking_WithControlModifier_Not_Selected_Item_Should_Select_It()
{
var tree = CreateTestTreeData();
var target = new TreeView
{
Template = CreateTreeViewTemplate(),
Items = tree
};
var visualRoot = new TestRoot();
visualRoot.Child = target;
CreateNodeDataTemplate(target);
ApplyTemplates(target);
var item1 = tree[0].Children[1].Children[0];
var container1 = (TreeViewItem)target.ItemContainerGenerator.Index.ContainerFromItem(item1);
var item2 = tree[0].Children[1];
var container2 = (TreeViewItem)target.ItemContainerGenerator.Index.ContainerFromItem(item2);
Assert.NotNull(container1);
Assert.NotNull(container2);
target.SelectedItem = item1;
Assert.True(container1.IsSelected);
container2.RaiseEvent(new PointerPressedEventArgs
{
RoutedEvent = InputElement.PointerPressedEvent,
MouseButton = MouseButton.Left,
InputModifiers = InputModifiers.Control
});
Assert.Equal(item2, target.SelectedItem);
Assert.False(container1.IsSelected);
Assert.True(container2.IsSelected);
}
[Fact]
public void Clicking_WithControlModifier_Selected_Item_Should_Deselect_And_Remove_From_SelectedItems()
{
var tree = CreateTestTreeData();
var target = new TreeView
{
Template = CreateTreeViewTemplate(),
Items = tree,
SelectionMode = SelectionMode.Multiple
};
var visualRoot = new TestRoot();
visualRoot.Child = target;
CreateNodeDataTemplate(target);
ApplyTemplates(target);
var rootNode = tree[0];
var item1 = rootNode.Children[0];
var item2 = rootNode.Children.Last();
var item1Container = (TreeViewItem)target.ItemContainerGenerator.Index.ContainerFromItem(item1);
var item2Container = (TreeViewItem)target.ItemContainerGenerator.Index.ContainerFromItem(item2);
TreeTestHelper.ClickContainer(item1Container, InputModifiers.Control);
Assert.True(item1Container.IsSelected);
TreeTestHelper.ClickContainer(item2Container, InputModifiers.Control);
Assert.True(item2Container.IsSelected);
Assert.Equal(new[] {item1, item2}, target.SelectedItems.OfType<Node>());
TreeTestHelper.ClickContainer(item1Container, InputModifiers.Control);
Assert.False(item1Container.IsSelected);
Assert.DoesNotContain(item1, target.SelectedItems.OfType<Node>());
}
[Fact]
public void Clicking_WithShiftModifier_DownDirection_Should_Select_Range_Of_Items()
{
var tree = CreateTestTreeData();
var target = new TreeView
{
Template = CreateTreeViewTemplate(),
Items = tree,
SelectionMode = SelectionMode.Multiple
};
var visualRoot = new TestRoot();
visualRoot.Child = target;
CreateNodeDataTemplate(target);
ApplyTemplates(target);
var rootNode = tree[0];
var from = rootNode.Children[0];
var to = rootNode.Children.Last();
var fromContainer = (TreeViewItem)target.ItemContainerGenerator.Index.ContainerFromItem(from);
var toContainer = (TreeViewItem)target.ItemContainerGenerator.Index.ContainerFromItem(to);
TreeTestHelper.ClickContainer(fromContainer, InputModifiers.None);
Assert.True(fromContainer.IsSelected);
TreeTestHelper.ClickContainer(toContainer, InputModifiers.Shift);
TreeTestHelper.AssertChildrenSelected(target, rootNode);
}
[Fact]
public void Clicking_WithShiftModifier_UpDirection_Should_Select_Range_Of_Items()
{
var tree = CreateTestTreeData();
var target = new TreeView
{
Template = CreateTreeViewTemplate(),
Items = tree,
SelectionMode = SelectionMode.Multiple
};
var visualRoot = new TestRoot();
visualRoot.Child = target;
CreateNodeDataTemplate(target);
ApplyTemplates(target);
var rootNode = tree[0];
var from = rootNode.Children.Last();
var to = rootNode.Children[0];
var fromContainer = (TreeViewItem)target.ItemContainerGenerator.Index.ContainerFromItem(from);
var toContainer = (TreeViewItem)target.ItemContainerGenerator.Index.ContainerFromItem(to);
TreeTestHelper.ClickContainer(fromContainer, InputModifiers.None);
Assert.True(fromContainer.IsSelected);
TreeTestHelper.ClickContainer(toContainer, InputModifiers.Shift);
TreeTestHelper.AssertChildrenSelected(target, rootNode);
}
[Fact]
public void Clicking_First_Item_Of_SelectedItems_Should_Select_Only_It()
{
var tree = CreateTestTreeData();
var target = new TreeView
{
Template = CreateTreeViewTemplate(),
Items = tree,
SelectionMode = SelectionMode.Multiple
};
var visualRoot = new TestRoot();
visualRoot.Child = target;
CreateNodeDataTemplate(target);
ApplyTemplates(target);
var rootNode = tree[0];
var from = rootNode.Children.Last();
var to = rootNode.Children[0];
var fromContainer = (TreeViewItem)target.ItemContainerGenerator.Index.ContainerFromItem(from);
var toContainer = (TreeViewItem)target.ItemContainerGenerator.Index.ContainerFromItem(to);
TreeTestHelper.ClickContainer(fromContainer, InputModifiers.None);
TreeTestHelper.ClickContainer(toContainer, InputModifiers.Shift);
TreeTestHelper.AssertChildrenSelected(target, rootNode);
TreeTestHelper.ClickContainer(fromContainer, InputModifiers.None);
Assert.True(fromContainer.IsSelected);
foreach (var child in rootNode.Children)
{
if (child == from)
{
continue;
}
var container = (TreeViewItem)target.ItemContainerGenerator.Index.ContainerFromItem(child);
Assert.False(container.IsSelected);
}
}
[Fact] [Fact]
public void Setting_SelectedItem_Should_Set_Container_Selected() public void Setting_SelectedItem_Should_Set_Container_Selected()
{ {
@ -166,7 +394,6 @@ namespace Avalonia.Controls.UnitTests
Assert.True(container.IsSelected); Assert.True(container.IsSelected);
} }
[Fact] [Fact]
public void Setting_SelectedItem_Should_Raise_SelectedItemChanged_Event() public void Setting_SelectedItem_Should_Raise_SelectedItemChanged_Event()
{ {
@ -186,7 +413,7 @@ namespace Avalonia.Controls.UnitTests
var item = tree[0].Children[1].Children[0]; var item = tree[0].Children[1].Children[0];
var called = false; var called = false;
target.SelectedItemChanged += (s, e) => target.SelectionChanged += (s, e) =>
{ {
Assert.Empty(e.RemovedItems); Assert.Empty(e.RemovedItems);
Assert.Equal(1, e.AddedItems.Count); Assert.Equal(1, e.AddedItems.Count);
@ -442,7 +669,7 @@ namespace Avalonia.Controls.UnitTests
new Node new Node
{ {
Value = "Child3", Value = "Child3",
}, }
} }
} }
}; };
@ -515,6 +742,29 @@ namespace Avalonia.Controls.UnitTests
} }
} }
private static class TreeTestHelper
{
public static void ClickContainer(IControl container, InputModifiers modifiers)
{
container.RaiseEvent(new PointerPressedEventArgs
{
RoutedEvent = InputElement.PointerPressedEvent,
MouseButton = MouseButton.Left,
InputModifiers = modifiers
});
}
public static void AssertChildrenSelected(TreeView treeView, Node rootNode)
{
foreach (var child in rootNode.Children)
{
var container = (TreeViewItem)treeView.ItemContainerGenerator.Index.ContainerFromItem(child);
Assert.True(container.IsSelected);
}
}
}
private class Node : NotifyingBase private class Node : NotifyingBase
{ {
private IAvaloniaList<Node> _children; private IAvaloniaList<Node> _children;

Loading…
Cancel
Save