From c90cc4bf2716b4ac62fd8972642c9a37278aca46 Mon Sep 17 00:00:00 2001 From: Jeremy Koritzinsky Date: Wed, 7 Sep 2016 16:03:49 -0500 Subject: [PATCH] Implemented feedback. --- .../Utilities/SingleOrDictionary.cs | 33 +++++++++---------- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/src/Avalonia.Base/Utilities/SingleOrDictionary.cs b/src/Avalonia.Base/Utilities/SingleOrDictionary.cs index 97d6b9ac95..fd984d758a 100644 --- a/src/Avalonia.Base/Utilities/SingleOrDictionary.cs +++ b/src/Avalonia.Base/Utilities/SingleOrDictionary.cs @@ -14,43 +14,40 @@ namespace Avalonia.Utilities /// The type of the value. public class SingleOrDictionary : IEnumerable> { - private KeyValuePair? singleValue; + private KeyValuePair? _singleValue; private Dictionary dictionary; - private bool useDictionary = false; - public void Add(TKey key, TValue value) { - if (singleValue != null) + if (_singleValue != null) { dictionary = new Dictionary(); - ((ICollection>)dictionary).Add(singleValue.Value); - useDictionary = true; - singleValue = null; + ((ICollection>)dictionary).Add(_singleValue.Value); + _singleValue = null; } - if (useDictionary) + if (dictionary != null) { dictionary.Add(key, value); } else { - singleValue = new KeyValuePair(key, value); + _singleValue = new KeyValuePair(key, value); } } public bool TryGetValue(TKey key, out TValue value) { - if (!useDictionary) + if (dictionary == null) { - if (!singleValue.HasValue || !singleValue.Value.Key.Equals(key)) + if (!_singleValue.HasValue || !_singleValue.Value.Key.Equals(key)) { value = default(TValue); return false; } else { - value = singleValue.Value.Value; + value = _singleValue.Value.Value; return true; } } @@ -62,11 +59,11 @@ namespace Avalonia.Utilities public IEnumerator> GetEnumerator() { - if (!useDictionary) + if (dictionary == null) { - if (singleValue.HasValue) + if (_singleValue.HasValue) { - return new SingleEnumerator>(singleValue.Value); + return new SingleEnumerator>(_singleValue.Value); } } else @@ -85,11 +82,11 @@ namespace Avalonia.Utilities { get { - if(!useDictionary) + if(dictionary == null) { - if (singleValue.HasValue) + if (_singleValue.HasValue) { - return new[] { singleValue.Value.Value }; + return new[] { _singleValue.Value.Value }; } } else