From d64b8582738f2fac85c3cc86d2660d2d8f2a5428 Mon Sep 17 00:00:00 2001
From: Benedikt Stebner <Gillibald@users.noreply.github.com>
Date: Fri, 10 Jun 2022 16:30:24 +0200
Subject: [PATCH] Simplify GeometryGroup.Children setter

---
 src/Avalonia.Base/Media/GeometryGroup.cs | 25 +++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/src/Avalonia.Base/Media/GeometryGroup.cs b/src/Avalonia.Base/Media/GeometryGroup.cs
index b3b807c0a0..dbd1b9c97c 100644
--- a/src/Avalonia.Base/Media/GeometryGroup.cs
+++ b/src/Avalonia.Base/Media/GeometryGroup.cs
@@ -14,7 +14,7 @@ namespace Avalonia.Media
             AvaloniaProperty.RegisterDirect<GeometryGroup, GeometryCollection> (
                 nameof(Children),
                 o => o.Children,
-                (o, v) => o.Children = v);
+                SetChildren);
 
         public static readonly StyledProperty<FillRule> FillRuleProperty =
             AvaloniaProperty.Register<GeometryGroup, FillRule>(nameof(FillRule));
@@ -29,18 +29,12 @@ namespace Avalonia.Media
         {
             get => _children;
             set
-            {
-                if(_children is GeometryCollection)
-                {
-                    _children.Parent = null;
-                }
-
-                if (value is GeometryCollection)
-                {
-                    value.Parent = this;
-                }
+            {             
+                _children.Parent = null;
 
                 SetAndRaise(ChildrenProperty, ref _children, value);
+
+                _children.Parent = this;
             }
         }
 
@@ -66,6 +60,15 @@ namespace Avalonia.Media
             return result;
         }
 
+        private static void SetChildren(GeometryGroup geometryGroup, GeometryCollection children)
+        {
+            geometryGroup.Children.Parent = null;
+
+            children.Parent = geometryGroup;
+
+            geometryGroup.Children = children;
+        }
+
         protected override IGeometryImpl? CreateDefiningGeometry()
         {
             if (_children.Count > 0)