diff --git a/samples/BindingTest/App.xaml.cs b/samples/BindingTest/App.xaml.cs index 26df631523..07fa406c1c 100644 --- a/samples/BindingTest/App.xaml.cs +++ b/samples/BindingTest/App.xaml.cs @@ -1,7 +1,6 @@ using System; using Avalonia; using Avalonia.Controls; -using Avalonia.Diagnostics; using Avalonia.Logging.Serilog; using Avalonia.Markup.Xaml; using Serilog; @@ -15,15 +14,19 @@ namespace BindingTest RegisterServices(); } + public override void Initialize() + { + AvaloniaXamlLoader.Load(this); + } + private static void Main() { InitializeLogging(); - new App() + AppBuilder.Configure() .UseWin32() - .UseDirect2D() - .LoadFromXaml() - .RunWithMainWindow(); + .UseDirect2D1() + .Start(); } private static void InitializeLogging() diff --git a/samples/BindingTest/MainWindow.xaml.cs b/samples/BindingTest/MainWindow.xaml.cs index 8b07c6b482..c1c3c09406 100644 --- a/samples/BindingTest/MainWindow.xaml.cs +++ b/samples/BindingTest/MainWindow.xaml.cs @@ -16,7 +16,7 @@ namespace BindingTest private void InitializeComponent() { - this.LoadFromXaml(); + AvaloniaXamlLoader.Load(this); } } } diff --git a/samples/ControlCatalog.Desktop/ControlCatalog.Desktop.csproj b/samples/ControlCatalog.Desktop/ControlCatalog.Desktop.csproj index 79f5f1d259..c56b61fc50 100644 --- a/samples/ControlCatalog.Desktop/ControlCatalog.Desktop.csproj +++ b/samples/ControlCatalog.Desktop/ControlCatalog.Desktop.csproj @@ -75,6 +75,10 @@ {6417E941-21BC-467B-A771-0DE389353CE6} Avalonia.Markup + + {d211e587-d8bc-45b9-95a4-f297c8fa5200} + Avalonia.Animation + {B09B78D8-9B26-48B0-9149-D64A2F120F3F} Avalonia.Base @@ -83,10 +87,26 @@ {D2221C82-4A25-4583-9B43-D791E3F6820C} Avalonia.Controls + + {62024b2d-53eb-4638-b26b-85eeaa54866e} + Avalonia.Input + + + {6b0ed19d-a08b-461c-a9d9-a9ee40b0c06b} + Avalonia.Interactivity + + + {42472427-4774-4c81-8aff-9f27b8e31721} + Avalonia.Layout + {B61B66A3-B82D-4875-8001-89D3394FE0C9} Avalonia.Logging.Serilog + + {eb582467-6abb-43a1-b052-e981ba910e3a} + Avalonia.SceneGraph + {F1BAA01A-F176-4C6A-B39D-5B40BB1B148F} Avalonia.Styling diff --git a/samples/ControlCatalog.Desktop/Program.cs b/samples/ControlCatalog.Desktop/Program.cs index 4257587b21..ae8c9f5d8f 100644 --- a/samples/ControlCatalog.Desktop/Program.cs +++ b/samples/ControlCatalog.Desktop/Program.cs @@ -1,10 +1,10 @@ -using Avalonia.Logging.Serilog; -using Serilog; using System; using System.Linq; using Avalonia; -using System.Reflection; +using Avalonia.Controls; +using Avalonia.Logging.Serilog; using Avalonia.Platform; +using Serilog; namespace ControlCatalog { @@ -14,10 +14,12 @@ namespace ControlCatalog { InitializeLogging(); - new App() - .ConfigureRenderSystem(args) - .LoadFromXaml() - .RunWithMainWindow(); + // TODO: Make this work with GTK/Skia/Cairo depending on command-line args + // again. + AppBuilder.Configure() + .UseWin32() + .UseDirect2D1() + .Start(); } // This will be made into a runtime configuration extension soon! @@ -31,6 +33,12 @@ namespace ControlCatalog #endif } + private static void ConfigureAssetAssembly(AppBuilder builder) + { + AvaloniaLocator.CurrentMutable + .GetService() + .SetDefaultAssembly(typeof(App).Assembly); + } } ///////////////////////////////////////////////////////////////////////////////////////////////////////////// @@ -96,33 +104,32 @@ namespace ControlCatalog /// /// Selects the optimal render system for desktop platforms. Supports cmd line overrides /// - /// + /// /// - public static TApp ConfigureRenderSystem(this TApp app, string[] args) where TApp : Application + public static AppBuilder ConfigureRenderSystem(this AppBuilder builder, string[] args) { // So this all works great under Windows where it can support // ALL configurations. But on OSX/Unix we cannot use Direct2D - // if (args.Contains("--gtk") || DefaultRenderSystem() == RenderSystem.GTK) { - app.UseGtk(); - app.UseCairo(); + builder.UseGtk(); + builder.UseCairo(); } else { - app.UseWin32(); + builder.UseWin32(); if (args.Contains("--skia") || DefaultRenderSystem() == RenderSystem.Skia) { - app.UseSkia(); + builder.UseSkia(); } else { - app.UseDirect2D(); + builder.UseDirect2D1(); } } - return app; + return builder; } } } diff --git a/samples/ControlCatalog.iOS/AppDelegate.cs b/samples/ControlCatalog.iOS/AppDelegate.cs index 94c79cd60b..e352b39200 100644 --- a/samples/ControlCatalog.iOS/AppDelegate.cs +++ b/samples/ControlCatalog.iOS/AppDelegate.cs @@ -19,17 +19,13 @@ namespace ControlCatalog // public override bool FinishedLaunching(UIApplication uiapp, NSDictionary options) { - new App() + AppBuilder.Configure() .UseiOS() .UseSkiaViewHost() .UseSkia() - .UseAssetAssembly(typeof(App).Assembly) - .LoadFromXaml() - .RunWithMainWindow(); + .Start(); return true; } } - - } \ No newline at end of file diff --git a/samples/ControlCatalog/App.xaml.cs b/samples/ControlCatalog/App.xaml.cs index 66bf8e6b8d..fe2ccdb218 100644 --- a/samples/ControlCatalog/App.xaml.cs +++ b/samples/ControlCatalog/App.xaml.cs @@ -1,16 +1,18 @@ using Avalonia; - +using Avalonia.Markup.Xaml; namespace ControlCatalog { - // Eventually we should move this into a PCL library so we can access - // from mobile platforms - // public class App : Application { public App() { RegisterServices(); } + + public override void Initialize() + { + AvaloniaXamlLoader.Load(this); + } } } diff --git a/samples/ControlCatalog/MainWindow.xaml.cs b/samples/ControlCatalog/MainWindow.xaml.cs index 2dea549160..c7c61e2b4e 100644 --- a/samples/ControlCatalog/MainWindow.xaml.cs +++ b/samples/ControlCatalog/MainWindow.xaml.cs @@ -19,9 +19,7 @@ namespace ControlCatalog // now I am doing that here. But we need a better solution!! var theme = new Avalonia.Themes.Default.DefaultTheme(); theme.FindResource("Button"); - - - this.LoadFromXaml(); + AvaloniaXamlLoader.Load(this); } } } diff --git a/samples/TestApplication/Program.cs b/samples/TestApplication/Program.cs index 3cee513c17..5e79916a8d 100644 --- a/samples/TestApplication/Program.cs +++ b/samples/TestApplication/Program.cs @@ -34,25 +34,10 @@ namespace TestApplication var app = new App(); - if (args.Contains("--gtk")) - { - app.UseGtk(); - app.UseCairo(); - } - else - { - app.UseWin32(); - - // not available until we do the SkiaSharp merge - //if (args.Contains("--skia")) - //{ - // app.UseSkia(); - //} - //else - { - app.UseDirect2D(); - } - } + AppBuilder.Configure(app) + .UseWin32() + .UseDirect2D1() + .SetupWithoutStarting(); app.Run(); } diff --git a/samples/XamlTestApplication/Program.cs b/samples/XamlTestApplication/Program.cs index 020c353677..50b3c364d4 100644 --- a/samples/XamlTestApplication/Program.cs +++ b/samples/XamlTestApplication/Program.cs @@ -7,6 +7,7 @@ using System.Windows.Threading; using Avalonia; using Serilog; using Avalonia.Logging.Serilog; +using Avalonia.Controls; namespace XamlTestApplication { @@ -19,11 +20,10 @@ namespace XamlTestApplication InitializeLogging(); - new XamlTestApp() - .UseWin32() - .UseDirect2D() - .LoadFromXaml() - .RunWithMainWindow(); + AppBuilder.Configure() + .UseWin32() + .UseDirect2D1() + .Start(); } private static void InitializeLogging() diff --git a/samples/XamlTestApplicationPcl/XamlTestApp.cs b/samples/XamlTestApplicationPcl/XamlTestApp.cs index efc744dcb0..7518346e91 100644 --- a/samples/XamlTestApplicationPcl/XamlTestApp.cs +++ b/samples/XamlTestApplicationPcl/XamlTestApp.cs @@ -10,5 +10,10 @@ namespace XamlTestApplication { RegisterServices(); } + + public override void Initialize() + { + AvaloniaXamlLoader.Load(this); + } } } diff --git a/src/Avalonia.Controls/AppBuilder.cs b/src/Avalonia.Controls/AppBuilder.cs new file mode 100644 index 0000000000..628fac3cc1 --- /dev/null +++ b/src/Avalonia.Controls/AppBuilder.cs @@ -0,0 +1,80 @@ +// Copyright (c) The Avalonia Project. All rights reserved. +// Licensed under the MIT license. See licence.md file in the project root for full license information. + +using Avalonia.Input; +using System; + +namespace Avalonia.Controls +{ + public class AppBuilder + { + public Application Instance { get; set; } + + public Action WindowingSubsystem { get; set; } + + public Action RenderingSubsystem { get; set; } + + public Action BeforeStartCallback { get; set; } + + public static AppBuilder Configure() + where TApp : Application, new() + { + return Configure(new TApp()); + } + + public static AppBuilder Configure(Application app) + { + AvaloniaLocator.CurrentMutable.BindToSelf(app); + + return new AppBuilder() + { + Instance = app, + }; + } + + public AppBuilder BeforeStarting(Action callback) + { + BeforeStartCallback = callback; + return this; + } + + public void Start() + where TMainWindow : Window, new() + { + Setup(); + BeforeStartCallback?.Invoke(this); + + var window = new TMainWindow(); + window.Show(); + Instance.Run(window); + } + + public AppBuilder SetupWithoutStarting() + { + Setup(); + return this; + } + + public void Setup() + { + if (Instance == null) + { + throw new InvalidOperationException("No App instance configured."); + } + + if (WindowingSubsystem == null) + { + throw new InvalidOperationException("No windowing system configured."); + } + + if (RenderingSubsystem == null) + { + throw new InvalidOperationException("No rendering system configured."); + } + + WindowingSubsystem(); + RenderingSubsystem(); + Instance.Initialize(); + } + } +} diff --git a/src/Avalonia.Controls/Application.cs b/src/Avalonia.Controls/Application.cs index a24f481fe5..aedf3370a3 100644 --- a/src/Avalonia.Controls/Application.cs +++ b/src/Avalonia.Controls/Application.cs @@ -50,12 +50,6 @@ namespace Avalonia /// public Application() { - if (Current != null) - { - throw new InvalidOperationException("Cannot create more than one Application instance."); - } - - AvaloniaLocator.CurrentMutable.BindToSelf(this); OnExit += OnExiting; } @@ -132,6 +126,13 @@ namespace Avalonia _platformInitializationCallback = cb; } + /// + /// Initializes the application by loading XAML etc. + /// + public virtual void Initialize() + { + } + /// /// Runs the application's main loop until the is closed. /// @@ -165,7 +166,6 @@ namespace Avalonia /// protected virtual void OnExiting(object sender, EventArgs e) { - } /// diff --git a/src/Avalonia.Controls/Avalonia.Controls.csproj b/src/Avalonia.Controls/Avalonia.Controls.csproj index 2a0040d863..6f7dd4bcf8 100644 --- a/src/Avalonia.Controls/Avalonia.Controls.csproj +++ b/src/Avalonia.Controls/Avalonia.Controls.csproj @@ -43,6 +43,7 @@ Properties\SharedAssemblyInfo.cs + diff --git a/src/Gtk/Avalonia.Cairo/CairoPlatform.cs b/src/Gtk/Avalonia.Cairo/CairoPlatform.cs index 0dd708d9d3..8092764c1b 100644 --- a/src/Gtk/Avalonia.Cairo/CairoPlatform.cs +++ b/src/Gtk/Avalonia.Cairo/CairoPlatform.cs @@ -6,15 +6,16 @@ using Avalonia.Cairo.Media; using Avalonia.Cairo.Media.Imaging; using Avalonia.Media; using Avalonia.Platform; +using Avalonia.Controls; namespace Avalonia { public static class GtkApplicationExtensions { - public static TApp UseCairo(this TApp app) where TApp : Application + public static AppBuilder UseCairo(this AppBuilder builder) { - Avalonia.Cairo.CairoPlatform.Initialize(); - return app; + builder.RenderingSubsystem = Avalonia.Cairo.CairoPlatform.Initialize; + return builder; } } } diff --git a/src/Gtk/Avalonia.Gtk/GtkPlatform.cs b/src/Gtk/Avalonia.Gtk/GtkPlatform.cs index cc19110e86..b09f1c9ea6 100644 --- a/src/Gtk/Avalonia.Gtk/GtkPlatform.cs +++ b/src/Gtk/Avalonia.Gtk/GtkPlatform.cs @@ -9,15 +9,16 @@ using Avalonia.Input.Platform; using Avalonia.Input; using Avalonia.Platform; using Avalonia.Shared.PlatformSupport; +using Avalonia.Controls; namespace Avalonia { public static class GtkApplicationExtensions { - public static TApp UseGtk(this TApp app) where TApp : Application + public static AppBuilder UseGtk(this AppBuilder builder) { - Avalonia.Gtk.GtkPlatform.Initialize(); - return app; + builder.WindowingSubsystem = Avalonia.Gtk.GtkPlatform.Initialize; + return builder; } } } diff --git a/src/Markup/Avalonia.Markup.Xaml/AvaloniaXamlLoader.cs b/src/Markup/Avalonia.Markup.Xaml/AvaloniaXamlLoader.cs index c36a58cf0b..437e6e849f 100644 --- a/src/Markup/Avalonia.Markup.Xaml/AvaloniaXamlLoader.cs +++ b/src/Markup/Avalonia.Markup.Xaml/AvaloniaXamlLoader.cs @@ -223,15 +223,3 @@ namespace Avalonia.Markup.Xaml } } } - -namespace Avalonia -{ - public static class XamlObjectExtensions - { - public static TObject LoadFromXaml(this TObject obj) - { - Markup.Xaml.AvaloniaXamlLoader.Load(obj); - return obj; - } - } -} diff --git a/src/Skia/Avalonia.Skia/SkiaPlatform.cs b/src/Skia/Avalonia.Skia/SkiaPlatform.cs index 31781ad0bd..1d93089e45 100644 --- a/src/Skia/Avalonia.Skia/SkiaPlatform.cs +++ b/src/Skia/Avalonia.Skia/SkiaPlatform.cs @@ -1,16 +1,17 @@ using System; using System.Collections.Generic; using System.Text; +using Avalonia.Controls; using Avalonia.Platform; namespace Avalonia { public static class SkiaApplicationExtensions { - public static TApp UseSkia(this TApp app) where TApp : Application + public static AppBuilder UseSkia(this AppBuilder builder) { - Avalonia.Skia.SkiaPlatform.Initialize(); - return app; + builder.RenderingSubsystem = Avalonia.Skia.SkiaPlatform.Initialize; + return builder; } } } diff --git a/src/Windows/Avalonia.Direct2D1/Direct2D1Platform.cs b/src/Windows/Avalonia.Direct2D1/Direct2D1Platform.cs index 03230a3e60..ae2b5d314d 100644 --- a/src/Windows/Avalonia.Direct2D1/Direct2D1Platform.cs +++ b/src/Windows/Avalonia.Direct2D1/Direct2D1Platform.cs @@ -6,15 +6,16 @@ using System.IO; using Avalonia.Direct2D1.Media; using Avalonia.Media; using Avalonia.Platform; +using Avalonia.Controls; namespace Avalonia { public static class Direct2DApplicationExtensions { - public static TApp UseDirect2D(this TApp app) where TApp : Application + public static AppBuilder UseDirect2D1(this AppBuilder builder) { - Avalonia.Direct2D1.Direct2D1Platform.Initialize(); - return app; + builder.RenderingSubsystem = Avalonia.Direct2D1.Direct2D1Platform.Initialize; + return builder; } } } diff --git a/src/Windows/Avalonia.Win32/Win32Platform.cs b/src/Windows/Avalonia.Win32/Win32Platform.cs index 71e18bcffe..c1e0260596 100644 --- a/src/Windows/Avalonia.Win32/Win32Platform.cs +++ b/src/Windows/Avalonia.Win32/Win32Platform.cs @@ -15,15 +15,16 @@ using Avalonia.Platform; using Avalonia.Shared.PlatformSupport; using Avalonia.Win32.Input; using Avalonia.Win32.Interop; +using Avalonia.Controls; namespace Avalonia { public static class Win32ApplicationExtensions { - public static TApp UseWin32(this TApp app) where TApp : Application + public static AppBuilder UseWin32(this AppBuilder builder) { - Avalonia.Win32.Win32Platform.Initialize(); - return app; + builder.WindowingSubsystem = Avalonia.Win32.Win32Platform.Initialize; + return builder; } } } diff --git a/src/iOS/Avalonia.iOS/iOSPlatform.cs b/src/iOS/Avalonia.iOS/iOSPlatform.cs index c78d1eaa82..e28aadf034 100644 --- a/src/iOS/Avalonia.iOS/iOSPlatform.cs +++ b/src/iOS/Avalonia.iOS/iOSPlatform.cs @@ -7,19 +7,20 @@ using Avalonia.Platform; using Avalonia.Shared.PlatformSupport; using Avalonia.Skia; using UIKit; +using Avalonia.Controls; namespace Avalonia { public static class iOSApplicationExtensions { - public static AppT UseiOS(this AppT app) where AppT : Application + public static AppBuilder UseiOS(this AppBuilder builder) { - Avalonia.iOS.iOSPlatform.Initialize(); - return app; + builder.WindowingSubsystem = Avalonia.iOS.iOSPlatform.Initialize; + return builder; } // TODO: Can we merge this with UseSkia somehow once HW/platform cleanup is done? - public static AppT UseSkiaViewHost(this AppT app) where AppT : Application + public static AppBuilder UseSkiaViewHost(this AppBuilder builder) { var window = new UIWindow(UIScreen.MainScreen.Bounds); var controller = new AvaloniaViewController(window); @@ -31,15 +32,7 @@ namespace Avalonia SkiaPlatform.Initialize(); - return app; - } - - public static AppT UseAssetAssembly(this AppT app, Assembly assembly) where AppT : Application - { - // Asset loading searches our own assembly? - var loader = new AssetLoader(assembly); - AvaloniaLocator.CurrentMutable.Bind().ToConstant(loader); - return app; + return builder; } } } diff --git a/src/iOS/Avalonia.iOSTestApplication/AppDelegate.cs b/src/iOS/Avalonia.iOSTestApplication/AppDelegate.cs index e4ef8b8afe..211b7d5daa 100644 --- a/src/iOS/Avalonia.iOSTestApplication/AppDelegate.cs +++ b/src/iOS/Avalonia.iOSTestApplication/AppDelegate.cs @@ -27,13 +27,14 @@ namespace Avalonia.iOSTestApplication // public override bool FinishedLaunching(UIApplication uiapp, NSDictionary options) { - var app = new App() + var app = new App(); + + AppBuilder.Configure(app) .UseiOS() .UseSkiaViewHost() - .UseSkia(); + .UseSkia() + .SetupWithoutStarting(); - var asm = typeof(App).Assembly; - app.UseAssetAssembly(asm); app.Run(); return true; diff --git a/tests/Avalonia.UnitTests/UnitTestApplication.cs b/tests/Avalonia.UnitTests/UnitTestApplication.cs index 9c7eb427ed..01151b4952 100644 --- a/tests/Avalonia.UnitTests/UnitTestApplication.cs +++ b/tests/Avalonia.UnitTests/UnitTestApplication.cs @@ -33,6 +33,7 @@ namespace Avalonia.UnitTests { var scope = AvaloniaLocator.EnterScope(); var app = new UnitTestApplication(services); + AvaloniaLocator.CurrentMutable.BindToSelf(app); return scope; }