From f6b4c8ef0dcd031cb415b8a35273fa2b58b212f7 Mon Sep 17 00:00:00 2001
From: Giuseppe Lippolis <workgroupengineering@outlook.com>
Date: Wed, 7 Jun 2023 15:43:43 +0200
Subject: [PATCH 1/3] feat(DevTools): Can be edit Brush if is Property is Null

---
 .../Diagnostics/Controls/BrushEditor.axaml    |  21 +++
 .../Diagnostics/Controls/BrushEditor.axaml.cs | 131 ++++++++++++++++++
 .../Diagnostics/Controls/BrushEditor.cs       |  94 -------------
 .../Diagnostics/Views/MainWindow.xaml         |   1 +
 4 files changed, 153 insertions(+), 94 deletions(-)
 create mode 100644 src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml
 create mode 100644 src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml.cs
 delete mode 100644 src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.cs

diff --git a/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml b/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml
new file mode 100644
index 0000000000..7162be888f
--- /dev/null
+++ b/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml
@@ -0,0 +1,21 @@
+<Styles xmlns="https://github.com/avaloniaui"
+        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
+        xmlns:controls="using:Avalonia.Diagnostics.Controls"
+        x:ClassModifier="internal">
+  <Design.PreviewWith>
+    <controls:BrushEditor />
+  </Design.PreviewWith>
+
+  <Style Selector=":is(controls|BrushEditor)">
+    <Setter Property="Template">
+      <ControlTemplate>
+        <Grid>
+          <Button Theme="{StaticResource SimpleTextBoxClearButtonTheme}"
+                  x:Name="PART_ClearButton"
+                  HorizontalAlignment="Right"
+                  VerticalContentAlignment="Center"/>
+        </Grid>
+      </ControlTemplate>
+    </Setter>
+  </Style>
+</Styles>
diff --git a/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml.cs b/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml.cs
new file mode 100644
index 0000000000..c75da84519
--- /dev/null
+++ b/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml.cs
@@ -0,0 +1,131 @@
+using System;
+using System.Globalization;
+using Avalonia.Controls;
+using Avalonia.Controls.Metadata;
+using Avalonia.Controls.Primitives;
+using Avalonia.Input;
+using Avalonia.Interactivity;
+using Avalonia.Media;
+using Avalonia.Media.Immutable;
+
+namespace Avalonia.Diagnostics.Controls
+{
+    [TemplatePart("PART_ClearButton", typeof(Button))]
+    partial class BrushEditor : TemplatedControl
+    {
+        private readonly EventHandler<RoutedEventArgs> clearHandler;
+        private Button? _cleraButton = default;
+        private readonly ColorView _colorView = new()
+        {
+            HexInputAlphaPosition = AlphaComponentPosition.Leading, // Always match XAML
+        };
+
+
+        public BrushEditor()
+        {
+            FlyoutBase.SetAttachedFlyout(this, new Flyout { Content = _colorView });
+            _colorView.ColorChanged += (_, e) => Brush = new ImmutableSolidColorBrush(e.NewColor);
+            clearHandler = (s, e) => Brush = default;
+        }
+
+        protected override Type StyleKeyOverride => typeof(BrushEditor);
+
+        protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
+        {
+            base.OnApplyTemplate(e);
+            if (_cleraButton is not null)
+            {
+                _cleraButton.Click -= clearHandler;
+            }
+            _cleraButton = e.NameScope.Find<Button>("PART_ClearButton");
+            if (_cleraButton is Button button)
+            {
+                button.Click += clearHandler;
+            }
+        }
+
+        /// <summary>
+        ///     Defines the <see cref="Brush" /> property.
+        /// </summary>
+        public static readonly DirectProperty<BrushEditor, IBrush?> BrushProperty =
+                AvaloniaProperty.RegisterDirect<BrushEditor, IBrush?>(
+                    nameof(Brush), o => o.Brush, (o, v) => o.Brush = v);
+
+        private IBrush? _brush;
+
+        public IBrush? Brush
+        {
+            get => _brush;
+            set => SetAndRaise(BrushProperty, ref _brush, value);
+        }
+
+        protected override void OnPropertyChanged(AvaloniaPropertyChangedEventArgs change)
+        {
+            base.OnPropertyChanged(change);
+
+            if (change.Property == BrushProperty)
+            {
+                if (Brush is ISolidColorBrush scb)
+                {
+                    _colorView.Color = scb.Color;
+                }
+                ToolTip.SetTip(this, Brush?.GetType().Name ?? "(null)");
+                InvalidateVisual();
+            }
+        }
+
+        protected override void OnPointerPressed(PointerPressedEventArgs e)
+        {
+            base.OnPointerPressed(e);
+
+            FlyoutBase.ShowAttachedFlyout(this);
+        }
+
+        public override void Render(DrawingContext context)
+        {
+            base.Render(context);
+
+            var brush = Brush ?? Brushes.Black;
+
+            context.FillRectangle(brush, Bounds);
+
+            var text = (Brush as ISolidColorBrush)?.Color.ToString() ?? "(null)";
+
+            var ft = new FormattedText(text,
+                CultureInfo.CurrentCulture,
+                FlowDirection.LeftToRight,
+                Typeface.Default,
+                10,
+                GetTextBrush(brush));
+
+            context.DrawText(ft,
+                new Point(Bounds.Width / 2 - ft.Width / 2, Bounds.Height / 2 - ft.Height / 2));
+        }
+
+        /// <summary>
+        /// <see cref="https://stackoverflow.com/questions/6763032/how-to-pick-a-background-color-depending-on-font-color-to-have-proper-contrast">How to pick a background color depending on font color to have proper contrast</see>/>
+        /// </summary>
+        /// <param name="brush"></param>
+        /// <returns></returns>
+        private static IBrush GetTextBrush(IBrush brush)
+        {
+            if (brush is ISolidColorBrush solid)
+            {
+                var color = solid.Color;
+
+
+                double R = color.R / 255.0;
+                double G = color.G / 255.0;
+                double B = color.B / 255.0;
+
+                R = Math.Pow((R + 0.055) / 1.055, 2.4);
+                G = Math.Pow((G + 0.055) / 1.055, 2.4);
+                B = Math.Pow((B + 0.055) / 1.055, 2.4);
+                var l = 0.2126 * R + 0.7152 * G + 0.0722 * B;
+
+                return l < 0.5 ? Brushes.White : Brushes.Black;
+            }
+            return Brushes.White;
+        }
+    }
+}
diff --git a/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.cs b/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.cs
deleted file mode 100644
index ff05614667..0000000000
--- a/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.cs
+++ /dev/null
@@ -1,94 +0,0 @@
-using System.Globalization;
-using Avalonia.Controls;
-using Avalonia.Controls.Primitives;
-using Avalonia.Input;
-using Avalonia.Media;
-using Avalonia.Media.Immutable;
-
-namespace Avalonia.Diagnostics.Controls
-{
-    internal sealed class BrushEditor : Control
-    {
-        /// <summary>
-        ///     Defines the <see cref="Brush" /> property.
-        /// </summary>
-        public static readonly DirectProperty<BrushEditor, IBrush?> BrushProperty =
-            AvaloniaProperty.RegisterDirect<BrushEditor, IBrush?>(
-                nameof(Brush), o => o.Brush, (o, v) => o.Brush = v);
-
-        private IBrush? _brush;
-
-        public IBrush? Brush
-        {
-            get => _brush;
-            set => SetAndRaise(BrushProperty, ref _brush, value);
-        }
-
-        protected override void OnPropertyChanged(AvaloniaPropertyChangedEventArgs change)
-        {
-            base.OnPropertyChanged(change);
-
-            if (change.Property == BrushProperty)
-            {
-                switch (Brush)
-                {
-                    case ISolidColorBrush scb:
-                    {
-                        var colorView = new ColorView
-                        {
-                            HexInputAlphaPosition = AlphaComponentPosition.Leading, // Always match XAML
-                            Color = scb.Color,
-                        };
-
-                        colorView.ColorChanged += (_, e) => Brush = new ImmutableSolidColorBrush(e.NewColor);
-
-                        FlyoutBase.SetAttachedFlyout(this, new Flyout { Content = colorView });
-                        ToolTip.SetTip(this, $"{scb.Color} ({Brush.GetType().Name})");
-
-                        break;
-                    }
-
-                    default:
-
-                        FlyoutBase.SetAttachedFlyout(this, null);
-                        ToolTip.SetTip(this, Brush?.GetType().Name ?? "(null)");
-
-                        break;
-                }
-
-                InvalidateVisual();
-            }
-        }
-
-        protected override void OnPointerPressed(PointerPressedEventArgs e)
-        {
-            base.OnPointerPressed(e);
-
-            FlyoutBase.ShowAttachedFlyout(this);
-        }
-
-        public override void Render(DrawingContext context)
-        {
-            base.Render(context);
-
-            if (Brush != null)
-            {
-                context.FillRectangle(Brush, Bounds);
-            }
-            else
-            {
-                context.FillRectangle(Brushes.Black, Bounds);
-
-                var ft = new FormattedText("(null)",
-                    CultureInfo.CurrentCulture,
-                    FlowDirection.LeftToRight,
-                    Typeface.Default,
-                    10,
-                    Brushes.White);
-
-                context.DrawText(ft, 
-                    new Point(Bounds.Width / 2 - ft.Width / 2, Bounds.Height / 2 - ft.Height / 2));
-            }
-        }
-    }
-}
diff --git a/src/Avalonia.Diagnostics/Diagnostics/Views/MainWindow.xaml b/src/Avalonia.Diagnostics/Diagnostics/Views/MainWindow.xaml
index 486df860c3..5d756fdc40 100644
--- a/src/Avalonia.Diagnostics/Diagnostics/Views/MainWindow.xaml
+++ b/src/Avalonia.Diagnostics/Diagnostics/Views/MainWindow.xaml
@@ -15,6 +15,7 @@
     <StyleInclude Source="avares://Avalonia.Controls.DataGrid/Themes/Simple.xaml"/>
     <StyleInclude Source="avares://Avalonia.Diagnostics/Diagnostics/Controls/ThicknessEditor.axaml" />
     <StyleInclude Source="avares://Avalonia.Diagnostics/Diagnostics/Controls/FilterTextBox.axaml" />
+    <StyleInclude Source="avares://Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml" />
     <StyleInclude Source="avares://Avalonia.Controls.ColorPicker/Themes/Simple/Simple.xaml" />
   </Window.Styles>
   <Window.KeyBindings>

From 10226e855c2c260b89ea93312292c3eaf705b94a Mon Sep 17 00:00:00 2001
From: Giuseppe Lippolis <workgroupengineering@outlook.com>
Date: Wed, 7 Jun 2023 16:43:41 +0200
Subject: [PATCH 2/3] fix: Address review

---
 .../Diagnostics/Controls/BrushEditor.axaml.cs       | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml.cs b/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml.cs
index c75da84519..5090279ae1 100644
--- a/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml.cs
+++ b/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml.cs
@@ -103,7 +103,7 @@ namespace Avalonia.Diagnostics.Controls
         }
 
         /// <summary>
-        /// <see cref="https://stackoverflow.com/questions/6763032/how-to-pick-a-background-color-depending-on-font-color-to-have-proper-contrast">How to pick a background color depending on font color to have proper contrast</see>/>
+        /// Get Contrasted Text Color
         /// </summary>
         /// <param name="brush"></param>
         /// <returns></returns>
@@ -112,16 +112,7 @@ namespace Avalonia.Diagnostics.Controls
             if (brush is ISolidColorBrush solid)
             {
                 var color = solid.Color;
-
-
-                double R = color.R / 255.0;
-                double G = color.G / 255.0;
-                double B = color.B / 255.0;
-
-                R = Math.Pow((R + 0.055) / 1.055, 2.4);
-                G = Math.Pow((G + 0.055) / 1.055, 2.4);
-                B = Math.Pow((B + 0.055) / 1.055, 2.4);
-                var l = 0.2126 * R + 0.7152 * G + 0.0722 * B;
+                var l = ColorHelper.GetRelativeLuminance(color);
 
                 return l < 0.5 ? Brushes.White : Brushes.Black;
             }

From eb83ad326f068c20c9abee22d510cd1a831d6f5b Mon Sep 17 00:00:00 2001
From: Giuseppe Lippolis <workgroupengineering@outlook.com>
Date: Wed, 7 Jun 2023 17:04:39 +0200
Subject: [PATCH 3/3] fix: Spelling

---
 .../Diagnostics/Controls/BrushEditor.axaml.cs         | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml.cs b/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml.cs
index 5090279ae1..268e42cff3 100644
--- a/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml.cs
+++ b/src/Avalonia.Diagnostics/Diagnostics/Controls/BrushEditor.axaml.cs
@@ -14,13 +14,12 @@ namespace Avalonia.Diagnostics.Controls
     partial class BrushEditor : TemplatedControl
     {
         private readonly EventHandler<RoutedEventArgs> clearHandler;
-        private Button? _cleraButton = default;
+        private Button? _clearButton = default;
         private readonly ColorView _colorView = new()
         {
             HexInputAlphaPosition = AlphaComponentPosition.Leading, // Always match XAML
         };
 
-
         public BrushEditor()
         {
             FlyoutBase.SetAttachedFlyout(this, new Flyout { Content = _colorView });
@@ -33,12 +32,12 @@ namespace Avalonia.Diagnostics.Controls
         protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
         {
             base.OnApplyTemplate(e);
-            if (_cleraButton is not null)
+            if (_clearButton is not null)
             {
-                _cleraButton.Click -= clearHandler;
+                _clearButton.Click -= clearHandler;
             }
-            _cleraButton = e.NameScope.Find<Button>("PART_ClearButton");
-            if (_cleraButton is Button button)
+            _clearButton = e.NameScope.Find<Button>("PART_ClearButton");
+            if (_clearButton is Button button)
             {
                 button.Click += clearHandler;
             }