diff --git a/samples/RenderDemo/Pages/WriteableBitmapPage.cs b/samples/RenderDemo/Pages/WriteableBitmapPage.cs
index 850e398a93..a13a625d14 100644
--- a/samples/RenderDemo/Pages/WriteableBitmapPage.cs
+++ b/samples/RenderDemo/Pages/WriteableBitmapPage.cs
@@ -59,7 +59,7 @@ namespace RenderDemo.Pages
color = new Color(fillAlpha, r, g, b);
}
- data[y * fb.Size.Width + x] = (int) color.ToUint32();
+ data[y * fb.Size.Width + x] = (int) color.ToUInt32();
}
}
diff --git a/src/Avalonia.Base/Media/Color.cs b/src/Avalonia.Base/Media/Color.cs
index 7b29ec640a..56a3b0d7a5 100644
--- a/src/Avalonia.Base/Media/Color.cs
+++ b/src/Avalonia.Base/Media/Color.cs
@@ -449,7 +449,7 @@ namespace Avalonia.Media
///
public override string ToString()
{
- uint rgb = ToUint32();
+ uint rgb = ToUInt32();
return KnownColors.GetKnownColorName(rgb) ?? $"#{rgb.ToString("x8", CultureInfo.InvariantCulture)}";
}
@@ -459,11 +459,18 @@ namespace Avalonia.Media
///
/// The integer representation of the color.
///
- public uint ToUint32()
+ public uint ToUInt32()
{
return ((uint)A << 24) | ((uint)R << 16) | ((uint)G << 8) | (uint)B;
}
+ ///
+ [Obsolete("Use Color.ToUInt32() instead.")]
+ public uint ToUint32()
+ {
+ return ToUInt32();
+ }
+
///
/// Returns the HSL color model equivalent of this RGB color.
///
diff --git a/src/Avalonia.Base/Media/GeometryDrawing.cs b/src/Avalonia.Base/Media/GeometryDrawing.cs
index abfd2e33ac..75d7e44ab8 100644
--- a/src/Avalonia.Base/Media/GeometryDrawing.cs
+++ b/src/Avalonia.Base/Media/GeometryDrawing.cs
@@ -10,7 +10,7 @@ namespace Avalonia.Media
public class GeometryDrawing : Drawing
{
// Adding the Pen's stroke thickness here could yield wrong results due to transforms.
- private static readonly IPen s_boundsPen = new ImmutablePen(Colors.Black.ToUint32(), 0);
+ private static readonly IPen s_boundsPen = new ImmutablePen(Colors.Black.ToUInt32(), 0);
///
/// Defines the property.
diff --git a/src/Avalonia.Base/Media/HslColor.cs b/src/Avalonia.Base/Media/HslColor.cs
index b4bf6fd217..897c883875 100644
--- a/src/Avalonia.Base/Media/HslColor.cs
+++ b/src/Avalonia.Base/Media/HslColor.cs
@@ -98,43 +98,13 @@ namespace Avalonia.Media
L = hsl.L;
}
- ///
- /// Gets the Alpha (transparency) component in the range from 0..1 (percentage).
- ///
- ///
- ///
- /// - 0 is fully transparent.
- /// - 1 is fully opaque.
- ///
- ///
+ ///
public double A { get; }
- ///
- /// Gets the Hue component in the range from 0..360 (degrees).
- /// This is the color's location, in degrees, on a color wheel/circle from 0 to 360.
- /// Note that 360 is equivalent to 0 and will be adjusted automatically.
- ///
- ///
- ///
- /// - 0/360 degrees is Red.
- /// - 60 degrees is Yellow.
- /// - 120 degrees is Green.
- /// - 180 degrees is Cyan.
- /// - 240 degrees is Blue.
- /// - 300 degrees is Magenta.
- ///
- ///
+ ///
public double H { get; }
- ///
- /// Gets the Saturation component in the range from 0..1 (percentage).
- ///
- ///
- ///
- /// - 0 is a shade of gray (no color).
- /// - 1 is the full color.
- ///
- ///
+ ///
public double S { get; }
///
diff --git a/src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/AvaloniaXamlIlLanguageParseIntrinsics.cs b/src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/AvaloniaXamlIlLanguageParseIntrinsics.cs
index 6c7b04dbfb..819e721b36 100644
--- a/src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/AvaloniaXamlIlLanguageParseIntrinsics.cs
+++ b/src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/AvaloniaXamlIlLanguageParseIntrinsics.cs
@@ -155,7 +155,7 @@ namespace Avalonia.Markup.Xaml.XamlIl.CompilerExtensions
result = new XamlStaticOrTargetedReturnMethodCallNode(node,
type.GetMethod(
new FindMethodMethodSignature("FromUInt32", type, types.UInt) { IsStatic = true }),
- new[] { new XamlConstantNode(node, types.UInt, color.ToUint32()) });
+ new[] { new XamlConstantNode(node, types.UInt, color.ToUInt32()) });
return true;
}
@@ -242,7 +242,7 @@ namespace Avalonia.Markup.Xaml.XamlIl.CompilerExtensions
result = new XamlAstNewClrObjectNode(node, brushTypeRef,
types.ImmutableSolidColorBrushConstructorColor,
- new List { new XamlConstantNode(node, types.UInt, color.ToUint32()) });
+ new List { new XamlConstantNode(node, types.UInt, color.ToUInt32()) });
return true;
}
diff --git a/tests/Avalonia.Markup.Xaml.UnitTests/MarkupExtensions/DynamicResourceExtensionTests.cs b/tests/Avalonia.Markup.Xaml.UnitTests/MarkupExtensions/DynamicResourceExtensionTests.cs
index 535b96420a..523b31e60a 100644
--- a/tests/Avalonia.Markup.Xaml.UnitTests/MarkupExtensions/DynamicResourceExtensionTests.cs
+++ b/tests/Avalonia.Markup.Xaml.UnitTests/MarkupExtensions/DynamicResourceExtensionTests.cs
@@ -34,7 +34,7 @@ namespace Avalonia.Markup.Xaml.UnitTests.MarkupExtensions
DelayedBinding.ApplyBindings(border);
var brush = (ISolidColorBrush)border.Background;
- Assert.Equal(0xff506070, brush.Color.ToUint32());
+ Assert.Equal(0xff506070, brush.Color.ToUInt32());
}
[Fact]
@@ -81,7 +81,7 @@ namespace Avalonia.Markup.Xaml.UnitTests.MarkupExtensions
DelayedBinding.ApplyBindings(border);
var brush = (ISolidColorBrush)border.Background;
- Assert.Equal(0xff506070, brush.Color.ToUint32());
+ Assert.Equal(0xff506070, brush.Color.ToUInt32());
}
[Fact]
@@ -109,7 +109,7 @@ namespace Avalonia.Markup.Xaml.UnitTests.MarkupExtensions
DelayedBinding.ApplyBindings(border);
var brush = (ISolidColorBrush)border.Background;
- Assert.Equal(0xff506070, brush.Color.ToUint32());
+ Assert.Equal(0xff506070, brush.Color.ToUInt32());
}
[Fact]
@@ -141,7 +141,7 @@ namespace Avalonia.Markup.Xaml.UnitTests.MarkupExtensions
DelayedBinding.ApplyBindings(border);
var brush = (ISolidColorBrush)border.Background;
- Assert.Equal(0xff506070, brush.Color.ToUint32());
+ Assert.Equal(0xff506070, brush.Color.ToUInt32());
}
[Fact]
@@ -161,7 +161,7 @@ namespace Avalonia.Markup.Xaml.UnitTests.MarkupExtensions
var border = window.FindControl("border");
var brush = (SolidColorBrush)border.Background;
- Assert.Equal(0xff506070, brush.Color.ToUint32());
+ Assert.Equal(0xff506070, brush.Color.ToUInt32());
}
}
@@ -187,7 +187,7 @@ namespace Avalonia.Markup.Xaml.UnitTests.MarkupExtensions
window.Show();
var brush = (SolidColorBrush)border.Background;
- Assert.Equal(0xff506070, brush.Color.ToUint32());
+ Assert.Equal(0xff506070, brush.Color.ToUInt32());
}
}
@@ -214,7 +214,7 @@ namespace Avalonia.Markup.Xaml.UnitTests.MarkupExtensions
var button = window.FindControl