Fix some other AVP warnings

samples/ControlCatalog/Pages/CustomDrawingExampleControl.cs

@@ -19,18 +19,16 @@ namespace ControlCatalog.Pages
         public static readonly StyledProperty<double> ScaleProperty = AvaloniaProperty.Register<CustomDrawingExampleControl, double>(nameof(Scale), 1.0d);
         public double Scale { get => GetValue(ScaleProperty); set => SetValue(ScaleProperty, value); }
 
-        public static readonly StyledProperty<double> RotationProperty = AvaloniaProperty.Register<CustomDrawingExampleControl, double>(nameof(Rotation));
+        public static readonly StyledProperty<double> RotationProperty = AvaloniaProperty.Register<CustomDrawingExampleControl, double>(nameof(Rotation),
+            coerce: (_, val) => val % (Math.PI * 2));
+
         /// <summary>
         /// Rotation, measured in Radians!
         /// </summary>
         public double Rotation
         {
             get => GetValue(RotationProperty);
-            set
-            {
-                double valueToUse = value % (Math.PI * 2);
-                SetValue(RotationProperty, valueToUse);
-            }
+            set => SetValue(RotationProperty, value);
         }
 
         public static readonly StyledProperty<double> ViewportCenterYProperty = AvaloniaProperty.Register<CustomDrawingExampleControl, double>(nameof(ViewportCenterY), 0.0d);
@@ -213,5 +211,6 @@ namespace ControlCatalog.Pages
 
             return workingPoint;
         }
+
     }
 }

src/Avalonia.Controls/DefinitionBase.cs

@@ -37,7 +37,7 @@ namespace Avalonia.Controls
             {
                 //  start with getting SharedSizeGroup value. 
                 //  this property is NOT inherited which should result in better overall perf.
-                if (SharedSizeGroup is { } sharedSizeGroupId && PrivateSharedSizeScope is { } privateSharedSizeScope)
+                if (SharedSizeGroup is { } sharedSizeGroupId && GetValue(PrivateSharedSizeScopeProperty) is { } privateSharedSizeScope)
                 {
                     _sharedState = privateSharedSizeScope.EnsureSharedState(sharedSizeGroupId);
                     _sharedState.AddMember(this);
@@ -333,7 +333,7 @@ namespace Avalonia.Controls
 
                 if (definition._sharedState == null
                     && sharedSizeGroupId != null
-                    && definition.PrivateSharedSizeScope is { } privateSharedSizeScope)
+                    && definition.GetValue(PrivateSharedSizeScopeProperty) is { } privateSharedSizeScope)
                 {
                     //  if definition is not registered and both: shared size group id AND private shared scope
                     //  are available, then register definition.
@@ -412,14 +412,6 @@ namespace Avalonia.Controls
             }
         }
 
-        /// <summary>
-        /// Private getter of shared state collection dynamic property.
-        /// </summary>
-        private SharedSizeScope? PrivateSharedSizeScope
-        {
-            get { return GetValue(PrivateSharedSizeScopeProperty); }
-        }
-
         /// <summary>
         /// Convenience accessor to UseSharedMinimum flag
         /// </summary>

src/Avalonia.Controls/Flyouts/PopupFlyoutBase.cs

@@ -44,7 +44,7 @@ namespace Avalonia.Controls.Primitives
         /// Defines the <see cref="OverlayInputPassThroughElement"/> property
         /// </summary>
         public static readonly StyledProperty<IInputElement?> OverlayInputPassThroughElementProperty =
-            Popup.OverlayInputPassThroughElementProperty.AddOwner<FlyoutBase>();
+            Popup.OverlayInputPassThroughElementProperty.AddOwner<PopupFlyoutBase>();
         
         private readonly Lazy<Popup> _popupLazy;
         private Rect? _enlargedPopupRect;

src/Avalonia.Controls/MenuItem.cs

@@ -53,12 +53,6 @@ namespace Avalonia.Controls
         public static readonly StyledProperty<KeyGesture?> InputGestureProperty =
             AvaloniaProperty.Register<MenuItem, KeyGesture?>(nameof(InputGesture));
 
-        /// <summary>
-        /// Defines the <see cref="IsSelected"/> property.
-        /// </summary>
-        public static readonly StyledProperty<bool> IsSelectedProperty =
-            SelectingItemsControl.IsSelectedProperty.AddOwner<MenuItem>();
-
         /// <summary>
         /// Defines the <see cref="IsSubMenuOpen"/> property.
         /// </summary>

src/Avalonia.Controls/PullToRefresh/RefreshVisualizer.cs

@@ -99,7 +99,7 @@ namespace Avalonia.Controls
             }
         }
 
-        internal PullDirection PullDirection
+        public PullDirection PullDirection
         {
             get => GetValue(PullDirectionProperty);
             set => SetValue(PullDirectionProperty, value);

src/Avalonia.ReactiveUI/Avalonia.ReactiveUI.csproj

@@ -12,4 +12,5 @@
   <Import Project="..\..\build\ApiDiff.props" />
   <Import Project="..\..\build\NullableEnable.props" />
   <Import Project="..\..\build\TrimmingEnable.props" />
+  <Import Project="..\..\build\DevAnalyzers.props" />
 </Project>

src/Avalonia.Themes.Fluent/Avalonia.Themes.Fluent.csproj

@@ -15,4 +15,5 @@
   <Import Project="..\..\build\BuildTargets.targets" />
   <Import Project="..\..\build\ApiDiff.props" />
   <Import Project="..\..\build\TrimmingEnable.props" />
+  <Import Project="..\..\build\DevAnalyzers.props" />
 </Project>

src/Avalonia.Themes.Simple/Avalonia.Themes.Simple.csproj

@@ -15,4 +15,5 @@
   <Import Project="..\..\build\BuildTargets.targets" />
   <Import Project="..\..\build\ApiDiff.props" />
   <Import Project="..\..\build\TrimmingEnable.props" />
+  <Import Project="..\..\build\DevAnalyzers.props" />
 </Project>