Browse Source

Starting removing hard dependency on Serilog.

Instead log through a static Logger, and provide a Serilog consumer for
this.
pull/486/head
Steven Kirk 10 years ago
parent
commit
ea6b1d4cfd
  1. 32
      Perspex.sln
  2. 9
      samples/ControlCatalog/App.xaml.cs
  3. 4
      samples/ControlCatalog/ControlCatalog.csproj
  4. 12
      samples/TestApplication/App.config
  5. 4
      src/Markup/Perspex.Markup.Xaml/Perspex.Markup.Xaml.csproj
  6. 1
      src/Markup/Perspex.Markup.Xaml/packages.config
  7. 15
      src/Perspex.Base/Logging/ILogSink.cs
  8. 31
      src/Perspex.Base/Logging/LogArea.cs
  9. 41
      src/Perspex.Base/Logging/LogEventLevel.cs
  10. 84
      src/Perspex.Base/Logging/Logger.cs
  11. 8
      src/Perspex.Base/Perspex.Base.csproj
  12. 46
      src/Perspex.Base/PerspexObject.cs
  13. 30
      src/Perspex.Base/PriorityValue.cs
  14. 1
      src/Perspex.Base/packages.config
  15. 11
      src/Perspex.Controls/Control.cs
  16. 4
      src/Perspex.Controls/Perspex.Controls.csproj
  17. 20
      src/Perspex.Controls/Primitives/TemplatedControl.cs
  18. 14
      src/Perspex.Controls/TopLevel.cs
  19. 1
      src/Perspex.Controls/packages.config
  20. 23
      src/Perspex.Layout/LayoutManager.cs
  21. 25
      src/Perspex.Layout/Layoutable.cs
  22. 4
      src/Perspex.Layout/Perspex.Layout.csproj
  23. 1
      src/Perspex.Layout/packages.config
  24. 63
      src/Perspex.Logging.Serilog/Perspex.Logging.Serilog.csproj
  25. 30
      src/Perspex.Logging.Serilog/Properties/AssemblyInfo.cs
  26. 44
      src/Perspex.Logging.Serilog/SerilogLogger.cs
  27. 4
      src/Perspex.Logging.Serilog/packages.config
  28. 4
      src/Perspex.SceneGraph/Perspex.SceneGraph.csproj
  29. 16
      src/Perspex.SceneGraph/Visual.cs
  30. 2
      src/Perspex.SceneGraph/VisualExtensions.cs
  31. 1
      src/Perspex.SceneGraph/packages.config
  32. 8
      tests/Perspex.Base.UnitTests/Perspex.Base.UnitTests.csproj
  33. 44
      tests/Perspex.Base.UnitTests/PriorityValueTests.cs
  34. 1
      tests/Perspex.Base.UnitTests/packages.config
  35. 12
      tests/Perspex.RenderTests/app.config

32
Perspex.sln

@ -142,6 +142,8 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Perspex.UnitTests", "tests\
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Perspex.Benchmarks", "tests\Perspex.Benchmarks\Perspex.Benchmarks.csproj", "{410AC439-81A1-4EB5-B5E9-6A7FC6B77F4B}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Perspex.Logging.Serilog", "src\Perspex.Logging.Serilog\Perspex.Logging.Serilog.csproj", "{B61B66A3-B82D-4875-8001-89D3394FE0C9}"
EndProject
Global
GlobalSection(SharedMSBuildProjectFiles) = preSolution
src\Shared\RenderHelpers\RenderHelpers.projitems*{fb05ac90-89ba-4f2f-a924-f37875fb547c}*SharedItemsImports = 4
@ -150,20 +152,20 @@ Global
src\Shared\PlatformSupport\PlatformSupport.projitems*{e4d9629c-f168-4224-3f51-a5e482ffbc42}*SharedItemsImports = 13
src\Skia\Perspex.Skia\Perspex.Skia.projitems*{2f59f3d0-748d-4652-b01e-e0d954756308}*SharedItemsImports = 13
src\Shared\PlatformSupport\PlatformSupport.projitems*{db070a10-bf39-4752-8456-86e9d5928478}*SharedItemsImports = 4
src\Shared\RenderHelpers\RenderHelpers.projitems*{925dd807-b651-475f-9f7c-cbeb974ce43d}*SharedItemsImports = 4
src\Skia\Perspex.Skia\Perspex.Skia.projitems*{925dd807-b651-475f-9f7c-cbeb974ce43d}*SharedItemsImports = 4
src\Shared\RenderHelpers\RenderHelpers.projitems*{925dd807-b651-475f-9f7c-cbeb974ce43d}*SharedItemsImports = 4
samples\TestApplicationShared\TestApplicationShared.projitems*{78345174-5b52-4a14-b9fd-d5f2428137f0}*SharedItemsImports = 13
src\Shared\PlatformSupport\PlatformSupport.projitems*{54f237d5-a70a-4752-9656-0c70b1a7b047}*SharedItemsImports = 4
samples\TestApplicationShared\TestApplicationShared.projitems*{ff69b927-c545-49ae-8e16-3d14d621aa12}*SharedItemsImports = 4
src\Shared\RenderHelpers\RenderHelpers.projitems*{3c4c0cb4-0c0f-4450-a37b-148c84ff905f}*SharedItemsImports = 13
src\Shared\PlatformSupport\PlatformSupport.projitems*{811a76cf-1cf6-440f-963b-bbe31bd72a82}*SharedItemsImports = 4
src\Shared\PlatformSupport\PlatformSupport.projitems*{88060192-33d5-4932-b0f9-8bd2763e857d}*SharedItemsImports = 4
src\Shared\RenderHelpers\RenderHelpers.projitems*{47be08a7-5985-410b-9ffc-2264b8ea595f}*SharedItemsImports = 4
src\Skia\Perspex.Skia\Perspex.Skia.projitems*{47be08a7-5985-410b-9ffc-2264b8ea595f}*SharedItemsImports = 4
src\Shared\RenderHelpers\RenderHelpers.projitems*{47be08a7-5985-410b-9ffc-2264b8ea595f}*SharedItemsImports = 4
samples\TestApplicationShared\TestApplicationShared.projitems*{8c923867-8a8f-4f6b-8b80-47d9e8436166}*SharedItemsImports = 4
samples\TestApplicationShared\TestApplicationShared.projitems*{e3a1060b-50d0-44e8-88b6-f44ef2e5bd72}*SharedItemsImports = 4
src\Shared\RenderHelpers\RenderHelpers.projitems*{bd43f7c0-396b-4aa1-bad9-dfde54d51298}*SharedItemsImports = 4
src\Skia\Perspex.Skia\Perspex.Skia.projitems*{bd43f7c0-396b-4aa1-bad9-dfde54d51298}*SharedItemsImports = 4
src\Shared\RenderHelpers\RenderHelpers.projitems*{bd43f7c0-396b-4aa1-bad9-dfde54d51298}*SharedItemsImports = 4
src\Shared\RenderHelpers\RenderHelpers.projitems*{3e908f67-5543-4879-a1dc-08eace79b3cd}*SharedItemsImports = 4
src\Shared\PlatformSupport\PlatformSupport.projitems*{e1aa3dbf-9056-4530-9376-18119a7a3ffe}*SharedItemsImports = 4
EndGlobalSection
@ -1321,6 +1323,30 @@ Global
{410AC439-81A1-4EB5-B5E9-6A7FC6B77F4B}.Release|iPhone.Build.0 = Release|Any CPU
{410AC439-81A1-4EB5-B5E9-6A7FC6B77F4B}.Release|iPhoneSimulator.ActiveCfg = Release|Any CPU
{410AC439-81A1-4EB5-B5E9-6A7FC6B77F4B}.Release|iPhoneSimulator.Build.0 = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Ad-Hoc|Any CPU.ActiveCfg = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Ad-Hoc|Any CPU.Build.0 = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Ad-Hoc|iPhone.ActiveCfg = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Ad-Hoc|iPhone.Build.0 = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Ad-Hoc|iPhoneSimulator.ActiveCfg = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Ad-Hoc|iPhoneSimulator.Build.0 = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.AppStore|Any CPU.ActiveCfg = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.AppStore|Any CPU.Build.0 = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.AppStore|iPhone.ActiveCfg = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.AppStore|iPhone.Build.0 = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.AppStore|iPhoneSimulator.ActiveCfg = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.AppStore|iPhoneSimulator.Build.0 = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Debug|Any CPU.Build.0 = Debug|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Debug|iPhone.ActiveCfg = Debug|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Debug|iPhone.Build.0 = Debug|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Debug|iPhoneSimulator.ActiveCfg = Debug|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Debug|iPhoneSimulator.Build.0 = Debug|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Release|Any CPU.ActiveCfg = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Release|Any CPU.Build.0 = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Release|iPhone.ActiveCfg = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Release|iPhone.Build.0 = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Release|iPhoneSimulator.ActiveCfg = Release|Any CPU
{B61B66A3-B82D-4875-8001-89D3394FE0C9}.Release|iPhoneSimulator.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE

9
samples/ControlCatalog/App.xaml.cs

@ -4,6 +4,7 @@ using Perspex;
using Perspex.Controls;
using Perspex.Diagnostics;
using Perspex.Markup.Xaml;
using Perspex.Logging.Serilog;
using Serilog;
namespace ControlCatalog
@ -41,10 +42,10 @@ namespace ControlCatalog
private void InitializeLogging()
{
#if DEBUG
Log.Logger = new LoggerConfiguration()
.MinimumLevel.Error()
.WriteTo.Trace(outputTemplate: "{Message}")
.CreateLogger();
SerilogLogger.Initialize(new LoggerConfiguration()
.MinimumLevel.Warning()
.WriteTo.Trace(outputTemplate: "{Area}: {Message}")
.CreateLogger());
#endif
}

4
samples/ControlCatalog/ControlCatalog.csproj

@ -174,6 +174,10 @@
<Project>{42472427-4774-4c81-8aff-9f27b8e31721}</Project>
<Name>Perspex.Layout</Name>
</ProjectReference>
<ProjectReference Include="..\..\src\Perspex.Logging.Serilog\Perspex.Logging.Serilog.csproj">
<Project>{b61b66a3-b82d-4875-8001-89d3394fe0c9}</Project>
<Name>Perspex.Logging.Serilog</Name>
</ProjectReference>
<ProjectReference Include="..\..\src\Perspex.ReactiveUI\Perspex.ReactiveUI.csproj">
<Project>{6417b24e-49c2-4985-8db2-3ab9d898ec91}</Project>
<Name>Perspex.ReactiveUI</Name>

12
samples/TestApplication/App.config

@ -18,16 +18,16 @@
<bindingRedirect oldVersion="0.0.0.0-2.2.5.0" newVersion="2.2.5.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="SharpDX.Direct2D1" publicKeyToken="b4dcf0f35e5521f1" culture="neutral"/>
<bindingRedirect oldVersion="0.0.0.0-3.0.1.0" newVersion="3.0.1.0"/>
<assemblyIdentity name="SharpDX.Direct2D1" publicKeyToken="b4dcf0f35e5521f1" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-3.0.1.0" newVersion="3.0.1.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="SharpDX" publicKeyToken="b4dcf0f35e5521f1" culture="neutral"/>
<bindingRedirect oldVersion="0.0.0.0-3.0.1.0" newVersion="3.0.1.0"/>
<assemblyIdentity name="SharpDX" publicKeyToken="b4dcf0f35e5521f1" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-3.0.1.0" newVersion="3.0.1.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="SharpDX.DXGI" publicKeyToken="b4dcf0f35e5521f1" culture="neutral"/>
<bindingRedirect oldVersion="0.0.0.0-3.0.1.0" newVersion="3.0.1.0"/>
<assemblyIdentity name="SharpDX.DXGI" publicKeyToken="b4dcf0f35e5521f1" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-3.0.1.0" newVersion="3.0.1.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="Mono.Cairo" publicKeyToken="0738eb9f132ed756" culture="neutral" />

4
src/Markup/Perspex.Markup.Xaml/Perspex.Markup.Xaml.csproj

@ -317,10 +317,6 @@
</ProjectReference>
</ItemGroup>
<ItemGroup>
<Reference Include="Serilog, Version=1.5.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Serilog.1.5.14\lib\portable-net45+win+wpa81+wp80+MonoAndroid10+MonoTouch10\Serilog.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="Sprache, Version=2.0.0.50, Culture=neutral, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Sprache.2.0.0.50\lib\portable-net4+netcore45+win8+wp8+sl5+MonoAndroid+Xamarin.iOS10+MonoTouch\Sprache.dll</HintPath>
<Private>True</Private>

1
src/Markup/Perspex.Markup.Xaml/packages.config

@ -5,6 +5,5 @@
<package id="Rx-Linq" version="2.2.5" targetFramework="portable46-net451+win81" />
<package id="Rx-Main" version="2.2.5" targetFramework="portable46-net451+win81" />
<package id="Rx-PlatformServices" version="2.2.5" targetFramework="portable46-net451+win81" />
<package id="Serilog" version="1.5.14" targetFramework="portable45-net45+win8" />
<package id="Sprache" version="2.0.0.50" targetFramework="portable45-net45+win8" />
</packages>

15
src/Perspex.Base/Logging/ILogSink.cs

@ -0,0 +1,15 @@
// Copyright (c) The Perspex Project. All rights reserved.
// Licensed under the MIT license. See licence.md file in the project root for full license information.
namespace Perspex.Logging
{
public interface ILogSink
{
void Log(
LogEventLevel level,
string area,
object source,
string messageTemplate,
params object[] propertyValues);
}
}

31
src/Perspex.Base/Logging/LogArea.cs

@ -0,0 +1,31 @@
// Copyright (c) The Perspex Project. All rights reserved.
// Licensed under the MIT license. See licence.md file in the project root for full license information.
namespace Perspex.Logging
{
/// <summary>
/// Specifies the area in which a log event occurred.
/// </summary>
public static class LogArea
{
/// <summary>
/// The log event comes from the property and binding system.
/// </summary>
public const string Property = "Property";
/// <summary>
/// The log event comes from the visual system.
/// </summary>
public const string Visual = "Visual";
/// <summary>
/// The log event comes from the layout system.
/// </summary>
public const string Layout = "Layout";
/// <summary>
/// The log event comes from the control system.
/// </summary>
public const string Control = "Control";
}
}

41
src/Perspex.Base/Logging/LogEventLevel.cs

@ -0,0 +1,41 @@
// Copyright (c) The Perspex Project. All rights reserved.
// Licensed under the MIT license. See licence.md file in the project root for full license information.
namespace Perspex.Logging
{
/// <summary>
/// Specifies the meaning and relative importance of a log event.
/// </summary>
public enum LogEventLevel
{
/// <summary>
/// Anything and everything you might want to know about a running block of code.
/// </summary>
Verbose,
/// <summary>
/// Internal system events that aren't necessarily observable from the outside.
/// </summary>
Debug,
/// <summary>
/// The lifeblood of operational intelligence - things happen.
/// </summary>
Information,
/// <summary>
/// Service is degraded or endangered.
/// </summary>
Warning,
/// <summary>
/// Functionality is unavailable, invariants are broken or data is lost.
/// </summary>
Error,
/// <summary>
/// If you have a pager, it goes off when one of these occurs.
/// </summary>
Fatal
}
}

84
src/Perspex.Base/Logging/Logger.cs

@ -0,0 +1,84 @@
// Copyright (c) The Perspex Project. All rights reserved.
// Licensed under the MIT license. See licence.md file in the project root for full license information.
using System;
using System.Runtime.CompilerServices;
namespace Perspex.Logging
{
public static class Logger
{
public static ILogSink Sink { get; set; }
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void Log(
LogEventLevel level,
string area,
object source,
string messageTemplate,
params object[] propertyValues)
{
Sink?.Log(level, area, source, messageTemplate, propertyValues);
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void Verbose(
string area,
object source,
string messageTemplate,
params object[] propertyValues)
{
Log(LogEventLevel.Verbose, area, source, messageTemplate, propertyValues);
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void Debug(
string area,
object source,
string messageTemplate,
params object[] propertyValues)
{
Log(LogEventLevel.Debug, area, source, messageTemplate, propertyValues);
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void Information(
string area,
object source,
string messageTemplate,
params object[] propertyValues)
{
Log(LogEventLevel.Information, area, source, messageTemplate, propertyValues);
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void Warning(
string area,
object source,
string messageTemplate,
params object[] propertyValues)
{
Log(LogEventLevel.Warning, area, source, messageTemplate, propertyValues);
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void Error(
string area,
object source,
string messageTemplate,
params object[] propertyValues)
{
Log(LogEventLevel.Error, area, source, messageTemplate, propertyValues);
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void Fatal(
string area,
object source,
string messageTemplate,
params object[] propertyValues)
{
Log(LogEventLevel.Fatal, area, source, messageTemplate, propertyValues);
}
}
}

8
src/Perspex.Base/Perspex.Base.csproj

@ -61,6 +61,10 @@
<Compile Include="IDirectPropertyMetadata.cs" />
<Compile Include="IStyledPropertyMetadata.cs" />
<Compile Include="ISupportInitialize.cs" />
<Compile Include="Logging\ILogSink.cs" />
<Compile Include="Logging\LogArea.cs" />
<Compile Include="Logging\LogEventLevel.cs" />
<Compile Include="Logging\Logger.cs" />
<Compile Include="Metadata\DependsOnAttribute.cs" />
<Compile Include="Metadata\ContentAttribute.cs" />
<Compile Include="PerspexDisposable.cs" />
@ -118,10 +122,6 @@
<HintPath>..\..\packages\JetBrains.Annotations.10.0.0\lib\portable-net4+sl5+netcore45+wpa81+wp8+MonoAndroid1+MonoTouch1\JetBrains.Annotations.PCL328.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="Serilog, Version=1.5.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10, processorArchitecture=MSIL">
<HintPath>..\..\packages\Serilog.1.5.14\lib\portable-net45+win+wpa81+wp80+MonoAndroid10+MonoTouch10\Serilog.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="System.Reactive.Core">
<HintPath>..\..\packages\Rx-Core.2.2.5\lib\portable-windows8+net45+wp8\System.Reactive.Core.dll</HintPath>
</Reference>

46
src/Perspex.Base/PerspexObject.cs

@ -7,13 +7,11 @@ using System.ComponentModel;
using System.Linq;
using System.Reactive.Disposables;
using System.Reactive.Linq;
using System.Reactive.Subjects;
using Perspex.Data;
using Perspex.Diagnostics;
using Perspex.Logging;
using Perspex.Threading;
using Perspex.Utilities;
using Serilog;
using Serilog.Core.Enrichers;
namespace Perspex
{
@ -57,23 +55,11 @@ namespace Perspex
/// </summary>
private EventHandler<PerspexPropertyChangedEventArgs> _propertyChanged;
/// <summary>
/// A serilog logger for logging property events.
/// </summary>
private readonly ILogger _propertyLog;
/// <summary>
/// Initializes a new instance of the <see cref="PerspexObject"/> class.
/// </summary>
public PerspexObject()
{
_propertyLog = Log.ForContext(new[]
{
new PropertyEnricher("Area", "Property"),
new PropertyEnricher("SourceContext", GetType()),
new PropertyEnricher("Id", GetHashCode()),
});
foreach (var property in PerspexPropertyRegistry.Instance.GetRegistered(this))
{
object value = property.IsDirect ?
@ -407,9 +393,11 @@ namespace Perspex
throw new ArgumentException($"The property {property.Name} is readonly.");
}
_propertyLog.Verbose(
"Bound {Property} to {Binding} with priority LocalValue",
property,
Logger.Verbose(
LogArea.Property,
this,
"Bound {Property} to {Binding} with priority LocalValue",
property,
GetDescription(source));
IDisposable subscription = null;
@ -442,7 +430,9 @@ namespace Perspex
_values.Add(property, v);
}
_propertyLog.Verbose(
Logger.Verbose(
LogArea.Property,
this,
"Bound {Property} to {Binding} with priority {Priority}",
property,
GetDescription(source),
@ -613,10 +603,10 @@ namespace Perspex
}
PriorityValue result = new PriorityValue(
this,
property.Name,
property.PropertyType,
validate2,
_propertyLog);
validate2);
result.Changed.Subscribe(x =>
{
@ -631,11 +621,13 @@ namespace Perspex
{
RaisePropertyChanged(property, oldValue, newValue, (BindingPriority)result.ValuePriority);
_propertyLog.Verbose(
Logger.Verbose(
LogArea.Property,
this,
"{Property} changed from {$Old} to {$Value} with priority {Priority}",
property,
oldValue,
newValue,
property,
oldValue,
newValue,
(BindingPriority)result.ValuePriority);
}
});
@ -728,7 +720,9 @@ namespace Perspex
/// <param name="priority">The priority.</param>
private void LogPropertySet(PerspexProperty property, object value, BindingPriority priority)
{
_propertyLog.Verbose(
Logger.Verbose(
LogArea.Property,
this,
"Set {Property} to {$Value} with priority {Priority}",
property,
value,

30
src/Perspex.Base/PriorityValue.cs

@ -6,8 +6,8 @@ using System.Collections.Generic;
using System.Linq;
using System.Reactive.Subjects;
using System.Text;
using Perspex.Logging;
using Perspex.Utilities;
using Serilog;
namespace Perspex
{
@ -25,6 +25,11 @@ namespace Perspex
/// </remarks>
internal class PriorityValue
{
/// <summary>
/// The owner of the object.
/// </summary>
private readonly PerspexObject _owner;
/// <summary>
/// The name of the property.
/// </summary>
@ -55,30 +60,25 @@ namespace Perspex
/// </summary>
private readonly Func<object, object> _validate;
/// <summary>
/// An optional logger.
/// </summary>
private ILogger _logger;
/// <summary>
/// Initializes a new instance of the <see cref="PriorityValue"/> class.
/// </summary>
/// <param name="owner">The owner of the object.</param>
/// <param name="name">The name of the property.</param>
/// <param name="valueType">The value type.</param>
/// <param name="validate">An optional validation function.</param>
/// <param name="logger">An optional logger</param>
public PriorityValue(
PerspexObject owner,
string name,
Type valueType,
Func<object, object> validate = null,
ILogger logger = null)
Func<object, object> validate = null)
{
_owner = owner;
_name = name;
_valueType = valueType;
_value = PerspexProperty.UnsetValue;
ValuePriority = int.MaxValue;
_validate = validate;
_logger = logger;
}
/// <summary>
@ -239,12 +239,14 @@ namespace Perspex
_value = castValue;
_changed.OnNext(Tuple.Create(old, _value));
}
else if (_logger != null)
else
{
_logger.Error(
Logger.Error(
LogArea.Property,
_owner,
"Binding produced invalid value for {$Property} ({$PropertyType}): {$Value} ({$ValueType})",
_name,
_valueType,
_name,
_valueType,
value,
value.GetType());
}

1
src/Perspex.Base/packages.config

@ -6,5 +6,4 @@
<package id="Rx-Linq" version="2.2.5" targetFramework="portable-net45+win8" />
<package id="Rx-Main" version="2.2.5" targetFramework="portable-net45+win8" />
<package id="Rx-PlatformServices" version="2.2.5" targetFramework="portable-net45+win8" />
<package id="Serilog" version="1.5.14" targetFramework="portable45-net45+win8" />
</packages>

11
src/Perspex.Controls/Control.cs

@ -15,6 +15,7 @@ using Perspex.Data;
using Perspex.Diagnostics;
using Perspex.Input;
using Perspex.Interactivity;
using Perspex.Logging;
using Perspex.LogicalTree;
using Perspex.Styling;
@ -543,11 +544,15 @@ namespace Perspex.Controls
child.OnDetachedFromLogicalTree(e);
}
#if DEBUG
if (((INotifyCollectionChangedDebug)_classes).GetCollectionChangedSubscribers()?.Length > 0)
{
// TODO: This should be output using a standard logging mechanism.
System.Diagnostics.Debug.WriteLine(
$"{this.GetType().Name} detached from logical tree but still has class listeners");
Logger.Warning(
LogArea.Control,
this,
"{Type} detached from logical tree but still has class listeners",
this.GetType());
#endif
}
}
}

4
src/Perspex.Controls/Perspex.Controls.csproj

@ -198,10 +198,6 @@
<HintPath>..\..\packages\JetBrains.Annotations.10.0.0\lib\portable-net4+sl5+netcore45+wpa81+wp8+MonoAndroid1+MonoTouch1\JetBrains.Annotations.PCL328.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="Serilog, Version=1.5.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10, processorArchitecture=MSIL">
<HintPath>..\..\packages\Serilog.1.5.14\lib\portable-net45+win+wpa81+wp80+MonoAndroid10+MonoTouch10\Serilog.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="System.Reactive.Core">
<HintPath>..\..\packages\Rx-Core.2.2.5\lib\portable-windows8+net45+wp8\System.Reactive.Core.dll</HintPath>
</Reference>

20
src/Perspex.Controls/Primitives/TemplatedControl.cs

@ -7,12 +7,11 @@ using System.Reactive.Linq;
using Perspex.Controls.Templates;
using Perspex.Data;
using Perspex.Interactivity;
using Perspex.Logging;
using Perspex.LogicalTree;
using Perspex.Media;
using Perspex.Styling;
using Perspex.VisualTree;
using Serilog;
using Serilog.Core.Enrichers;
namespace Perspex.Controls.Primitives
{
@ -97,8 +96,6 @@ namespace Perspex.Controls.Primitives
private bool _templateApplied;
private readonly ILogger _templateLog;
/// <summary>
/// Initializes static members of the <see cref="TemplatedControl"/> class.
/// </summary>
@ -108,19 +105,6 @@ namespace Perspex.Controls.Primitives
TemplateProperty.Changed.AddClassHandler<TemplatedControl>(x => x.OnTemplateChanged);
}
/// <summary>
/// Initializes a new instance of the <see cref="TemplatedControl"/> class.
/// </summary>
public TemplatedControl()
{
_templateLog = Log.ForContext(new[]
{
new PropertyEnricher("Area", "Template"),
new PropertyEnricher("SourceContext", GetType()),
new PropertyEnricher("Id", GetHashCode()),
});
}
/// <summary>
/// Raised when the control's template is applied.
/// </summary>
@ -264,7 +248,7 @@ namespace Perspex.Controls.Primitives
if (Template != null)
{
_templateLog.Verbose("Creating control template");
Logger.Verbose(LogArea.Control, this, "Creating control template");
var child = Template.Build(this);
var nameScope = new NameScope();

14
src/Perspex.Controls/TopLevel.cs

@ -9,6 +9,7 @@ using Perspex.Controls.Primitives;
using Perspex.Input;
using Perspex.Input.Raw;
using Perspex.Layout;
using Perspex.Logging;
using Perspex.Platform;
using Perspex.Rendering;
using Perspex.Styling;
@ -320,13 +321,18 @@ namespace Perspex.Controls
/// <typeparam name="T">The service type.</typeparam>
/// <param name="resolver">The resolver.</param>
/// <returns>The service.</returns>
private static T TryGetService<T>(IPerspexDependencyResolver resolver) where T : class
private T TryGetService<T>(IPerspexDependencyResolver resolver) where T : class
{
var result = resolver.GetService<T>();
System.Diagnostics.Debug.WriteLineIf(
result == null,
$"Could not create {typeof(T).Name} : maybe Application.RegisterServices() wasn't called?");
if (result == null)
{
Logger.Warning(
LogArea.Control,
this,
"Could not create {Service} : maybe Application.RegisterServices() wasn't called?",
typeof(T));
}
return result;
}

1
src/Perspex.Controls/packages.config

@ -6,5 +6,4 @@
<package id="Rx-Linq" version="2.2.5" targetFramework="portable-net45+win8" />
<package id="Rx-Main" version="2.2.5" targetFramework="portable-net45+win8" />
<package id="Rx-PlatformServices" version="2.2.5" targetFramework="portable-net45+win8" />
<package id="Serilog" version="1.5.14" targetFramework="portable45-net45+win8" />
</packages>

23
src/Perspex.Layout/LayoutManager.cs

@ -3,9 +3,8 @@
using System;
using System.Collections.Generic;
using Perspex.Logging;
using Perspex.Threading;
using Serilog;
using Serilog.Core.Enrichers;
namespace Perspex.Layout
{
@ -16,23 +15,9 @@ namespace Perspex.Layout
{
private readonly Queue<ILayoutable> _toMeasure = new Queue<ILayoutable>();
private readonly Queue<ILayoutable> _toArrange = new Queue<ILayoutable>();
private readonly ILogger _log;
private bool _queued;
private bool _running;
/// <summary>
/// Initializes a new instance of the <see cref="LayoutManager"/> class.
/// </summary>
public LayoutManager()
{
_log = Log.ForContext(new[]
{
new PropertyEnricher("Area", "Layout"),
new PropertyEnricher("SourceContext", GetType()),
new PropertyEnricher("Id", GetHashCode()),
});
}
/// <summary>
/// Gets the layout manager.
/// </summary>
@ -70,7 +55,9 @@ namespace Perspex.Layout
{
_running = true;
_log.Information(
Logger.Information(
LogArea.Layout,
this,
"Started layout pass. To measure: {Measure} To arrange: {Arrange}",
_toMeasure.Count,
_toArrange.Count);
@ -97,7 +84,7 @@ namespace Perspex.Layout
}
stopwatch.Stop();
_log.Information("Layout pass finised in {Time}", stopwatch.Elapsed);
Logger.Information(LogArea.Layout, this, "Layout pass finised in {Time}", stopwatch.Elapsed);
}
_queued = false;

25
src/Perspex.Layout/Layoutable.cs

@ -3,10 +3,9 @@
using System;
using System.Linq;
using Perspex.Logging;
using Perspex.Platform;
using Perspex.VisualTree;
using Serilog;
using Serilog.Core.Enrichers;
namespace Perspex.Layout
{
@ -133,7 +132,6 @@ namespace Perspex.Layout
public static readonly StyledProperty<bool> UseLayoutRoundingProperty =
PerspexProperty.Register<Layoutable, bool>(nameof(UseLayoutRounding), defaultValue: true, inherits: true);
private readonly ILogger _layoutLog;
private bool _measuring;
private Size? _previousMeasure;
private Rect? _previousArrange;
@ -156,19 +154,6 @@ namespace Perspex.Layout
VerticalAlignmentProperty);
}
/// <summary>
/// Initializes a new instance of the <see cref="Layoutable"/> class.
/// </summary>
public Layoutable()
{
_layoutLog = Log.ForContext(new[]
{
new PropertyEnricher("Area", "Layout"),
new PropertyEnricher("SourceContext", GetType()),
new PropertyEnricher("Id", GetHashCode()),
});
}
/// <summary>
/// Gets or sets the width of the element.
/// </summary>
@ -340,7 +325,7 @@ namespace Perspex.Layout
DesiredSize = desiredSize;
_previousMeasure = availableSize;
_layoutLog.Verbose("Measure requested {DesiredSize}", DesiredSize);
Logger.Verbose(LogArea.Layout, this, "Measure requested {DesiredSize}", DesiredSize);
if (DesiredSize != previousDesiredSize)
{
@ -367,7 +352,7 @@ namespace Perspex.Layout
if (!IsArrangeValid || _previousArrange != rect)
{
_layoutLog.Verbose("Arrange to {Rect} ", rect);
Logger.Verbose(LogArea.Layout, this, "Arrange to {Rect} ", rect);
IsArrangeValid = true;
ArrangeCore(rect);
@ -382,7 +367,7 @@ namespace Perspex.Layout
{
if (IsMeasureValid)
{
_layoutLog.Verbose("Invalidated measure");
Logger.Verbose(LogArea.Layout, this, "Invalidated measure");
IsMeasureValid = false;
IsArrangeValid = false;
@ -398,7 +383,7 @@ namespace Perspex.Layout
{
if (IsArrangeValid)
{
_layoutLog.Verbose("Arrange measure");
Logger.Verbose(LogArea.Layout, this, "Invalidated arrange");
IsArrangeValid = false;
LayoutManager.Instance?.InvalidateArrange(this);

4
src/Perspex.Layout/Perspex.Layout.csproj

@ -67,10 +67,6 @@
<Compile Include="Properties\AssemblyInfo.cs" />
</ItemGroup>
<ItemGroup>
<Reference Include="Serilog, Version=1.5.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10, processorArchitecture=MSIL">
<HintPath>..\..\packages\Serilog.1.5.14\lib\portable-net45+win+wpa81+wp80+MonoAndroid10+MonoTouch10\Serilog.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="System.Reactive.Core">
<HintPath>..\..\packages\Rx-Core.2.2.5\lib\portable-windows8+net45+wp8\System.Reactive.Core.dll</HintPath>
</Reference>

1
src/Perspex.Layout/packages.config

@ -5,5 +5,4 @@
<package id="Rx-Linq" version="2.2.5" targetFramework="portable-net45+win8" />
<package id="Rx-Main" version="2.2.5" targetFramework="portable-net45+win8" />
<package id="Rx-PlatformServices" version="2.2.5" targetFramework="portable-net45+win8" />
<package id="Serilog" version="1.5.14" targetFramework="portable45-net45+win8" />
</packages>

63
src/Perspex.Logging.Serilog/Perspex.Logging.Serilog.csproj

@ -0,0 +1,63 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<PropertyGroup>
<MinimumVisualStudioVersion>10.0</MinimumVisualStudioVersion>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
<Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
<ProjectGuid>{B61B66A3-B82D-4875-8001-89D3394FE0C9}</ProjectGuid>
<OutputType>Library</OutputType>
<AppDesignerFolder>Properties</AppDesignerFolder>
<RootNamespace>Perspex.Logging.Serilog</RootNamespace>
<AssemblyName>Perspex.Logging.Serilog</AssemblyName>
<DefaultLanguage>en-US</DefaultLanguage>
<FileAlignment>512</FileAlignment>
<ProjectTypeGuids>{786C830F-07A1-408B-BD7F-6EE04809D6DB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
<TargetFrameworkProfile>Profile7</TargetFrameworkProfile>
<TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DebugSymbols>true</DebugSymbols>
<DebugType>full</DebugType>
<Optimize>false</Optimize>
<OutputPath>bin\Debug\</OutputPath>
<DefineConstants>DEBUG;TRACE</DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<DebugType>pdbonly</DebugType>
<Optimize>true</Optimize>
<OutputPath>bin\Release\</OutputPath>
<DefineConstants>TRACE</DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
</PropertyGroup>
<ItemGroup>
<Compile Include="SerilogLogger.cs" />
<Compile Include="Properties\AssemblyInfo.cs" />
</ItemGroup>
<ItemGroup>
<Reference Include="Serilog, Version=1.5.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10, processorArchitecture=MSIL">
<HintPath>..\..\packages\Serilog.1.5.14\lib\portable-net45+win+wpa81+wp80+MonoAndroid10+MonoTouch10\Serilog.dll</HintPath>
<Private>True</Private>
</Reference>
</ItemGroup>
<ItemGroup>
<None Include="packages.config" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Perspex.Base\Perspex.Base.csproj">
<Project>{b09b78d8-9b26-48b0-9149-d64a2f120f3f}</Project>
<Name>Perspex.Base</Name>
</ProjectReference>
</ItemGroup>
<Import Project="$(MSBuildExtensionsPath32)\Microsoft\Portable\$(TargetFrameworkVersion)\Microsoft.Portable.CSharp.targets" />
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
Other similar extension points exist, see Microsoft.Common.targets.
<Target Name="BeforeBuild">
</Target>
<Target Name="AfterBuild">
</Target>
-->
</Project>

30
src/Perspex.Logging.Serilog/Properties/AssemblyInfo.cs

@ -0,0 +1,30 @@
using System.Resources;
using System.Reflection;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
// General Information about an assembly is controlled through the following
// set of attributes. Change these attribute values to modify the information
// associated with an assembly.
[assembly: AssemblyTitle("Perspex.Serilog")]
[assembly: AssemblyDescription("")]
[assembly: AssemblyConfiguration("")]
[assembly: AssemblyCompany("")]
[assembly: AssemblyProduct("Perspex.Serilog")]
[assembly: AssemblyCopyright("Copyright © 2016")]
[assembly: AssemblyTrademark("")]
[assembly: AssemblyCulture("")]
[assembly: NeutralResourcesLanguage("en")]
// Version information for an assembly consists of the following four values:
//
// Major Version
// Minor Version
// Build Number
// Revision
//
// You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")]

44
src/Perspex.Logging.Serilog/SerilogLogger.cs

@ -0,0 +1,44 @@
// Copyright (c) The Perspex Project. All rights reserved.
// Licensed under the MIT license. See licence.md file in the project root for full license information.
using System.Collections.Generic;
using Serilog;
using PerspexLogEventLevel = Perspex.Logging.LogEventLevel;
using SerilogLogEventLevel = Serilog.Events.LogEventLevel;
namespace Perspex.Logging.Serilog
{
public class SerilogLogger : ILogSink
{
private readonly ILogger _output;
private readonly Dictionary<string, ILogger> _areas = new Dictionary<string, ILogger>();
public SerilogLogger(ILogger output)
{
_output = output;
}
public static void Initialize(ILogger output)
{
Logger.Sink = new SerilogLogger(output);
}
public void Log(
PerspexLogEventLevel level,
string area,
object source,
string messageTemplate,
params object[] propertyValues)
{
ILogger areaLogger;
if (!_areas.TryGetValue(area, out areaLogger))
{
areaLogger = _output.ForContext("Area", area);
_areas.Add(area, areaLogger);
}
areaLogger.Write((SerilogLogEventLevel)level, messageTemplate, propertyValues);
}
}
}

4
src/Perspex.Logging.Serilog/packages.config

@ -0,0 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="Serilog" version="1.5.14" targetFramework="portable45-net45+win8" />
</packages>

4
src/Perspex.SceneGraph/Perspex.SceneGraph.csproj

@ -140,10 +140,6 @@
<Compile Include="VisualTree\VisualExtensions.cs" />
</ItemGroup>
<ItemGroup>
<Reference Include="Serilog, Version=1.5.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10, processorArchitecture=MSIL">
<HintPath>..\..\packages\Serilog.1.5.14\lib\portable-net45+win+wpa81+wp80+MonoAndroid10+MonoTouch10\Serilog.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="System.Reactive.Core">
<HintPath>..\..\packages\Rx-Core.2.2.5\lib\portable-windows8+net45+wp8\System.Reactive.Core.dll</HintPath>
</Reference>

16
src/Perspex.SceneGraph/Visual.cs

@ -2,19 +2,17 @@
// Licensed under the MIT license. See licence.md file in the project root for full license information.
using System;
using System.Collections.Generic;
using System.Collections.Specialized;
using System.Linq;
using System.Reactive.Linq;
using Perspex.Animation;
using Perspex.Collections;
using Perspex.Data;
using Perspex.Logging;
using Perspex.Media;
using Perspex.Platform;
using Perspex.Rendering;
using Perspex.VisualTree;
using Serilog;
using Serilog.Core.Enrichers;
namespace Perspex
{
@ -79,7 +77,6 @@ namespace Perspex
private Rect _bounds;
private IVisual _visualParent;
private readonly ILogger _visualLogger;
/// <summary>
/// Initializes static members of the <see cref="Visual"/> class.
@ -95,13 +92,6 @@ namespace Perspex
/// </summary>
public Visual()
{
_visualLogger = Log.ForContext(new[]
{
new PropertyEnricher("Area", "Visual"),
new PropertyEnricher("SourceContext", GetType()),
new PropertyEnricher("Id", GetHashCode()),
});
var visualChildren = new PerspexList<IVisual>();
visualChildren.ResetBehavior = ResetBehavior.Remove;
visualChildren.Validate = ValidateLogicalChild;
@ -474,7 +464,7 @@ namespace Perspex
/// <param name="e">The event args.</param>
private void NotifyAttachedToVisualTree(VisualTreeAttachmentEventArgs e)
{
_visualLogger.Verbose("Attached to visual tree");
Logger.Verbose(LogArea.Visual, this, "Attached to visual tree");
VisualRoot = e.Root;
OnAttachedToVisualTree(e);
@ -495,7 +485,7 @@ namespace Perspex
/// <param name="e">The event args.</param>
private void NotifyDetachedFromVisualTree(VisualTreeAttachmentEventArgs e)
{
_visualLogger.Verbose("Detached from visual tree");
Logger.Verbose(LogArea.Visual, this, "Detached from visual tree");
VisualRoot = null;
OnDetachedFromVisualTree(e);

2
src/Perspex.SceneGraph/VisualExtensions.cs

@ -13,8 +13,6 @@ using Perspex.Media;
using Perspex.Platform;
using Perspex.Rendering;
using Perspex.VisualTree;
using Serilog;
using Serilog.Core.Enrichers;
namespace Perspex
{

1
src/Perspex.SceneGraph/packages.config

@ -5,5 +5,4 @@
<package id="Rx-Linq" version="2.2.5" targetFramework="portable-net45+win8" />
<package id="Rx-Main" version="2.2.5" targetFramework="portable-net45+win8" />
<package id="Rx-PlatformServices" version="2.2.5" targetFramework="portable-net45+win8" />
<package id="Serilog" version="1.5.14" targetFramework="portable45-net45+win8" />
</packages>

8
tests/Perspex.Base.UnitTests/Perspex.Base.UnitTests.csproj

@ -44,14 +44,6 @@
<Private>True</Private>
</Reference>
<Reference Include="Microsoft.VisualStudio.QualityTools.UnitTestFramework, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL" />
<Reference Include="Serilog, Version=1.5.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10, processorArchitecture=MSIL">
<HintPath>..\..\packages\Serilog.1.5.14\lib\net45\Serilog.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="Serilog.FullNetFx, Version=1.5.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10, processorArchitecture=MSIL">
<HintPath>..\..\packages\Serilog.1.5.14\lib\net45\Serilog.FullNetFx.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="System" />
<Reference Include="System.Reactive.Core, Version=2.2.5.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\packages\Rx-Core.2.2.5\lib\net45\System.Reactive.Core.dll</HintPath>

44
tests/Perspex.Base.UnitTests/PriorityValueTests.cs

@ -14,7 +14,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Initial_Value_Should_Be_UnsetValue()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
Assert.Same(PerspexProperty.UnsetValue, target.Value);
}
@ -22,7 +22,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void First_Binding_Sets_Value()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
target.Add(Single("foo"), 0);
@ -32,7 +32,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Changing_Binding_Should_Set_Value()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
var subject = new BehaviorSubject<string>("foo");
target.Add(subject, 0);
@ -44,7 +44,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Setting_Direct_Value_Should_Override_Binding()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
target.Add(Single("foo"), 0);
target.SetValue("bar", 0);
@ -55,7 +55,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Binding_Firing_Should_Override_Direct_Value()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
var source = new BehaviorSubject<object>("initial");
target.Add(source, 0);
@ -69,7 +69,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Earlier_Binding_Firing_Should_Override_Later_Priority_0()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
var nonActive = new BehaviorSubject<object>("na");
var source = new BehaviorSubject<object>("initial");
@ -85,7 +85,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Earlier_Binding_Firing_Should_Not_Override_Later_Priority_1()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
var nonActive = new BehaviorSubject<object>("na");
var source = new BehaviorSubject<object>("initial");
@ -101,7 +101,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Binding_Completing_Should_Revert_To_Direct_Value()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
var source = new BehaviorSubject<object>("initial");
target.Add(source, 0);
@ -117,7 +117,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Binding_With_Lower_Priority_Has_Precedence()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
target.Add(Single("foo"), 1);
target.Add(Single("bar"), 0);
@ -129,7 +129,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Later_Binding_With_Same_Priority_Should_Take_Precedence()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
target.Add(Single("foo"), 1);
target.Add(Single("bar"), 0);
@ -142,7 +142,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Changing_Binding_With_Lower_Priority_Should_Set_Not_Value()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
var subject = new BehaviorSubject<string>("bar");
target.Add(Single("foo"), 0);
@ -155,7 +155,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void UnsetValue_Should_Fall_Back_To_Next_Binding()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
var subject = new BehaviorSubject<object>("bar");
target.Add(subject, 0);
@ -171,7 +171,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Adding_Value_Should_Call_OnNext()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
bool called = false;
target.Changed.Subscribe(value => called = value.Item1 == PerspexProperty.UnsetValue && (string)value.Item2 == "foo");
@ -183,7 +183,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Changing_Value_Should_Call_OnNext()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
var subject = new BehaviorSubject<object>("foo");
bool called = false;
@ -197,7 +197,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Disposing_A_Binding_Should_Revert_To_Next_Value()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
target.Add(Single("foo"), 0);
var disposable = target.Add(Single("bar"), 0);
@ -210,7 +210,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Disposing_A_Binding_Should_Remove_BindingEntry()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
target.Add(Single("foo"), 0);
var disposable = target.Add(Single("bar"), 0);
@ -223,7 +223,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Completing_A_Binding_Should_Revert_To_Previous_Binding()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
var source = new BehaviorSubject<object>("bar");
target.Add(Single("foo"), 0);
@ -237,7 +237,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Completing_A_Binding_Should_Revert_To_Lower_Priority()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
var source = new BehaviorSubject<object>("bar");
target.Add(Single("foo"), 1);
@ -251,7 +251,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Completing_A_Binding_Should_Remove_BindingEntry()
{
var target = new PriorityValue("Test", typeof(string));
var target = new PriorityValue(null, "Test", typeof(string));
var subject = new BehaviorSubject<object>("bar");
target.Add(Single("foo"), 0);
@ -265,7 +265,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Direct_Value_Should_Be_Coerced()
{
var target = new PriorityValue("Test", typeof(int), x => Math.Min((int)x, 10));
var target = new PriorityValue(null, "Test", typeof(int), x => Math.Min((int)x, 10));
target.SetValue(5, 0);
Assert.Equal(5, target.Value);
@ -276,7 +276,7 @@ namespace Perspex.Base.UnitTests
[Fact]
public void Bound_Value_Should_Be_Coerced()
{
var target = new PriorityValue("Test", typeof(int), x => Math.Min((int)x, 10));
var target = new PriorityValue(null, "Test", typeof(int), x => Math.Min((int)x, 10));
var source = new Subject<object>();
target.Add(source, 0);
@ -290,7 +290,7 @@ namespace Perspex.Base.UnitTests
public void Revalidate_Should_ReCoerce_Value()
{
var max = 10;
var target = new PriorityValue("Test", typeof(int), x => Math.Min((int)x, max));
var target = new PriorityValue(null, "Test", typeof(int), x => Math.Min((int)x, max));
var source = new Subject<object>();
target.Add(source, 0);

1
tests/Perspex.Base.UnitTests/packages.config

@ -6,7 +6,6 @@
<package id="Rx-Main" version="2.2.5" targetFramework="net45" />
<package id="Rx-PlatformServices" version="2.2.5" targetFramework="net45" />
<package id="Rx-Testing" version="2.2.5" targetFramework="net45" />
<package id="Serilog" version="1.5.14" targetFramework="net45" />
<package id="xunit" version="2.1.0" targetFramework="net45" />
<package id="xunit.abstractions" version="2.0.0" targetFramework="net45" />
<package id="xunit.assert" version="2.1.0" targetFramework="net45" />

12
tests/Perspex.RenderTests/app.config

@ -15,16 +15,16 @@
<bindingRedirect oldVersion="0.0.0.0-2.1.30214.0" newVersion="2.1.30214.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="SharpDX.Direct2D1" publicKeyToken="b4dcf0f35e5521f1" culture="neutral"/>
<bindingRedirect oldVersion="0.0.0.0-3.0.1.0" newVersion="3.0.1.0"/>
<assemblyIdentity name="SharpDX.Direct2D1" publicKeyToken="b4dcf0f35e5521f1" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-3.0.1.0" newVersion="3.0.1.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="SharpDX" publicKeyToken="b4dcf0f35e5521f1" culture="neutral"/>
<bindingRedirect oldVersion="0.0.0.0-3.0.1.0" newVersion="3.0.1.0"/>
<assemblyIdentity name="SharpDX" publicKeyToken="b4dcf0f35e5521f1" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-3.0.1.0" newVersion="3.0.1.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="SharpDX.DXGI" publicKeyToken="b4dcf0f35e5521f1" culture="neutral"/>
<bindingRedirect oldVersion="0.0.0.0-3.0.1.0" newVersion="3.0.1.0"/>
<assemblyIdentity name="SharpDX.DXGI" publicKeyToken="b4dcf0f35e5521f1" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-3.0.1.0" newVersion="3.0.1.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="Mono.Cairo" publicKeyToken="0738eb9f132ed756" culture="neutral" />

Loading…
Cancel
Save