diff --git a/src/Avalonia.Base/Rendering/Composition/CompositingRenderer.cs b/src/Avalonia.Base/Rendering/Composition/CompositingRenderer.cs
index 9aa3c25425..9742a6b3ba 100644
--- a/src/Avalonia.Base/Rendering/Composition/CompositingRenderer.cs
+++ b/src/Avalonia.Base/Rendering/Composition/CompositingRenderer.cs
@@ -29,6 +29,7 @@ public class CompositingRenderer : IRendererWithCompositor
private bool _queuedUpdate;
private Action _update;
private Action _invalidateScene;
+ private bool _updating;
internal CompositionTarget CompositionTarget;
@@ -77,6 +78,8 @@ public class CompositingRenderer : IRendererWithCompositor
///
public void AddDirty(IVisual visual)
{
+ if (_updating)
+ throw new InvalidOperationException("Visual was invalidated during the render pass");
_dirty.Add((Visual)visual);
QueueUpdate();
}
@@ -107,6 +110,8 @@ public class CompositingRenderer : IRendererWithCompositor
///
public void RecalculateChildren(IVisual visual)
{
+ if (_updating)
+ throw new InvalidOperationException("Visual was invalidated during the render pass");
_recalculateChildren.Add((Visual)visual);
QueueUpdate();
}
@@ -191,7 +196,7 @@ public class CompositingRenderer : IRendererWithCompositor
private void InvalidateScene() =>
SceneInvalidated?.Invoke(this, new SceneInvalidatedEventArgs(_root, new Rect(_root.ClientSize)));
- private void Update()
+ private void UpdateCore()
{
_queuedUpdate = false;
foreach (var visual in _dirty)
@@ -240,6 +245,21 @@ public class CompositingRenderer : IRendererWithCompositor
CompositionTarget.Scaling = _root.RenderScaling;
Compositor.InvokeOnNextCommit(_invalidateScene);
}
+
+ private void Update()
+ {
+ if(_updating)
+ return;
+ _updating = true;
+ try
+ {
+ UpdateCore();
+ }
+ finally
+ {
+ _updating = false;
+ }
+ }
public void Resized(Size size)
{
diff --git a/src/Avalonia.Base/Rendering/DirtyVisuals.cs b/src/Avalonia.Base/Rendering/DirtyVisuals.cs
index 00bc236b9c..999b12e810 100644
--- a/src/Avalonia.Base/Rendering/DirtyVisuals.cs
+++ b/src/Avalonia.Base/Rendering/DirtyVisuals.cs
@@ -17,8 +17,7 @@ namespace Avalonia.Rendering
{
private SortedDictionary> _inner = new SortedDictionary>();
private Dictionary _index = new Dictionary();
- private List _deferredChanges = new List();
- private int _deferring;
+ private int _enumerating;
///
/// Gets the number of dirty visuals.
@@ -31,10 +30,9 @@ namespace Avalonia.Rendering
/// The dirty visual.
public void Add(IVisual visual)
{
- if (_deferring > 0)
+ if (_enumerating > 0)
{
- _deferredChanges.Add(visual);
- return;
+ throw new InvalidOperationException("Visual was invalidated during a render pass");
}
var distance = visual.CalculateDistanceFromAncestor(visual.VisualRoot);
@@ -65,7 +63,7 @@ namespace Avalonia.Rendering
///
public void Clear()
{
- if (_deferring > 0)
+ if (_enumerating > 0)
{
throw new InvalidOperationException("Cannot clear while enumerating");
}
@@ -80,7 +78,7 @@ namespace Avalonia.Rendering
/// A collection of visuals.
public IEnumerator GetEnumerator()
{
- BeginDefer();
+ _enumerating++;
try
{
foreach (var i in _inner)
@@ -93,27 +91,10 @@ namespace Avalonia.Rendering
}
finally
{
- EndDefer();
+ _enumerating--;
}
}
-
- private void BeginDefer()
- {
- ++_deferring;
- }
-
- private void EndDefer()
- {
- if (--_deferring > 0) return;
-
- foreach (var visual in _deferredChanges)
- {
- Add(visual);
- }
-
- _deferredChanges.Clear();
- }
-
+
///
/// Gets the dirty visuals, in ascending order of distance to their root.
///