diff --git a/src/Avalonia.Base/Controls/ResourceDictionary.cs b/src/Avalonia.Base/Controls/ResourceDictionary.cs index 5123803f6e..231a19baab 100644 --- a/src/Avalonia.Base/Controls/ResourceDictionary.cs +++ b/src/Avalonia.Base/Controls/ResourceDictionary.cs @@ -15,6 +15,7 @@ namespace Avalonia.Controls /// public class ResourceDictionary : IResourceDictionary { + private object? lastDeferredItemKey; private Dictionary? _inner; private IResourceHost? _owner; private AvaloniaList? _mergedDictionaries; @@ -241,12 +242,27 @@ namespace Avalonia.Controls { if (value is DeferredItem deffered) { - _inner[key] = value = deffered.Factory(null) switch + // Avoid simple reentrancy, which could commonly occur on redefining the resource. + if (lastDeferredItemKey == key) { - ITemplateResult t => t.Result, - object v => v, - _ => null, - }; + value = null; + return false; + } + + try + { + lastDeferredItemKey = key; + _inner[key] = value = deffered.Factory(null) switch + { + ITemplateResult t => t.Result, + { } v => v, + _ => null, + }; + } + finally + { + lastDeferredItemKey = null; + } } return true; } diff --git a/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/ResourceDictionaryTests.cs b/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/ResourceDictionaryTests.cs index bea6bc4dc8..e73ef456af 100644 --- a/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/ResourceDictionaryTests.cs +++ b/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/ResourceDictionaryTests.cs @@ -307,6 +307,60 @@ namespace Avalonia.Markup.Xaml.UnitTests.Xaml Assert.True(buttonResources.ContainsDeferredKey("Red")); } } + + [Fact] + public void Should_Be_Possible_To_Redefine_Referenced_Resource_ControlTheme() + { + using (StyledWindow()) + { + var xaml = @" + + + + + + + + + +"; + var window = (Window)AvaloniaRuntimeXamlLoader.Load(xaml); + var windowResources = (ResourceDictionary)window.Resources; + var innerResources = (ResourceDictionary)((UserControl)window.Content!).Resources; + + var winButtonTheme = Assert.IsType(windowResources[typeof(Button)]); + var innerButtonTheme = Assert.IsType(innerResources[typeof(Button)]); + Assert.Equal(winButtonTheme, innerButtonTheme.BasedOn); + } + } + + [Fact] + public void Should_Be_Possible_To_Redefine_Referenced_Resource() + { + using (StyledWindow()) + { + var xaml = @" + + + #aaa + + + + + + +"; + var window = (Window)AvaloniaRuntimeXamlLoader.Load(xaml); + var windowResources = (ResourceDictionary)window.Resources; + var innerResources = (ResourceDictionary)((UserControl)window.Content!).Resources; + + var winButtonTheme = Assert.IsType(windowResources["SystemAccentColor"]); + var innerButtonTheme = Assert.IsType(innerResources["SystemAccentColor"]); + Assert.Equal(winButtonTheme, innerButtonTheme); + } + } [Fact] public void Dynamically_Changing_Referenced_Resources_Works_With_DynamicResource()