From f8eceb4af9f78d9a9da582885593fc957ef8fffe Mon Sep 17 00:00:00 2001 From: Steven Kirk Date: Wed, 8 Mar 2023 16:18:36 +0100 Subject: [PATCH] Update usages of ItemsControl Items/ItemsSource. - Use `ItemsSource` when appropriate - When `Items` is appropriate, don't use the setter --- samples/ControlCatalog/MainView.xaml | 2 +- .../Pages/CompositionPage.axaml.cs | 2 +- .../Pages/ContextFlyoutPage.xaml | 2 +- .../ControlCatalog/Pages/ContextMenuPage.xaml | 4 +- samples/ControlCatalog/Pages/CursorPage.xaml | 2 +- .../ControlCatalog/Pages/DialogsPage.xaml.cs | 12 +- samples/ControlCatalog/Pages/ListBoxPage.xaml | 2 +- samples/ControlCatalog/Pages/MenuPage.xaml | 6 +- .../Pages/NativeEmbedPage.xaml.cs | 8 +- .../Pages/NumericUpDownPage.xaml | 6 +- .../Pages/RefreshContainerPage.axaml | 2 +- .../ControlCatalog/Pages/ScrollSnapPage.xaml | 4 +- .../Pages/ScrollViewerPage.xaml | 4 +- .../ControlCatalog/Pages/TabStripPage.xaml | 2 +- .../ControlCatalog/Pages/ThemePage.axaml.cs | 2 +- .../TransitioningContentControlPage.axaml | 2 +- .../ControlCatalog/Pages/TreeViewPage.xaml | 2 +- samples/IntegrationTestApp/MainWindow.axaml | 2 +- .../Themes/Fluent/ColorPicker.xaml | 2 +- .../Themes/Fluent/ColorView.xaml | 2 +- .../Themes/Simple/ColorPicker.xaml | 2 +- .../Themes/Simple/ColorView.xaml | 2 +- src/Avalonia.Controls/ItemsControl.cs | 1 + .../Diagnostics/Views/ConsoleView.xaml | 2 +- .../Diagnostics/Views/ControlDetailsView.xaml | 6 +- .../Diagnostics/Views/EventsPageView.xaml | 6 +- .../Views/PropertyValueEditorView.cs | 2 +- .../Diagnostics/Views/TreePageView.xaml | 2 +- .../Controls/DataValidationErrors.xaml | 4 +- .../Controls/ManagedFileChooser.xaml | 6 +- .../Controls/NativeMenuBar.xaml | 4 +- .../Controls/DataValidationErrors.xaml | 2 +- .../Controls/ManagedFileChooser.xaml | 6 +- .../Controls/NativeMenuBar.xaml | 4 +- src/Windows/Avalonia.Win32/TrayIconImpl.cs | 2 +- .../Win32NativeToManagedMenuExporter.cs | 2 +- .../CarouselTests.cs | 20 +- .../ComboBoxTests.cs | 88 ++++--- .../ItemsControlTests.cs | 113 +++------ .../ListBoxTests.cs | 43 ++-- .../ListBoxTests_Multiple.cs | 6 +- .../ListBoxTests_Single.cs | 24 +- .../MenuItemTests.cs | 10 +- .../Presenters/ItemsPresenterTests.cs | 2 +- .../Primitives/PopupTests.cs | 4 +- .../Primitives/SelectingItemsControlTests.cs | 166 ++++++------- .../SelectingItemsControlTests_AutoSelect.cs | 12 +- .../SelectingItemsControlTests_Multiple.cs | 231 +++++++++--------- ...electingItemsControlTests_SelectedValue.cs | 26 +- .../Primitives/TabStripTests.cs | 94 ++++--- .../TabControlTests.cs | 154 ++++++------ .../TreeViewTests.cs | 116 +++++---- .../Utils/HotKeyManagerTests.cs | 4 +- .../VirtualizingStackPanelTests.cs | 2 +- tests/Avalonia.LeakTests/ControlTests.cs | 14 +- .../Data/MultiBindingTests.cs | 8 +- .../CompiledBindingExtensionTests.cs | 8 +- .../Xaml/BasicTests.cs | 8 +- .../Xaml/DataTemplateTests.cs | 2 +- .../Xaml/StyleTests.cs | 2 +- .../Xaml/XamlIlTests.cs | 2 +- .../AutoDataTemplateBindingHookTest.cs | 2 +- 62 files changed, 607 insertions(+), 677 deletions(-) diff --git a/samples/ControlCatalog/MainView.xaml b/samples/ControlCatalog/MainView.xaml index 3681298a72..9f06525821 100644 --- a/samples/ControlCatalog/MainView.xaml +++ b/samples/ControlCatalog/MainView.xaml @@ -241,7 +241,7 @@ diff --git a/samples/ControlCatalog/Pages/CompositionPage.axaml.cs b/samples/ControlCatalog/Pages/CompositionPage.axaml.cs index 8b12a2d663..0d3061f361 100644 --- a/samples/ControlCatalog/Pages/CompositionPage.axaml.cs +++ b/samples/ControlCatalog/Pages/CompositionPage.axaml.cs @@ -32,7 +32,7 @@ public partial class CompositionPage : UserControl protected override void OnAttachedToVisualTree(VisualTreeAttachmentEventArgs e) { base.OnAttachedToVisualTree(e); - this.Get("Items").Items = CreateColorItems(); + this.Get("Items").ItemsSource = CreateColorItems(); } diff --git a/samples/ControlCatalog/Pages/ContextFlyoutPage.xaml b/samples/ControlCatalog/Pages/ContextFlyoutPage.xaml index 6ef6a202b6..cb294442d2 100644 --- a/samples/ControlCatalog/Pages/ContextFlyoutPage.xaml +++ b/samples/ControlCatalog/Pages/ContextFlyoutPage.xaml @@ -61,7 +61,7 @@ diff --git a/samples/ControlCatalog/Pages/ContextMenuPage.xaml b/samples/ControlCatalog/Pages/ContextMenuPage.xaml index 962f0308f7..06eba52605 100644 --- a/samples/ControlCatalog/Pages/ContextMenuPage.xaml +++ b/samples/ControlCatalog/Pages/ContextMenuPage.xaml @@ -51,13 +51,13 @@ - + diff --git a/samples/ControlCatalog/Pages/CursorPage.xaml b/samples/ControlCatalog/Pages/CursorPage.xaml index 30bad06d72..66f2b8b2e3 100644 --- a/samples/ControlCatalog/Pages/CursorPage.xaml +++ b/samples/ControlCatalog/Pages/CursorPage.xaml @@ -8,7 +8,7 @@ Defines a cursor (mouse pointer) - + @@ -68,7 +68,7 @@ - + - + - + @@ -173,7 +173,7 @@ @@ -220,7 +220,7 @@ + ItemsSource="{Binding $parent[TopLevel].(NativeMenu.Menu).Items}">