From f3fce17a6b4d4365b62ea8d12444a4e0c835fdd1 Mon Sep 17 00:00:00 2001 From: Maksym Katsydan Date: Sun, 23 Aug 2020 22:32:39 -0400 Subject: [PATCH 1/3] Fix datagrid columns sort/resize/reorder #4476 --- src/Avalonia.Controls.DataGrid/DataGridColumnHeader.cs | 2 +- src/Avalonia.Controls.DataGrid/DataGridRow.cs | 2 +- src/Avalonia.Controls.DataGrid/DataGridRowHeader.cs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Avalonia.Controls.DataGrid/DataGridColumnHeader.cs b/src/Avalonia.Controls.DataGrid/DataGridColumnHeader.cs index e6cc7e5e40..c153ae220f 100644 --- a/src/Avalonia.Controls.DataGrid/DataGridColumnHeader.cs +++ b/src/Avalonia.Controls.DataGrid/DataGridColumnHeader.cs @@ -457,7 +457,7 @@ namespace Avalonia.Controls private void DataGridColumnHeader_PointerPressed(object sender, PointerPressedEventArgs e) { - if (OwningColumn == null || e.Handled || !IsEnabled || e.GetCurrentPoint(this).Properties.IsLeftButtonPressed) + if (OwningColumn == null || e.Handled || !IsEnabled || !e.GetCurrentPoint(this).Properties.IsLeftButtonPressed) { return; } diff --git a/src/Avalonia.Controls.DataGrid/DataGridRow.cs b/src/Avalonia.Controls.DataGrid/DataGridRow.cs index d5115c983a..6ab72b1d3c 100644 --- a/src/Avalonia.Controls.DataGrid/DataGridRow.cs +++ b/src/Avalonia.Controls.DataGrid/DataGridRow.cs @@ -789,7 +789,7 @@ namespace Avalonia.Controls private void DataGridRow_PointerPressed(PointerPressedEventArgs e) { - if (e.GetCurrentPoint(this).Properties.IsLeftButtonPressed) + if (!e.GetCurrentPoint(this).Properties.IsLeftButtonPressed) { return; } diff --git a/src/Avalonia.Controls.DataGrid/DataGridRowHeader.cs b/src/Avalonia.Controls.DataGrid/DataGridRowHeader.cs index 324227d749..798d01b402 100644 --- a/src/Avalonia.Controls.DataGrid/DataGridRowHeader.cs +++ b/src/Avalonia.Controls.DataGrid/DataGridRowHeader.cs @@ -162,7 +162,7 @@ namespace Avalonia.Controls.Primitives //TODO TabStop private void DataGridRowHeader_PointerPressed(object sender, PointerPressedEventArgs e) { - if (e.GetCurrentPoint(this).Properties.IsLeftButtonPressed) + if (!e.GetCurrentPoint(this).Properties.IsLeftButtonPressed) { return; } From 517e860b27db8fe6619e5410c1ef3f9f0211f7c9 Mon Sep 17 00:00:00 2001 From: Jumar Macato Date: Mon, 24 Aug 2020 18:51:45 +0800 Subject: [PATCH 2/3] Disable commands when Textbox is on password textbox mode. --- src/Avalonia.Controls/TextBox.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Avalonia.Controls/TextBox.cs b/src/Avalonia.Controls/TextBox.cs index a07aeb16f1..73a1ae3335 100644 --- a/src/Avalonia.Controls/TextBox.cs +++ b/src/Avalonia.Controls/TextBox.cs @@ -456,9 +456,9 @@ namespace Avalonia.Controls private void UpdateCommandStates() { var text = GetSelection(); - var isNullOrEmpty = string.IsNullOrEmpty(text); - CanCopy = !isNullOrEmpty; - CanCut = !isNullOrEmpty && !IsReadOnly; + var isSelectionNullOrEmpty = string.IsNullOrEmpty(text); + CanCopy = !IsPasswordBox && !isSelectionNullOrEmpty; + CanCut = !IsPasswordBox && !isSelectionNullOrEmpty && !IsReadOnly; CanPaste = !IsReadOnly; } From 4f7fdd31c20acc5d61ffb04e4ab2fa423707f82c Mon Sep 17 00:00:00 2001 From: Dan Walmsley Date: Mon, 24 Aug 2020 14:34:39 +0100 Subject: [PATCH 3/3] fix expander as not easy to click on, and glyph not visible on fluent theme. --- src/Avalonia.Themes.Default/Expander.xaml | 2 +- src/Avalonia.Themes.Fluent/Expander.xaml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Avalonia.Themes.Default/Expander.xaml b/src/Avalonia.Themes.Default/Expander.xaml index d63f785e77..08d8b4c995 100644 --- a/src/Avalonia.Themes.Default/Expander.xaml +++ b/src/Avalonia.Themes.Default/Expander.xaml @@ -86,7 +86,7 @@