From eaa62b782824915687dcc8ddefe1746db8d06776 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Wies=C5=82aw=20=C5=A0olt=C3=A9s?= <wieslaw.soltes@gmail.com>
Date: Sun, 30 Jan 2022 13:51:19 +0100
Subject: [PATCH 1/2] Set combobox items from xaml on ViewboxPage

---
 samples/ControlCatalog/Pages/ViewboxPage.xaml | 21 +++++++++++++++----
 .../ControlCatalog/Pages/ViewboxPage.xaml.cs  | 19 -----------------
 2 files changed, 17 insertions(+), 23 deletions(-)

diff --git a/samples/ControlCatalog/Pages/ViewboxPage.xaml b/samples/ControlCatalog/Pages/ViewboxPage.xaml
index 81e5046636..ac52a6d0ee 100644
--- a/samples/ControlCatalog/Pages/ViewboxPage.xaml
+++ b/samples/ControlCatalog/Pages/ViewboxPage.xaml
@@ -12,8 +12,8 @@
           <Border HorizontalAlignment="Center" Grid.Column="0" BorderThickness="1" BorderBrush="Orange" Width="200" Height="200">
             <Border VerticalAlignment="Center" HorizontalAlignment="Center" Grid.Column="0" BorderThickness="1" BorderBrush="CornflowerBlue" Width="{Binding #WidthSlider.Value}" Height="{Binding #HeightSlider.Value}" >
               <Viewbox
-                  Stretch="{Binding #StretchSelector.SelectedItem}"
-                  StretchDirection="{Binding #StretchDirectionSelector.SelectedItem}">
+                  Stretch="{Binding #StretchSelector.SelectedItem.Content, FallbackValue={x:Static Stretch.Uniform}}"
+                  StretchDirection="{Binding #StretchDirectionSelector.SelectedItem.Content, FallbackValue={x:Static StretchDirection.Both}}">
                 <Ellipse Width="50" Height="50" Fill="CornflowerBlue" />
               </Viewbox>
             </Border>
@@ -25,9 +25,22 @@
             <TextBlock Text="Height" />
             <Slider Minimum="10" Maximum="200" Value="100" x:Name="HeightSlider" TickFrequency="25" TickPlacement="TopLeft" />
             <TextBlock Text="Stretch" />
-            <ComboBox x:Name="StretchSelector" HorizontalAlignment="Stretch" Margin="0,0,0,2" />
+            <ComboBox x:Name="StretchSelector" HorizontalAlignment="Stretch" SelectedIndex="0" Margin="0,0,0,2" >
+              <ComboBox.Items>
+                <ComboBoxItem Content="{x:Static Stretch.Uniform}"/>
+                <ComboBoxItem Content="{x:Static Stretch.UniformToFill}"/>
+                <ComboBoxItem Content="{x:Static Stretch.Fill}"/>
+                <ComboBoxItem Content="{x:Static Stretch.None}"/>
+              </ComboBox.Items>
+              </ComboBox>
             <TextBlock Text="Stretch Direction" />
-            <ComboBox x:Name="StretchDirectionSelector" HorizontalAlignment="Stretch" />
+            <ComboBox x:Name="StretchDirectionSelector" SelectedIndex="0" HorizontalAlignment="Stretch" >
+              <ComboBox.Items>
+                <ComboBoxItem Content="{x:Static StretchDirection.Both}"/>
+                <ComboBoxItem Content="{x:Static StretchDirection.DownOnly}"/>
+                <ComboBoxItem Content="{x:Static StretchDirection.UpOnly}"/>
+              </ComboBox.Items>
+            </ComboBox>
           </StackPanel>
         </Grid>
 
diff --git a/samples/ControlCatalog/Pages/ViewboxPage.xaml.cs b/samples/ControlCatalog/Pages/ViewboxPage.xaml.cs
index 94b3f3ea14..12b5086e12 100644
--- a/samples/ControlCatalog/Pages/ViewboxPage.xaml.cs
+++ b/samples/ControlCatalog/Pages/ViewboxPage.xaml.cs
@@ -1,6 +1,5 @@
 using Avalonia.Controls;
 using Avalonia.Markup.Xaml;
-using Avalonia.Media;
 
 namespace ControlCatalog.Pages
 {
@@ -9,24 +8,6 @@ namespace ControlCatalog.Pages
         public ViewboxPage()
         {
             InitializeComponent();
-
-            var stretchSelector = this.FindControl<ComboBox>("StretchSelector");
-
-            stretchSelector.Items = new[]
-            {
-                Stretch.Uniform, Stretch.UniformToFill, Stretch.Fill, Stretch.None
-            };
-
-            stretchSelector.SelectedIndex = 0;
-
-            var stretchDirectionSelector = this.FindControl<ComboBox>("StretchDirectionSelector");
-
-            stretchDirectionSelector.Items = new[]
-            {
-                StretchDirection.Both, StretchDirection.DownOnly, StretchDirection.UpOnly
-            };
-
-            stretchDirectionSelector.SelectedIndex = 0;
         }
 
         private void InitializeComponent()

From 26eba8d80e16edb1ba5f269f2e38f344ff126423 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Wies=C5=82aw=20=C5=A0olt=C3=A9s?= <wieslaw.soltes@gmail.com>
Date: Sun, 30 Jan 2022 23:41:39 +0100
Subject: [PATCH 2/2] Use ArrayList for items

---
 samples/ControlCatalog/Pages/ViewboxPage.xaml | 33 ++++++++++---------
 1 file changed, 17 insertions(+), 16 deletions(-)

diff --git a/samples/ControlCatalog/Pages/ViewboxPage.xaml b/samples/ControlCatalog/Pages/ViewboxPage.xaml
index ac52a6d0ee..e7e3007d35 100644
--- a/samples/ControlCatalog/Pages/ViewboxPage.xaml
+++ b/samples/ControlCatalog/Pages/ViewboxPage.xaml
@@ -1,5 +1,6 @@
 <UserControl xmlns="https://github.com/avaloniaui"
              xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
+             xmlns:collections="clr-namespace:System.Collections;assembly=netstandard"
              x:Class="ControlCatalog.Pages.ViewboxPage">
 
     <Grid RowDefinitions="Auto,*,*">
@@ -12,8 +13,8 @@
           <Border HorizontalAlignment="Center" Grid.Column="0" BorderThickness="1" BorderBrush="Orange" Width="200" Height="200">
             <Border VerticalAlignment="Center" HorizontalAlignment="Center" Grid.Column="0" BorderThickness="1" BorderBrush="CornflowerBlue" Width="{Binding #WidthSlider.Value}" Height="{Binding #HeightSlider.Value}" >
               <Viewbox
-                  Stretch="{Binding #StretchSelector.SelectedItem.Content, FallbackValue={x:Static Stretch.Uniform}}"
-                  StretchDirection="{Binding #StretchDirectionSelector.SelectedItem.Content, FallbackValue={x:Static StretchDirection.Both}}">
+                  Stretch="{Binding #StretchSelector.SelectedItem, FallbackValue={x:Static Stretch.Uniform}}"
+                  StretchDirection="{Binding #StretchDirectionSelector.SelectedItem, FallbackValue={x:Static StretchDirection.Both}}">
                 <Ellipse Width="50" Height="50" Fill="CornflowerBlue" />
               </Viewbox>
             </Border>
@@ -25,21 +26,21 @@
             <TextBlock Text="Height" />
             <Slider Minimum="10" Maximum="200" Value="100" x:Name="HeightSlider" TickFrequency="25" TickPlacement="TopLeft" />
             <TextBlock Text="Stretch" />
-            <ComboBox x:Name="StretchSelector" HorizontalAlignment="Stretch" SelectedIndex="0" Margin="0,0,0,2" >
-              <ComboBox.Items>
-                <ComboBoxItem Content="{x:Static Stretch.Uniform}"/>
-                <ComboBoxItem Content="{x:Static Stretch.UniformToFill}"/>
-                <ComboBoxItem Content="{x:Static Stretch.Fill}"/>
-                <ComboBoxItem Content="{x:Static Stretch.None}"/>
-              </ComboBox.Items>
-              </ComboBox>
+            <ComboBox x:Name="StretchSelector" HorizontalAlignment="Stretch" SelectedIndex="0" Margin="0,0,0,2">
+              <collections:ArrayList>
+                <Stretch>Uniform</Stretch>
+                <Stretch>UniformToFill</Stretch>
+                <Stretch>Fill</Stretch>
+                <Stretch>None</Stretch>
+              </collections:ArrayList>
+            </ComboBox>
             <TextBlock Text="Stretch Direction" />
-            <ComboBox x:Name="StretchDirectionSelector" SelectedIndex="0" HorizontalAlignment="Stretch" >
-              <ComboBox.Items>
-                <ComboBoxItem Content="{x:Static StretchDirection.Both}"/>
-                <ComboBoxItem Content="{x:Static StretchDirection.DownOnly}"/>
-                <ComboBoxItem Content="{x:Static StretchDirection.UpOnly}"/>
-              </ComboBox.Items>
+            <ComboBox x:Name="StretchDirectionSelector" SelectedIndex="0" HorizontalAlignment="Stretch">
+              <collections:ArrayList>
+                <StretchDirection>Both</StretchDirection>
+                <StretchDirection>DownOnly</StretchDirection>
+                <StretchDirection>UpOnly</StretchDirection>
+              </collections:ArrayList>
             </ComboBox>
           </StackPanel>
         </Grid>