Avalonia

Commit Graph

Author	SHA1	Message	Date
Max Katz	d5f11c135f	Thread.Sleep should be done before the assert in WindowOrder_Modal_Dialog_Stays_InFront_Of_Parent	3 weeks ago
Max Katz	39baee97de	Add WindowOrder_Owned_Window_Stays_InFront_Of_Topmost_Owner integration test Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	3 weeks ago
Evan	eb5cce2492	Fix CalendarDatePicker.Focus() not focusing the text box (#22170 ) * Fix CalendarDatePicker.Focus() not focusing the text box OnGotFocus only forwarded focus to PART_TextBox when the navigation method was Tab, so a programmatic Focus() call left focus on the picker itself. Gate on the focus source instead, and keep select-all on Tab only. * Remove comment from CalendarDatePicker.OnGotFocus	3 weeks ago
Evan	082a03b7c4	Handle DataValidationError notifications returned by ConvertBack (#22171 ) * Handle DataValidationError notifications returned by ConvertBack A converter returning a BindingNotification with DataValidationError fell through to the target type converter, which replaced it with a cast error that stringified the notification. Publish the original error instead. * Add additional failing tests. There are more `BindingNotification` cases to handle. * Handle the other `BindingNotification` cases. --------- Co-authored-by: grokys <grokys@users.noreply.github.com>	3 weeks ago
Tom Edwards	0a7699a141	Fixed "TESTAPP" window sometimes appearing when Avalonia solution is open in Visual Studio (#22201 )	4 weeks ago
Julien Lebosquain	4393d521ec	Ignore child margins when positioning a popup (redux) (#21856 ) * Added failng popup child margin test * Ignore popup child margin when positioning Avoids drop shadows and other out-of-bounds visual effects from affecting popup positioning * Fix warnings in tests * Pass Deflate to WSurface --------- Co-authored-by: Tom Edwards <tom.edwards@chaos.com>	4 weeks ago
Evan	fedb14ce85	Short-circuit a null-conditional operator after a cast (#22174 ) Follow-up to #22082, which added the short-circuit to the property accessor nodes. The cast nodes still called ValidateNonNullSource, so a cast reported "Value is null" before the following ?. could suppress it. Casting null now produces null, as in C#, leaving any error to the member access that follows.	4 weeks ago
Evan	8057428233	Allow casting to a nested type in a binding path (#22173 ) The binding path parser built type names with ParseIdentifier, which doesn't accept '+', so a cast like ((local:Outer+Nested)DataContext) stopped parsing at the '+' and then failed expecting a ')'. Parse type names with a variant that accepts '+'. Ordinary identifiers are unchanged.	4 weeks ago
Tim	2a34135703	Fix: Switching themes may crash the App (#22189 ) * Unit test: Switching themes may crash the App * fix for theme switching * address copilot review * make the code cleaner and nicer	4 weeks ago
Benedikt Stebner	14d462439e	Match font family names case-insensitively (#22163 ) * Tighten the comments on the synthetic caching fix Keep the invariant and the reason, drop the retelling of how the leak was found. Also plain-ASCII the dashes and correct the doc on the test counter: the alias resolution goes through the same overload, so the counter proves the cached result short-circuits the platform call too. * Match font family names case-insensitively in the glyph typeface cache Every other family-name comparison in FontCollectionBase is OrdinalIgnoreCase - the sorted family array, the binary search in TryGetGlyphTypeface, AddFontFamily's de-duplication - but the cache itself used the default ordinal comparer. Two consequences: - A request whose casing differs from the cached one misses the bucket and so skips the nearest-match branch entirely. The family-name search that picks it up afterwards returns the nearest match raw, without synthesis and without caching, so "MyAlias" at Black renders faux-bold while "MYALIAS" at Black renders regular weight. - SystemFontCollection registers a resolved face under both the platform's family name and the requested one. When those differ only in casing that stores two buckets, while AddFontFamily de-duplicates case-insensitively and publishes only the first, leaving the second unreachable from every family-name search. Also compares the requested and platform family names case-insensitively before the second registration, so the redundant add goes away rather than becoming a silent no-op. * Reuse an already cached synthetic glyph typeface TryCreateSyntheticGlyphTypeface synthesised unconditionally. When a synthetic for the same source family and key was already cached, the second one lost TryAddGlyphTypeface to the instance holding the slot, so it was handed to the caller but never cached - and GlyphTypeface has no finalizer, only an explicit Dispose reachable from the cache, so its native typeface stayed alive for the rest of the process. Each one costs a full copy of the font file, which TryGetStream reads into memory and SKTypeface.FromStream copies again. Return the cached synthetic instead when its simulations match the ones this call would apply. The source family's typefaces are already in hand for the early-out above; they were fetched and then never used. Caching under the requested family name removed the path that reached this on every call, but the method is public on IFontCollection and the race remains, so guard it at the source. * Match font family mappings case-insensitively FontManagerOptions.FontFamilyMappings is supplied by the application, so its comparer is whatever its author gave it - ordinal for a plain Dictionary<string, FontFamily>. Family names are matched case-insensitively everywhere else, so a mapping silently did not apply when the requested name differed in casing from the configured key. Copy the mappings into an OrdinalIgnoreCase dictionary in the constructor. Keys that collide only by casing were separate entries before; the last wins rather than throwing, since a mapping table is configuration and failing here would take the application down at startup. Two behaviour changes worth naming: a mapping now applies whatever casing the name arrives in, and FontManager no longer observes mutations made to the caller's dictionary after construction.	4 weeks ago
Ole Ross	e91bad598c	Add TableViewColumn.IsVisible property (#22162 ) * feat: Add IsVisible to TableViewColumn * test: Add TableView IsVisible tests * feat: Add option to hide a column in the ControlCatalog * chore: Remove unnecessary remark from property * docs: An other xml comment cleanup * fix: Use NaN as a sign that the width is reset and needs recalculation Also, set the ActualWidth of a hidden column to 0 * chore: Add a comment explaining what NaN means for columns ActualSize	4 weeks ago
Benedikt Stebner	acc1494308	Consolidate the Unicode segmentation trie and add UAX-29 sentence segmentation (#21875 ) * Pack the segmentation properties into one Unicode trie Grapheme, indic-conjunct, word, line and sentence break classes now share a single SegmentationTrie, together with the Emoji, Emoji_Presentation and Default_Ignorable_Code_Point flags that rode in the grapheme word. The UnicodeDataTrie word keeps general category, script and script extensions. - SegmentationTrieGenerator replaces GraphemeBreakClassTrieGenerator and emits Segmentation.trie.cs; UnicodeData.trie.cs is regenerated without the break fields it no longer carries. - SentenceBreakClass data and Codepoint.SentenceBreakClass expose UAX-29 sentence classes to callers. - WordSegment carries the source text slice alongside the code-unit and code-point readouts, matching the shape newer segment types use; the existing constructor and members stay for compatibility. Data regenerated against UCD 17.0.0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Add UAX-29 sentence segmentation SentenceBreakEnumerator walks sentence boundaries over a UTF-16 span (rules SB1-SB11 and SB998), yielding SentenceSegment values of offset plus text slice. Sentence is the one segmentation granularity accessibility clients and IME navigation ask for that had no implementation, so callers had to approximate it with punctuation heuristics. The conformance suite runs against the Unicode SentenceBreakTest.txt data. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Make sentence segmentation linear in the text length Every rule that needed left-hand context rescanned the text backwards from the current position, so a run of spaces or closing brackets was walked once per character in it. Enumerating 40k spaces took 5.5 s; 40k closing brackets took 8.1 s, and both grew quadratically. - Fold the left-hand context into the enumerator as it advances: the last two significant classes for SB6/SB7, and a stage counter over the (STerm \| ATerm) Close* Sp* (Sep \| CR \| LF)? grammar for SB8-SB11. - Memoize the SB8 lookahead. A scan answers every start position it passed over, so the Close* Sp* run after an ATerm is scanned once, not once per position. - Classify with bitmasks, matching LineBreakEnumerator. Both pathological inputs now finish in 0.1 ms at 40k characters. Output is unchanged: the UCD SentenceBreakTest.txt suite passes, and 1.4M random strings over the break classes segment identically to the previous implementation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Read the word segment length from the property valid for every segment WordSegment.Text is empty for segments built through the code-unit constructor that shipped in 12.1, so Text.Length holds only for segments that come from WordBreakEnumerator. Length is set by both constructors. - Measure the ellipsis break position from Length again. - Say on the Text property itself, where it is read, that it can be empty. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Benchmark word and sentence segmentation across text shapes The break enumerator benchmark covered three enumerators over random codepoint distributions, which measures trie lookup cost but not the per-character cost of the rules themselves. Long runs of one class are where a segmentation algorithm degrades, and nothing measured them. - Add the sentence enumerator to UnicodeBreakEnumeratorBenchmark. - Add UnicodeSegmentationScalingBenchmark: prose, Han, ZWJ emoji, and runs of spaces, closing punctuation, terminator-plus-spaces and regional indicators, each at two lengths so the cost per character is comparable between them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Document the sentence break classes and trim the break unit SentenceBreakClass is public API with nothing but the UCD aliases to go on, so a caller reading Codepoint.SentenceBreakClass has to consult UAX #29 to learn what a value means or which rule reacts to it. - Describe the type and every member in terms of what the sentence rules do with it, keeping the UCD alias as a trailing comment. - Give SentenceBreakUnit a primary constructor and drop its Codepoint property, which nothing reads now that the class is stored directly. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Clean up documentation for SentenceBreakClass Removed remarks from the SentenceBreakClass documentation. --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>	4 weeks ago
Benedikt Stebner	920eaa4a22	Carry the regional indicator parity forward instead of recounting it (#22197 ) WB15 and WB16 pair regional indicators from the start of their run, and the run was recounted from that start at every indicator, so word segmentation was quadratic in the length of an unbroken run of flags. One pass over 4096 flags took 140 ms; the same text with a space between each flag took 121 us. - Track whether an odd number of regional indicators precedes the position the walk has reached, updating it as each code point is consumed. - Drop CountRegionalIndicatorsBefore, which was the only backward scan in the enumerator not bounded by the first significant code point. - Cover the pairing rules: even and odd runs, a run reached after a letter, a run split by a space, and a combining mark inside a flag. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>	4 weeks ago
Benedikt Stebner	0dbce40347	Add RelativeTransform to brushes (#21881 ) * Apply tile brush transforms once the tile sits in target space Brush.Transform was concatenated into the shader matrix before the translation that moves the tile onto the painted area, so it acted in the tile's own space instead of the target's. A brush transform on a fill away from the origin - the common case, since a relative viewport resolves against the fill's bounds - came out displaced, and WPF, whose behaviour these brushes follow, disagrees. Both tile paths now place the tile first and let the transform act on the result. Where the placement is identity, which is what the existing goldens cover, the matrices are unchanged. The cross suite gains an image brush so the non-scalable path is covered too, plus a smooth ramp fixture: the star line drawing that was the only image asset survives resampling as sparse speckle, which the comparison metric cannot tell apart from a geometry error. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Apply the conic gradient transform after its angle The sweep shader carried Angle as its local matrix and pre-concatenated Brush.Transform onto it, so the transform acted on the raw sweep and the angle then turned the result. Every other brush bakes its intrinsic geometry in first and lets the brush transform act on the finished pattern. The visible effect was that a translation moved the gradient in a direction rotated by Angle - 90 instead of the direction asked for. A sweep gradient is fully determined by its centre and angle, so the golden here is checked against the brush with its centre moved by the same offset and no transform: the two renders are pixel-identical, while the previous order is 0.169 rmse away against a 0.022 tolerance. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Add RelativeTransform to every brush A brush transform expressed in the unit space of the painted bounds, applied before the absolute Transform - WPF's Brush.RelativeTransform. It lets one brush express a bounds-dependent transform, an SVG gradientTransform in objectBoundingBox units for instance, without baking any one consumer's bounds into a matrix, which is what makes a single brush per gradient definition possible. The property sits on IBrush and Brush, so every brush kind carries it and a consumer reads it without a type test. Each immutable brush takes it through a second constructor, leaving the existing signatures alone and marking them for collapse in v13. The gradient brush animator interpolates it alongside Transform, and the composition schema gains it on both brush bases so the value reaches the render thread as a live resource rather than a snapshot. IBrush is NotClientImplementable, so the added member is suppressed for API validation the way earlier additions to those interfaces are. Nothing consumes it yet. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Consume RelativeTransform in the Skia backend The relative matrix is conjugated into target space at draw time - the unit square maps onto the painted rect, whose origin translation and scale wrap the matrix - and composes before the absolute brush transform. All three gradient kinds and both tile brush paths read it; a solid colour brush has nothing for it to act on, matching WPF. With no relative transform every path reduces to the previous matrices, so existing goldens stay byte-identical. The cross suite compares the result against WPF for the linear and radial gradients, a drawing brush tiled and untiled, an image brush, the composition order against Transform, one brush shared by two differently sized fills, and the solid colour no-op. Goldens under Skia/Media additionally cover the immediate renderer and the GPU backends, which the cross suite does not exercise; each was measured against its WPF counterpart before being committed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>	4 weeks ago
Yoyo	cd3b218eb4	Fix DateTimePickerPanel ItemHeight updates (#22158 )	4 weeks ago
Benedikt Stebner	888f7557bd	Rebuild TextBlock text runs only when the content changes (#22149 ) * Keep TextBlock text runs in sync with its inlines _textRuns is built from Inlines, but OnMeasureInvalidated discarded it on any measure invalidation while Inlines still held the content. Between that point and the next measure pass, CreateTextLayout read a null _textRuns as "no inlines" and shaped Text instead, which is null whenever the content lives in Inlines. That empty result went into the TextRunCache, keyed by text source index, so every later layout reused it and the control rendered nothing until something invalidated the cache. - Discard _textRuns in InvalidateTextLayout, next to the run cache, so the runs and the cache are dropped by the same event and cannot disagree about the content. - Build the runs on demand in EnsureTextRuns, and pick the text source by HasComplexContent rather than by _textRuns being set. - Split the constraint-dependent work out of run building. Runs answer to the content alone; only an embedded control answers to the available width, so Inline.MeasureEmbeddedControls measures it and EmbeddedControlRun reports the child's DesiredSize live. Runs now survive a constraint change instead of being rebuilt every measure. SelectableTextBlock never hands the run cache to its layout, but it shared the same fallback and kept the wrong layout on _textLayout. Fixes #21902 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Invalidate the layout when LineSpacing changes LineSpacing had no case in the property change switch and is not one of the properties registered with AffectsRender, so changing it left the measured size and the rendered text untouched even though CreateTextLayout feeds it into the paragraph properties. It changes line placement rather than shaping, so it belongs with LineHeight and the other properties that keep the run cache. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Drop the text layout whenever the content is invalidated InvalidateMeasure only raises OnMeasureInvalidated while the measure is still valid, so a second content change before the next measure pass left _textLayout holding the layout the first change had already replaced. MeasureOverride keeps that layout when the constraint has not moved, so the block measured and rendered the superseded content. Clear the layout in InvalidateTextLayout and InvalidateTextLayoutKeepCache rather than relying on OnMeasureInvalidated to run, which is what TextPresenter already does. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Drop the text layout when an embedded control resizes A line snapshots its metrics when it is formatted, so a layout built before a child was measured again keeps reporting the width and height that child used to have. MeasureOverride reuses the layout whenever the constraint has not moved, so a control that resizes while the block is already measure invalid never reaches the measured size. - MeasureEmbeddedControls reports whether any child came back a different size, and the layout is dropped only then rather than on every pass. - Route the remaining layout resets through DisposeTextLayout so every reset goes through one place. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>	4 weeks ago
Shirasagi	27c1ece36c	Fix SplineEasing constructor assigning y2 to Y1 (#22169 )	4 weeks ago
Tim	54ae2d047f	Fix for ListBox ghost items - Alternative version (#22165 ) * add failing test for ghost items after showing a hidden ListBox * fix ghost items * add a failing test * fix for ghost item * more tests * Fix return statement in VirtualizingStackPanel Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>	4 weeks ago
Steven Kirk	0082fc6b2a	Fix UIA selection never reaching the client on Windows (#22151 ) * Add failing tests for SAFEARRAY marshalling of COM providers SafeArrayRef.CreateFromObjects sizes the SAFEARRAY to the pooled buffer it rents rather than to the input, and only fills a slot when the object already has a live COM wrapper. Cover both with tests driven through SafeArrayMarshaller, which is how the UIA interop actually reaches this code. Two of the three tests fail: a two-element input produces a 16-element array of nulls. The string test passes and is the control. Each provider test checks the length before it reads the entries. A wrongly sized array holds slots that were never written, and dereferencing those takes down the test host with an access violation. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RYYMWsTkmkKjptFL88xjAg * Fix ISelectionProvider.GetSelection() never reaching the UIA client SafeArrayRef.CreateFromObjects had two defects, and between them every VT_UNKNOWN SAFEARRAY the automation interop produced was empty. It sized the array to the buffer it rented from ArrayPool rather than to the input, so a one-element selection became a 16-element array. The rented buffer isn't cleared, so stale pointers from an earlier rent could leak in and later be released by SafeArrayDestroy. It also filled a slot only when ComWrappers.TryGetComInstance succeeded. That call resolves a managed object that wraps a native COM instance; for a purely managed object it always fails, so no slot was ever filled and UIA received an array of nulls. Wrappers now come from ComInterfaceMarshaller<T>, which is what the rest of the interop uses. Sharing the instance matters: UI Automation identifies elements by IUnknown pointer, so a wrapper from a second ComWrappers would read as a different element. The element type isn't recoverable from the values, so SafeArrayMarshaller<T> passes it through a new generic TryCreate<T> overload. The object branch of the non-generic TryCreate is gone with it. Nothing reached it: the only other caller is ComVariant.Create, and no property value is an array of providers. This fixes ISelectionProvider.GetSelection() and, by the same route, ITableProvider.GetRowHeaders/GetColumnHeaders, ITableItemProvider, and ITextProvider.GetSelection/GetVisibleRanges. Fixes #22150 Claude-Session: https://claude.ai/code/session_01RYYMWsTkmkKjptFL88xjAg Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>	4 weeks ago
Yoshihiro Ito	4ec9cbb7b8	Support Windows shell virtual files in drag and drop (#21907 ) * Add Win32 virtual file drop support * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * docs(win32): clarify virtual file disposal * fix(win32): handle empty virtual file reads * Address virtual file data review feedback * Address virtual stream review feedback * Address final virtual stream review nits --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Julien Lebosquain <julien@lebosquain.net>	4 weeks ago
Benedikt Stebner	79ff4ff73e	[Text] Glyph Outline Part 5/13 - Shaped buffer glyph indices (#21501 ) * Fix glyph metrics; expose glyph bounding box GlyphMetrics previously stored the advance in Width/Height, leaving no field for the actual ink bounding box. Correct the contract: - Expand GlyphMetrics with AdvanceWidth / AdvanceHeight (and the bitmap / vertical-layout members XOffset / YOffset / VerticalOriginX/Y, reserved for later population). - Add GlyfTable.TryGetGlyphBounds: an allocation-free, header-only read of the glyph's control-point bounding box (xMin/yMin/xMax/yMax). Empty glyphs return true with zero bounds; out-of-range / short data return false. Composite glyphs use their header bbox without recursion. - TryGetGlyphMetrics (single + batch) now sources advances into AdvanceWidth / AdvanceHeight and the bounding box into Width / Height / XBearing / YBearing via TryGetGlyphBounds. Side bearings fall back to hmtx/vmtx when the glyph has no outline. The previously latent API had one test relying on the old behaviour (Width == advance); it's updated to assert AdvanceWidth. New tests cover TryGetGlyphBounds (range, empty, letter, descriptor parity) and the corrected metrics (advance placement, ink width distinct from advance, empty-glyph advance-without-ink, batch/single parity). * Add glyph-bounds benchmark GlyphBoundsBenchmark (Avalonia.Benchmarks): a BenchmarkDotNet comparison of the table-based bounds read against Skia's SKFont.GetGlyphWidths, in kernel (font pre-created) and per-run variants across 1 / 16 / 256 glyphs, with MemoryDiagnoser. * Add allocation-free batch glyph-bounds path Adds a bounds-only batch reader so ink-bounds computation (the GlyphRunImpl use case, which already has advances from shaping) doesn't pay for advance lookup or per-glyph indirection: - GlyphBounds: internal value type carrying the control-point box. - GlyfTable.GetGlyphBounds / GlyphTypeface.TryGetGlyphBounds: fetch the glyf and loca spans once per batch and read offsets + headers directly via BinaryPrimitives — no per-glyph ReadOnlyMemory.Span conversion, no intermediate Memory.Slice, no nested call chain. LocaTable exposes RawData / IsShortFormat for this. - Batch TryGetGlyphMetrics refactored onto the same span-cached reader. Measured against Skia's SKFont.GetGlyphWidths (bounds-only, in-process BenchmarkDotNet): the table path is faster at every run length (0.06× / 0.32× / 0.66× at 1 / 16 / 256 glyphs) and allocation-free, where Skia allocates 104 B/run for the SKFont. The earlier advance+bounds path via TryGetGlyphMetrics was ~2.2× slower than Skia at 256 glyphs; the bounds-only span-cached path is ~1.5× faster. The benchmark is updated to compare bounds-only on both sides. * Restore System.Buffers.Binary using in GlyfTable The glyf bounds readers (TryGetGlyphBounds / GetGlyphBounds) read the header int16s via BinaryPrimitives. The base pr2 commit trimmed this using as unused there, but it is needed once pr2b adds the bounds code — without it GlyfTable does not compile on this branch. * Clamp glyph bounding-box extents to non-negative GlyphBounds.Width/Height and both TryGetGlyphMetrics overloads computed the ink extent as (xMax - xMin) / (yMax - yMin). A malformed glyf header where xMax < xMin (or yMax < yMin) produced a negative value that, when narrowed to the ushort GlyphMetrics.Width/Height, wrapped to a huge positive extent instead of a safe zero. Clamp the extent to non-negative in GlyphBounds (the single source of truth for both the single and batch metric paths) and route the single TryGetGlyphMetrics path through GlyphBounds so both behave identically. For int16 coordinates the maximum extent is 65535 = ushort.MaxValue, so the clamped value always fits without overflow. Adds GlyphBoundsTests. * Allocate batch glyph-metric buffers only when their source is present Batch TryGetGlyphMetrics unconditionally sized the hMetrics, vMetrics and bounds temporary buffers to glyphIds.Length, even when the font has no hmtx, no vmtx, or no glyf table. For CFF/CFF2 fonts (no glyf) the bounds buffer is never read, and most fonts have no vmtx, so a large batch on such a font heap-allocated a per-glyph array that was pure waste. Size each buffer to zero — a free, empty stackalloc — when its source table is absent, so it only materialises (and only spills to the heap past 256 glyphs) when it will actually be filled and read. * Note the halved loca offsets in the batch bounds reader The short loca format stores every offset divided by two, which is why the batch reader doubles what it reads. LocaTable's single-glyph path already carries that note; the inline decode in the batch path did not. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Split the batch metrics loop on the glyf branch instead of per glyph The glyf check does not vary across the run, so it belongs above the loop rather than inside it. Splitting it also lets the bounds buffer live only in the branch that reads it, which drops the zero-length allocation that CFF / CFF2 fonts used to make just to satisfy the shared loop. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Add vertical glyph advance API to GlyphTypeface Mirror the existing TryGetHorizontalGlyphAdvance / ...Advances pair with vertical equivalents. Until now a vertical-layout caller (CJK, Mongolian) had no advance-only path on GlyphTypeface and had to go through TryGetGlyphMetrics, which after PR2b reads the glyf bounding box per glyph — pure waste when only the advance is needed. VerticalMetricsTable already exposes the per-glyph and batch readers internally (used by TryGetGlyphMetrics(batch)); this is a thin wrapper over them. Tests cover the Latin (no vmtx → false) and CJK (vmtx → positive advances) cases and batch/single parity using Inter and MiSans-Normal. Audit note: HorizontalMetricsTable and VerticalMetricsTable batch readers already span-cache (each fetches _data.Span once per call, reusing a BigEndianBinaryReader across glyphs). No metrics-table refactor is needed — the speculative Part 2 of the plan collapses to nothing. * Expose contiguous glyph indices span on ShapedBuffer Consumers that need a ReadOnlySpan<ushort> of glyph IDs (the upcoming GlyphTypeface.TryGetGlyphBounds batch path, SKFont.GetGlyphWidths, atlas lookups...) previously had to allocate a parallel ushort[] and project GlyphInfo.GlyphIndex into it. Carry that array on the ShapedBuffer instead: - ShapedBuffer rents a parallel ushort[] from ArrayPool alongside the existing GlyphInfo[] rental, exposed as `public ReadOnlySpan<ushort> GlyphIndices`. - The indexer setter syncs both, so HarfBuzz shaping and post-shape mutators (InterWordJustification rewrites the same GlyphIndex) keep the parallel view in lockstep with no caller change. - Split / WithBidiLevel slice the indices alongside the GlyphInfos at the same offsets — both share the parent's pooled arrays. - Dispose returns both rentals. Consumer wiring: - GlyphRunImpl: copies ShapedBuffer.GlyphIndices once via CopyTo when the source is a ShapedBuffer, dropping the per-glyph extract from the position loop. - TextFormatterImpl.CreateEmptyTextLine: switched to the pooled public ctor + indexer (was passing a heap-allocated GlyphInfo[] to the internal slice ctor, which now requires a parallel ushort slice). Tests cover indexer sync, overwrite, ascending split alignment, empty-leading split, and dispose clearing the view. --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>	4 weeks ago
Ronny	5846116674	Cache synthetic/nearest glyph typefaces under the requested family name (#21993 ) * Cache synthetic/nearest glyph typefaces under the requested family name FontCollectionBase.TryGetGlyphTypeface only cached the resolved typeface under the requested family name when synthesis FAILED. When TryCreateSyntheticGlyphTypeface succeeds it registers the synthetic only under the source font's own family names, never under the name the caller asked for. A request arriving through a different name therefore never hits the cache and re-enters synthesis on every call. Synthesis goes through IPlatformTypeface.TryGetStream, which reads the entire font file into memory and hands it to SKTypeface.FromStream, which copies it again natively - so every resolution costs one retained copy of the whole font file. Two common shapes reach this path: - a platform alias, i.e. a family the font manager resolves but that is absent from GetInstalledFontFamilyNames(). Android declares several in /system/etc/fonts.xml (arial, helvetica, tahoma, verdana, times, courier); - a "Family Style" composite decomposed by Typeface.Normalize (e.g. "Arial Black" -> family arial + FontWeight.Black), which makes the requested key differ from the key the platform returns. Windows/DirectWrite is structurally immune: every resolvable family is also an installed family there, so the case-insensitive family-name search finds the synthetic (registered under its real name) on the second call and the missing entry repairs itself after one copy. With a platform alias nothing repairs it. Measured on Android 13 / arm64: a text widget set to "Arial Black" grew the native heap by +1187 MB over ~14 redraws (chunks of Roboto-Regular.ttf, identified by byte comparison), until the platform memory guard killed the process at 2.6 GB. Adds a regression test with an IFontManagerImpl that models a platform alias: without the fix the second resolution returns a different instance (re-synthesis), with it the cached one. * Make the regression test platform-independent Back the alias with an embedded test font instead of an installed Arial, and turn the test into a plain [Fact] so it runs on every platform. The defect being covered lives in FontCollectionBase and is platform-agnostic, so gating the test behind [Win32Fact] left it unexercised on the Linux and macOS legs of CI. Relying on an installed system font also made the test dependent on the build environment. The fake font manager now always resolves the alias to the regular face of an embedded font, whatever weight is asked for - which is what a platform alias actually does - so no system font is involved at all. * Make the regression test fail against unfixed code Name the backing font explicitly instead of taking whichever asset GetAssets enumerates first (currently AdobeBlank2VF.ttf, a blank variable font), matching the style used elsewhere for embedded test fonts. Assert that the first resolution really is a synthesised bold. Without it, a backing font that cannot be emboldened makes TryCreateSyntheticGlyphTypeface fail, the old else branch caches the nearest match, and the whole test passes against unfixed code. Verified both ways: FontCollectionTests is 4/4 with the fix, and Should_Cache_Synthetic_Match_Under_Requested_Family_Name is the single failure without it. --------- Co-authored-by: ronnycohen <19652995+ronnycohen@users.noreply.github.com> Co-authored-by: Benedikt Stebner <Gillibald@users.noreply.github.com>	4 weeks ago
Benedikt Stebner	b709c58c6b	[Text] Glyph Outline Part 2/13 - GlyphTypeface.GetGlyphOutline implementation (#21406 ) * Harden cmap/name/post parsing against malformed fonts Fonts are untrusted input, but several pre-existing table parsers throw out of the GlyphTypeface constructor on hostile data, denying the whole font instead of degrading the affected (cosmetic) table. - name: wrap NameTable.Load in try/catch so a malformed table falls back to a default family name (same outcome as an absent name), and bounds-check NameRecord.GetValue's (offset,length) slice — the record array is validated at load but each record's storage slice is read later during construction. - post: wrap PostTable.Load so a malformed cosmetic-hint table degrades to defaults rather than denying the font. - cmap format 12/13: clamp the declared length and group count to the buffer, computing the group span in long to avoid the nGroups12 int overflow a hostile count would wrap to a negative slice length. - cmap format 4 selection: score a Windows Symbol subtable worse than any Unicode subtable so ASCII resolves regardless of subtable order, while a Symbol-only font still selects its only subtable. maxp/cmap remain fatal by design. Behavioural hardening only; public API unchanged. Backportable independently of the glyph-outline stack. Clamp cmap range contents and harden binary reader primitives Format 12/13 group contents are attacker-controlled: TryGetRange used to hand the raw uint32 end straight to per-codepoint consumers, so a group with endCharCode 0x7FFFFFFF turned range enumeration into an unbounded (for int.MaxValue, non-terminating) loop. Clamp ranges to the Unicode range and map inverted/out-of-range groups to empty ranges so later groups still enumerate. Give the format 4 constructor the same treatment its format 12 sibling already received: clamp the declared length and segment count to what the buffer actually holds instead of slicing unchecked (debug asserts replaced by the clamps). In BigEndianBinaryReader, bounds-check array reads before allocating (a hostile length is rejected instead of attempting the allocation), make EnsureAvailable overflow-proof, and clamp ReadBytes against negative counts. * Add font parsing infrastructure for glyph outline/color drawing Introduces shared utility types that subsequent PRs will use to implement GetGlyphOutline (glyf table) and GetGlyphDrawing (COLR v0/v1) on GlyphTypeface: - ObjectPool<T>: thread-safe object pool used by Decyclers - Decycler<T> / CycleGuard<T> / DecyclerException: generic cycle-detection and depth-limiting utility for recursive font-table traversal (composite glyphs, paint graphs) - FontVariationSettings: parameter type for the upcoming GetGlyphOutline / GetGlyphDrawing overloads - IGlyphDrawing / GlyphDrawingType: return-type contract for color glyph drawings (outline, color layers, SVG, bitmap) - CharacterToGlyphMapDictionary: lightweight, allocation-free IReadOnlyDictionary<int, ushort> view over the cmap, plus CharacterToGlyphMap.AsReadOnlyDictionary() to expose it No behavior change; types are not yet consumed in this PR. * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Validate ObjectPool maxSize and add unit tests The ObjectPool<T> constructor previously accepted any maxSize value. A value of 0 or below silently caused every Return to be discarded, which is hard to diagnose at the call site. - Reject maxSize < 1 with ArgumentOutOfRangeException at construction. - Document the new precondition in the XML comment. - Add ObjectPoolTests covering: factory null guard, maxSize bounds, Rent/Return basics, Return ignoring null, max-size enforcement, validator invocation and rejection, validator-as-reset, plus concurrent stress tests for cap enforcement and parallel use. * Validate Decycler maxDepth and add unit tests The Decycler<T> constructor previously accepted any maxDepth value. A value of 0 or below made the very first Enter throw DepthLimitExceeded, which presents as a cycle/depth error at use time instead of pointing at the construction site. - Reject maxDepth < 1 with ArgumentOutOfRangeException at construction. - Document the new precondition in the XML comment. - Add DecyclerTests covering: maxDepth bounds, Enter/Exit lifecycle, nested depth, cycle detection, depth-limit-exceeded, depth-vs-cycle ordering, no state mutation on failed Enter, Reset semantics, guard idempotency, MaxDepth/CurrentDepth properties, and a struct type other than int. * Add tests for CharacterToGlyphMap.AsReadOnlyDictionary Covers the IReadOnlyDictionary<int, ushort> view returned by AsReadOnlyDictionary, using the existing Inter font asset: - ContainsKey agrees with the underlying map for both mapped and unmapped code points. - Indexer returns the same glyph id as map.GetGlyph for several representative ASCII characters. - Indexer throws KeyNotFoundException for an unmapped code point. - TryGetValue: positive and negative paths. - Count is positive and matches the enumerated pair count. - Enumeration yields (key, value) pairs that round-trip through the underlying CharacterToGlyphMap. - Keys enumeration and pair-key enumeration agree. - Two AsReadOnlyDictionary() calls produce functionally equivalent views (no identity assumption). Tests live alongside the existing CharacterToGlyphMap tests in GlyphTypefaceTests so they can reuse the CustomPlatformTypeface helper. * Redesign FontVariationSettings; add GlyphDrawingOptions FontVariationSettings is changed from a public record to a sealed class with internal factory methods (FromCoordinates / FromInstance), a FrozenDictionary backing for NormalizedCoordinates, and structural Equals/GetHashCode. The type now exclusively models variable-font axis configuration; palette and bitmap-strike concerns are moved out. GlyphDrawingOptions is a new public sealed record that carries the drawing options that are independent of axis configuration: an optional CPAL palette index (≥ 0) and an optional bitmap-strike pixel size (≥ 1). Both properties validate at init time and the type participates in record-equality and with-expressions. Tests are added for both types (48 new assertions). * Make FontVariationSettings factories public FromCoordinates and FromInstance are promoted from internal to public. They were kept internal while the consuming public API was being designed; that design is now settled (GlyphTypeface.CreateVariationSettings / VariationAxes / VariationInstances, planned for PR2). Class-level remarks are updated to describe the typeface-agnostic design rationale and point to GlyphTypeface.CreateVariationSettings as the preferred entry point for user-space axis values. * Tighten contracts and docs on font-parsing infra Polish pass on the shared infrastructure types so the contract surface is unambiguous before PR2 (GetGlyphOutline) and PR3 (GetGlyphDrawing) build on it: - IGlyphDrawing now exposes GlyphDrawingType Type so callers can branch on format without downcasting. The GlyphDrawingType enum was already defined but unreferenced by the interface; this closes the loop. PR3's ColorGlyphDrawing and ColorGlyphV1Drawing already implement the property, so the rebase is a no-op. - IGlyphDrawing.Bounds and Draw(origin) get explicit coordinate-space docs (drawing-space, Y-down; origin is the post-flipped glyph anchor). - Decycler<T> gets a class-level remarks block stating it is not thread-safe (one instance per traversal) and that Enter throws on cycle / depth-limit so callers can catch at the outermost site. - FontVariationSettings.Default documents that null and Default are interchangeable for parameters typed as FontVariationSettings?. - ObjectPool.Return documents that callers must not return the same item twice without an intervening Rent — the pool does not detect duplicate returns by design. Tests: - ObjectPool: validator must not be invoked on Rent (pins the validate-on-return contract). - GlyphDrawingOptions: parameterless ctor equals Default (record equality should make them interchangeable). - FontVariationSettings: FromCoordinates with both coordinates AND instanceIndex populated (combined form documented in the API). 83 tests pass (was 76). * Reshape FontVariationSettings for cache-key use Switch from a class wrapping FrozenDictionary + nullable instance index to a readonly struct backed by a sorted ImmutableArray of a dedicated FontVariationCoordinate record-struct. Driven by the type's role as a field on FontCollectionKey: - Hash code is computed once at construction and cached. Lookups in the font-resolution cache no longer pay an OrderBy allocation per call. - Equality is a parallel walk over two sorted arrays — no hash lookup, no TryGetValue per element. Short-circuits on cached-hash mismatch. - TryGetCoordinate / GetCoordinateOrDefault are linear scans, faster than hash lookup for the typical handful-of-axes case. - default(FontVariationSettings) is the "no variation" value. The old Default singleton goes away; nullable-handling at the cache layer becomes unnecessary. - InstanceIndex is dropped from the type. Named-instance selection is a typeface-level concern that resolves to coordinates; the runtime settings carry coordinates only, matching CSS / HarfBuzz / DirectWrite conventions. Tests rewritten: 34 cases covering struct semantics, sorting, TryGetCoordinate, hash caching, equality short-circuits, and the FontVariationCoordinate record's own equality. * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Fix auto suggestion * Add synthetic-font test harness SyntheticFont / BigEndianBuffer build and mutate in-memory sfnt fonts so the table parsers can be exercised against hand-crafted malformed input without a platform shaper. Shared by every parser PR's malformed-font tests. * Characterize cmap/name/post degradation on malformed input Regression guards over the synthetic-font harness: a truncated post/name table degrades to defaults / a fallback family name instead of denying the font, the cmap format-12 nGroups12 overflow is clamped, and Format-4 selection prefers a Unicode subtable over Windows Symbol regardless of directory order. Fix dictionary wrapper contract, guard double-exit, and zero-coordinate canonicalization CharacterToGlyphMapDictionary mixed two membership predicates: Keys and Count filtered by ContainsGlyph while the indexer, TryGetValue and the enumerator used TryGetGlyph, so glyph-0 mappings produced keys the indexer rejected. Everything now answers through TryGetGlyph, and the Count walk (O(codepoints) over the mapped ranges) is computed once and cached. Decycler.Exit decremented the depth unconditionally: CycleGuard is a copyable ref struct, so a copied guard could exit the same id twice and grant later traversals extra depth budget. Depth is now only returned when the id was actually removed from the visited set. FontVariationSettings.FromCoordinates kept zero-valued coordinates, so an explicitly-default axis (wght=0 normalized) hashed and compared as a distinct value from settings omitting the axis - producing duplicate variation clones and font-collection cache entries downstream. Both factories now canonicalize zeros away (after the duplicate-axis check, which the dictionary overload previously skipped entirely). * Document the cmap dictionary view and tighten Decycler/ObjectPool internals Add XML docs to CharacterToGlyphMapDictionary's members. Collapse Decycler.Enter's Contains-then-Add into a single HashSet.Add (a false return means the id was already visited - a cycle). Make ObjectPool's lock-free count fast-check a volatile read. * Simplify FontVariationSettings.Equals to a span SequenceEqual Map the coordinate comparison onto the inner array via the span overload (Coordinates normalizes default to Empty, so both spans are valid). The span SequenceEqual avoids the boxing the LINQ overload would incur on this dictionary-key type, and FontVariationCoordinate's record-struct value equality drives the element compare. The cached-hash early-out is kept. * Add pre-allocation validation in NameTable.Load so malformed name tables are rejected before creating the names array. * Make PostTable.Load to catch only the malformed-data exception raised by this parsing path, instead of catching everything. * Raise ArgumentOutOfRangeException for negative count * Validate tableLength for CmapFormat12Or13Table ctor * Fixes GlyphDrawingOptions ArgumentOutOfRangeException nameof usage * Fix CmapFormat4Table ctor: clamp parallel-array offsets to tableLength When a malformed subtable declares a length that drives _segCount to 0, startCodeOffset = endCodeOffset + 02 + 2 (reservedPad) can exceed tableLength, causing Slice() to throw and denying the font entirely. Apply Math.Min(offset, tableLength) to each derived array offset so that zero-length slices always start at a valid position, degrading silently to an empty mapping instead of crashing. Revert change * Only handle specific exceptions in NameTable.Load Guard against negative count in BigEndianBuffer.Zeros * Speak user space in the public variation API Normalized coordinates are font-relative - the same value means different user positions under different fvar ranges and avar maps - so they cannot be authored in a style before font resolution and do not interpolate meaningfully. Every mainstream API (CSS font-variation-settings, DirectWrite, HarfBuzz, Skia) traffics in user-space values, and a public normalized type named like theirs invites passing wght=700 into a [-1,1] slot. - new public currency: FontVariation (tag=value in designer units) and an immutable FontVariationSettings with Parse/ToString ("wght=700,wdth=85"), order-independent structural equality, a cached hash, and CSS last-wins duplicate handling - usable as a style value and a cache key - the normalized pair moves out of public view: FontVariationCoordinate becomes internal NormalizedVariationCoordinate and the normalized settings struct becomes internal NormalizedVariationPosition, unchanged in behavior - the user-space -> normalized conversion stays a per-font, application- time concern; the fvar/avar reader lands in a follow-up PR * Accept infinite font variation values Infinities clamp to the axis range at apply time like any out-of-range value, so only NaN is rejected now. Parse also uses explicit number styles instead of NumberStyles.Float since the value text is pre-trimmed and the whitespace flags were redundant. * Guard NameRecord.GetValue against decoder exceptions The selected encodings use replacement fallback and never throw on malformed bytes, but degrade to an empty value anyway so an exception-throwing fallback can never deny the font. * Use nameof(value) in GlyphDrawingOptions setter exceptions Matches the .NET runtime convention for property setters, also used elsewhere in this repo (e.g. FormattedText). * Add GetGlyphOutline API with glyf/loca table parsing Implements vector outline retrieval for TrueType glyphs: - LocaTable: parses the 'loca' table (short/long offset variants) to map glyph IDs to glyf offsets - GlyfTable: parses the 'glyf' table, supporting simple and composite glyphs, and builds geometry into an IGeometryContext - SimpleGlyph / CompositeGlyph / GlyphDescriptor / GlyphComponent / GlyphFlag / CompositeFlags: data model for the parsed glyph records - GlyphDecycler: pooled cycle/depth guard for composite-glyph recursion (derives from the shared Decycler<int>) GlyphTypeface now eagerly loads the glyf table when a head table is present and exposes: Geometry? GetGlyphOutline(ushort glyphId, Matrix transform, FontVariationSettings? variation = null) Returns null when the font has no outline data for the glyph or the glyph index is out of range. * Drop variation parameter from GetGlyphOutline The FontVariationSettings? variation parameter was a forward-compat placeholder that was never wired through to the glyph parser. Remove it so the API doesn't advertise capability it doesn't have. Variable-font support will land as an instance-level concern on GlyphTypeface itself (mirroring how FontSimulations is already baked in at construction time), resolved through IFontCollection alongside FontWeight/Style/Stretch. Adding variation back as a per-call parameter would be additive at that point if a concrete need emerges. * Add unit tests for loca/glyf parsing Covers the glyph-outline parser that GetGlyphOutline builds on, exercised directly against the Inter test font without a platform render interface: - LocaTableTests: glyph-count parity with maxp, out-of-range handling, ascending ranges for every glyph, empty-glyph (space) zero-length range. - GlyfTableTests: TryGetGlyphData for out-of-range / empty / letter glyphs; TryBuildGlyphGeometry into a recording IGeometryContext for simple, empty, out-of-range and composite glyphs; transform application; closed- figure invariants. Tables are loaded via their internal factories and geometry is captured through a fake IGeometryContext, so the parser logic is tested in isolation. * Add glyph-outline render tests with Inter Variable Render-comparison coverage for GetGlyphOutline, drawing the returned Geometry filled in black on a white background and diffing against an expected PNG (RMSE, 2.2% tolerance, both immediate and compositor paths): - Should_Render_Inter_Latin_Glyph — Inter-Regular 'A' (simple glyph). - Should_Render_Inter_Composite_Glyph — Inter-Regular 'Á' (composite glyph: base + accent), exercises the recursive component path. - Should_Render_MiSans_CJK_Glyph — MiSans-Normal '中' (CJK ideograph, many contours / counters). - Should_Render_InterVariable_At_Default — new Inter Variable asset rendered at the default variation point. PR2 doesn't apply variation, so this baselines the default-instance outline against which the future variable-font work can compare deformed outputs. - Blank_Variable_Font_Returns_Null_Outline — AdobeBlank2VF (variable font with intentionally empty glyphs) verifies GetGlyphOutline returns null without throwing. Fonts are loaded via SKData.CreateCopy + SKTypeface.FromData so the typeface's lifetime survives the source stream's disposal. This also sidesteps a family-name collision: Inter-Regular and InterVariable both identify as family "Inter", so FontManager resolution would be ambiguous — direct loading targets each file unambiguously. InterVariable.ttf is added under Assets/ and picked up by the existing EmbeddedResource wildcard in both render-test projects. * Set non-zero fill rule on glyph outlines Avalonia geometries default to FillRule.EvenOdd. TrueType outlines expect the non-zero winding rule: where same-orientation contours overlap (an 'A' crossbar over its diagonal strokes, an accent over its base glyph in a composite), EvenOdd XORs the regions and leaves visible gaps. Setting the fill rule once on the outer context at the entry to TryBuildGlyphGeometry fills the geometry correctly, including through the composite path's TransformingGeometryContext wrapping (the wrapping applies to transforms, not to the geometry-level fill rule). Baselines for the three Inter glyphs were regenerated; the MiSans ideograph is unaffected because CJK strokes don't overlap. * Drop per-point debug logging from TransformingGeometryContext The glyph-outline transform wrapper logged every ArcTo / BeginFigure / CubicBezierTo / QuadraticBezierTo / LineTo / EndFigure / SetFillRule / Dispose call through Logger.TryGet(LogEventLevel.Debug, ...). That was useful while bringing up the glyf parser but runs a guard check per contour point on every glyph outline build — pure overhead now that the path is stable. Each method is back to a plain transform-and-delegate; Dispose is a no-op (the wrapper never owned the inner context). The exceptional-path warning in TryBuildGlyphGeometry (cyclic composite glyphs) is unrelated and stays. * Add InterVariable.ttf to Should_AddGlyphTypeface_By_Stream font list The glyph-outline render tests embed InterVariable.ttf under Avalonia.RenderTests/Assets, which the Skia unit-test project picks up via its `EmbeddedResource Include="..\Avalonia.RenderTests\Assets\*\.ttf"` glob. The asset enumeration therefore returns 16 fonts while the test's hard-coded `infos` list had 15, failing the count assertion. Add the missing entry in its ordinal-case-insensitive sort position (after Inter-Regular.ttf). Its production identity — FamilyName "Inter Variable", Weight Normal (the default fvar instance, usWeightClass 400) — is distinct from the "Inter" family of Inter-Regular/Inter-Bold, so the (family, weight) round-trip lookup stays unique. * Fix off-by-one glyph-id bounds check; drop unused usings GetGlyphOutline rejected out-of-range ids with `glyphId > GlyphCount`, which let the id equal to GlyphCount slip through — valid glyph ids are 0..GlyphCount-1, and reading at index GlyphCount walks past the end of the loca offsets. Use `>=` so the upper bound is excluded. Also remove unused using directives from the glyf parsers (CompositeGlyph, GlyfTable, GlyphDescriptor, SimpleGlyph). * Allocate batch glyph-metric buffers only when their source is present Batch TryGetGlyphMetrics unconditionally sized the hMetrics and vMetrics temporary buffers to glyphIds.Length even when the font has no hmtx or no vmtx. Most fonts ship no vmtx, so a large batch heap-allocated a per-glyph vertical-metric array that was never read. Size each buffer to zero — a free, empty stackalloc — when its source table is absent, so it only materialises (and only spills to the heap past 256 glyphs) when it will actually be filled and read. * Bail out of composite glyphs that use point matching A composite component with ARGS_ARE_XY_VALUES clear positions itself by point matching: arg1/arg2 are point indices, and the component is placed so one of its points coincides with a point in the already-assembled parent glyph. CreateComponentTransform only applied a translation when ARGS_ARE_XY_VALUES was set, so a point-matched component was rendered at zero translation — a visibly wrong outline. Point matching isn't implemented. Rather than emit an incorrect glyph, return false for any composite that uses it (checked before any geometry is emitted) so the caller falls back to "no outline". XY-value composites (the overwhelming common case, e.g. accented Latin letters) are unaffected. * Support composite glyph point matching Composite components with ARGS_ARE_XY_VALUES clear are positioned by aligning one of their points onto a point of the already-assembled glyph rather than by an x/y offset. The streaming build path cannot retain points, so route these (rare) composites through a new materialising path: resolve every component into a pooled buffer, apply the point-match translation, then emit the assembled contours. Out-of-range point indices, phantom-point references, and nested composite components bail out (no outline) rather than render incorrectly. Replaces the previous bail-out, and adds a synthetic-font test covering matched-point alignment and the bail-out cases. * Add point-matching composite render test No production font encodes composite point matching (ARGS_ARE_XY_VALUES clear) — verified across the Inter, Noto, Source, SIL (Gentium/Charis/Andika) and Oswald families, which all use x/y offsets. To exercise GlyfTable's point-matching path through the full Skia pipeline, this adds a small purpose-built fixture (PointMatch.ttf, 880 bytes) whose 'P' glyph is a composite: a base rectangle plus a square placed by point matching, aligning the square's bottom-left point onto the rectangle's top-right point. The baseline shows the square fused to the rectangle's top-right corner; a regression that mishandled point matching would drop it at the origin, which the image diff catches. * Add missing test font to the list of expected fonts in the Should_AddGlyphTypeface_By_Stream test * Return an immutable IGeometryImpl from GetGlyphOutline GetGlyphOutline(ushort, Matrix) returned a mutable StreamGeometry (an AvaloniaObject) with the transform baked in — neither cacheable (every pen position is a distinct geometry) nor safe to share. Reshape to GetGlyphOutline(ushort) returning design-unit-space geometry as an immutable IGeometryImpl (a small sealed wrapper that exposes only the read-only surface and can't be re-opened), so a single instance is safe to cache and share on the future glyph-run hot path. Callers apply scale/position via IGeometryImpl.WithTransform or a drawing-context transform, and draw through the existing DrawGeometry(IGeometryImpl) overload. * Add SyntheticFont harness self-tests Round-trip, table patch/replace/remove/truncate, and asset-load tests for the synthetic-font harness over Inter-Regular and InterVariable. * Reject non-monotonic contour endpoints in simple glyph parsing numPoints is derived from the last contour endpoint alone, so a glyph whose endPtsOfContours array is not strictly increasing sized its point buffers too small and sent every consumer walk indexing past them - an IndexOutOfRangeException on each outline build of that glyph. Validate the endpoints up front and return the default (empty) glyph instead. * Rename glyph-index parameters to glyphIndex / glyphIndices Review feedback on the glyph-outline API: the ushort values these members take are glyph indices, and the platform already speaks that language (GlyphRun.GlyphIndices), so the parameters say what they are instead of the looser glyphId/glyphIds. Applies to GetGlyphOutline and the advance/metrics members this series reworks, plus the tests exercising them. Purely a naming change - no call site uses named arguments. * Add failing tests for the off-curve contour walk The off-curve-start branch of the glyph walker drops one quadratic per extra point in runs of consecutive off-curve points and ignores an on-curve last point when picking the figure start. Pins the correct TrueType decomposition; the on-curve-start case is pinned as-is. * Unify the contour walkers into one EmitContour Both geometry emitters carried the same on-curve/off-curve branch pair, and the off-curve branch had two defects: it advanced past both points of an off-curve pair (dropping one quadratic per extra point in longer off-curve runs) and always started at the implied midpoint even when the last point of the contour is on-curve. One shared walker now does the TrueType decomposition with a pending-control state machine and an explicit close, and both the simple-glyph path and the point-matching composite path route every contour through it. * Add failing tests for truncated glyf and loca data The counts in a simple glyph header and in maxp are untrusted: a body shorter than they promise currently throws out of SimpleGlyph.Create, and a short loca table reports a glyph count it cannot index. * Degrade to an empty outline on truncated glyf/loca data SimpleGlyph.Create bounds-checks the endpoint array, the declared instruction run and every flag/coordinate read, returning default (and the rented buffers) instead of throwing when the body is shorter than its untrusted counts promise. LocaTable clamps its glyph count to the entries the table data actually covers, replacing an empty validation block that only claimed to handle short tables. * Name bit 6 of the simple glyph flags OVERLAP_SIMPLE The OpenType spec assigns bit 6 (0x40) OVERLAP_SIMPLE; only bit 7 is reserved. --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Julien Lebosquain <julien@lebosquain.net>	4 weeks ago
Emmanuel Hansen	f2e8e8931f	Add generic navigation apis to Page Navigation (#22010 ) * add page navigation using generic type * add tests * add default impl to INavigation api * fix nullable errors * update api diff * addressed comment * update api * move page externsion to own class * make parameter overload non-optional	1 month ago
kerams	9d5c2fa81d	Fix empty FlexPanel size (#22130 )	1 month ago
Julien Lebosquain	5d25bd6463	Fix init order of SetupWithClassicDesktopLifetime (#21954 ) * Fix init order of SetupWithClassicDesktopLifetime * Don't raise Startup in Setup * Fix warning	1 month ago
Emmanuel Hansen	72218879d8	Fix focus being locked when restoring focus to a control thats detached from visual tree. (#22113 ) * add failing test for detached focus * Clear focus if restore element is not in focus scope * check for focus eligibility when restoring focus * add failing test for second focus scope stealing focus * if focus scope is not the current focus scope, don't attempt to set focus	1 month ago
Benedikt Stebner	2e7d2c5c60	Fix infinite loop when a text run shapes to no glyphs (#22119 ) * Add failing tests for runs that shape to no glyphs A shaper hides the default ignorables it substitutes for line breaks behind the font's space glyph, and deletes them when the font has no such glyph. A run holding nothing but a line break then shapes to an empty glyph buffer while still owning its characters. - TextFormatter drops that run today, so the line covers no text and the layout loop never advances past it - measuring a wrapping TextBlock whose text starts with a newline never returns. - GlyphRun indexes its glyph list without checking it is non-empty, so hit-testing such a run throws IndexOutOfRangeException. Covers all three layers: GlyphRun hit-testing, the formatted line, and the TextLayout repro from the issue. The layout test bounds maxLines so a regression fails instead of hanging the test run. The Skia tests embed the headless platform's BareMinimum.ttf, which has four glyphs and no space, rather than a copy of it. * Keep text runs that shape to no glyphs ShapeTogether split the shaped buffer by glyph count, so a run whose glyphs were all deleted by the shaper was skipped and its characters rolled into previousLength for a following run to absorb. When no such run follows, the characters are lost: the line reports a length of 0 and TextLayout formats the same line forever. Splitting by text length preserves the case the accumulation exists for - a run whose glyphs merged into a neighbouring cluster splits off no text either - and stops discarding characters that shaped to nothing. That makes zero-glyph glyph runs reachable for the first time, so: - GetDistanceFromCharacterHit, FindGlyphIndex and FindNearestCharacterHit handle an empty glyph list. There is no cluster to snap to and the run sits at a single position, so it degenerates to one zero-width cluster. - InkBounds answers empty directly instead of building a platform glyph run. TextLineImpl reads it for every shaped run in a line, and the Skia implementation creates an SKFont and measures glyph widths in its constructor - wasted on a run that marks nothing. Fixes #22004 * Adjust GlyphRun.InkBounds xml comment	1 month ago
Steven Kirk	1c9e559996	Fix #7536 : crash when changing source during SelectionChanged (#22102 ) * Add failing test for #7536 Reproduces the "Cannot change source while update is in progress" crash that occurs when a SelectingItemsControl's ItemsSource is changed from within its own SelectionChanged handler while the selection is being lost. When selection is lost, CommitOperation bumps the operation UpdateCount before raising LostSelection but never decrements it, so SelectionChanged is raised with UpdateCount > 0 and SetSource throws. Claude-Session: https://claude.ai/code/session_01FXP1ejZ9VhUwecY9QCRKVb Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Fix #7536: crash when changing source during SelectionChanged When the selection was lost, SelectionModel.CommitOperation incremented the operation's UpdateCount before raising LostSelection but never decremented it. As a result the rest of the commit - including the SelectionChanged event - ran with UpdateCount > 0, so a handler that changed the control's source (as StructuredLogViewer's UpdateBreadcrumb does) hit the "Cannot change source while update is in progress." guard in SetSource and threw. Decrement UpdateCount again once the LostSelection handler has returned so that the batching only covers the handler itself and the SelectionChanged event is free to change the source. Claude-Session: https://claude.ai/code/session_01FXP1ejZ9VhUwecY9QCRKVb Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Add test for changing selection from SelectionChanged when AlwaysSelected reselects Covers the interaction between the #7536 fix and AlwaysSelected: clearing the selection makes AlwaysSelected reselect the first item via LostSelection (which must still fold into the current operation), and a SelectionChanged handler that then changes the selection must be honoured rather than swallowed by the batch update wrapping the LostSelection handler. Fails before the fix (selection stays on the reselected item), passes after. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FXP1ejZ9VhUwecY9QCRKVb * Assert that `SelectionChanged` was called. --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>	1 month ago
Nikita Tsukanov	6896f08f37	Basic infra to use headless platform in "normal" unit tests (#22078 ) * Basic infra for using headless platform in normal tests * Add RunJobs helper to scope returned from HeadlessUnitTestApplication	1 month ago
Nathan Nguyen	a8b1a6b55a	Don't build the selected text just to check whether a selection exists (#22100 ) * perf(text): test the selection by index instead of building it UpdateCommandStates only needs to know whether the selection is empty, but it called GetSelection, which allocates a substring on every selection change. Test the indices instead, so a selection change no longer allocates. Requested by @Gillibald in #21492. * perf(text): read the selection properties once in HasSelection	1 month ago
Steven Kirk	31d6979377	Fix data validation errors not showing for OneWayToSource bindings (#22103 ) * Add failing tests for OneWayToSource validation (#8235) Data validation errors from validation attributes (e.g. [MaxLength]) and INotifyDataErrorInfo are not displayed when binding with Mode=OneWayToSource. Add tests covering both the DataAnnotations and INDEI cases when writing to the source. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013gwdaykrFyoMZFeVmWMydb * Publish data validation errors for OneWayToSource bindings (#8235) In OneWayToSource mode, BindingExpression.OnNodeValueChanged discarded any data validation error produced when writing the value to the source, so validation attributes and INotifyDataErrorInfo errors were never displayed. Publish (and clear) the error via UnchangedValue so that the error state reaches the target without pushing a value back to it, preserving the one-way-to-source semantics. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013gwdaykrFyoMZFeVmWMydb * Added passing test for #15378. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>	1 month ago
Steven Kirk	9d54818fd5	Fix memory leak when binding to observables (#5872 , #18176 ) (#22097 ) * Add failing leak tests for observable binding target retention (#5872) A binding to a long-lived observable via the `^` stream operator (or via `Observable.ToBinding()`, #18176) keeps the binding target alive for the lifetime of the observable. Every other binding type holds its target weakly so the target can be collected even while the binding is active; observable-sourced bindings break this invariant because the observable holds the observer (and therefore the whole expression/target chain) strongly. These tests currently fail and document the leak. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wc2sczJ87MD2wVDjgQjDLB * Subscribe weakly to observable binding sources (#5872, #18176) Bindings hold their target weakly so that a control can be collected even while a binding to a long-lived source is active; normal property bindings preserve this by subscribing to their source via weak events. Observable sources broke the invariant: `observable.Subscribe(this)` let the observable hold the observer strongly, which transitively rooted the ValueStore and therefore the binding target, so a long-lived observable pinned the control for the observable's lifetime. Introduce WeakObserverSubscription, which subscribes an observer to an observable via a weak reference and disposes itself once the observer has been collected, and use it from StreamNode (the `^` stream operator) and UntypedObservableBindingExpression (Observable.ToBinding()). Claude-Session: https://claude.ai/code/session_01Wc2sczJ87MD2wVDjgQjDLB Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Remove null-forgiving operator. * Remove unnecesary comments. It's plain from the code what's going on here. --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>	1 month ago
Steven Kirk	7527557ca0	Short-circuit the binding chain on a null-conditional operator (#22082 ) * Add failing test for issue described in #22069. https://github.com/AvaloniaUI/Avalonia/pull/22069#issuecomment-5442287978 * Add failing test for #18949. * Add failing tests for null conditional on attached property. * Short-circuit the binding chain on a null-conditional operator. The null-conditional operator in a binding path was only applied to the node it was attached to: a null source produced a null value which was then passed to the next node in the chain, which raised "Value is null.". C# instead short-circuits the remainder of the expression, so `a?.b.c` evaluates to null when `a` is null. Do the same for binding paths. When a null-conditional node has a null source it now sets its own value and that of all subsequent nodes to null, and the binding publishes null rather than an error. Publishing null rather than UnsetValue means TargetNullValue still applies. Attached properties in reflection bindings never honoured the operator at all: the grammar parses `?.(Foo.Bar)` and sets AttachedPropertyNameNode.AcceptsNull, but ExpressionNodeFactory discarded the flag and AvaloniaPropertyAccessorNode had no way to accept it. Pass it through. Compiled bindings were unaffected as they route attached properties through PropertyAccessorNode. Fixes #18949. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Atuuu4jtp14QXXoCzkp2A6 * Add TargetNullValue tests for short-circuited chains. Covers `A?.B.C` where A is null, for both CLR and Avalonia properties. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014aahFHMmgxZtZ5EH3H5Xcc --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>	1 month ago
Benedikt Stebner	eeb9e36a05	[Text] Glyph Outline Part 1/13 - Utility types for glyph outline support (#21405 ) * Harden cmap/name/post parsing against malformed fonts Fonts are untrusted input, but several pre-existing table parsers throw out of the GlyphTypeface constructor on hostile data, denying the whole font instead of degrading the affected (cosmetic) table. - name: wrap NameTable.Load in try/catch so a malformed table falls back to a default family name (same outcome as an absent name), and bounds-check NameRecord.GetValue's (offset,length) slice — the record array is validated at load but each record's storage slice is read later during construction. - post: wrap PostTable.Load so a malformed cosmetic-hint table degrades to defaults rather than denying the font. - cmap format 12/13: clamp the declared length and group count to the buffer, computing the group span in long to avoid the nGroups12 int overflow a hostile count would wrap to a negative slice length. - cmap format 4 selection: score a Windows Symbol subtable worse than any Unicode subtable so ASCII resolves regardless of subtable order, while a Symbol-only font still selects its only subtable. maxp/cmap remain fatal by design. Behavioural hardening only; public API unchanged. Backportable independently of the glyph-outline stack. Clamp cmap range contents and harden binary reader primitives Format 12/13 group contents are attacker-controlled: TryGetRange used to hand the raw uint32 end straight to per-codepoint consumers, so a group with endCharCode 0x7FFFFFFF turned range enumeration into an unbounded (for int.MaxValue, non-terminating) loop. Clamp ranges to the Unicode range and map inverted/out-of-range groups to empty ranges so later groups still enumerate. Give the format 4 constructor the same treatment its format 12 sibling already received: clamp the declared length and segment count to what the buffer actually holds instead of slicing unchecked (debug asserts replaced by the clamps). In BigEndianBinaryReader, bounds-check array reads before allocating (a hostile length is rejected instead of attempting the allocation), make EnsureAvailable overflow-proof, and clamp ReadBytes against negative counts. * Add font parsing infrastructure for glyph outline/color drawing Introduces shared utility types that subsequent PRs will use to implement GetGlyphOutline (glyf table) and GetGlyphDrawing (COLR v0/v1) on GlyphTypeface: - ObjectPool<T>: thread-safe object pool used by Decyclers - Decycler<T> / CycleGuard<T> / DecyclerException: generic cycle-detection and depth-limiting utility for recursive font-table traversal (composite glyphs, paint graphs) - FontVariationSettings: parameter type for the upcoming GetGlyphOutline / GetGlyphDrawing overloads - IGlyphDrawing / GlyphDrawingType: return-type contract for color glyph drawings (outline, color layers, SVG, bitmap) - CharacterToGlyphMapDictionary: lightweight, allocation-free IReadOnlyDictionary<int, ushort> view over the cmap, plus CharacterToGlyphMap.AsReadOnlyDictionary() to expose it No behavior change; types are not yet consumed in this PR. * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Validate ObjectPool maxSize and add unit tests The ObjectPool<T> constructor previously accepted any maxSize value. A value of 0 or below silently caused every Return to be discarded, which is hard to diagnose at the call site. - Reject maxSize < 1 with ArgumentOutOfRangeException at construction. - Document the new precondition in the XML comment. - Add ObjectPoolTests covering: factory null guard, maxSize bounds, Rent/Return basics, Return ignoring null, max-size enforcement, validator invocation and rejection, validator-as-reset, plus concurrent stress tests for cap enforcement and parallel use. * Validate Decycler maxDepth and add unit tests The Decycler<T> constructor previously accepted any maxDepth value. A value of 0 or below made the very first Enter throw DepthLimitExceeded, which presents as a cycle/depth error at use time instead of pointing at the construction site. - Reject maxDepth < 1 with ArgumentOutOfRangeException at construction. - Document the new precondition in the XML comment. - Add DecyclerTests covering: maxDepth bounds, Enter/Exit lifecycle, nested depth, cycle detection, depth-limit-exceeded, depth-vs-cycle ordering, no state mutation on failed Enter, Reset semantics, guard idempotency, MaxDepth/CurrentDepth properties, and a struct type other than int. * Add tests for CharacterToGlyphMap.AsReadOnlyDictionary Covers the IReadOnlyDictionary<int, ushort> view returned by AsReadOnlyDictionary, using the existing Inter font asset: - ContainsKey agrees with the underlying map for both mapped and unmapped code points. - Indexer returns the same glyph id as map.GetGlyph for several representative ASCII characters. - Indexer throws KeyNotFoundException for an unmapped code point. - TryGetValue: positive and negative paths. - Count is positive and matches the enumerated pair count. - Enumeration yields (key, value) pairs that round-trip through the underlying CharacterToGlyphMap. - Keys enumeration and pair-key enumeration agree. - Two AsReadOnlyDictionary() calls produce functionally equivalent views (no identity assumption). Tests live alongside the existing CharacterToGlyphMap tests in GlyphTypefaceTests so they can reuse the CustomPlatformTypeface helper. * Redesign FontVariationSettings; add GlyphDrawingOptions FontVariationSettings is changed from a public record to a sealed class with internal factory methods (FromCoordinates / FromInstance), a FrozenDictionary backing for NormalizedCoordinates, and structural Equals/GetHashCode. The type now exclusively models variable-font axis configuration; palette and bitmap-strike concerns are moved out. GlyphDrawingOptions is a new public sealed record that carries the drawing options that are independent of axis configuration: an optional CPAL palette index (≥ 0) and an optional bitmap-strike pixel size (≥ 1). Both properties validate at init time and the type participates in record-equality and with-expressions. Tests are added for both types (48 new assertions). * Make FontVariationSettings factories public FromCoordinates and FromInstance are promoted from internal to public. They were kept internal while the consuming public API was being designed; that design is now settled (GlyphTypeface.CreateVariationSettings / VariationAxes / VariationInstances, planned for PR2). Class-level remarks are updated to describe the typeface-agnostic design rationale and point to GlyphTypeface.CreateVariationSettings as the preferred entry point for user-space axis values. * Tighten contracts and docs on font-parsing infra Polish pass on the shared infrastructure types so the contract surface is unambiguous before PR2 (GetGlyphOutline) and PR3 (GetGlyphDrawing) build on it: - IGlyphDrawing now exposes GlyphDrawingType Type so callers can branch on format without downcasting. The GlyphDrawingType enum was already defined but unreferenced by the interface; this closes the loop. PR3's ColorGlyphDrawing and ColorGlyphV1Drawing already implement the property, so the rebase is a no-op. - IGlyphDrawing.Bounds and Draw(origin) get explicit coordinate-space docs (drawing-space, Y-down; origin is the post-flipped glyph anchor). - Decycler<T> gets a class-level remarks block stating it is not thread-safe (one instance per traversal) and that Enter throws on cycle / depth-limit so callers can catch at the outermost site. - FontVariationSettings.Default documents that null and Default are interchangeable for parameters typed as FontVariationSettings?. - ObjectPool.Return documents that callers must not return the same item twice without an intervening Rent — the pool does not detect duplicate returns by design. Tests: - ObjectPool: validator must not be invoked on Rent (pins the validate-on-return contract). - GlyphDrawingOptions: parameterless ctor equals Default (record equality should make them interchangeable). - FontVariationSettings: FromCoordinates with both coordinates AND instanceIndex populated (combined form documented in the API). 83 tests pass (was 76). * Reshape FontVariationSettings for cache-key use Switch from a class wrapping FrozenDictionary + nullable instance index to a readonly struct backed by a sorted ImmutableArray of a dedicated FontVariationCoordinate record-struct. Driven by the type's role as a field on FontCollectionKey: - Hash code is computed once at construction and cached. Lookups in the font-resolution cache no longer pay an OrderBy allocation per call. - Equality is a parallel walk over two sorted arrays — no hash lookup, no TryGetValue per element. Short-circuits on cached-hash mismatch. - TryGetCoordinate / GetCoordinateOrDefault are linear scans, faster than hash lookup for the typical handful-of-axes case. - default(FontVariationSettings) is the "no variation" value. The old Default singleton goes away; nullable-handling at the cache layer becomes unnecessary. - InstanceIndex is dropped from the type. Named-instance selection is a typeface-level concern that resolves to coordinates; the runtime settings carry coordinates only, matching CSS / HarfBuzz / DirectWrite conventions. Tests rewritten: 34 cases covering struct semantics, sorting, TryGetCoordinate, hash caching, equality short-circuits, and the FontVariationCoordinate record's own equality. * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Fix auto suggestion * Add synthetic-font test harness SyntheticFont / BigEndianBuffer build and mutate in-memory sfnt fonts so the table parsers can be exercised against hand-crafted malformed input without a platform shaper. Shared by every parser PR's malformed-font tests. * Characterize cmap/name/post degradation on malformed input Regression guards over the synthetic-font harness: a truncated post/name table degrades to defaults / a fallback family name instead of denying the font, the cmap format-12 nGroups12 overflow is clamped, and Format-4 selection prefers a Unicode subtable over Windows Symbol regardless of directory order. Fix dictionary wrapper contract, guard double-exit, and zero-coordinate canonicalization CharacterToGlyphMapDictionary mixed two membership predicates: Keys and Count filtered by ContainsGlyph while the indexer, TryGetValue and the enumerator used TryGetGlyph, so glyph-0 mappings produced keys the indexer rejected. Everything now answers through TryGetGlyph, and the Count walk (O(codepoints) over the mapped ranges) is computed once and cached. Decycler.Exit decremented the depth unconditionally: CycleGuard is a copyable ref struct, so a copied guard could exit the same id twice and grant later traversals extra depth budget. Depth is now only returned when the id was actually removed from the visited set. FontVariationSettings.FromCoordinates kept zero-valued coordinates, so an explicitly-default axis (wght=0 normalized) hashed and compared as a distinct value from settings omitting the axis - producing duplicate variation clones and font-collection cache entries downstream. Both factories now canonicalize zeros away (after the duplicate-axis check, which the dictionary overload previously skipped entirely). * Document the cmap dictionary view and tighten Decycler/ObjectPool internals Add XML docs to CharacterToGlyphMapDictionary's members. Collapse Decycler.Enter's Contains-then-Add into a single HashSet.Add (a false return means the id was already visited - a cycle). Make ObjectPool's lock-free count fast-check a volatile read. * Simplify FontVariationSettings.Equals to a span SequenceEqual Map the coordinate comparison onto the inner array via the span overload (Coordinates normalizes default to Empty, so both spans are valid). The span SequenceEqual avoids the boxing the LINQ overload would incur on this dictionary-key type, and FontVariationCoordinate's record-struct value equality drives the element compare. The cached-hash early-out is kept. * Add pre-allocation validation in NameTable.Load so malformed name tables are rejected before creating the names array. * Make PostTable.Load to catch only the malformed-data exception raised by this parsing path, instead of catching everything. * Raise ArgumentOutOfRangeException for negative count * Validate tableLength for CmapFormat12Or13Table ctor * Fixes GlyphDrawingOptions ArgumentOutOfRangeException nameof usage * Fix CmapFormat4Table ctor: clamp parallel-array offsets to tableLength When a malformed subtable declares a length that drives _segCount to 0, startCodeOffset = endCodeOffset + 02 + 2 (reservedPad) can exceed tableLength, causing Slice() to throw and denying the font entirely. Apply Math.Min(offset, tableLength) to each derived array offset so that zero-length slices always start at a valid position, degrading silently to an empty mapping instead of crashing. Revert change * Only handle specific exceptions in NameTable.Load Guard against negative count in BigEndianBuffer.Zeros * Speak user space in the public variation API Normalized coordinates are font-relative - the same value means different user positions under different fvar ranges and avar maps - so they cannot be authored in a style before font resolution and do not interpolate meaningfully. Every mainstream API (CSS font-variation-settings, DirectWrite, HarfBuzz, Skia) traffics in user-space values, and a public normalized type named like theirs invites passing wght=700 into a [-1,1] slot. - new public currency: FontVariation (tag=value in designer units) and an immutable FontVariationSettings with Parse/ToString ("wght=700,wdth=85"), order-independent structural equality, a cached hash, and CSS last-wins duplicate handling - usable as a style value and a cache key - the normalized pair moves out of public view: FontVariationCoordinate becomes internal NormalizedVariationCoordinate and the normalized settings struct becomes internal NormalizedVariationPosition, unchanged in behavior - the user-space -> normalized conversion stays a per-font, application- time concern; the fvar/avar reader lands in a follow-up PR * Accept infinite font variation values Infinities clamp to the axis range at apply time like any out-of-range value, so only NaN is rejected now. Parse also uses explicit number styles instead of NumberStyles.Float since the value text is pre-trimmed and the whitespace flags were redundant. * Guard NameRecord.GetValue against decoder exceptions The selected encodings use replacement fallback and never throw on malformed bytes, but degrade to an empty value anyway so an exception-throwing fallback can never deny the font. * Use nameof(value) in GlyphDrawingOptions setter exceptions Matches the .NET runtime convention for property setters, also used elsewhere in this repo (e.g. FormattedText). --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Julien Lebosquain <julien@lebosquain.net>	1 month ago
Nikita Tsukanov	76735b20a4	Add touch input simulation to the headless platform (#22084 ) TouchBegin presses a touch contact and returns an IHeadlessTouchPointer handle that TouchMove/TouchEnd drive; keeping several handles pressed simulates multi-touch, and disposing one cancels its contact if still pressed. Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Julien Lebosquain <julien@lebosquain.net>	1 month ago
Nikita Tsukanov	3b259812c4	Fixed dispatcher frame capturing wrong dispatcher (#22086 )	1 month ago
Nikita Tsukanov	73ab31fcce	Use _effective_ capturer (which can be recognizer) for PlatformCapture (#22076 )	1 month ago
Julien Lebosquain	4142052f9e	Add BringIntoView pass to the LayoutManager (#22002 ) * Add BringIntoView pass to the LayoutManager * Make ProcessBringIntoViewRequests part of the standard layout pass * Clarify why TryScrollIntoViewNow's result is ignored --------- Co-authored-by: grokys <grokys@users.noreply.github.com>	1 month ago
Julien Lebosquain	11593a70ce	Fix auto-sized VirtualizingStackPanel not rendering (#22081 ) * Add failing test for auto-sized VSP * Fix auto-sized VirtualizingStackPanel not rendering	1 month ago
Lin	6b185ed56a	fix: light dismiss behavior fails when opened from the ContextMenu. (#22037 ) * fix: light dismiss behavior fails when opened from the ContextMenu. * 1. LightDismissOverlayLayer is invisible by default. 2. Eliminate misinformation that Registration may bring. 3. Remove LightDismissOverlayLayer Manually set IsVisible to false at creation time. --------- Co-authored-by: Steven Kirk <grokys@users.noreply.github.com>	1 month ago
Steven Kirk	15a9c99fc6	Add typed binding expressions (#21552 ) * Update ncrunch config. * Initial groundwork for typed binding expressions. - Moved a bunch of stuff from `UntypedBindingExpressionBase` to `BindingExpressionBase` - Make various APIs accept `BindingExpressionBase` instead of `UntypedBindingExpressionBase` - Added a typed `IPropertyInfo` - Added a method on the `CompiledBindingPathBuilder` to build typed property accessors - Initial basic implementation of `TypedBindingExpression` * Track values in typed binding expression. * Support binding mode in typed binding expression. * Add typed binding expression benchmarks. Add Setup/Values benchmarks comparing the typed binding expression against the untyped CompiledBinding (as emitted by the XAML compiler today) and the reflection-based Binding. Writing the benchmarks surfaced that TypedBindingExpression never detached: it had no Dispose override, so disposing a binding (or rebinding the same property) leaked its PropertyChanged subscriptions and left it registered in the value store. Wire up disposal mirroring UntypedBindingExpressionBase: stop, detach handlers, remove from the value store and frame. This required widening IBindingExpressionSink.OnCompleted from UntypedBindingExpressionBase to BindingExpressionBase. Also fix a nullable warning that broke the Release build. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> @ * Don't box value in IBindingExpressionSink.OnChanged. Instead notify the sink of what's changed and let the sink read the value boxed or unboxed. * Move `IValueEntry` to `BindingExpressionBase` * Fall back to BindingExpression. Make `TypedPropertyElement` derive from `PropertyElement` and fall back to creating a standard boxing `BindingExpression` if any of the requirements for a typed binding expression are not met. * Don't use typed expressions for DataContext. * Emit typed binding expression from XAML compiler. When a compiled binding path is shape-eligible (single CLR property on a reference-type source, no transforms, instance getter) the compiler now emits a call to the typed CompiledBindingPathBuilder.Property<TSource, TResult> overload, producing a TypedPropertyElement that the runtime turns into a non-boxing TypedBindingExpression<TSource, TValue>. Other shapes continue to use the existing untyped emission path, and runtime fallback to BindingExpression still kicks in when modifiers (Source, Converter, StringFormat, etc.) make the typed expression unsuitable. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Add failing tests for TwoWay typed binding source echo. TypedBindingExpression writes the source value back to the source both on attach and whenever the source raises a change: pushing the value to the target re-enters OnTargetPropertyChanged, which (in TwoWay mode) calls WriteValueToSource with the value that just arrived from the source. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Don't echo source value back to source in TwoWay typed binding. When TypedBindingExpression pushed the source value to the target, the resulting target PropertyChanged re-entered OnTargetPropertyChanged which, in TwoWay mode, wrote the value straight back to the source - a redundant round-trip on every attach and every source-originated change. Guard the source->target push with a flag and skip WriteValueToSource while it is set, so only genuine target changes are written back to the source. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Address typed binding code-review follow-ups. - Reset _isRunning when a typed binding is unsubscribed so the expression can be restarted (and re-subscribe to its source) if the value store reactivates the entry later, matching UntypedBindingExpressionBase.Stop(). - Remove a stray `using static PropertySetSnapshot` import. - Extract the duplicated IValueEntry value-unwrapping logic (shared by EffectiveValue<T> and DirectPropertyBase) into IValueEntry.TryGetValue. - Drop the unreachable UpdateSourceTrigger NotSupportedException in CreateTypedExpression; CanUseTypedBindingExpression already constrains it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Fix TypedBinding_Values benchmark build error. The typed binding path was built with a single-argument `Property(propertyInfo)` call, which has no matching overload, so the benchmark project did not compile. Use the same typed three-argument overload as TypedBinding_Setup so the benchmark exercises the TypedPropertyElement path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Skip typed binding expression for data-validation properties. TypedBindingExpression does not support data validation, but the eligibility check didn't account for it, so a directly-assignable single-property DataContext binding to a validation-enabled target (e.g. TextBox.Text, NumericUpDown.Value) would take the typed path and silently drop validation errors. Fall back to the untyped BindingExpression when the target property enables data validation. Data validation support in the typed expression can be added as a follow-up. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Clarify that data validation is not supported. * Address typed binding review comments. - React to null/empty PropertyChanged.PropertyName ("all properties changed") in the typed expression, matching the untyped path. - Swallow source getter exceptions raised during PropertyChanged. - Fall back to the untyped path for non-StyledElement targets, read-only sources and wider target types in TwoWay/OneWayToSource modes. - Fix a stray space in an exception message. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Share TypedBindingExpression.Attach validation across instantiations. Factor the validation logic (most notably the exception string formatting) out of the generic Attach method into a non-generic static helper. It only uses typeof(TValue), not TValue, so sharing it avoids duplicating the code per generic instantiation, a meaningful NativeAOT size saving (~3.3 KB => ~2.5 KB per instantiation). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Update API suppressions. These APIs are in a `[PrivateApi]`. * Use cached boolean boxes in typed binding expression. Merging main brought in the cached boxed booleans emitted for compiled binding property getters (#21065), but bindings that now take the typed binding expression path don't go through that getter: the value is boxed in TypedBindingExpression.GetUntypedValue when the target property isn't strongly typed (e.g. binding a bool to TextBlock.Tag). Box booleans via a shared cache there too, restoring the no-allocation-per-read behaviour. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QkxawATDHa6rbPaDmPCLHZ * Extract the whole TypedBindingExpression.Attach body into AttachCore. `3198196b4c` only factored out the validation, leaving the field assignments in the generic method. As MrJul pointed out, none of those assignments depend on TSource or TValue either, so the entire body can move into a method that doesn't reference the generic parameters and be shared across instantiations rather than duplicated per instantiation. Attach is now just a forwarder passing typeof(TValue) as a Type, and AttachCore reads _sink/TargetProperty directly instead of having them threaded through as parameters, which reads better than the previous split. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QkxawATDHa6rbPaDmPCLHZ * Move the method alongside the other privates. * Add failing tests for typed binding expression breaking changes. Each test binds the same property twice: once via a path which produces a TypedBindingExpression and once via a path which produces an untyped BindingExpression. The assertions describe the untyped behaviour, so the typed cases fail where the typed expression diverges: - A binding with no value (null or incompatible DataContext) publishes the target property's default value at the binding's priority instead of not contributing a value, overriding style setters and breaking inheritance. - Writing a value of another type, or null, to an object-typed target property throws from OnTargetPropertyChanged. - No binding error is logged when the DataContext is of the wrong type. - A throwing source getter leaves the stale value in place. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B66teLaFQBr9GJe4a1aTZm * Fix typed binding expression divergences from the untyped path. - Don't notify when the expression has no value and had none before: doing so pushed the target property's default value at the binding's priority, overriding style setters and breaking property inheritance. - Read the target property's new value defensively. The binding value type only needs to be assignable to the target property type, so the property can hold a value which isn't a TValue; casting it threw out of the caller's SetValue. - Log a binding error when the DataContext can't be converted to the source type, and when the source getter throws. The getter also now clears the value rather than leaving the stale one in place. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B66teLaFQBr9GJe4a1aTZm * Pass correct priority to child bindings. The priority here doesn't actually have any effect as the binding isn't in a value store, but there's no reason to not use the correct one. * Use the typed overload. * Set initial priority to default priority. Makes `TypedBindingExpressionBase` and `UntypedBindingExpressionBase` have the same behavior here. * Remove unused vars. * We now have a typed value here. * Publish typed binding values on the UI thread. The source's PropertyChanged event can be raised on any thread, so marshal the notification to the UI thread as UntypedBindingExpressionBase does. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B1ZwmCJkThPSeViLnRxoYs * Share the property info cache lookup. Emit and EmitTyped had identical cache lookups, differing only in which dictionary they searched. Also delay constructing the generic types in EmitTyped until a cache miss, as they aren't needed on a hit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B1ZwmCJkThPSeViLnRxoYs * Share the property accessor delegate emission. EmitFunc was duplicated as a local function in both Emit and EmitTyped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B1ZwmCJkThPSeViLnRxoYs --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	1 month ago
Yoyo	38402fc046	Fix VirtualizingStackPanel offset when scrolling to variable-sized items (#21975 ) * Fix VirtualizingStackPanel offset when scrolling to variable-sized items * Remove the `isScrollIntoView` parameter. * Tweak now-failing test. Change the the test to check that the element is outside of the viewport, instead of asserting its exact coordinates - that's the important part. * Retrigger CI. Azure Pipelines never queued a build for `3d81ceb9`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0169P8BipcMkn44hvhpQ2UNF --------- Co-authored-by: grokys <grokys@users.noreply.github.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>	1 month ago
Julien Lebosquain	33b288ffd6	Fix multiple ScrollContentPresenter.BringDescendantIntoView calls (#22001 ) * Add failing test for ScrollContentPresenter * Fix ScrollContentPresenter multiple BringDescendantIntoView * Update src/Avalonia.Controls/Presenters/ScrollContentPresenter.cs Co-authored-by: Steven Kirk <grokys@users.noreply.github.com> --------- Co-authored-by: Steven Kirk <grokys@users.noreply.github.com>	1 month ago
Benedikt Stebner	648edcdbc4	[Text] Do not shape the space after fallback text with the fallback font (#22067 ) * Add failing tests for whitespace absorbed into a fallback run A fallback run is extended for as long as the fallback font has glyphs instead of ending where the primary font regains coverage. Practically every font maps U+0020, so the space that follows fallback text is pulled into the fallback run and shaped with its space glyph. - itemization: a Hebrew letter followed by " b" must produce a 1-char fallback run, not a 2-char one that swallows the space - measurement: the space after an emoji must have the same advance as the same space elsewhere in the line * Merge abutting text bounds within the usual float tolerance The two edges being compared are reached by summing glyph advances along different paths, so abutting bounds can land an ULP apart and a single directional span gets reported as two rectangles. Compare them the way the rest of layout compares coordinates. * End a fallback run where the default typeface regains coverage Whitespace was exempt from the return-to-primary check so that a space wouldn't split a fallback run. Practically every font maps U+0020, so the exemption let a fallback run reach past the text the default typeface couldn't render and shape the following space with the fallback's own advance - a full em in most emoji fonts, which is the long space reported after an emoji. - the check now applies to spacing whitespace (Zs), so a fallback run ends at the first cluster the default typeface can render; control and format codepoints stay exempt - many fonts map the default-ignorable bidi controls, and a default typeface whose cmap merely has such a mark must not pull it out of the fallback run: the mark renders nothing either way, and the split cuts the run for no reason - a default typeface that cannot shape the run's script is still not a return target for text, but it does reclaim the spacing whitespace between the words, which carries no shaping - a run of pure whitespace no longer becomes the anti-thrashing bias for the next run, so the words on either side of a space keep resolving to the same fallback font Test expectations that encoded the old run structure move with it: a line of emoji separated by spaces is no longer a single run, glyph clusters are relative to each run's own text (the affected helpers now add the run's start), and the spaces of a right-to-left line measure with the primary font, which widens those lines.	1 month ago
Max Katz	97dd7857fd	Implement TopLevel.OpenedPopups (#22074 ) * Implement TopLevel.OpenedPopups * Delete Headless `GetOpenPopups` * Reorganize popup tests between Headless/Primitives layers Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Add Popup.OpenedPopups to keep opened popups in tree structure Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Help NUnit suppressing CS8777 * Update suppresions --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>	1 month ago
Max Katz	b84025f6c9	C# source generator for Avalonia properties (#21797 ) * Add AttachedPropertyAttribute, DirectPropertyAttribute and StyledPropertyAttribute attribtues * Add shared GeneratedPropertyShape * Move AvaloniaPropertyAnalyzer ids to DiagnosticIds * Add generated properties analyzer descriptors * Implement GeneratedPropertyAnalyzer Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Implement GeneratedProperty code fixers Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Update solution files with new projects * Enable new diagnostics on Avalonia code itself * Fix VB project * Implement actual PropertyGenEmitter Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Replace several manual property declarations in ControlCatalog with new source gen * Implement basic ConvertToGeneratedProperty analyzer, without code-fixer * Lower supported C# version to 13 * Misc * Add AvaloniaPropertyGeneratorIsEnabled msbuild prop * Fix SetCurrentValue warning * Use RegisterSyntaxNodeAction instead of RegisterOperationAction for new analyzer * Fix some of the new CodeFix tests * Support AddOwner to other generated properties * Remove `AllowMultiple = false`, it's implied by default * Remove ChangedMethodName * Rename new attributes with "Generated" prefix * Misc improvements * Enable nullable per each property * Switch to #nullable enable annotations to not break warnings * Do not enforce partial callbacks, instead use existing warning if method is missing or incorrect * Support callbacks defined in the base class Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Jumar Macato <16554748+jmacato@users.noreply.github.com>	1 month ago
Theofanis kouniakis	b1e68c3e0f	Implement ObjectMultiConverters. (#21428 ) * Implement object multi converters and tests. * Rename null check methods * Remove method AreNotEqual * Move to ObjectConverters * Change logic for AreAnyNull --------- Co-authored-by: Emmanuel Hansen <emmausssss@gmail.com>	1 month ago
Max Katz	bd6c8823d7	ControlCatalog home page (cherry-pick) (#22058 ) * ControlCatalog: add dashboard home page with animated hero and nav cards A new Home page (first in the drawer) modeled on the Accelerate demo dashboard: a gradient hero banner with floating control glyphs animated via keyframed TranslateTransforms, followed by categorized card sections for every catalog page. Cards carry an icon badge, title and one-line description, and clicking one navigates via SelectedPageIndex so the drawer selection stays in sync. PageItem gains Description/Category and the view model exposes grouped HomeSections plus NavigateToPageCommand. Card colors are self-contained theme dictionaries so the page works across Fluent/Fluent2/Simple in both variants. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ControlCatalog: use the Accelerate demo hero banner verbatim on the home page Replaces the gradient/glyph hero with a 1:1 copy of AvaloniaProDemo's DashboardView banner: banner-bg backdrop, the four 3D logos floating at the original positions/durations, and the centered Avalonia wordmark. Assets copied from the Accelerate repo (~4.8 MB of PNGs). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * DataGridPage was removed * Make Main Window a bit wider to fit 3 full columns instead of 2.5 * Fix ScreenPage not rendering * Replace Avalonia old icon with a new one * Update main logo too * Force Avalonia SyncContext inside of OnSizeChanged callback * Restructure MainWindowViewModel_PageList, avoid duplication of categories * Fix screens page invalidation * Fix minor warnings * Redo HomePage items layouting * Add missing pages * Reuse $(SharedAssetsPath) * Don't pin exact patch version of DiagnosticsSupport * Resize new assets * Include page section in search * Use expression setters in main view model * Restore filtered page sorting * Fix CI build * Add 1px margin to the UniformGrid to fix cropped border issue --------- Co-authored-by: Mike James <michael.james6@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>	1 month ago
Benedikt Stebner	4459a577fd	[Text] Snap a right-to-left buffer split to the cluster boundary (#22066 ) * Add failing test for a right-to-left split inside a cluster Splitting a right-to-left shaped buffer keeps a straddling cluster's glyphs together in the leading half, but cuts the text at the requested offset instead of following them. The halves then disagree about which characters their glyphs cover: the leading half claims one character while holding the glyphs for two, and the trailing half claims a character whose glyphs it doesn't have. The left-to-right path already snaps the text boundary to the cluster. * Snap a right-to-left split to the cluster the glyphs stay with A cluster straddling the split point keeps all its glyphs in the leading half, so the text has to be cut where those glyphs end, not at the requested offset. Cutting at the offset produced two halves whose glyph and character coverage disagreed, and their shared cluster cache then described neither: measuring the trailing half returned counts that cut a cluster, and splitting it again could hand back a leading half holding every glyph and no trailing half at all - a null run that crashed the bidi reorderer. The ascending path already snapped this way; this makes the descending path match.	1 month ago

1 2 3 4 5 ...

5747 Commits (fixes/macos-owned-window-level-inheritance)