Avalonia

Branch: fixes/macos-owned-window-level-inheritance

Commit Graph

Author	SHA1	Message	Date
GreySaturn	ea2dc8fef7	Fix ServerCompositionDrawingSurface orphaning GPU snapshots when an update is processed after Dispose (#21876 ) * Add failing test: CompositionDrawingSurface update processed after Dispose orphans the GPU snapshot A commit batch is processed on the render thread in serialization order: the dispose list is written before queued server jobs. The legal user-code order `surface.UpdateAsync(image); surface.Dispose();` therefore executes on the render thread as Dispose() -> UpdateWithAutomaticSync(), and the update stores a fresh snapshot ref into the already-disposed ServerCompositionDrawingSurface. Nothing disposes that ref afterwards, so the GPU-backed snapshot is cleaned up by the RefCountable.Ref<T> critical finalizer, which performs GPU work on the finalizer thread and races the compositor render loop (#21865). * Fix ServerCompositionDrawingSurface orphaning GPU snapshots when an update is processed after Dispose Add a disposed flag: an Update processed after Dispose now disposes the fresh snapshot immediately on the render thread (where the GPU context is current) instead of storing it into the disposed surface where nothing will ever release it. This removes the finalizer-thread GPU cleanup path that races the compositor render loop and crashes in sk_canvas_flush (#21865).	1 month ago

Author

SHA1

Message

Date

GreySaturn

ea2dc8fef7

Fix ServerCompositionDrawingSurface orphaning GPU snapshots when an update is processed after Dispose (#21876 )

* Add failing test: CompositionDrawingSurface update processed after Dispose orphans the GPU snapshot

A commit batch is processed on the render thread in serialization order: the
dispose list is written before queued server jobs. The legal user-code order
`surface.UpdateAsync(image); surface.Dispose();` therefore executes on the
render thread as Dispose() -> UpdateWithAutomaticSync(), and the update stores
a fresh snapshot ref into the already-disposed ServerCompositionDrawingSurface.
Nothing disposes that ref afterwards, so the GPU-backed snapshot is cleaned up
by the RefCountable.Ref<T> critical finalizer, which performs GPU work on the
finalizer thread and races the compositor render loop (#21865).

* Fix ServerCompositionDrawingSurface orphaning GPU snapshots when an update is processed after Dispose

Add a disposed flag: an Update processed after Dispose now disposes the fresh
snapshot immediately on the render thread (where the GPU context is current)
instead of storing it into the disposed surface where nothing will ever
release it. This removes the finalizer-thread GPU cleanup path that races the
compositor render loop and crashes in sk_canvas_flush (#21865).

1 month ago

1 Commits (fixes/macos-owned-window-level-inheritance)