Avalonia

Commit Graph

Author	SHA1	Message	Date
Benedikt Stebner	888f7557bd	Rebuild TextBlock text runs only when the content changes (#22149 ) * Keep TextBlock text runs in sync with its inlines _textRuns is built from Inlines, but OnMeasureInvalidated discarded it on any measure invalidation while Inlines still held the content. Between that point and the next measure pass, CreateTextLayout read a null _textRuns as "no inlines" and shaped Text instead, which is null whenever the content lives in Inlines. That empty result went into the TextRunCache, keyed by text source index, so every later layout reused it and the control rendered nothing until something invalidated the cache. - Discard _textRuns in InvalidateTextLayout, next to the run cache, so the runs and the cache are dropped by the same event and cannot disagree about the content. - Build the runs on demand in EnsureTextRuns, and pick the text source by HasComplexContent rather than by _textRuns being set. - Split the constraint-dependent work out of run building. Runs answer to the content alone; only an embedded control answers to the available width, so Inline.MeasureEmbeddedControls measures it and EmbeddedControlRun reports the child's DesiredSize live. Runs now survive a constraint change instead of being rebuilt every measure. SelectableTextBlock never hands the run cache to its layout, but it shared the same fallback and kept the wrong layout on _textLayout. Fixes #21902 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Invalidate the layout when LineSpacing changes LineSpacing had no case in the property change switch and is not one of the properties registered with AffectsRender, so changing it left the measured size and the rendered text untouched even though CreateTextLayout feeds it into the paragraph properties. It changes line placement rather than shaping, so it belongs with LineHeight and the other properties that keep the run cache. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Drop the text layout whenever the content is invalidated InvalidateMeasure only raises OnMeasureInvalidated while the measure is still valid, so a second content change before the next measure pass left _textLayout holding the layout the first change had already replaced. MeasureOverride keeps that layout when the constraint has not moved, so the block measured and rendered the superseded content. Clear the layout in InvalidateTextLayout and InvalidateTextLayoutKeepCache rather than relying on OnMeasureInvalidated to run, which is what TextPresenter already does. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Drop the text layout when an embedded control resizes A line snapshots its metrics when it is formatted, so a layout built before a child was measured again keeps reporting the width and height that child used to have. MeasureOverride reuses the layout whenever the constraint has not moved, so a control that resizes while the block is already measure invalid never reaches the measured size. - MeasureEmbeddedControls reports whether any child came back a different size, and the layout is dropped only then rather than on every pass. - Route the remaining layout resets through DisposeTextLayout so every reset goes through one place. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>	1 week ago
Nathan Nguyen	a8b1a6b55a	Don't build the selected text just to check whether a selection exists (#22100 ) * perf(text): test the selection by index instead of building it UpdateCommandStates only needs to know whether the selection is empty, but it called GetSelection, which allocates a substring on every selection change. Test the indices instead, so a selection change no longer allocates. Requested by @Gillibald in #21492. * perf(text): read the selection properties once in HasSelection	2 weeks ago
Julien Lebosquain	ba2c3416bd	Handle clipboard exceptions in TextBox/SelectableTextBlock (#22052 )	3 weeks ago
Yoyo	faf7137b2a	fix(SelectableTextBlock): fix SelectableTextBlock selection for centered and right-aligned text (#21369 ) * fix(SelectableTextBlock): fix SelectableTextBlock selection for centered and right-aligned text * Fix failing unit tests * Let TextLayout handle out-of-bounds hit testing --------- Co-authored-by: Julien Lebosquain <julien@lebosquain.net>	1 month ago
Yoyo	e36b803256	Fix SelectableTextBlock selection when text content changes (#21894 ) * Fix SelectableTextBlock selection when text content changes * Clean up	1 month ago
JoshuaRowePhantom	9becf5d634	Fix SelectableTextBlock selection offset with InlineUIContainer (#21646 ) * Fix SelectableTextBlock selection offset with InlineUIContainer (#15880) EmbeddedControlRun inherits TextRun.DefaultTextSourceLength = 1, so each InlineUIContainer occupies one position in TextLayout. However, InlineUIContainer.AppendText was a no-op, causing Inlines.Text to have zero characters for each embedded control. This made TextLayout.HitTestPoint return positions that were ahead of Inlines.Text indices by one per InlineUIContainer, breaking SelectedText for any text after an embedded control. Fix: append the Unicode Object Replacement Character (U+FFFC) — the standard placeholder for embedded objects — in AppendText so that Inlines.Text character offsets stay in sync with the TextLayout positions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Expand InlineUIContainer selection tests with fencepost cases Replace single assertion with a [Theory] covering all boundary positions around the embedded control in 'foo\uFFFCbar': - entirely before the container - exactly the container character - up to and including the container - starting exactly after the container - container through end - one character either side of the container - entire content Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>	2 months ago
Julien Lebosquain	960cb39414	Enable nullability in Controls.UnitTests (#20373 )	9 months ago
Artemis Li	60ee26ae21	Preserve run formatting when applying SelectionForegroundBrush in SelectableTextBlock (#20110 ) * Add failing test for preserving run formatting during selection * Fix selection styling to preserve original text formatting in SelectableTextBlock * fix: apply old logic when `_textRuns` is null	10 months ago

8 Commits (fixes/macos-owned-window-level-inheritance)