Avalonia

Commit Graph

Author	SHA1	Message	Date
Steven Kirk	15a9c99fc6	Add typed binding expressions (#21552 ) * Update ncrunch config. * Initial groundwork for typed binding expressions. - Moved a bunch of stuff from `UntypedBindingExpressionBase` to `BindingExpressionBase` - Make various APIs accept `BindingExpressionBase` instead of `UntypedBindingExpressionBase` - Added a typed `IPropertyInfo` - Added a method on the `CompiledBindingPathBuilder` to build typed property accessors - Initial basic implementation of `TypedBindingExpression` * Track values in typed binding expression. * Support binding mode in typed binding expression. * Add typed binding expression benchmarks. Add Setup/Values benchmarks comparing the typed binding expression against the untyped CompiledBinding (as emitted by the XAML compiler today) and the reflection-based Binding. Writing the benchmarks surfaced that TypedBindingExpression never detached: it had no Dispose override, so disposing a binding (or rebinding the same property) leaked its PropertyChanged subscriptions and left it registered in the value store. Wire up disposal mirroring UntypedBindingExpressionBase: stop, detach handlers, remove from the value store and frame. This required widening IBindingExpressionSink.OnCompleted from UntypedBindingExpressionBase to BindingExpressionBase. Also fix a nullable warning that broke the Release build. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> @ * Don't box value in IBindingExpressionSink.OnChanged. Instead notify the sink of what's changed and let the sink read the value boxed or unboxed. * Move `IValueEntry` to `BindingExpressionBase` * Fall back to BindingExpression. Make `TypedPropertyElement` derive from `PropertyElement` and fall back to creating a standard boxing `BindingExpression` if any of the requirements for a typed binding expression are not met. * Don't use typed expressions for DataContext. * Emit typed binding expression from XAML compiler. When a compiled binding path is shape-eligible (single CLR property on a reference-type source, no transforms, instance getter) the compiler now emits a call to the typed CompiledBindingPathBuilder.Property<TSource, TResult> overload, producing a TypedPropertyElement that the runtime turns into a non-boxing TypedBindingExpression<TSource, TValue>. Other shapes continue to use the existing untyped emission path, and runtime fallback to BindingExpression still kicks in when modifiers (Source, Converter, StringFormat, etc.) make the typed expression unsuitable. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Add failing tests for TwoWay typed binding source echo. TypedBindingExpression writes the source value back to the source both on attach and whenever the source raises a change: pushing the value to the target re-enters OnTargetPropertyChanged, which (in TwoWay mode) calls WriteValueToSource with the value that just arrived from the source. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Don't echo source value back to source in TwoWay typed binding. When TypedBindingExpression pushed the source value to the target, the resulting target PropertyChanged re-entered OnTargetPropertyChanged which, in TwoWay mode, wrote the value straight back to the source - a redundant round-trip on every attach and every source-originated change. Guard the source->target push with a flag and skip WriteValueToSource while it is set, so only genuine target changes are written back to the source. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Address typed binding code-review follow-ups. - Reset _isRunning when a typed binding is unsubscribed so the expression can be restarted (and re-subscribe to its source) if the value store reactivates the entry later, matching UntypedBindingExpressionBase.Stop(). - Remove a stray `using static PropertySetSnapshot` import. - Extract the duplicated IValueEntry value-unwrapping logic (shared by EffectiveValue<T> and DirectPropertyBase) into IValueEntry.TryGetValue. - Drop the unreachable UpdateSourceTrigger NotSupportedException in CreateTypedExpression; CanUseTypedBindingExpression already constrains it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Fix TypedBinding_Values benchmark build error. The typed binding path was built with a single-argument `Property(propertyInfo)` call, which has no matching overload, so the benchmark project did not compile. Use the same typed three-argument overload as TypedBinding_Setup so the benchmark exercises the TypedPropertyElement path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Skip typed binding expression for data-validation properties. TypedBindingExpression does not support data validation, but the eligibility check didn't account for it, so a directly-assignable single-property DataContext binding to a validation-enabled target (e.g. TextBox.Text, NumericUpDown.Value) would take the typed path and silently drop validation errors. Fall back to the untyped BindingExpression when the target property enables data validation. Data validation support in the typed expression can be added as a follow-up. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Clarify that data validation is not supported. * Address typed binding review comments. - React to null/empty PropertyChanged.PropertyName ("all properties changed") in the typed expression, matching the untyped path. - Swallow source getter exceptions raised during PropertyChanged. - Fall back to the untyped path for non-StyledElement targets, read-only sources and wider target types in TwoWay/OneWayToSource modes. - Fix a stray space in an exception message. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Share TypedBindingExpression.Attach validation across instantiations. Factor the validation logic (most notably the exception string formatting) out of the generic Attach method into a non-generic static helper. It only uses typeof(TValue), not TValue, so sharing it avoids duplicating the code per generic instantiation, a meaningful NativeAOT size saving (~3.3 KB => ~2.5 KB per instantiation). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Update API suppressions. These APIs are in a `[PrivateApi]`. * Use cached boolean boxes in typed binding expression. Merging main brought in the cached boxed booleans emitted for compiled binding property getters (#21065), but bindings that now take the typed binding expression path don't go through that getter: the value is boxed in TypedBindingExpression.GetUntypedValue when the target property isn't strongly typed (e.g. binding a bool to TextBlock.Tag). Box booleans via a shared cache there too, restoring the no-allocation-per-read behaviour. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QkxawATDHa6rbPaDmPCLHZ * Extract the whole TypedBindingExpression.Attach body into AttachCore. `3198196b4c` only factored out the validation, leaving the field assignments in the generic method. As MrJul pointed out, none of those assignments depend on TSource or TValue either, so the entire body can move into a method that doesn't reference the generic parameters and be shared across instantiations rather than duplicated per instantiation. Attach is now just a forwarder passing typeof(TValue) as a Type, and AttachCore reads _sink/TargetProperty directly instead of having them threaded through as parameters, which reads better than the previous split. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QkxawATDHa6rbPaDmPCLHZ * Move the method alongside the other privates. * Add failing tests for typed binding expression breaking changes. Each test binds the same property twice: once via a path which produces a TypedBindingExpression and once via a path which produces an untyped BindingExpression. The assertions describe the untyped behaviour, so the typed cases fail where the typed expression diverges: - A binding with no value (null or incompatible DataContext) publishes the target property's default value at the binding's priority instead of not contributing a value, overriding style setters and breaking inheritance. - Writing a value of another type, or null, to an object-typed target property throws from OnTargetPropertyChanged. - No binding error is logged when the DataContext is of the wrong type. - A throwing source getter leaves the stale value in place. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B66teLaFQBr9GJe4a1aTZm * Fix typed binding expression divergences from the untyped path. - Don't notify when the expression has no value and had none before: doing so pushed the target property's default value at the binding's priority, overriding style setters and breaking property inheritance. - Read the target property's new value defensively. The binding value type only needs to be assignable to the target property type, so the property can hold a value which isn't a TValue; casting it threw out of the caller's SetValue. - Log a binding error when the DataContext can't be converted to the source type, and when the source getter throws. The getter also now clears the value rather than leaving the stale one in place. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B66teLaFQBr9GJe4a1aTZm * Pass correct priority to child bindings. The priority here doesn't actually have any effect as the binding isn't in a value store, but there's no reason to not use the correct one. * Use the typed overload. * Set initial priority to default priority. Makes `TypedBindingExpressionBase` and `UntypedBindingExpressionBase` have the same behavior here. * Remove unused vars. * We now have a typed value here. * Publish typed binding values on the UI thread. The source's PropertyChanged event can be raised on any thread, so marshal the notification to the UI thread as UntypedBindingExpressionBase does. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B1ZwmCJkThPSeViLnRxoYs * Share the property info cache lookup. Emit and EmitTyped had identical cache lookups, differing only in which dictionary they searched. Also delay constructing the generic types in EmitTyped until a cache miss, as they aren't needed on a hit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B1ZwmCJkThPSeViLnRxoYs * Share the property accessor delegate emission. EmitFunc was duplicated as a local function in both Emit and EmitTyped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B1ZwmCJkThPSeViLnRxoYs --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	3 weeks ago
Julien Lebosquain	656d691940	Move ConstructorArgumentAttribute and remove BindingMode from ReflectionBinding constructor (#20589 ) * Move ConstructorArgumentAttribute to Avalonia.Base assembly * Move IOptionalFeatureProvider to Avalonia namespace * Remove BindingMode from ReflectionBinding constructor * Update API suppressions	7 months ago
Benedikt Stebner	e8424283fe	Universal GlyphTypeface implementation (#19852 ) * Introduce a universal IGlyphTypeface implementation that does not rely on any platform implementation * Revert changes * Fix Android * Make the test happy * Fix build * Update baseline * Fix naming * Fix headless * Move interfaces to dedicated files Make GlyphTypeface.GlyphCount an integer * Fix GlyphCount * Make IGlyphTypeface NotClientImplementable * Make sure we cache platform typefaces by their desired name, style, weight and stretch * Update baseline * Only use IGlyphTypeface * Fix Android * Try to clear the buffer before we encode somethimg * Add needed test font * Add more unit tests * Reduce allocations * Remove Direct2D1 test files * More tests * More complete table implementations * More adjustments * Use batch APIs * Handle invalid timestamps * Update baseline * Introduce a CharacterToGlyphMap struct for faster access * Remove AggressiveInlining * Remove AggressiveInlining * Make the head table optional for legacy fonts * Remove Load method. Fix TextBlockTests * Fix nullables * Remove redundant folder * Update Api baseline * revert diff helper changes * revert changes * Use bare minimum font for Headless platform and introduce a test font manager that uses the Inter font for testing. * Add missing font file for Headless platform --------- Co-authored-by: Gillibald <stebner@avaloniaui.net> Co-authored-by: Julien Lebosquain <julien@lebosquain.net>	8 months ago
Julien Lebosquain	960cb39414	Enable nullability in Controls.UnitTests (#20373 )	9 months ago
Nikita Tsukanov	fedbb270c0	Make sure that tests inherit from ScropedTestBase (#18690 )	1 year ago
Bartosz Korczyński	93d2140cc0	Wrap type conversions in try-catch to prevent crashes due to unhandled exceptions (#15640 )	2 years ago
Tim	8fc0be82cd	Converter for DataValidationErrors (#11282 ) * Introduce ErrorConverter and DisplayErrors attached properties - the converter can be used to change the way a message is print - we use DisplayErrors to get the converted error messages * Adjust FluentTheme * [WIP] Add a sample Page for DataValidationErrors * use a private attached property to store recent errors this approach gets rid of the need to DisplayErrors property * Update samples with some additional details * Reuse rich SetError logic in DataGrid as well * Unify some code with OnErrorsOrConverterChanged * Restore old behavior with null default value * Add SetErrorConverter test --------- Co-authored-by: Max Katz <maxkatz6@outlook.com>	3 years ago
Max Katz	4aa6035ec3	Reuse text and geometry related headless mocks in Avalonia unit tests and benchmarks	3 years ago
Steven Kirk	1945345cd1	Rename TemplatedParent priority to Template. It no longer represents just `TemplatedParent` bindings, but every value or binding created by a template.	4 years ago
Giuseppe Lippolis	de4b55f8ee	feat(tests): Address rule CA1822	4 years ago
Benedikt Stebner	b815a22d5a	Port WPF's FormattedText to Avalonia and rework TextPresenter	5 years ago
Steven Kirk	a832d63915	IStandardCursorFactory -> ICursorFactory.	6 years ago
Steven Kirk	4d01dacd77	Remove copyright headers. Some of our files had them, some didn't. They serve no purpose legally so best to remove the ceremony.	7 years ago
all.owing	a6b65a39de	Test fix	7 years ago
Nikita Tsukanov	1ab923c02e	Removed WithNameScope	7 years ago
Nikita Tsukanov	fa55755b71	Manually handle name scope registrations	7 years ago
Jeremy Koritzinsky	cf8244b37a	Move current contents of Avalonia.Markup to Avalonia.Base. Move Avalonia.Markup.Xaml.Data/Parser classes to Avalonia.Markup since they're not Xaml-specific. Use pattern-matching switch. Fix bug from cleanup.	8 years ago
sdoroff	5dce65f7b6	Created a shared DataValidationErrors framework Moved Validation Error tracking to attached an attached property Created an shared error indicator that can be simply added to control templates and re-styled across all controls This should reduce the need for code and markup duplication while allowing for a consistent visual interface	9 years ago
Steven Kirk	5cc5b91930	Fix xunit warnings.	9 years ago
Steven Kirk	41ba3b7782	Started adding TextBox error adornments.	10 years ago
Steven Kirk	941246e75c	Started to implement data validation on TextBox. Not working still - added a failing test to demonstrate it.	10 years ago
Steven Kirk	5a9371f786	Pass EnableDataValidation to ExpressionObserver.	10 years ago
Steven Kirk	4906a472b0	Reimplemented data validation using BindingNotifications.	10 years ago
Steven Kirk	5c33fbc6ee	Reimplemented property validation. As far as it was in `property-validation-grokys` branch. Things were messed up on master so had to merge this manually so may be problems.	10 years ago

21 Commits (fixes/macos-owned-window-level-inheritance)