Avalonia

Branch: main

Commit Graph

Author	SHA1	Message	Date
Benedikt Stebner	1bd786090d	CompositionBrush corrections (#21873 ) * Add failing tests for composition gradient brush change tracking Three defects in the unreleased CompositionBrush surface: - Replacing GradientStops after the first commit never reaches the server: the hand-written property registers nothing for serialization, so the change only ships once an unrelated tracked property dirties the brush. - SpreadMethod has the same gap. - A mutable Media.GradientStop crosses the batch by reference and the render thread then reads a UI-thread object at replay time. - A CompositionBrush resolves its server object for any compositor, so a foreign compositor ends up sharing a resource across render loops. * Track composition gradient brush changes and respect compositor affinity - GradientStops and SpreadMethod now register for serialization when assigned, so changes made after the first commit reach the server without waiting for an unrelated tracked property to dirty the brush. In-place list mutation stays untracked and is documented as requiring re-assignment. - Non-composition gradient stops are snapshotted to ImmutableGradientStop at serialization time instead of crossing the batch by reference, since the render thread reads the server list at replay time. - Resolving a CompositionBrush for a different compositor now throws instead of silently wiring one server resource into two render loops. Transient contexts without a compositor keep receiving the client brush unchanged.	2 months ago

Author

SHA1

Message

Date

Benedikt Stebner

1bd786090d

CompositionBrush corrections (#21873 )

* Add failing tests for composition gradient brush change tracking

Three defects in the unreleased CompositionBrush surface:

- Replacing GradientStops after the first commit never reaches the
  server: the hand-written property registers nothing for
  serialization, so the change only ships once an unrelated tracked
  property dirties the brush.
- SpreadMethod has the same gap.
- A mutable Media.GradientStop crosses the batch by reference and the
  render thread then reads a UI-thread object at replay time.
- A CompositionBrush resolves its server object for any compositor,
  so a foreign compositor ends up sharing a resource across render
  loops.

* Track composition gradient brush changes and respect compositor affinity

- GradientStops and SpreadMethod now register for serialization when
  assigned, so changes made after the first commit reach the server
  without waiting for an unrelated tracked property to dirty the
  brush. In-place list mutation stays untracked and is documented as
  requiring re-assignment.
- Non-composition gradient stops are snapshotted to
  ImmutableGradientStop at serialization time instead of crossing the
  batch by reference, since the render thread reads the server list at
  replay time.
- Resolving a CompositionBrush for a different compositor now throws
  instead of silently wiring one server resource into two render
  loops. Transient contexts without a compositor keep receiving the
  client brush unchanged.

2 months ago

1 Commits (main)